capybara 3.3.0 → 3.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ec1af73714c227e46b54e14d716a63f2cc75011d2cb8f0fde62eecb8d5d07785
-  data.tar.gz: 907fecc783f2a9b23529e10b0e4775dc0f1015ffc5163157523772d192456e5f
+  metadata.gz: 31eb0715167852439533fdb10e4cb15b9cb1d7531e7821a6f70d2a208d6cb232
+  data.tar.gz: 58f5b7496bade61b732ab10831dc237f64dc7f288bd34bdbe61b58535d0fa475
 SHA512:
-  metadata.gz: f5c6f7cdf74cb231ee795c299f7ee28688dc8ecfd371b97c1744e77a823209e5270626cdf36e8c171fe1018394d1f1176b15e0b61e88e18f4c60ff402d1aad88
-  data.tar.gz: 29fcba8784b579ff159a00df91ddf83aa0cdc14fb6061535943933aa89796848068b8dea1da723cdaeda9ec3a3c81c8ce7fb7857f052b3764ffe7cbcea790d93
+  metadata.gz: 5563fda1e5f2965eb8d93cf42ecb8423bb316d6381410a79dc3a18d41364502b893ff5ce7974f48888f87583f53d7b43037a5f80c20fd20b1bad6a2d1a144f51
+  data.tar.gz: 8361afb0ecb0fbe34b045b031ae2466483128f69ccb2be4637ad77a7ec41bac39fa44acd8ae1cbefdb94b4bec1679ee2e6e25fadc7d8062130ac59d992b45c36

data/History.md

@@ -1,3 +1,11 @@
+# Version 3.3.1
+Release date: 2018-06-27
+
+### Fixed
+
+* `selenium-webdriver` version check [ahorek]
+* Selenium driver correctly responds to `disabled?` for fieldset elements - Issue #2059 [Thomas Walpole]
+
 # Version 3.3.0
 Release date: 2018-06-25
 

data/README.md

@@ -7,7 +7,7 @@
 [![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=capybara&package-manager=bundler&version-scheme=semver)](https://dependabot.com/compatibility-score.html?dependency-name=capybara&package-manager=bundler&version-scheme=semver)
 
 **Note** You are viewing the README for the development version of Capybara.  If you are using the current release version
-you can find the README at https://github.com/teamcapybara/capybara/blob/3.2_stable/README.md
+you can find the README at https://github.com/teamcapybara/capybara/blob/3.3_stable/README.md
 
 
 Capybara helps you test web applications by simulating how a real user would

data/lib/capybara/selenium/driver.rb

@@ -14,7 +14,7 @@ class Capybara::Selenium::Driver < Capybara::Driver::Base
 
   def self.load_selenium
     require 'selenium-webdriver'
-    warn "Warning: You're using an unsupported version of selenium-webdriver, please upgrade." if Gem::Version.new(Selenium::WebDriver::VERSION) < Gem::Version.new('3.5.0')
+    warn "Warning: You're using an unsupported version of selenium-webdriver, please upgrade." if Gem.loaded_specs["selenium-webdriver"].version < Gem::Version.new('3.5.0')
   rescue LoadError => e
     raise e if e.message !~ /selenium-webdriver/
     raise LoadError, "Capybara's selenium driver is unable to load `selenium-webdriver`, please install the gem and add `gem 'selenium-webdriver'` to your Gemfile if you are using bundler."

data/lib/capybara/selenium/node.rb

@@ -140,7 +140,10 @@ class Capybara::Selenium::Node < Capybara::Driver::Node
   alias :checked? :selected?
 
   def disabled?
-    !native.enabled?
+    return true unless native.enabled?
+    # WebDriver only defines `disabled?` for form controls but fieldset makes sense too
+    return boolean_attr(self[:disabled]) if tag_name == 'fieldset'
+    false
   end
 
   def content_editable?

data/lib/capybara/spec/session/node_spec.rb

@@ -177,6 +177,11 @@ Capybara::SpecHelper.spec "node" do
       expect(@session.find('//option', text: "A.2")).not_to be_disabled
     end
 
+    it "should see a disabled fieldset as disabled" do
+      @session.visit('/form')
+      expect(@session.find(:css, '#form_disabled_fieldset')).to be_disabled
+    end
+
     context "in a disabled fieldset" do
       # https://html.spec.whatwg.org/#the-fieldset-element
       it "should see elements not in first legend as disabled" do

data/lib/capybara/spec/views/form.erb

@@ -386,7 +386,7 @@ New line after and before textarea tag
 
 
   <p>
-    <fieldset disabled="disabled">
+    <fieldset disabled="disabled" id="form_disabled_fieldset">
       <legend>Disabled Child</legend>
       <input name="form[disabled_fieldset_child]" id="form_disabled_fieldset_child"/>
       <select>

data/lib/capybara/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Capybara
-  VERSION = '3.3.0'
+  VERSION = '3.3.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.3.0
+  version: 3.3.1
 platform: ruby
 authors:
 - Thomas Walpole
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - gem-public_cert.pem
-date: 2018-06-25 00:00:00.000000000 Z
+date: 2018-06-27 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable