capybara 3.28.0 → 3.29.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 59f170c7004d4936ffb0d136a4dd0755a9c1ec5870f6bf1114d693b99a8fed51
-  data.tar.gz: 955e163359d522952afdc7d776458667f97aa053e6eb704320733eae8340544a
+  metadata.gz: 5f11a887ca6aed51d064d9c8eb797e0db4605a3d013082a11f4f4b1013b27bef
+  data.tar.gz: 714e834fdb1c2f0e692f547a1d032113dd888d6905eddecc60f05503720bcd8e
 SHA512:
-  metadata.gz: 13d33c4977455c5d2e9a5aa7532ffed98573795a1528685ded75574dfabd58512f5d3e71d3582d8155fe4325209ba3bbde3246a29b4436de573c5b492dffe1cc
-  data.tar.gz: 52b33d646ec5c86b61a04b7f2c354a1d1e77d1c363b0ba8d19e7ad1b48679a53078766c8f018f1d7f223b730d9b4d951f005a689a3f143999fdeead4c522242c
+  metadata.gz: 82c37d1b9c8d1c7f9d858f8d7aebebfc2ecee4c5e35d35f9a3c949d978e4e97d48f78b9d5f93079e209fc779ab31e5707ecce8ac0d2a4ce8108fc3be2437e1bc
+  data.tar.gz: '06886b335dd0ef5f93f59a09026877bc460e6430b2d2f1902cd31a3179b1bd52b9418a1b43ab558dcf18e92b198506023c3549a065949bb33f881538ec9e018d'

data/History.md

@@ -1,3 +1,21 @@
+# Version 3.29.0
+Release date: Unreleased
+
+### Added
+
+* Allow clicking on file input when using the block version of `attach_file` with Chrome and Firefox
+* Spatial filters (`left_of`, `right_of`, `above`, `below`, `near`)
+* rack_test driver now supports clicking on details elements to open/close them
+
+### Fixed
+
+* rack_test driver correctly determines visibility for open details elements descendants
+
+### Changed
+
+* Results will now be lazily evaluated when using JRuby >= 9.2.8.0
+
+
 # Version 3.28.0
 Release date: 2019-08-03
 

data/README.md

@@ -7,7 +7,7 @@
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/jnicklas/capybara?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=capybara&package-manager=bundler&version-scheme=semver)](https://dependabot.com/compatibility-score.html?dependency-name=capybara&package-manager=bundler&version-scheme=semver)
 
-**Note** You are viewing the README for the 3.28.x version of Capybara.
+**Note** You are viewing the README for the 3.29.x version of Capybara.
 
 Capybara helps you test web applications by simulating how a real user would
 interact with your app. It is agnostic about the driver running your tests and
@@ -391,7 +391,7 @@ Capybara supports [Selenium 3.5+
 In order to use Selenium, you'll need to install the `selenium-webdriver` gem,
 and add it to your Gemfile if you're using bundler.
 
-Capybara pre-registers a number of named drives that use Selenium - they are:
+Capybara pre-registers a number of named drivers that use Selenium - they are:
 
   * :selenium                 => Selenium driving Firefox
   * :selenium_headless        => Selenium driving Firefox in a headless configuration

data/lib/capybara/driver/node.rb

@@ -113,6 +113,10 @@ module Capybara
         !!self[:multiple]
       end
 
+      def rect
+        raise NotSupportedByDriverError, 'Capybara::Driver::Node#rect'
+      end
+
       def path
         raise NotSupportedByDriverError, 'Capybara::Driver::Node#path'
       end

data/lib/capybara/node/actions.rb

@@ -288,6 +288,7 @@ module Capybara
             execute_script CAPTURE_FILE_ELEMENT_SCRIPT
             yield
             file_field = evaluate_script 'window._capybara_clicked_file_input'
+            raise ArgumentError, "Capybara was unable to determine the file input you're attaching to" unless file_field
           rescue ::Capybara::NotSupportedByDriverError
             warn 'Block mode of `#attach_file` is not supported by the current driver - ignoring.'
           end

data/lib/capybara/node/element.rb

@@ -371,6 +371,10 @@ module Capybara
         synchronize { base.path }
       end
 
+      def rect
+        synchronize { base.rect }
+      end
+
       ##
       #
       # Trigger any event on the current element, for example mouseover or focus

data/lib/capybara/node/simple.rb

@@ -198,7 +198,7 @@ module Capybara
           x.attr(:style)[x.contains('display:none') | x.contains('display: none')] |
           x.attr(:hidden) |
           x.qname.one_of('script', 'head') |
-          (~x.self(:summary) & XPath.parent(:details))
+          (~x.self(:summary) & XPath.parent(:details)[!XPath.attr(:open)])
         ].boolean
       end.to_s.freeze
     end

data/lib/capybara/queries/selector_query.rb

@@ -1,10 +1,13 @@
 # frozen_string_literal: true
 
+require 'matrix'
+
 module Capybara
   module Queries
     class SelectorQuery < Queries::BaseQuery
       attr_reader :expression, :selector, :locator, :options
-      VALID_KEYS = COUNT_KEYS +
+      SPATIAL_KEYS = %i[above below left_of right_of near].freeze
+      VALID_KEYS = SPATIAL_KEYS + COUNT_KEYS +
                    %i[text id class style visible obscured exact exact_text normalize_ws match wait filter_set]
       VALID_MATCH = %i[first smart prefer_exact one].freeze
 
@@ -18,6 +21,8 @@ module Capybara
         @resolved_node = nil
         @resolved_count = 0
         @options = options.dup
+        @filter_cache = Hash.new { |hsh, key| hsh[key] = {} }
+
         super(@options)
         self.session_options = session_options
 
@@ -50,13 +55,17 @@ module Capybara
           desc << 'visible ' if visible == :visible
           desc << 'non-visible ' if visible == :hidden
         end
+
         desc << "#{label} #{locator.inspect}"
+
         if show_for[:any]
           desc << " with#{' exact' if exact_text == true} text #{options[:text].inspect}" if options[:text]
           desc << " with exact text #{exact_text}" if exact_text.is_a?(String)
         end
+
         desc << " with id #{options[:id]}" if options[:id]
         desc << " with classes [#{Array(options[:class]).join(',')}]" if options[:class]
+
         desc << case options[:style]
         when String
           " with style attribute #{options[:style].inspect}"
@@ -66,8 +75,15 @@ module Capybara
           " with styles #{options[:style].inspect}"
         else ''
         end
+
+        %i[above below left_of right_of near].each do |spatial_filter|
+          desc << " #{spatial_filter} #{options[spatial_filter] rescue '<ERROR>'}" if options[spatial_filter] && show_for[:spatial] # rubocop:disable Style/RescueModifier
+        end
+
         desc << selector.description(node_filters: show_for[:node], **options)
+
         desc << ' that also matches the custom filter block' if @filter_block && show_for[:node]
+
         desc << " within #{@resolved_node.inspect}" if describe_within?
         if locator.is_a?(String) && locator.start_with?('#', './/', '//')
           unless selector.raw_locator?
@@ -87,6 +103,7 @@ module Capybara
 
         matches_locator_filter?(node) &&
           matches_system_filters?(node) &&
+          matches_spatial_filters?(node) &&
           matches_node_filters?(node, node_filter_errors) &&
           matches_filter_block?(node)
       rescue *(node.respond_to?(:session) ? node.session.driver.invalid_element_errors : [])
@@ -125,8 +142,10 @@ module Capybara
       # @api private
       def resolve_for(node, exact = nil)
         applied_filters.clear
+        @filter_cache.clear
         @resolved_node = node
         @resolved_count += 1
+
         node.synchronize do
           children = find_nodes_by_selector_format(node, exact).map(&method(:to_element))
           Capybara::Result.new(children, self)
@@ -208,6 +227,7 @@ module Capybara
         hints[:uses_visibility] = true unless visible == :all
         hints[:texts] = text_fragments unless selector_format == :xpath
         hints[:styles] = options[:style] if use_default_style_filter?
+        hints[:position] = true if use_spatial_filter?
 
         if selector_format == :css
           if node.method(:find_css).arity != 1
@@ -333,6 +353,10 @@ module Capybara
         options.key?(:style) && !custom_keys.include?(:style)
       end
 
+      def use_spatial_filter?
+        options.values_at(*SPATIAL_KEYS).compact.any?
+      end
+
       def apply_expression_filters(expression)
         unapplied_options = options.keys - valid_keys
         expression_filters.inject(expression) do |expr, (name, ef)|
@@ -397,6 +421,42 @@ module Capybara
           matches_exact_text_filter?(node)
       end
 
+      def matches_spatial_filters?(node)
+        applied_filters << :spatial
+        return true unless use_spatial_filter?
+
+        node_rect = Rectangle.new(node.initial_cache[:position] || node.rect)
+
+        if options[:above]
+          el_rect = rect_cache(options[:above])
+          return false unless node_rect.above? el_rect
+        end
+
+        if options[:below]
+          el_rect = rect_cache(options[:below])
+          return false unless node_rect.below? el_rect
+        end
+
+        if options[:left_of]
+          el_rect = rect_cache(options[:left_of])
+          return false unless node_rect.left_of? el_rect
+        end
+
+        if options[:right_of]
+          el_rect = rect_cache(options[:right_of])
+          return false unless node_rect.right_of? el_rect
+        end
+
+        if options[:near]
+          return false if node == options[:near]
+
+          el_rect = rect_cache(options[:near])
+          return false unless node_rect.near? el_rect
+        end
+
+        true
+      end
+
       def matches_id_filter?(node)
         return true unless use_default_id_filter? && options[:id].is_a?(Regexp)
 
@@ -491,6 +551,147 @@ module Capybara
       def builder(expr)
         selector.builder(expr)
       end
+
+      def position_cache(key)
+        @filter_cache[key][:position] ||= key.rect
+      end
+
+      def rect_cache(key)
+        @filter_cache[key][:rect] ||= Rectangle.new(position_cache(key))
+      end
+
+      class Rectangle
+        attr_reader :top, :bottom, :left, :right
+        def initialize(position)
+          # rubocop:disable Style/RescueModifier
+          @top = position['top'] rescue position['y']
+          @bottom = position['bottom'] rescue (@top + position['height'])
+          @left = position['left'] rescue position['x']
+          @right = position['right'] rescue (@left + position['width'])
+          # rubocop:enable Style/RescueModifier
+        end
+
+        def distance(other)
+          distance = Float::INFINITY
+
+          line_segments.each do |ls1|
+            other.line_segments.each do |ls2|
+              distance = [
+                distance,
+                distance_segment_segment(*ls1, *ls2)
+              ].min
+            end
+          end
+
+          distance
+        end
+
+        def above?(other)
+          bottom <= other.top
+        end
+
+        def below?(other)
+          top >= other.bottom
+        end
+
+        def left_of?(other)
+          right <= other.left
+        end
+
+        def right_of?(other)
+          left >= other.right
+        end
+
+        def near?(other)
+          distance(other) <= 50
+        end
+
+      protected
+
+        def line_segments
+          [
+            [Vector[top, left], Vector[top, right]],
+            [Vector[top, right], Vector[bottom, left]],
+            [Vector[bottom, left], Vector[bottom, right]],
+            [Vector[bottom, right], Vector[top, left]]
+          ]
+        end
+
+      private
+
+        def distance_segment_segment(l1p1, l1p2, l2p1, l2p2)
+          # See http://geomalgorithms.com/a07-_distance.html
+          # rubocop:disable Naming/VariableName
+          u = l1p2 - l1p1
+          v = l2p2 - l2p1
+          w = l1p1 - l2p1
+
+          a = u.dot u
+          b = u.dot v
+          c = v.dot v
+
+          d = u.dot w
+          e = v.dot w
+          cap_d = (a * c) - (b * b)
+          sD = tD = cap_d
+
+          # compute the line parameters of the two closest points
+          if cap_d < Float::EPSILON # the lines are almost parallel
+            sN = 0.0 # force using point P0 on segment S1
+            sD = 1.0 # to prevent possible division by 0.0 later
+            tN = e
+            tD = c
+          else # get the closest points on the infinite lines
+            sN = (b * e) - (c * d)
+            tN = (a * e) - (b * d)
+            if sN.negative? # sc < 0 => the s=0 edge is visible
+              sN = 0
+              tN = e
+              tD = c
+            elsif sN > sD # sc > 1 => the s=1 edge is visible
+              sN = sD
+              tN = e + b
+              tD = c
+            end
+          end
+
+          if tN.negative? # tc < 0 => the t=0 edge is visible
+            tN = 0
+            # recompute sc for this edge
+            if (-d).negative?
+              sN = 0.0
+            elsif -d > a
+              sN = sD
+            else
+              sN = -d
+              sD = a
+            end
+          elsif tN > tD # tc > 1 => the t=1 edge is visible
+            tN = tD
+            # recompute sc for this edge
+            if (-d + b).negative?
+              sN = 0.0
+            elsif (-d + b) > a
+              sN = sD
+            else
+              sN = (-d + b)
+              sD = a
+            end
+          end
+
+          # finally do the division to get sc and tc
+          sc = sN.abs < Float::EPSILON ? 0.0 : sN / sD
+          tc = tN.abs < Float::EPSILON ? 0.0 : tN / tD
+
+          # difference of the two closest points
+          dP = w + (u * sc) - (v * tc)
+
+          Math.sqrt(dP.dot(dP))
+          # rubocop:enable Naming/VariableName
+        end
+      end
+
+      private_constant :Rectangle
     end
   end
 end

data/lib/capybara/rack_test/node.rb

@@ -76,6 +76,8 @@ class Capybara::RackTest::Node < Capybara::Driver::Node
       set(!checked?)
     elsif tag_name == 'label'
       click_label
+    elsif tag_name == 'details'
+      toggle_details
     end
   end
 
@@ -236,6 +238,14 @@ private
     labelled_control.set(!labelled_control.checked?) if checkbox_or_radio?(labelled_control)
   end
 
+  def toggle_details
+    if native.has_attribute?('open')
+      native.remove_attribute('open')
+    else
+      native.set_attribute('open', 'open')
+    end
+  end
+
   def link?
     tag_name == 'a' && !self[:href].nil?
   end

data/lib/capybara/result.rb

@@ -150,15 +150,15 @@ module Capybara
       @rest ||= @elements - full_results
     end
 
-    def lazy_select_elements(&block)
+    if (RUBY_PLATFORM == 'java') && (Gem::Version.new(JRUBY_VERSION) < Gem::Version.new('9.2.8.0'))
       # JRuby < 9.2.8.0 has an issue with lazy enumerators which
       # causes a concurrency issue with network requests here
       # https://github.com/jruby/jruby/issues/4212
-      if (RUBY_PLATFORM == 'java') && (Gem::Version.new(JRUBY_VERSION) < Gem::Version.new('9.2.8.0'))
-        # :nocov:
+      def lazy_select_elements(&block)
         @elements.select(&block).to_enum # non-lazy evaluation
-        # :nocov:
-      else
+      end
+    else
+      def lazy_select_elements(&block)
         @elements.lazy.select(&block)
       end
     end

data/lib/capybara/rspec/matchers/base.rb

@@ -2,6 +2,7 @@
 
 require 'capybara/rspec/matchers/compound'
 require 'capybara/rspec/matchers/count_sugar'
+require 'capybara/rspec/matchers/spatial_sugar'
 
 module Capybara
   module RSpecMatchers
@@ -68,6 +69,7 @@ module Capybara
 
       class CountableWrappedElementMatcher < WrappedElementMatcher
         include ::Capybara::RSpecMatchers::CountSugar
+        include ::Capybara::RSpecMatchers::SpatialSugar
       end
 
       class NegatedMatcher

data/lib/capybara/rspec/matchers/spatial_sugar.rb

@@ -0,0 +1,38 @@
+# frozen_string_literal: true
+
+module Capybara
+  module RSpecMatchers
+    module SpatialSugar
+      def above(el)
+        options[:above] = el
+        self
+      end
+
+      def below(el)
+        options[:below] = el
+        self
+      end
+
+      def left_of(el)
+        options[:left_of] = el
+        self
+      end
+
+      def right_of(el)
+        options[:right_of] = el
+        self
+      end
+
+      def near(el)
+        options[:near] = el
+        self
+      end
+
+    private
+
+      def options
+        (@args.last.is_a?(Hash) ? @args : @args.push({})).last
+      end
+    end
+  end
+end

data/lib/capybara/selector.rb

@@ -9,6 +9,11 @@ require 'capybara/selector/definition'
 #   * :id (String, Regexp, XPath::Expression) - Matches the id attribute
 #   * :class (String, Array<String>, Regexp, XPath::Expression) - Matches the class(es) provided
 #   * :style (String, Regexp, Hash<String, String>) - Match on elements style
+#   * :above (Element) - Match elements above the passed element on the page
+#   * :below (Element) - Match elements below the passed element on the page
+#   * :left_of (Element) - Match elements left of the passed element on the page
+#   * :right_of (Element) - Match elements right of the passed element on the page
+#   * :near (Element) - Match elements near (within 50px) the passed element on the page
 #
 # ### Built-in Selectors
 #

data/lib/capybara/selenium/extensions/file_input_click_emulation.rb

@@ -0,0 +1,34 @@
+# frozen_string_literal: true
+
+class Capybara::Selenium::Node
+  module FileInputClickEmulation
+    def click(keys = [], **options)
+      super
+    rescue Selenium::WebDriver::Error::InvalidArgumentError
+      return emulate_click if attaching_file? && visible_file_field?
+
+      raise
+    end
+
+  private
+
+    def visible_file_field?
+      (attrs(:tagName, :type).map { |val| val&.downcase } == %w[input file]) && visible?
+    end
+
+    def attaching_file?
+      caller_locations.any? { |cl| cl.base_label == 'attach_file' }
+    end
+
+    def emulate_click
+      driver.execute_script(<<~JS, self)
+        arguments[0].dispatchEvent(
+          new MouseEvent('click', {
+            view: window,
+            bubbles: true,
+            cancelable: true
+          }));
+      JS
+    end
+  end
+end

data/lib/capybara/selenium/extensions/find.rb

@@ -3,34 +3,35 @@
 module Capybara
   module Selenium
     module Find
-      def find_xpath(selector, uses_visibility: false, styles: nil, **_options)
-        find_by(:xpath, selector, uses_visibility: uses_visibility, texts: [], styles: styles)
+      def find_xpath(selector, uses_visibility: false, styles: nil, position: false, **_options)
+        find_by(:xpath, selector, uses_visibility: uses_visibility, texts: [], styles: styles, position: position)
       end
 
-      def find_css(selector, uses_visibility: false, texts: [], styles: nil, **_options)
-        find_by(:css, selector, uses_visibility: uses_visibility, texts: texts, styles: styles)
+      def find_css(selector, uses_visibility: false, texts: [], styles: nil, position: false, **_options)
+        find_by(:css, selector, uses_visibility: uses_visibility, texts: texts, styles: styles, position: position)
       end
 
     private
 
-      def find_by(format, selector, uses_visibility:, texts:, styles:)
+      def find_by(format, selector, uses_visibility:, texts:, styles:, position:)
         els = find_context.find_elements(format, selector)
         hints = []
 
         if (els.size > 2) && !ENV['DISABLE_CAPYBARA_SELENIUM_OPTIMIZATIONS']
           els = filter_by_text(els, texts) unless texts.empty?
-          hints = gather_hints(els, uses_visibility: uses_visibility, styles: styles)
+          hints = gather_hints(els, uses_visibility: uses_visibility, styles: styles, position: position)
         end
         els.map.with_index { |el, idx| build_node(el, hints[idx] || {}) }
       end
 
-      def gather_hints(elements, uses_visibility:, styles:)
-        hints_js, functions = build_hints_js(uses_visibility, styles)
+      def gather_hints(elements, uses_visibility:, styles:, position:)
+        hints_js, functions = build_hints_js(uses_visibility, styles, position)
         return [] unless functions.any?
 
         es_context.execute_script(hints_js, elements).map! do |results|
           hint = {}
           hint[:style] = results.pop if functions.include?(:style_func)
+          hint[:position] = results.pop if functions.include?(:position_func)
           hint[:visible] = results.pop if functions.include?(:vis_func)
           hint
         end
@@ -50,7 +51,7 @@ module Capybara
         JS
       end
 
-      def build_hints_js(uses_visibility, styles)
+      def build_hints_js(uses_visibility, styles, position)
         functions = []
         hints_js = +''
 
@@ -61,6 +62,15 @@ module Capybara
           functions << :vis_func
         end
 
+        if position
+          hints_js << <<~POSITION_JS
+            var position_func = function(el){
+              return el.getBoundingClientRect();
+            };
+          POSITION_JS
+          functions << :position_func
+        end
+
         if styles.is_a? Hash
           hints_js << <<~STYLE_JS
             var style_func = function(el){

data/lib/capybara/selenium/node.rb

@@ -179,6 +179,10 @@ class Capybara::Selenium::Node < Capybara::Driver::Node
     driver.frame_obscured_at?(x: res['x'], y: res['y'])
   end
 
+  def rect
+    native.rect
+  end
+
 protected
 
   def scroll_if_needed

data/lib/capybara/selenium/nodes/chrome_node.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
 require 'capybara/selenium/extensions/html5_drag'
+require 'capybara/selenium/extensions/file_input_click_emulation'
 
 class Capybara::Selenium::ChromeNode < Capybara::Selenium::Node
   include Html5Drag
+  include FileInputClickEmulation
 
   def set_text(value, clear: nil, **_unused)
     super.tap do

data/lib/capybara/selenium/nodes/firefox_node.rb

@@ -1,9 +1,11 @@
 # frozen_string_literal: true
 
 require 'capybara/selenium/extensions/html5_drag'
+require 'capybara/selenium/extensions/file_input_click_emulation'
 
 class Capybara::Selenium::FirefoxNode < Capybara::Selenium::Node
   include Html5Drag
+  include FileInputClickEmulation
 
   def click(keys = [], **options)
     super

data/lib/capybara/spec/session/find_spec.rb

@@ -428,6 +428,38 @@ Capybara::SpecHelper.spec '#find' do
     expect(@session.find(:css, 'input', &:disabled?)[:name]).to eq('disabled_text')
   end
 
+  context 'with spatial filters', requires: [:spatial] do
+    before do
+      @session.visit('/spatial')
+      @center = @session.find(:css, 'div.center')
+    end
+
+    it 'should find an element above another element' do
+      expect(@session.find(:css, 'div:not(.corner)', above: @center).text).to eq('2')
+    end
+
+    it 'should find an element below another element' do
+      expect(@session.find(:css, 'div:not(.corner):not(.footer)', below: @center).text).to eq('8')
+    end
+
+    it 'should find an element left of another element' do
+      expect(@session.find(:css, 'div:not(.corner)', left_of: @center).text).to eq('4')
+    end
+
+    it 'should find an element right of another element' do
+      expect(@session.find(:css, 'div:not(.corner)', right_of: @center).text).to eq('6')
+    end
+
+    it 'should combine spatial filters' do
+      expect(@session.find(:css, 'div', left_of: @center, above: @center).text).to eq('1')
+      expect(@session.find(:css, 'div', right_of: @center, below: @center).text).to eq('9')
+    end
+
+    it 'should find an element "near" another element' do
+      expect(@session.find(:css, 'div.distance', near: @center).text).to eq('2')
+    end
+  end
+
   context 'within a scope' do
     before do
       @session.visit('/with_scope')

data/lib/capybara/spec/session/has_css_spec.rb

@@ -231,6 +231,24 @@ Capybara::SpecHelper.spec '#has_css?' do
     end
   end
 
+  context 'with spatial requirements', requires: [:spatial] do
+    before do
+      @session.visit('/spatial')
+      @center = @session.find(:css, '.center')
+    end
+
+    it 'accepts spatial options' do
+      expect(@session).to have_css('div', above: @center).thrice
+      expect(@session).to have_css('div', above: @center, right_of: @center).once
+    end
+
+    it 'supports spatial sugar' do
+      expect(@session).to have_css('div').left_of(@center).thrice
+      expect(@session).to have_css('div').below(@center).right_of(@center).once
+      expect(@session).to have_css('div').near(@center).exactly(8).times
+    end
+  end
+
   it 'should allow escapes in the CSS selector' do
     expect(@session).to have_css('p[data-random="abc\\\\def"]')
     expect(@session).to have_css("p[data-random='#{Capybara::Selector::CSS.escape('abc\def')}']")

data/lib/capybara/spec/session/node_spec.rb

@@ -254,20 +254,30 @@ Capybara::SpecHelper.spec 'node' do
       expect(@session.find('//div[@id="hidden"]').visible?).to be false
     end
 
-    it 'details > summary elements and descendants should be visible' do
-      expect(@session.find(:css, 'details summary')).to be_visible
-      expect(@session.find(:css, 'details summary h6')).to be_visible
+    it 'closed details > summary elements and descendants should be visible' do
+      expect(@session.find(:css, '#closed_details summary')).to be_visible
+      expect(@session.find(:css, '#closed_details summary h6')).to be_visible
     end
 
-    it 'details non-summary descendants should be non-visible' do
-      @session.first(:css, 'details li').visible?
-      descendants = @session.all(:css, 'details > *:not(summary), details > *:not(summary) *', minimum: 2)
+    it 'details non-summary descendants should be non-visible when closed' do
+      descendants = @session.all(:css, '#closed_details > *:not(summary), #closed_details > *:not(summary) *', minimum: 2)
       expect(descendants).not_to include(be_visible)
     end
 
-    it 'sees open details as visible', requires: [:js] do
-      @session.find(:css, 'details').click
-      expect(@session.all(:css, 'details *')).to all(be_visible)
+    it 'deatils descendants should be visible when open' do
+      descendants = @session.all(:css, '#open_details *')
+      expect(descendants).to all(be_visible)
+    end
+
+    it 'works when details is toggled open and closed' do
+      @session.find(:css, '#closed_details').click
+      expect(@session).to have_css('#closed_details *', visible: true, count: 5)
+        .and(have_no_css('#closed_details *', visible: :hidden))
+
+      @session.find(:css, '#closed_details').click
+      descendants_css = '#closed_details > *:not(summary), #closed_details > *:not(summary) *'
+      expect(@session).to have_no_css(descendants_css, visible: true)
+        .and(have_css(descendants_css, visible: :hidden, count: 3))
     end
   end
 

data/lib/capybara/spec/views/spatial.erb

@@ -0,0 +1,31 @@
+<html>
+  <head>
+    <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
+    <title>spatial</title>
+    <style>
+      #spatial {
+        display: grid;
+        grid-template-columns: repeat(3, 1fr);
+        grid-gap: 10px;
+        grid-auto-rows: minmax(100px, auto);
+      }
+      .footer {
+        grid-column: 1 / 4;
+      }
+    </style>
+  </head>
+
+  <body id="spatial">
+    <div class="corner">1</div>
+    <div class="distance">2</div>
+    <div class="corner">3</div>
+    <div>4</div>
+    <div class="center">5</div>
+    <div>6</div>
+    <div class="corner">7</div>
+    <div>8</div>
+    <div class="corner">9</div>
+    <div class="footer distance">10</div>
+  </body>
+</html>
+

data/lib/capybara/spec/views/with_html.erb

@@ -181,7 +181,7 @@ banana
                   　
 </div>
 
-<details>
+<details id="closed_details">
   <summary>
     <h6>Something</h6>
   </summary>
@@ -191,6 +191,15 @@ banana
   </ul>
 </details>
 
+<details id="open_details" open>
+  <summary>
+    <h6>Summary</h6>
+  </summary>
+  <div>
+    Contents
+  </div>
+</details>
+
 <template id="template">
   <input />
 </template>

data/lib/capybara/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Capybara
-  VERSION = '3.28.0'
+  VERSION = '3.29.0'
 end

data/spec/dsl_spec.rb

@@ -8,7 +8,7 @@ class TestClass
 end
 
 Capybara::SpecHelper.run_specs TestClass.new, 'DSL', capybara_skip: %i[
-  js modals screenshot frames windows send_keys server hover about_scheme psc download css driver scroll
+  js modals screenshot frames windows send_keys server hover about_scheme psc download css driver scroll spatial
 ] do |example|
   case example.metadata[:full_description]
   when /has_css\? should support case insensitive :class and :id options/

data/spec/rack_test_spec.rb

@@ -25,6 +25,7 @@ skipped_tests = %i[
   download
   css
   scroll
+  spatial
 ]
 Capybara::SpecHelper.run_specs TestSessions::RackTest, 'RackTest', capybara_skip: skipped_tests do |example|
   case example.metadata[:full_description]

data/spec/result_spec.rb

@@ -166,7 +166,7 @@ RSpec.describe Capybara::Result do
   context 'lazy select' do
     it 'is compatible' do
       # This test will let us know when JRuby fixes lazy select so we can re-enable it in Result
-      pending 'JRuby has an issue with lazy enumberator evaluation' if RUBY_PLATFORM == 'java'
+      pending 'JRuby < 9.2.8.0 has an issue with lazy enumberator evaluation' if jruby_lazy_enumerator_workaround?
       eval_count = 0
       enum = %w[Text1 Text2 Text3].lazy.select do
         eval_count += 1

data/spec/selenium_spec_chrome.rb

@@ -13,9 +13,13 @@ Selenium::WebDriver::Chrome.path = '/usr/bin/google-chrome-beta' if ENV['CI'] &&
 browser_options = ::Selenium::WebDriver::Chrome::Options.new
 browser_options.headless! if ENV['HEADLESS']
 browser_options.add_option(:w3c, ENV['W3C'] != 'false')
+# Chromedriver 77 requires setting this for headless mode on linux
+# browser_options.add_preference('download.default_directory', Capybara.save_path)
+browser_options.add_preference(:download, default_directory: Capybara.save_path)
 
 Capybara.register_driver :selenium_chrome do |app|
   Capybara::Selenium::Driver.new(app, browser: :chrome, options: browser_options, timeout: 30).tap do |driver|
+    # Set download dir for Chrome < 77
     driver.browser.download_path = Capybara.save_path
   end
 end

data/spec/selenium_spec_firefox.rb

@@ -62,8 +62,6 @@ Capybara::SpecHelper.run_specs TestSessions::SeleniumFirefox, 'selenium', capyba
     skip 'Need to figure out testing of file downloading on windows platform' if Gem.win_platform?
   when 'Capybara::Session selenium #reset_session! removes ALL cookies'
     pending "Geckodriver doesn't provide a way to remove cookies outside the current domain"
-  when 'Capybara::Session selenium #attach_file with a block can upload by clicking the file input'
-    pending "Geckodriver doesn't allow clicking on file inputs"
   when /drag_to.*HTML5/
     pending "Firefox < 62 doesn't support a DataTransfer constuctor" if firefox_lt?(62.0, @session)
   end

data/spec/selenium_spec_firefox_remote.rb

@@ -65,8 +65,6 @@ Capybara::SpecHelper.run_specs TestSessions::RemoteFirefox, FIREFOX_REMOTE_DRIVE
   when /#accept_confirm should work with nested modals$/
     # skip because this is timing based and hence flaky when set to pending
     skip 'Broken in FF 63 - https://bugzilla.mozilla.org/show_bug.cgi?id=1487358' if firefox_gte?(63, @session)
-  when 'Capybara::Session selenium_firefox_remote #attach_file with a block can upload by clicking the file input'
-    pending "Geckodriver doesn't allow clicking on file inputs"
   end
 end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.28.0
+  version: 3.29.0
 platform: ruby
 authors:
 - Thomas Walpole
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - gem-public_cert.pem
-date: 2019-08-03 00:00:00.000000000 Z
+date: 2019-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -470,6 +470,7 @@ files:
 - lib/capybara/rspec/matchers/have_title.rb
 - lib/capybara/rspec/matchers/match_selector.rb
 - lib/capybara/rspec/matchers/match_style.rb
+- lib/capybara/rspec/matchers/spatial_sugar.rb
 - lib/capybara/selector.rb
 - lib/capybara/selector/builders/css_builder.rb
 - lib/capybara/selector/builders/xpath_builder.rb
@@ -515,6 +516,7 @@ files:
 - lib/capybara/selenium/driver_specializations/firefox_driver.rb
 - lib/capybara/selenium/driver_specializations/internet_explorer_driver.rb
 - lib/capybara/selenium/driver_specializations/safari_driver.rb
+- lib/capybara/selenium/extensions/file_input_click_emulation.rb
 - lib/capybara/selenium/extensions/find.rb
 - lib/capybara/selenium/extensions/html5_drag.rb
 - lib/capybara/selenium/extensions/modifier_keys_stack.rb
@@ -657,6 +659,7 @@ files:
 - lib/capybara/spec/views/postback.erb
 - lib/capybara/spec/views/react.erb
 - lib/capybara/spec/views/scroll.erb
+- lib/capybara/spec/views/spatial.erb
 - lib/capybara/spec/views/tables.erb
 - lib/capybara/spec/views/with_animation.erb
 - lib/capybara/spec/views/with_base_tag.erb
@@ -741,7 +744,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.0.3
+rubygems_version: 3.0.6
 signing_key: 
 specification_version: 4
 summary: Capybara aims to simplify the process of integration testing Rack applications,