capybara 3.27.0 → 3.28.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d2fb2005b8e78a2ee5cd0cf72bdfe2143988cce46abf19422f00bc78ac6336fa
-  data.tar.gz: 17f7b3eba5799d74ba90bddd6bacec90f1318e3c731097a4cb362f211272652b
+  metadata.gz: 59f170c7004d4936ffb0d136a4dd0755a9c1ec5870f6bf1114d693b99a8fed51
+  data.tar.gz: 955e163359d522952afdc7d776458667f97aa053e6eb704320733eae8340544a
 SHA512:
-  metadata.gz: 28e92147279b5b2ee953853fd93071e143719ec099fb68187ea4fa666fbe3593606876968861c9104967e7b7bbd2033b2105ce9720bb00b4de94cd98c8473553
-  data.tar.gz: 25aee95fc26cc88c27e5229f73665a1cf6b2a8658ece2b8503809a520a45afe5622b28825206cff599ad7a2e749dbc168941dcc298995bc43fd61545b6a306a1
+  metadata.gz: 13d33c4977455c5d2e9a5aa7532ffed98573795a1528685ded75574dfabd58512f5d3e71d3582d8155fe4325209ba3bbde3246a29b4436de573c5b492dffe1cc
+  data.tar.gz: 52b33d646ec5c86b61a04b7f2c354a1d1e77d1c363b0ba8d19e7ad1b48679a53078766c8f018f1d7f223b730d9b4d951f005a689a3f143999fdeead4c522242c

data/History.md

@@ -1,3 +1,14 @@
+# Version 3.28.0
+Release date: 2019-08-03
+
+### Added
+
+* Allow forcing HTML5 or legacy dragging via the `:html5` option to `drag_to` when using Selenium with Chrome or Firefox
+* Autodetection of drag type interprets not seeing the mousedown event as legacy.
+* HTML5 form validation `:valid` node filter added to `:field` and `:fillable_field` selectors
+* When using Capybara registered :puma server - patches Puma 4.0.x to fix SSL connection behavior. Removes
+  default `queue_requests` setting - Issue #2227
+
 # Version 3.27.0
 Release date: 2019-07-28
 

data/README.md

@@ -7,7 +7,7 @@
 [![Gitter](https://badges.gitter.im/Join%20Chat.svg)](https://gitter.im/jnicklas/capybara?utm_source=badge&utm_medium=badge&utm_campaign=pr-badge&utm_content=badge)
 [![SemVer](https://api.dependabot.com/badges/compatibility_score?dependency-name=capybara&package-manager=bundler&version-scheme=semver)](https://dependabot.com/compatibility-score.html?dependency-name=capybara&package-manager=bundler&version-scheme=semver)
 
-**Note** You are viewing the README for the 3.27.x version of Capybara
+**Note** You are viewing the README for the 3.28.x version of Capybara.
 
 Capybara helps you test web applications by simulating how a real user would
 interact with your app. It is agnostic about the driver running your tests and

data/lib/capybara/node/element.rb

@@ -396,8 +396,13 @@ module Capybara
       #
       # @param [Capybara::Node::Element] node     The element to drag to
       # @param [Hash] options  Driver specific options for dragging. May not be supported by all drivers.
+      # @option options [Numeric] :delay   (0.05) When using Chrome/Firefox with Selenium and HTML5 dragging this is the number
+      #                                    of seconds between each stage of the drag.
+      # @option options [Boolean] :html5   When using Chrome/Firefox with Selenium enables to force the use of HTML5
+      #                                    (true) or legacy (false) dragging. If not specified the driver will attempt to
+      #                                    detect the correct method to use.
       #
-      # @return [Capybara::Node::Element]  The element
+      # @return [Capybara::Node::Element]  The dragged element
       def drag_to(node, **options)
         synchronize { base.drag_to(node.base, **options) }
         self
@@ -510,6 +515,28 @@ module Capybara
         JS
       end
 
+      ##
+      #
+      # Toggle the elements background color between white and black for a period of time.
+      #
+      # @return [Capybara::Node::Element]  The element
+      def flash
+        execute_script(<<~JS, 100)
+          async function flash(el, delay){
+            var old_bg = el.style.backgroundColor;
+            var colors = ["black", "white"];
+            for(var i=0; i<20; i++){
+              el.style.backgroundColor = colors[i % colors.length];
+              await new Promise(resolve => setTimeout(resolve, delay));
+            }
+            el.style.backgroundColor = old_bg;
+          }
+          flash(this, arguments[0]);
+        JS
+
+        self
+      end
+
       # @api private
       def reload
         if @allow_reload

data/lib/capybara/registrations/patches/puma_ssl.rb

@@ -0,0 +1,27 @@
+# frozen_string_literal: true
+
+module Puma
+  module MiniSSL
+    class Socket
+      def read_nonblock(size, *_)
+        loop do
+          output = engine_read_all
+          return output if output
+
+          data = @socket.read_nonblock(size, exception: false)
+          raise IO::EAGAINWaitReadable if %i[wait_readable wait_writable].include? data
+          return nil if data.nil?
+
+          @engine.inject(data)
+          output = engine_read_all
+
+          return output if output
+
+          while (neg_data = @engine.extract)
+            @socket.write neg_data
+          end
+        end
+      end
+    end
+  end
+end

data/lib/capybara/registrations/servers.rb

@@ -20,16 +20,19 @@ Capybara.register_server :puma do |app, port, host, **options|
       raise LoadError, 'Capybara requires `puma` version 3.8.0 or higher, please upgrade `puma` or register and specify your own server block'
     end
   end
+
   # If we just run the Puma Rack handler it installs signal handlers which prevent us from being able to interrupt tests.
   # Therefore construct and run the Server instance ourselves.
   # Rack::Handler::Puma.run(app, { Host: host, Port: port, Threads: "0:4", workers: 0, daemon: false }.merge(options))
-  default_options = { Host: host, Port: port, Threads: '0:4', workers: 0, daemon: false, queue_requests: false }
-  default_options[:queue_requests] = false if options[:Host]&.start_with?('ssl://')
+  default_options = { Host: host, Port: port, Threads: '0:4', workers: 0, daemon: false }
   options = default_options.merge(options)
 
   conf = Rack::Handler::Puma.config(app, options)
   events = conf.options[:Silent] ? ::Puma::Events.strings : ::Puma::Events.stdio
 
+  puma_ver = Gem::Version.new(Puma::Const::PUMA_VERSION)
+  require_relative 'patches/puma_ssl' if (Gem::Version.new('4.0.0')...Gem::Version.new('4.1.0')).cover? puma_ver
+
   events.log 'Capybara starting Puma...'
   events.log "* Version #{Puma::Const::PUMA_VERSION} , codename: #{Puma::Const::CODE_NAME}"
   events.log "* Min threads: #{conf.options[:min_threads]}, max threads: #{conf.options[:max_threads]}"

data/lib/capybara/selector.rb

@@ -34,6 +34,7 @@ require 'capybara/selector/definition'
 #       * :unchecked (Boolean) - Match unchecked fields?
 #       * :disabled (Boolean, :all) - Match disabled field? (Default: false)
 #       * :multiple (Boolean) - Match fields that accept multiple values
+#       * :valid (Boolean) - Match fields that are valid/invalid according to HTML5 form validation
 #
 # * **:fieldset** - Select fieldset elements
 #   * Locator: Matches id, {Capybara.configure test_id}, or contents of wrapped legend
@@ -72,6 +73,7 @@ require 'capybara/selector/definition'
 #       * :type (String) - Matches the type attribute of the field or element type for 'textarea'
 #       * :disabled (Boolean, :all) - Match disabled field? (Default: false)
 #       * :multiple (Boolean) - Match fields that accept multiple values
+#       * :valid (Boolean) - Match fields that are valid/invalid according to HTML5 form validation
 #
 # * **:radio_button** - Find radio buttons
 #   * Locator: Match id, {Capybara.configure test_id} attribute, name, or associated label text
@@ -166,6 +168,7 @@ Capybara::Selector::FilterSet.add(:_field) do
   node_filter(:checked, :boolean) { |node, value| !(value ^ node.checked?) }
   node_filter(:unchecked, :boolean) { |node, value| (value ^ node.checked?) }
   node_filter(:disabled, :boolean, default: false, skip_if: :all) { |node, value| !(value ^ node.disabled?) }
+  node_filter(:valid, :boolean) { |node, value| node.evaluate_script('this.validity.valid') == value }
 
   expression_filter(:name) { |xpath, val| xpath[XPath.attr(:name) == val] }
   expression_filter(:placeholder) { |xpath, val| xpath[XPath.attr(:placeholder) == val] }
@@ -182,12 +185,14 @@ Capybara::Selector::FilterSet.add(:_field) do
     desc
   end
 
-  describe(:node_filters) do |checked: nil, unchecked: nil, disabled: nil, **|
+  describe(:node_filters) do |checked: nil, unchecked: nil, disabled: nil, valid: nil, **|
     desc, states = +'', []
     states << 'checked' if checked || (unchecked == false)
     states << 'not checked' if unchecked || (checked == false)
     states << 'disabled' if disabled == true
     desc << " that is #{states.join(' and ')}" unless states.empty?
+    desc << ' that is valid' if valid == true
+    desc << ' that is invalid' if valid == false
     desc
   end
 end

data/lib/capybara/selector/definition/fillable_field.rb

@@ -18,7 +18,7 @@ Capybara.add_selector(:fillable_field, locator_type: [String, Symbol]) do
     end
   end
 
-  filter_set(:_field, %i[disabled multiple name placeholder])
+  filter_set(:_field, %i[disabled multiple name placeholder valid])
 
   node_filter(:with) do |node, with|
     val = node.value

data/lib/capybara/selenium/driver.rb

@@ -430,6 +430,10 @@ private
     ::Capybara::Selenium::Node.new(self, native_node, initial_cache)
   end
 
+  def bridge
+    browser.send(:bridge)
+  end
+
   def specialize_driver
     browser_type = browser.browser
     Capybara::Selenium::Driver.specializations.select { |k, _v| k === browser_type }.each_value do |specialization| # rubocop:disable Style/CaseEquality

data/lib/capybara/selenium/driver_specializations/chrome_driver.rb

@@ -108,10 +108,6 @@ private
     ::Capybara::Selenium::ChromeNode.new(self, native_node, initial_cache)
   end
 
-  def bridge
-    browser.send(:bridge)
-  end
-
   def chromedriver_version
     @chromedriver_version ||= begin
       caps = browser.capabilities

data/lib/capybara/selenium/driver_specializations/edge_driver.rb

@@ -3,6 +3,12 @@
 require 'capybara/selenium/nodes/edge_node'
 
 module Capybara::Selenium::Driver::EdgeDriver
+  def self.extended(base)
+    bridge = base.send(:bridge)
+    bridge.extend Capybara::Selenium::IsDisplayed unless bridge.commands(:is_element_displayed)
+    base.options[:native_displayed] = false if base.options[:native_displayed].nil?
+  end
+
   def fullscreen_window(handle)
     return super if edgedriver_version < 75
 
@@ -108,10 +114,6 @@ private
     ::Capybara::Selenium::EdgeNode.new(self, native_node, initial_cache)
   end
 
-  def bridge
-    browser.send(:bridge)
-  end
-
   def edgedriver_version
     @edgedriver_version ||= begin
       caps = browser.capabilities

data/lib/capybara/selenium/driver_specializations/firefox_driver.rb

@@ -13,12 +13,6 @@ module Capybara::Selenium::Driver::FirefoxDriver
     (defined?(Selenium::WebDriver::VERSION) && (Selenium::WebDriver::VERSION.to_f >= 4)) ||
       driver.browser.capabilities.is_a?(::Selenium::WebDriver::Remote::W3C::Capabilities)
   end
-
-private
-
-  def bridge
-    browser.send(:bridge)
-  end
 end
 
 module Capybara::Selenium::Driver::W3CFirefoxDriver

data/lib/capybara/selenium/driver_specializations/safari_driver.rb

@@ -18,10 +18,6 @@ private
   def build_node(native_node, initial_cache = {})
     ::Capybara::Selenium::SafariNode.new(self, native_node, initial_cache)
   end
-
-  def bridge
-    browser.send(:bridge)
-  end
 end
 
 Capybara::Selenium::Driver.register_specialization(/^(safari|Safari_Technology_Preview)$/,

data/lib/capybara/selenium/extensions/html5_drag.rb

@@ -4,13 +4,14 @@ class Capybara::Selenium::Node
   module Html5Drag
     # Implement methods to emulate HTML5 drag and drop
 
-    def drag_to(element, delay: 0.05)
+    def drag_to(element, html5: nil, delay: 0.05)
       driver.execute_script MOUSEDOWN_TRACKER
       scroll_if_needed { browser_action.click_and_hold(native).perform }
-      if driver.evaluate_script(LEGACY_DRAG_CHECK, self)
-        perform_legacy_drag(element)
-      else
+      html5 = !driver.evaluate_script(LEGACY_DRAG_CHECK, self) if html5.nil?
+      if html5
         perform_html5_drag(element, delay)
+      else
+        perform_legacy_drag(element)
       end
     end
 
@@ -89,6 +90,7 @@ class Capybara::Selenium::Node
     JS
 
     MOUSEDOWN_TRACKER = <<~JS
+      window.capybara_mousedown_prevented = null;
       document.addEventListener('mousedown', ev => {
         window.capybara_mousedown_prevented = ev.defaultPrevented;
       }, { once: true, passive: true })
@@ -96,7 +98,10 @@ class Capybara::Selenium::Node
 
     LEGACY_DRAG_CHECK = <<~JS
       (function(el){
-        if (window.capybara_mousedown_prevented) return true;
+        if ([true, null].indexOf(window.capybara_mousedown_prevented) >= 0){
+          return true;
+        }
+
         do {
           if (el.draggable) return false;
         } while (el = el.parentElement );

data/lib/capybara/selenium/node.rb

@@ -299,11 +299,31 @@ private
   end
 
   def set_file(value) # rubocop:disable Naming/AccessorMethodName
-    path_names = value.to_s.empty? ? [] : value
-    file_names = Array(path_names).map do |pn|
-      Pathname.new(pn).absolute? ? pn : File.expand_path(pn)
-    end.join("\n")
-    native.send_keys(file_names)
+    with_file_detector do
+      path_names = value.to_s.empty? ? [] : value
+      file_names = Array(path_names).map do |pn|
+        Pathname.new(pn).absolute? ? pn : File.expand_path(pn)
+      end.join("\n")
+      native.send_keys(file_names)
+    end
+  end
+
+  def with_file_detector
+    if driver.options[:browser] == :remote &&
+       bridge.respond_to?(:file_detector) &&
+       bridge.file_detector.nil?
+      begin
+        bridge.file_detector = lambda do |(fn, *)|
+          str = fn.to_s
+          str if File.exist?(str)
+        end
+        yield
+      ensure
+        bridge.file_detector = nil
+      end
+    else
+      yield
+    end
   end
 
   def set_content_editable(value) # rubocop:disable Naming/AccessorMethodName
@@ -359,6 +379,10 @@ private
     driver.browser
   end
 
+  def bridge
+    browser.send(:bridge)
+  end
+
   def browser_action
     browser.action
   end

data/lib/capybara/selenium/nodes/chrome_node.rb

@@ -84,10 +84,6 @@ private
     end
   end
 
-  def bridge
-    driver.browser.send(:bridge)
-  end
-
   def w3c?
     (defined?(Selenium::WebDriver::VERSION) && (Selenium::WebDriver::VERSION.to_f >= 4)) ||
       capabilities.is_a?(::Selenium::WebDriver::Remote::W3C::Capabilities)

data/lib/capybara/selenium/nodes/edge_node.rb

@@ -36,14 +36,16 @@ class Capybara::Selenium::EdgeNode < Capybara::Selenium::Node
     html5_drop(*args)
   end
 
-  # def click(*)
-  #   super
-  # rescue ::Selenium::WebDriver::Error::WebDriverError => e
-  #   # chromedriver 74 (at least on mac) raises the wrong error for this
-  #   raise ::Selenium::WebDriver::Error::ElementClickInterceptedError, e.message if e.message.match?(/element click intercepted/)
-  #
-  #   raise
-  # end
+  def click(*)
+    super
+  rescue Selenium::WebDriver::Error::InvalidArgumentError => e
+    tag_name, type = attrs(:tagName, :type).map { |val| val&.downcase }
+    if tag_name == 'input' && type == 'file'
+      raise Selenium::WebDriver::Error::InvalidArgumentError, "EdgeChrome can't click on file inputs.\n#{e.message}"
+    end
+
+    raise
+  end
 
   def disabled?
     return super unless chrome_edge?
@@ -61,6 +63,18 @@ class Capybara::Selenium::EdgeNode < Capybara::Selenium::Node
     click unless selected_or_disabled
   end
 
+  def visible?
+    return super unless chrome_edge? && native_displayed?
+
+    begin
+      bridge.send(:execute, :is_element_displayed, id: native.ref)
+    rescue Selenium::WebDriver::Error::UnknownCommandError
+      # If the is_element_displayed command is unknown, no point in trying again
+      driver.options[:native_displayed] = false
+      super
+    end
+  end
+
 private
 
   def file_errors
@@ -69,10 +83,6 @@ private
     end
   end
 
-  def bridge
-    driver.browser.send(:bridge)
-  end
-
   def browser_version
     @browser_version ||= begin
       caps = driver.browser.capabilities
@@ -83,4 +93,10 @@ private
   def chrome_edge?
     browser_version >= 75
   end
+
+  def native_displayed?
+    (driver.options[:native_displayed] != false) &&
+      # chromedriver_supports_displayed_endpoint? &&
+      (!ENV['DISABLE_CAPYBARA_SELENIUM_OPTIMIZATIONS'])
+  end
 end

data/lib/capybara/selenium/nodes/firefox_node.rb

@@ -115,10 +115,6 @@ private
     actions
   end
 
-  def bridge
-    driver.browser.send(:bridge)
-  end
-
   def upload(local_file)
     return nil unless local_file
     raise ArgumentError, "You may only upload files: #{local_file.inspect}" unless File.file?(local_file)

data/lib/capybara/selenium/nodes/safari_node.rb

@@ -90,10 +90,6 @@ class Capybara::Selenium::SafariNode < Capybara::Selenium::Node
 
 private
 
-  def bridge
-    driver.browser.send(:bridge)
-  end
-
   def _send_keys(keys, actions = browser_action, down_keys = ModifierKeysStack.new)
     case keys
     when *MODIFIER_KEYS

data/lib/capybara/spec/session/has_field_spec.rb

@@ -93,6 +93,24 @@ Capybara::SpecHelper.spec '#has_field' do
       expect(@session).not_to have_field('Html5 Multiple Email', multiple: false)
     end
   end
+
+  context 'with valid', requires: [:js] do
+    it 'should be true if field is valid' do
+      @session.fill_in 'required', with: 'something'
+      @session.fill_in 'length', with: 'abcd'
+
+      expect(@session).to have_field('required', valid: true)
+      expect(@session).to have_field('length', valid: true)
+    end
+
+    it 'should be false if field is invalid' do
+      expect(@session).not_to have_field('required', valid: true)
+      expect(@session).to have_field('required', valid: false)
+
+      @session.fill_in 'length', with: 'abc'
+      expect(@session).not_to have_field('length', valid: true)
+    end
+  end
 end
 
 Capybara::SpecHelper.spec '#has_no_field' do

data/lib/capybara/spec/session/node_spec.rb

@@ -444,6 +444,20 @@ Capybara::SpecHelper.spec 'node' do
       end
     end
 
+    it 'should work with jsTree' do
+      @session.visit('/with_jstree')
+      @session.within(:css, '#container') do
+        @session.assert_text(/A.*B.*C/m)
+        source = @session.find(:css, '#j1_1_anchor')
+        target = @session.find(:css, '#j1_2_anchor')
+
+        source.drag_to(target)
+
+        @session.assert_no_text(/A.*B.*C/m)
+        @session.assert_text(/B.*C/m)
+      end
+    end
+
     context 'HTML5', requires: %i[js html5_drag] do
       it 'should HTML5 drag and drop an object' do
         @session.visit('/with_js')

data/lib/capybara/spec/views/form.erb

@@ -1,7 +1,7 @@
 
 <h1>Form</h1>
 
-<form action="/form" method="post">
+<form action="/form" method="post" novalidate>
 
   <p>
     <label for="form_title">Title</label>
@@ -460,6 +460,11 @@ New line after and before textarea tag
     <input id="readonly" name="form[readonly_test]" readonly/>
     <input id="not_readonly" name="form[readonly_test]" />
   </p>
+
+  <p>
+    <input id="required" name="form[required]" required />
+    <input id="length" name="form[length]" minlength="4" maxlength="4" />
+  </p>
 </form>
 
 <input type="text" name="form[outside_input]" value="outside_input" form="form1"/>

data/lib/capybara/spec/views/with_jstree.erb

@@ -0,0 +1,26 @@
+<!doctype html>
+<html>
+  <head>
+    <meta http-equiv="Content-type" content="text/html; charset=utf-8"/>
+    <title>with_jstree</title>
+  </head>
+  <body id="with_jstree">
+    <div id="container">
+      <ul>
+        <li>Child node A</li>
+        <li>Child node B</li>
+        <li>Child node C</li>
+      </ul>
+    </div>
+    <script src="https://cdnjs.cloudflare.com/ajax/libs/jquery/3.2.1/jquery.min.js"></script>
+    <script src="https://cdnjs.cloudflare.com/ajax/libs/jstree/3.3.8/jstree.min.js"></script>
+    <script>
+      $(function () {
+        $('#container').jstree({
+          "core" : { "check_callback" : true }, // so that operations work
+          "plugins" : ["dnd"]
+        });
+      });
+    </script>
+  </body>
+</html>

data/lib/capybara/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Capybara
-  VERSION = '3.27.0'
+  VERSION = '3.28.0'
 end

data/spec/selenium_spec_chrome_remote.rb

@@ -54,12 +54,6 @@ module TestSessions
   Chrome = Capybara::Session.new(CHROME_REMOTE_DRIVER, TestApp)
 end
 
-TestSessions::Chrome.driver.browser.file_detector = lambda do |args|
-  # args => ["/path/to/file"]
-  str = args.first.to_s
-  str if File.exist?(str)
-end
-
 skipped_tests = %i[response_headers status_code trigger download]
 
 Capybara::SpecHelper.run_specs TestSessions::Chrome, CHROME_REMOTE_DRIVER.to_s, capybara_skip: skipped_tests do |example|

data/spec/selenium_spec_edge.rb

@@ -6,16 +6,19 @@ require 'shared_selenium_session'
 require 'shared_selenium_node'
 require 'rspec/shared_spec_matchers'
 
-unless ENV['CI']
-  Selenium::WebDriver::Edge::Service.driver_path = '/usr/local/bin/msedgedriver'
-  Selenium::WebDriver::EdgeChrome.path = '/Applications/Microsoft Edge Canary.app/Contents/MacOS/Microsoft Edge Canary'
-end
+# unless ENV['CI']
+#   Selenium::WebDriver::Edge::Service.driver_path = '/usr/local/bin/msedgedriver'
+# end
 
-Webdrivers::Edgedriver.required_version = '76.0.168' if ENV['CI']
+if ::Selenium::WebDriver::Platform.mac?
+  Selenium::WebDriver::EdgeChrome.path = '/Applications/Microsoft Edge Dev.app/Contents/MacOS/Microsoft Edge Dev'
+end
 
 Capybara.register_driver :selenium_edge do |app|
   # ::Selenium::WebDriver.logger.level = "debug"
-  Capybara::Selenium::Driver.new(app, browser: :edge_chrome).tap do |driver|
+  # If we don't create an options object the path set above won't be used
+  browser_options = ::Selenium::WebDriver::EdgeChrome::Options.new
+  Capybara::Selenium::Driver.new(app, browser: :edge_chrome, options: browser_options).tap do |driver|
     driver.browser
     driver.download_path = Capybara.save_path
   end
@@ -27,17 +30,13 @@ end
 
 skipped_tests = %i[response_headers status_code trigger]
 
-Capybara::SpecHelper.log_selenium_driver_version(Selenium::WebDriver::Edge) if ENV['CI']
+Capybara::SpecHelper.log_selenium_driver_version(Selenium::WebDriver::EdgeChrome) if ENV['CI']
 
 Capybara::SpecHelper.run_specs TestSessions::SeleniumEdge, 'selenium', capybara_skip: skipped_tests do |example|
-  # case example.metadata[:description]
-  # when /#refresh it reposts$/
-  #   skip 'Edge insists on prompting without providing a way to suppress'
-  # when /should be able to open non-http url/
-  #   skip 'Crashes'
-  # when /when Capybara.always_include_port is true/
-  #   skip 'Crashes'
-  # end
+  case example.metadata[:full_description]
+  when 'Capybara::Session selenium #attach_file with a block can upload by clicking the file input'
+    pending "EdgeChrome doesn't allow clicking on file inputs"
+  end
 end
 
 RSpec.describe 'Capybara::Session with Edge', capybara_skip: skipped_tests do

data/spec/selenium_spec_firefox_remote.rb

@@ -50,12 +50,6 @@ module TestSessions
   RemoteFirefox = Capybara::Session.new(FIREFOX_REMOTE_DRIVER, TestApp)
 end
 
-TestSessions::RemoteFirefox.driver.browser.file_detector = lambda do |args|
-  # args => ["/path/to/file"]
-  str = args.first.to_s
-  str if File.exist?(str)
-end
-
 skipped_tests = %i[response_headers status_code trigger download]
 
 Capybara::SpecHelper.run_specs TestSessions::RemoteFirefox, FIREFOX_REMOTE_DRIVER.to_s, capybara_skip: skipped_tests do |example|

data/spec/selenium_spec_ie.rb

@@ -39,12 +39,7 @@ Capybara.register_driver :selenium_ie do |app|
     Capybara::Selenium::Driver.new(app,
                                    browser: :remote,
                                    options: options,
-                                   url: url).tap do |driver|
-      driver.browser.file_detector = lambda do |args|
-        str = args.first.to_s
-        str if File.exist?(str)
-      end
-    end
+                                   url: url)
   else
     Capybara::Selenium::Driver.new(
       app,

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.27.0
+  version: 3.28.0
 platform: ruby
 authors:
 - Thomas Walpole
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - gem-public_cert.pem
-date: 2019-07-28 00:00:00.000000000 Z
+date: 2019-08-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -451,6 +451,7 @@ files:
 - lib/capybara/rack_test/node.rb
 - lib/capybara/rails.rb
 - lib/capybara/registrations/drivers.rb
+- lib/capybara/registrations/patches/puma_ssl.rb
 - lib/capybara/registrations/servers.rb
 - lib/capybara/result.rb
 - lib/capybara/rspec.rb
@@ -668,6 +669,7 @@ files:
 - lib/capybara/spec/views/with_html5_svg.erb
 - lib/capybara/spec/views/with_html_entities.erb
 - lib/capybara/spec/views/with_js.erb
+- lib/capybara/spec/views/with_jstree.erb
 - lib/capybara/spec/views/with_namespace.erb
 - lib/capybara/spec/views/with_scope.erb
 - lib/capybara/spec/views/with_scope_other.erb