capybara 3.20.0 → 3.20.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '087a3e5a863f14cabebd8344fa0e2f04cb5c48c386014e5fd46eab2e715a8040'
-  data.tar.gz: 2ea4bc5aec32f6a7bd63856d922264d29d9629f4c6af71867d30b963d2f04697
+  metadata.gz: 6a7113f8a1fdef865586a49c01ae406da91d172955acf96b4038f81d39afdd4d
+  data.tar.gz: 9d01e25c2d34e5e2870da21ed33e3b136630c3b035fec3c95aeaccf02548e0cc
 SHA512:
-  metadata.gz: cbc11a7fe022eb230aa9e9342d26b88619cb3cb65931b89487ff448575e6cb794e7460679bd1c37c336bdd65229ca72b4e489b5fbe1a5e2ea7ff92945bb1a1ca
-  data.tar.gz: 0a3103be3113216c40efa1cb22cc261141ed940e205c6e9e9483233c5e672079da5b6950aa4f1bf6871524a6f803eb400ed735f48e13429f57eaa9e8376ae367
+  metadata.gz: ca15a47f8e6e98479d369c90518815fdecc62c2b0e576794fa88ec62a3fb5a39047733a482ec85af6ea85c359932b2c91d9dd77c84945b25021e21338787338e
+  data.tar.gz: ade8a1e834b23281cbcab18fdf226dcd5f7617d1fc9325c52d766f031497f0a1ef1129ff3582c5b87ce8df46a9449fbc6bd156a5e7fb5d941d5322751e4cd9de

data/History.md

@@ -1,5 +1,13 @@
+# Version 3.20.1
+Release date: 2019-05-17
+
+### Fixed
+
+* RackTest driver considers <template> elements to be non-visible and ignores the contents
+
 # Version 3.20.0
 Release date: 2019-05-14
+
 ### Added
 
 * `Node#obscured?` to check viewport presence and element overlap

data/lib/capybara.rb

@@ -371,6 +371,10 @@ module Capybara
     def HTML(html) # rubocop:disable Naming/MethodName
       if Nokogiri.respond_to?(:HTML5) && Capybara.allow_gumbo # Nokogumbo installed and allowed for use
         Nokogiri::HTML5(html).tap do |document|
+          document.xpath('//template').each do |template|
+            # template elements content is not part of the document
+            template.inner_html = ''
+          end
           document.xpath('//textarea').each do |textarea|
             # The Nokogumbo HTML5 parser already returns spec compliant contents
             textarea['_capybara_raw_value'] = textarea.content
@@ -378,6 +382,10 @@ module Capybara
         end
       else
         Nokogiri::HTML(html).tap do |document|
+          document.xpath('//template').each do |template|
+            # template elements content is not part of the document
+            template.inner_html = ''
+          end
           document.xpath('//textarea').each do |textarea|
             textarea['_capybara_raw_value'] = textarea.content.sub(/\A\n/, '')
           end

data/lib/capybara/node/simple.rb

@@ -102,6 +102,7 @@ module Capybara
       #
       def visible?(check_ancestors = true)
         return false if (tag_name == 'input') && (native[:type] == 'hidden')
+        return false if tag_name == 'template'
 
         if check_ancestors
           !find_xpath(VISIBILITY_XPATH)

data/lib/capybara/spec/session/node_spec.rb

@@ -242,6 +242,7 @@ Capybara::SpecHelper.spec 'node' do
       expect(@session.find('//div[@id="hidden_attr"]')).not_to be_visible
       expect(@session.find('//a[@id="hidden_attr_via_ancestor"]')).not_to be_visible
       expect(@session.find('//input[@id="hidden_input"]')).not_to be_visible
+      expect(@session.find('//template')).not_to be_visible
     end
 
     it 'should be boolean' do

data/lib/capybara/spec/session/scroll_spec.rb

@@ -24,7 +24,7 @@ Capybara::SpecHelper.spec '#scroll_to', requires: [:scroll] do
     @session.scroll_to(el, align: :center)
     el_center = el.evaluate_script('(function(rect){return (rect.top + rect.bottom)/2})(this.getBoundingClientRect())')
     viewport_bottom = el.evaluate_script('document.body.clientHeight')
-    expect(el_center).to be_within(1).of(viewport_bottom / 2)
+    expect(el_center).to be_within(2).of(viewport_bottom / 2)
   end
 
   it 'can scroll the window to the vertical top' do

data/lib/capybara/spec/views/with_html.erb

@@ -178,5 +178,9 @@ banana</textarea>
 &#x20;&#x1680;&#x2000;&#x2001;&#x2002; &#x2003;&#x2004;&nbsp;&#x2005; &#x2006;&#x2007;&#x2008;&#x2009;&#x200A;&#x202F;&#x205F;&#x3000;
 </div>
 
+<template id="template">
+  <input />
+</template>
+
 <a href="/download.csv" download>Download Me</a>
 <a href="/download.csv" download="other.csv">Download Other</a>

data/lib/capybara/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Capybara
-  VERSION = '3.20.0'
+  VERSION = '3.20.1'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara
 version: !ruby/object:Gem::Version
-  version: 3.20.0
+  version: 3.20.1
 platform: ruby
 authors:
 - Thomas Walpole
@@ -10,7 +10,7 @@ autorequire:
 bindir: bin
 cert_chain:
 - gem-public_cert.pem
-date: 2019-05-15 00:00:00.000000000 Z
+date: 2019-05-17 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable