capybara-webkit 1.8.0 → 1.9.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 02ad3535fdad745cf9b7aac9b2da913420070788
-  data.tar.gz: 2fa85fc80384cba0e272bf026158382946836cf7
+  metadata.gz: 60209d81bf188faa0999eaefc0ed131547e4bcc1
+  data.tar.gz: 69865244998cee40ed5a6a49225f6ae555962ecf
 SHA512:
-  metadata.gz: 542d81525108392ad7e40e400f519b326543b791c2175f334a86d82efcdef8cfd085d2a4dacef87be243c6508de057eb3e4c53e78e23c7493db0cfbb51a6cbaf
-  data.tar.gz: 610466612a11c0dd32b8d97b50f38a2d85473c9588abe11c76fc3fd6a3948d6bf23b3b32c948a6a2ce59229da2824a67308d7a3fc0858a44e5ba2d68f506cff2
+  metadata.gz: f9287cdc79dc08a5c996d8cb7275bbf002e53589f68d009472f057ed66b17391e14d30ed5ff4264bc87f71c26aa2eb76ca1861e5ac25592c4e6715095a6f50b1
+  data.tar.gz: 0ce7df637af72ca80c176649c9e9ec456b0ebf6991f0f8e47edc33e81fced0b577ee351ce7cf7c5e016bebb7e39aab01189cf0f8fc35f4a55b562f7adcf39c1c

data/NEWS.md

@@ -1,3 +1,9 @@
+New for 1.9.0:
+
+* Raise error for Qt version greater than 5.5
+* Fix hovering SVG elements
+* Add basic send_keys implementation
+
 New for 1.8.0:
 
 * Allow Capybara 2.6

data/README.md

@@ -190,15 +190,6 @@ Thank you, [contributors]!
 [CONTRIBUTING]: CONTRIBUTING.md
 [contributors]: https://github.com/thoughtbot/capybara-webkit/graphs/contributors
 
-Need Help?
-----------
-
-We offer 1-on-1 coaching. We can help you install Qt, set up Capybara, get
-started writing integration tests, and track down slow or erratic tests. [Get in
-touch].
-
-[Get in touch]: http://coaching.thoughtbot.com/rails/?utm_source=github
-
 License
 -------
 

data/gemfiles/2.4.gemfile

@@ -2,7 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "mime-types", "< 3.0", :platforms=>[:ruby_19, :jruby_19]
 gem "capybara", "~> 2.4.0"
-gem "mime-types", "< 3.0", platforms: [:ruby_19, :jruby_19]
 
 gemspec :path=>"../"

data/gemfiles/2.5.gemfile

@@ -2,7 +2,7 @@
 
 source "https://rubygems.org"
 
+gem "mime-types", "< 3.0", :platforms=>[:ruby_19, :jruby_19]
 gem "capybara", "~> 2.5.0"
-gem "mime-types", "< 3.0", platforms: [:ruby_19, :jruby_19]
 
 gemspec :path=>"../"

data/gemfiles/master.gemfile

@@ -2,7 +2,7 @@
 
 source "https://rubygems.org"
 
-gem "capybara", github: "jnicklas/capybara"
-gem "mime-types", "<3.0", platforms: [:ruby_19, :jruby_19]
+gem "mime-types", "< 3.0", :platforms=>[:ruby_19, :jruby_19]
+gem "capybara", :github=>"jnicklas/capybara"
 
 gemspec :path=>"../"

data/lib/capybara/webkit/node.rb

@@ -47,6 +47,21 @@ module Capybara::Webkit
       invoke "set", *[value].flatten
     end
 
+    def send_keys(*keys)
+      invoke("sendKeys", keys.map { |key|
+        case key
+        when :space
+          " "
+        when :enter
+          "\r"
+        when String
+          key.to_s
+        else
+          raise Capybara::NotSupportedByDriverError.new
+        end
+      }.join)
+    end
+
     def select_option
       invoke "selectOption"
     end

data/lib/capybara/webkit/version.rb

@@ -1,7 +1,7 @@
 module Capybara
   module Driver
     class Webkit
-      VERSION = "1.8.0".freeze
+      VERSION = "1.9.0".freeze
     end
   end
 end

data/spec/driver_spec.rb

@@ -1526,6 +1526,7 @@ describe Capybara::Webkit::Driver do
           #hover { max-width: 30em; }
           #hover span { line-height: 1.5; }
           #hover span:hover + .hidden { display: block; }
+          #circle_hover:hover + .hidden { display: block; }
           .hidden { display: none; }
         </style>
         </head>
@@ -1537,6 +1538,10 @@ describe Capybara::Webkit::Driver do
             <span>This really long paragraph has a lot of text and will wrap. This sentence ensures that we have four lines of text.</span>
             <div class="hidden">Text that only shows on hover.</div>
           </div>
+          <svg height="200" width="300">
+            <circle id="circle_hover" cx="50" cy="50" r="40" stroke="black" stroke-width="3" fill="red" />
+            <text class="hidden" y="110"> Sibling that only shows when circle is hovered over.</text>
+          </svg>
           <form action="/" method="GET">
             <select id="change_select" name="change_select">
               <option value="1" id="option-1" selected="selected">one</option>
@@ -1574,6 +1579,13 @@ describe Capybara::Webkit::Driver do
       driver.find_css("#hover").first.visible_text.should =~ /Text that only shows on hover/
     end
 
+    it "hovers an svg element" do
+      # visible_text does not work for SVG elements. It returns all the text.
+      driver.find_css("text").first.should_not be_visible
+      driver.find_css("#circle_hover").first.hover
+      driver.find_css("text").first.should be_visible
+    end
+
     it "hovers an element off the screen" do
       driver.resize_window(200, 200)
       driver.evaluate_script(<<-JS)

data/spec/spec_helper.rb

@@ -49,9 +49,11 @@ RSpec.configure do |c|
 
   # We can't support outerWidth and outerHeight without a visible window.
   # We focus the next window instead of failing when closing windows.
-  # Node #send_keys is not yet implemented.
   c.filter_run_excluding :full_description => lambda { |description, metadata|
-    description =~ /Capybara::Session webkit Capybara::Window #(size|resize_to|maximize|close.*no_such_window_error|send_keys)/ || description =~ /Capybara::Session webkit node #send_keys/
+    (description !~ /Capybara::Session webkit node #send_keys should send a string of keys to an element/) && (
+      description =~ /Capybara::Session webkit Capybara::Window #(size|resize_to|maximize|close.*no_such_window_error|send_keys)/ ||
+      description =~ /Capybara::Session webkit node #send_keys/
+    )
   }
 end
 

data/src/capybara.js

@@ -184,13 +184,20 @@ Capybara = {
   },
 
   clickPosition: function(node) {
-    var rects = node.getClientRects();
-    var rect;
+    if(node.namespaceURI == 'http://www.w3.org/2000/svg') {
+      var rect = node.getBoundingClientRect();
 
-    for (var i = 0; i < rects.length; i++) {
-      rect = rects[i];
       if (rect.width > 0 && rect.height > 0)
         return CapybaraInvocation.clickPosition(node, rect.left, rect.top, rect.width, rect.height);
+    } else {
+      var rects = node.getClientRects();
+      var rect;
+
+      for (var i = 0; i < rects.length; i++) {
+        rect = rects[i];
+        if (rect.width > 0 && rect.height > 0)
+          return CapybaraInvocation.clickPosition(node, rect.left, rect.top, rect.width, rect.height);
+      }
     }
 
     var visible = this.isNodeVisible(node);
@@ -269,6 +276,20 @@ Capybara = {
     return true;
   },
 
+  sendKeys: function (index, keys) {
+    var strindex, length;
+
+    length = keys.length;
+
+    if (length) {
+      this.focus(index);
+    }
+
+    for (strindex = 0; strindex < length; strindex++) {
+      CapybaraInvocation.keypress(keys[strindex]);
+    }
+  },
+
   set: function (index, value) {
     var length, maxLength, node, strindex, textTypes, type;
 
@@ -293,8 +314,9 @@ Capybara = {
           CapybaraInvocation.keypress(value[strindex]);
         }
 
-        if (value == '')
+        if (value === "") {
           this.trigger(index, "change");
+        }
       }
     } else if (type === "checkbox" || type === "radio") {
       if (node.checked != (value === "true")) {

data/src/webkit_server.pro

@@ -176,6 +176,9 @@ SOURCES = \
 RESOURCES = webkit_server.qrc
 QT += network
 greaterThan(QT_MAJOR_VERSION, 4) {
+  greaterThan(QT_MAJOR_VERSION, 5) | greaterThan(QT_MINOR_VERSION, 5) {
+    error(capybara-webkit does not support Qt versions greater than 5.5)
+  }
   QT += webkitwidgets
 } else {
   QT += webkit

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara-webkit
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.9.0
 platform: ruby
 authors:
 - thoughtbot
@@ -13,7 +13,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-01-22 00:00:00.000000000 Z
+date: 2016-03-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: capybara
@@ -400,21 +400,4 @@ rubygems_version: 2.4.5.1
 signing_key: 
 specification_version: 4
 summary: Headless Webkit driver for Capybara
-test_files:
-- spec/browser_spec.rb
-- spec/capybara_webkit_builder_spec.rb
-- spec/configuration_spec.rb
-- spec/connection_spec.rb
-- spec/cookie_jar_spec.rb
-- spec/driver_rendering_spec.rb
-- spec/driver_resize_window_spec.rb
-- spec/driver_spec.rb
-- spec/errors_spec.rb
-- spec/integration/session_spec.rb
-- spec/selenium_compatibility_spec.rb
-- spec/self_signed_ssl_cert.rb
-- spec/spec_helper.rb
-- spec/support/app_runner.rb
-- spec/support/matchers/include_response.rb
-- spec/support/output_writer.rb
-has_rdoc: 
+test_files: []