capybara-screenshot-diff 0.6.0 → 0.7.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3417ac0f41265b198a6807b0ae2ea3fe24d4fcae
-  data.tar.gz: efcc110c396d89cf8ed51e982c57cc1a6c3e9b4b
+  metadata.gz: c51c0b3910c0d9084516caa214cc4def9f3555e5
+  data.tar.gz: d6a6c7b9c780bba92792dea8d18ad5e6a4309004
 SHA512:
-  metadata.gz: 0d1aecff95b1e1eb031397488bec689f4f1410de71a093914fc2601932237abfb8de30dce236ececb641c0b85dae350d012b6881a5e69c01b1f0eafea300fae9
-  data.tar.gz: 19bb7deb896fe5de11c94ca2d1c4309dba6a774603b859050ff1a6c31a3cc07c5b5e1cdac4355b35b154cea3db5bbf108cd3572e6b32a75845104b4935922d89
+  metadata.gz: ff97131d3381c1db29293d78c70d090ef0f08e31878f2c680305bf2e0205d79257acfee39769b0025d75a56137ed6ef31338333ac682571c2856118cffb3560c
+  data.tar.gz: 55375885f91dff602b8744a46254261597fc19d1066057e350623bcb96152f0c28853be88b4436920c91e54e9d8f084c913454e4c23148bd0f3bb986e5331c61

data/.rubocop_todo.yml

@@ -16,12 +16,12 @@ Layout/IndentHeredoc:
 
 # Offense count: 7
 Metrics/AbcSize:
-  Max: 26
+  Max: 28
 
 # Offense count: 1
 # Configuration parameters: CountComments.
 Metrics/ClassLength:
-  Max: 186
+  Max: 188
 
 # Offense count: 2
 Metrics/CyclomaticComplexity:

data/README.md

@@ -243,10 +243,24 @@ Capybara::Screenshot.stability_time_limit = 0.5
 
 
 
+### Removing focus from the active element
+
+In Chrome the screenshot includes the blinking input cursor.  This can make it impossible to get a
+stable screenshot.  To get around this you can set the `blur_active_element` option:
+
+```ruby
+Capybara::Screenshot.blur_active_element = true
+```
+
+This will remove the focus from the active element, removing the blinking cursor.
+
+
+
 ### Allowed color distance
 
-Sometimes you want to allow small differences in the images.  You can set set the difference
-threshold for the comparison using the `color_distance_limit` option to the `screenshot` method:
+Sometimes you want to allow small differences in the images.  For example, Chrome renders the same
+page slightly differently sometimes.  You can set set the difference threshold for the comparison
+using the `color_distance_limit` option to the `screenshot` method:
 
 ```ruby
 test 'color threshold' do

data/lib/capybara/screenshot/diff.rb

@@ -6,6 +6,7 @@ module Capybara
   module Screenshot
     mattr_accessor :add_driver_path
     mattr_accessor :add_os_path
+    mattr_accessor :blur_active_element
     mattr_accessor :enabled
     mattr_accessor :screenshot_root
     mattr_accessor :stability_time_limit

data/lib/capybara/screenshot/diff/capybara_setup.rb

@@ -196,6 +196,7 @@ EOF
 
     private def take_stable_screenshot(comparison)
       assert_images_loaded
+      execute_script('document.activeElement.blur()') if Capybara::Screenshot.blur_active_element
       previous_file_size = comparison.old_file_size
       screeenshot_started_at = last_image_change_at = Time.now
       loop do
@@ -236,7 +237,7 @@ EOF
 
     def assert_image_not_changed(caller, name, comparison)
       return unless comparison.different?
-      "Screenshot does not match for '#{name}' (area: #{comparison.size} #{comparison.dimensions}" \
+      "Screenshot does not match for '#{name}' (area: #{comparison.size}px #{comparison.dimensions}" \
         ", max_color_distance: #{comparison.max_color_distance.round(1)})\n" \
         "#{comparison.new_file_name}\n#{comparison.annotated_old_file_name}\n" \
         "#{comparison.annotated_new_file_name}\n" \

data/lib/capybara/screenshot/diff/image_compare.rb

@@ -29,7 +29,7 @@ module Capybara
         end
 
         def reset
-          @max_color_distance = 0 if @color_distance_limit
+          @max_color_distance = @color_distance_limit ? 0 : nil
           @left = @top = @right = @bottom = nil
         end
 
@@ -229,13 +229,12 @@ module Capybara
         private def same_color?(old_img, new_img, x, y)
           org_color = old_img[x, y]
           new_color = new_img[x, y]
-          if @color_distance_limit && @color_distance_limit > 0
-            distance = ChunkyPNG::Color.euclidean_distance_rgba(org_color, new_color)
-            @max_color_distance = distance if distance > @max_color_distance
-            distance <= @color_distance_limit
-          else
-            org_color == new_color
-          end
+          return true if org_color == new_color
+
+          distance = ChunkyPNG::Color.euclidean_distance_rgba(org_color, new_color)
+          @max_color_distance = distance if !@max_color_distance || distance > @max_color_distance
+
+          @color_distance_limit && @color_distance_limit > 0 && distance <= @color_distance_limit
         end
       end
     end

data/lib/capybara/screenshot/diff/version.rb

@@ -3,7 +3,7 @@
 module Capybara
   module Screenshot
     module Diff
-      VERSION = '0.6.0'.freeze
+      VERSION = '0.7.0'.freeze
     end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capybara-screenshot-diff
 version: !ruby/object:Gem::Version
-  version: 0.6.0
+  version: 0.7.0
 platform: ruby
 authors:
 - Uwe Kubosch
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-07-06 00:00:00.000000000 Z
+date: 2017-07-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: actionpack