capybara-playwright-driver 0.5.7 → 0.5.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 36e3eb177b25d9c711d190e31beeeebc7fcba4a40b5c1ffa6d2e995ac2b34219
-  data.tar.gz: 961a358b0aeb9cf2ededd3491b0850e8df4ce9ccdf3c3a895cd69fea589923ad
+  metadata.gz: fe14f82e64d08efc962dda883c9c4a6b54b794c75bb5458c522fbf88e839267a
+  data.tar.gz: 59156f6e1a5db3dd787b1342cafd5c9f8aca74df33042013304cdd029875e64c
 SHA512:
-  metadata.gz: d62a3e62ceee42b31676fa7e2728e1d49e24592f32b889a7cf8732ad076bfae839b4009ee56f4031657c6906f2906e412f1df442482ac79b0974a35722fa07a4
-  data.tar.gz: 12d105953dd329eb5eb118d1ab81370f395810004b2e940dc356f5457f36db96ede3fc75938727374124cc9cccb0fb83fe4d71e65b167071bdea7d47a7b8e634
+  metadata.gz: 3bbf39026f4bc9dfdce2c319510c709e00b6eb5a890e8057566f57a2b804e2890ff3ee97d67a8ba5da3fe7ede58c526f4b239cd425fe6ac47f049075a83a0a7d
+  data.tar.gz: 813ccb3ce551cb1a3484d261096d8847d045cd694b6dc8275ba27f4012fab798ed23ad2bf36f2996818b653bf6ed4d0213d8f7c9f131cccf1c242450ea86327c

data/README.md

@@ -43,10 +43,27 @@ end
 
 Refer the [documentation](https://playwright-ruby-client.vercel.app/docs/article/guides/rails_integration) for more detailed configuration.
 
+## Development
+
+Prepare to run tests:
+
+```bash
+bundle install
+export PLAYWRIGHT_CLI_VERSION=$(bundle exec ruby -e 'require "playwright"; puts Playwright::COMPATIBLE_PLAYWRIGHT_VERSION.strip')
+npm install playwright@${PLAYWRIGHT_CLI_VERSION}
+./node_modules/.bin/playwright install --with-deps
+```
+
+Now, run tests: note that they are run in a virtual framebuffer (Xvfb).
+
+```bash
+PLAYWRIGHT_CLI_EXECUTABLE_PATH=./node_modules/.bin/playwright xvfb-run bundle exec rspec
+```
+
 ## License
 
 The gem is available as open source under the terms of the [MIT License](https://opensource.org/licenses/MIT).
 
 ## Code of Conduct
 
-Everyone interacting in the Capybara::Playwright project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/[USERNAME]/capybara-playwright/blob/master/CODE_OF_CONDUCT.md).
+Everyone interacting in the Capybara::Playwright project’s codebases, issue trackers, chat rooms and mailing lists is expected to follow the [code of conduct](https://github.com/YusukeIwaki/capybara-playwright-driver/blob/main/CODE_OF_CONDUCT.md).

data/capybara-playwright.gemspec

@@ -20,8 +20,6 @@ Gem::Specification.new do |spec|
       f.match(%r{^(test|spec|features)/}) || f.include?('.git')
     end
   end
-  spec.bindir        = 'exe'
-  spec.executables   = spec.files.grep(%r{^exe/}) { |f| File.basename(f) }
   spec.require_paths = ['lib']
 
   spec.required_ruby_version = '>= 2.4'

data/lib/capybara/playwright/browser.rb

@@ -84,7 +84,8 @@ module Capybara
             path
           end
 
-          @playwright_page.capybara_current_frame.goto(url)
+          response = @playwright_page.capybara_current_frame.goto(url)
+          @playwright_page.capybara_set_last_response(response)
         }
       end
 
@@ -144,13 +145,15 @@ module Capybara
 
       def go_back
         assert_page_alive {
-          @playwright_page.go_back
+          response = @playwright_page.go_back
+          @playwright_page.capybara_set_last_response(response)
         }
       end
 
       def go_forward
         assert_page_alive {
-          @playwright_page.go_forward
+          response = @playwright_page.go_forward
+          @playwright_page.capybara_set_last_response(response)
         }
       end
 

data/lib/capybara/playwright/driver.rb

@@ -90,8 +90,8 @@ module Capybara
           end
         end
 
-        # video path can be aquired only before closing context.
-        # video is completedly saved only after closing context.
+        # video path can be acquired only before closing context.
+        # video is completely saved only after closing context.
         video_path = @browser&.video_path
 
         # [NOTE] @playwright_browser should keep alive for better performance.

data/lib/capybara/playwright/node.rb

@@ -30,6 +30,75 @@ module Capybara
   end
   Node::Element.prepend(WithElementHandlePatch)
 
+  module NodeActionsAllowLabelClickPatch
+    def choose(locator = nil, **options)
+      _playwright_check_via_get_by_label(locator, checked: true, **options) { super }
+    end
+
+    def check(locator = nil, **options)
+      _playwright_check_via_get_by_label(locator, checked: true, **options) { super }
+    end
+
+    def uncheck(locator = nil, **options)
+      _playwright_check_via_get_by_label(locator, checked: false, **options) { super }
+    end
+
+    private def _playwright_check_via_get_by_label(locator, checked:, allow_label_click: session_options.automatic_label_click, **options)
+      unless _playwright_use_get_by_label?(locator, allow_label_click, options)
+        return yield
+      end
+
+      return self if _playwright_try_get_by_label(locator, checked: checked)
+
+      yield
+    end
+
+    private def _playwright_use_get_by_label?(locator, allow_label_click, options)
+      return false if locator.nil?
+      return false unless allow_label_click
+      return false unless driver.is_a?(Capybara::Playwright::Driver)
+      return false if Hash.try_convert(allow_label_click)
+      return false unless options.empty?
+
+      true
+    end
+
+    private def _playwright_try_get_by_label(locator, checked:)
+      handled = false
+      driver.with_playwright_page do |playwright_page|
+        begin
+          control_locator = playwright_page.get_by_label(locator.to_s)
+          control = control_locator
+
+          if control.evaluate('el => !!el.checked') != checked
+            label = control.evaluate_handle('(el) => (el.labels && el.labels[0]) || el.closest("label") || null')
+            next unless label.is_a?(::Playwright::ElementHandle)
+
+            label.click
+          end
+
+          next unless control.evaluate('el => !!el.checked') == checked
+
+          handled = true
+        rescue ::Playwright::Error
+          handled = false
+        end
+      end
+
+      handled
+    rescue StandardError
+      false
+    end
+  end
+  if Gem::Version.new(RUBY_VERSION) >= Gem::Version.new('2.7')
+    # Prepend to Node::Base instead of Node::Actions because Ruby < 3.1
+    # does not propagate Module#prepend to classes that have already
+    # included the target module. Node::Base includes Node::Actions at
+    # load time, so prepending to Node::Actions afterwards has no effect
+    # on Node::Document / Node::Element in older Rubies.
+    Node::Base.prepend(NodeActionsAllowLabelClickPatch)
+  end
+
   module CapybaraObscuredPatch
     # ref: https://github.com/teamcapybara/capybara/blob/f7ab0b5cd5da86185816c2d5c30d58145fe654ed/lib/capybara/selenium/node.rb#L523
     OBSCURED_OR_OFFSET_SCRIPT = <<~JAVASCRIPT
@@ -97,6 +166,8 @@ module Capybara
           raise StaleReferenceError.new(err)
         when /error in channel "content::page": exception while running method "adoptNode"/ # for Firefox
           raise StaleReferenceError.new(err)
+        when /(: Shadow DOM element - no XPath :)/
+          raise StaleReferenceError.new(err)
         else
           raise
         end
@@ -905,6 +976,9 @@ module Capybara
                 xpath = el.nodeName.toUpperCase()+"["+pos+"]/"+xpath;
               }
               el = el.parentNode;
+              if (!el) {
+                throw "(: Shadow DOM element - no XPath :)";
+              }
             }
             xpath = '/'+xml.documentElement.nodeName.toUpperCase()+'/'+xpath;
             xpath = xpath.replace(/\\/$/, '');

data/lib/capybara/playwright/page.rb

@@ -17,7 +17,7 @@ module Capybara
       end
 
       private def capybara_initialize
-        @capybara_all_responses = {}
+        @capybara_response_mutex = Mutex.new
         @capybara_last_response = nil
         @capybara_frames = []
 
@@ -31,13 +31,9 @@ module Capybara
           Thread.new(dest) { |_dest| download.save_as(_dest) }
         })
         on('response', -> (response) {
-          @capybara_all_responses[response.url] = response
-        })
-        on('framenavigated', -> (frame) {
-          @capybara_last_response = @capybara_all_responses[frame.url]
-        })
-        on('load', -> (page) {
-          @capybara_all_responses.clear
+          if response.request.navigation_request?
+            capybara_set_last_response(response)
+          end
         })
       end
 
@@ -146,6 +142,12 @@ module Capybara
         end
       end
 
+      def capybara_set_last_response(response)
+        @capybara_response_mutex.synchronize do
+          @capybara_last_response = response
+        end
+      end
+
       class Headers < Hash
         def [](key)
           # Playwright accepts lower-cased keys.
@@ -155,7 +157,7 @@ module Capybara
       end
 
       def capybara_response_headers
-        headers = @capybara_last_response&.headers || {}
+        headers = @capybara_response_mutex.synchronize { @capybara_last_response&.headers || {} }
 
         Headers.new.tap do |h|
           headers.each do |key, value|
@@ -165,7 +167,7 @@ module Capybara
       end
 
       def capybara_status_code
-        @capybara_last_response&.status.to_i
+        @capybara_response_mutex.synchronize { @capybara_last_response&.status.to_i }
       end
 
       def capybara_reset_frames

data/lib/capybara/playwright/shadow_root_node.rb

@@ -5,12 +5,12 @@ module Capybara
     class ShadowRootNode < Node
       def initialize(driver, internal_logger, page, element)
         super
-        @shadow_roow_element = element.evaluate_handle('el => el.shadowRoot')
+        @shadow_root_element = element.evaluate_handle('el => el.shadowRoot')
       end
 
       def all_text
         assert_element_not_stale {
-          text = @shadow_roow_element.text_content
+          text = @shadow_root_element.text_content
           text.to_s.gsub(/[\u200b\u200e\u200f]/, '')
               .gsub(/[\ \n\f\t\v\u2028\u2029]+/, ' ')
               .gsub(/\A[[:space:]&&[^\u00a0]]+/, '')
@@ -25,7 +25,7 @@ module Capybara
           return '' unless visible?
 
           # https://github.com/teamcapybara/capybara/blob/1c164b608fa6452418ec13795b293655f8a0102a/lib/capybara/rack_test/node.rb#L18
-          displayed_text = @shadow_roow_element.text_content.to_s.
+          displayed_text = @shadow_root_element.text_content.to_s.
                               gsub(/[\u200b\u200e\u200f]/, '').
                               gsub(/[\ \n\f\t\v\u2028\u2029]+/, ' ')
           displayed_text.squeeze(' ')

data/lib/capybara/playwright/version.rb

@@ -2,6 +2,6 @@
 
 module Capybara
   module Playwright
-    VERSION = '0.5.7'
+    VERSION = '0.5.8'
   end
 end

metadata

@@ -1,14 +1,13 @@
 --- !ruby/object:Gem::Specification
 name: capybara-playwright-driver
 version: !ruby/object:Gem::Version
-  version: 0.5.7
+  version: 0.5.8
 platform: ruby
 authors:
 - YusukeIwaki
-autorequire:
-bindir: exe
+bindir: bin
 cert_chain: []
-date: 2025-08-05 00:00:00.000000000 Z
+date: 1980-01-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: addressable
@@ -52,7 +51,6 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: 1.16.0
-description:
 email:
 - q7w8e9w8q7w8e9@yahoo.co.jp
 executables: []
@@ -86,7 +84,6 @@ homepage: https://github.com/YusukeIwaki/capybara-playwright-driver
 licenses:
 - MIT
 metadata: {}
-post_install_message:
 rdoc_options: []
 require_paths:
 - lib
@@ -101,8 +98,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
-rubygems_version: 3.5.22
-signing_key:
+rubygems_version: 3.6.9
 specification_version: 4
 summary: Playwright driver for Capybara
 test_files: []