capybara-lightpanda 0.14.1 → 0.14.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: d38fc6a0a5cbba01bba3a0a1363d8e0577dc99c2cb8a77b81f407b273a91863b
-  data.tar.gz: 21cdea0aeba27736c52f800c22e850d80ea15d3c7bb1c6c9b173421bb227be7d
+  metadata.gz: 197930c8808e3cb4d58ce97952b13e657dfbf8e7d200a98b03a5e71e7afdc87f
+  data.tar.gz: 6401c206e53dce565b29eab2e4c4b01bbf141a88c81025bc12b584b7cc0e75af
 SHA512:
-  metadata.gz: ec4a2743650df3602c43fc393a82af00c19c5b44d59fab31156aed0b3252e8fb7f3c5f06df1b6e2fe994c9b974a1b21b29707c22c6bff571d4c2b6aca195add4
-  data.tar.gz: ba19fbd3c2754eae2b6d3af02584d739eba498b93e0e0ff392f9dc7a9feefdc1af1ff68081cd5b6963ca41c768cf8cebcf3b48b9debd9923e5142b15ac1c9223
+  metadata.gz: 0cfe0bd2b2491e8b26715110950286a74e9bd1a7816d52a76b87cc601814ed4dd4faabf5665108f82624d6720581bdc7560c82445220456cb089a13313618857
+  data.tar.gz: 84fb972984583e315cf20f0a70a114238015aa29c49786a6aec5f329556518fc63ee5bb2204e430ccdb81e014943535cc2899c1ec40fb673d3f641bf5b201063

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## [0.14.2] - 2026-10-14
+
+### Fixed
+
+- **A browser that stops reading no longer hangs the test process.** If Lightpanda got stuck (a page in an endless synchronous loop, a stopped process) while a large command was being sent, about 1 MB and up (a big `execute_script` bundle, for example), the send blocked forever: the command's timeout never started, every other command waited behind it, and so did quitting the browser, at exit included. Sending now gives up after the command's timeout and raises `DeadBrowserError`.
+- **Clicking a `mailto:` or `tel:` link keeps the page, as in Chrome.** On Lightpanda 1.0.0, clicking `<a href="mailto:someone@example.com">` left the page and loaded `example.com`, the host in the address. On nightlies 10261 to 10535, clicking a `tel:` link left the page unusable: every later call raised `NoExecutionContextError`. The page now stays and your own click handlers still run. The same applies to any link whose scheme the browser can't load (`sms:`, `ftp:`…).
+
 ## [0.14.1] - 2026-10-12
 
 ### Fixed

data/lib/capybara/lightpanda/client/web_socket.rb

@@ -26,11 +26,18 @@ module Capybara
           connect
         end
 
-        def send_message(message)
+        # `timeout` bounds how long the browser may go without taking any of
+        # the frame's bytes (see #write); nil falls back to options.timeout.
+        def send_message(message, timeout: nil)
           raise DeadBrowserError, "WebSocket is not open" unless @status == :open
 
           @logger&.puts("\n\n▶ #{@logger.elapsed_time} #{message}")
-          @driver_mutex.synchronize { @driver.text(message) }
+          @driver_mutex.synchronize do
+            @write_timeout = timeout
+            @driver.text(message)
+          ensure
+            @write_timeout = nil
+          end
         end
 
         # The socket is closed even when the connection is already dead. A
@@ -53,8 +60,25 @@ module Capybara
           @status == :closed || @status == :error
         end
 
+        # Called by websocket-driver, always under @driver_mutex. A browser
+        # that stops reading (hung, stopped, or a page stuck in a sync JS loop
+        # on Lightpanda's single thread) would block a plain write forever
+        # once the frame outgrows the socket buffers, holding the lock that
+        # every other command, the reader's parse and #close need — and the
+        # command timeout only starts after the write returns. So the write
+        # gives up once the browser takes no byte for the timeout; the wait
+        # restarts on every partial write, so a slow but moving peer is fine
+        # (ferrum #644). Close and pong frames have no command timeout and
+        # fall back to options.timeout rather than waiting forever.
         def write(data)
-          @socket.write(data)
+          until data.empty?
+            written = @socket.write_nonblock(data, exception: false)
+            if written.is_a?(Integer)
+              data = data.byteslice(written..)
+            elsif !wait_for_socket(written)
+              abandon_stalled_write
+            end
+          end
         rescue Errno::EPIPE, Errno::ECONNRESET, IOError
           mark_dead
         end
@@ -71,6 +95,21 @@ module Capybara
 
         private
 
+        def wait_for_socket(state)
+          timeout = @write_timeout || @options.timeout
+          state == :wait_readable ? @socket.wait_readable(timeout) : @socket.wait_writable(timeout)
+        end
+
+        # The frame was cut off midway, so the connection can't be reused:
+        # mark it dead (the reader and message threads stop, pending commands
+        # are released) and close the socket.
+        def abandon_stalled_write
+          timeout = @write_timeout || @options.timeout
+          mark_dead(:error)
+          close_socket
+          raise DeadBrowserError, "Browser accepted no data for #{timeout}s and is likely stuck; connection closed"
+        end
+
         def close_socket
           @socket&.close unless @socket.nil? || @socket.closed?
         rescue IOError, SystemCallError

data/lib/capybara/lightpanda/client.rb

@@ -22,18 +22,18 @@ module Capybara
 
       def command(method, params = {}, async: false, session_id: nil, timeout: nil)
         message = build_message(method, params, session_id: session_id)
+        effective_timeout = timeout || @options.timeout
 
         if async
-          @ws.send_message(JSON.generate(message))
+          @ws.send_message(JSON.generate(message), timeout: effective_timeout)
           return true
         end
 
         pending = Concurrent::IVar.new
         @pendings[message[:id]] = pending
 
-        @ws.send_message(JSON.generate(message))
+        @ws.send_message(JSON.generate(message), timeout: effective_timeout)
 
-        effective_timeout = timeout || @options.timeout
         response = pending.value!(effective_timeout)
 
         if response.nil?

data/lib/capybara/lightpanda/node.rb

@@ -638,8 +638,27 @@ module Capybara
           }
           hit.dispatchEvent(new EventCtor('mouseup', { bubbles: true, cancelable: true }));
           var clickEvt = new EventCtor('click', { bubbles: true, cancelable: true });
-          var notCancelled = hit.dispatchEvent(clickEvt);
-          if (!notCancelled || clickEvt.defaultPrevented) return;
+          // A link to a scheme the browser can't fetch (mailto:, tel:, sms:…)
+          // goes to an external app in Chrome and the page stays. Below
+          // upstream #3940 (build 10536) the link's own activation instead
+          // turns `mailto:a@b.com` into `http://mailto:a@b.com/` and loads
+          // b.com (1.0.0), or loses the execution context on a failed `tel:`
+          // navigation (10261–10535). Cancel that default from a window
+          // listener added for this one dispatch: it runs after the page's
+          // own listeners, which still see an uncancelled click.
+          var link = hit.closest ? hit.closest('a[href]') : null;
+          var scheme = link && /^\\s*([a-z][a-z0-9+.-]*):/i.exec(link.getAttribute('href'));
+          var external = !!scheme && !/^(https?|about|blob|data|file|javascript)$/i.test(scheme[1]);
+          var view = hit.ownerDocument.defaultView;
+          var keepPage = function (e) { if (e === clickEvt) e.preventDefault(); };
+          if (external && view) view.addEventListener('click', keepPage);
+          var notCancelled;
+          try {
+            notCancelled = hit.dispatchEvent(clickEvt);
+          } finally {
+            if (external && view) view.removeEventListener('click', keepPage);
+          }
+          if (external || !notCancelled || clickEvt.defaultPrevented) return;
           var tag = hit.tagName;
           // A `javascript:` link never navigates: the click's own activation
           // behavior has already run its code. Assigning it to location.href

data/lib/capybara/lightpanda/version.rb

@@ -2,6 +2,6 @@
 
 module Capybara
   module Lightpanda
-    VERSION = "0.14.1"
+    VERSION = "0.14.2"
   end
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capybara-lightpanda
 version: !ruby/object:Gem::Version
-  version: 0.14.1
+  version: 0.14.2
 platform: ruby
 authors:
 - Navid Emad