caption_crunch 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d0f8b1d9f147b877698a20702ade0b5d093ae848
-  data.tar.gz: 0c0f9b15655691f52a43f2eb8052abf64dd7c900
+  metadata.gz: ae3a295af13db4cba6334779f26b3a7311ea5f77
+  data.tar.gz: 1d137d6113eb2685e51a68ccfdda4807a8e86dd9
 SHA512:
-  metadata.gz: 12a21b0bf104e69e3301373bc235eaa11c3665157d60c571bf300927e461d60792b87facc8e60732620006d3ba429cfd20dd3f8bccf751f9cb26f79a5c80e22d
-  data.tar.gz: 6d4fd6420d85d7edd4261f1eae7f1cf3eaaaa7aacd527d85d35c59cb3fba37c34ded0d96a4a27c34cc078df9861ce857858b7d97719a6f99376a2ccd8affdbc0
+  metadata.gz: 065b3720596520b1c56d075b596521c085b9a5bb8ad1e9c0e1cae0f27c95a79b3e60817bc8cd89d8115f43a5e486ba103b0da034711cf6c992f062d47dbd281b
+  data.tar.gz: e20f1506f05d54ee96b5facb6b8f2df7c88e892fd27c3f42b4470d8c7b175e62cf831c5557f61b5b73e17d4a549f5dc7f5c208567a0e373408ff4bb8f99da85d

data/lib/caption_crunch/adapters/vtt.rb

@@ -1,7 +1,7 @@
 module CaptionCrunch
   module Adapters
     class VTT
-      SIGNATURE_REGEX = /\AWEBVTT\Z|\AWEBVTT[ \t]/.freeze
+      SIGNATURE_REGEX = /\AWEBVTT\Z|\AWEBVTT[ \t\n]/.freeze
       COMMENT_REGEX   = /\ANOTE\Z|\ANOTE[ \t\n]/.freeze
       ARROW_REGEX     = /-->/.freeze
       # Format: hour:minute:second.milliseconds
@@ -35,11 +35,15 @@ module CaptionCrunch
         # Returns a string corresponding to the contents of a File instance.
         # Alternatively, if the argument is not a File, simply calls `.to_s`.
         def read_file(file)
-          if file.respond_to?(:read)
+          contents = if file.respond_to?(:read)
             file.read
           else
             file.to_s
-          end.strip
+          end
+
+          raise ParseError, "Invalid encoding" unless contents.valid_encoding?
+
+          contents.strip
         end
 
         def remove_bom(string)

data/lib/caption_crunch/version.rb

@@ -1,3 +1,3 @@
 module CaptionCrunch
-  VERSION = "0.0.3"
+  VERSION = "0.0.4"
 end

data/spec/caption_crunch_spec.rb

@@ -38,6 +38,15 @@ describe 'CaptionCrunch' do
       end
     end
 
+    describe 'parsing a binary file' do
+      it 'should raise a ParseError' do
+        error = ->{
+          CaptionCrunch.parse(fixture('binary.jpg'))
+        }.must_raise CaptionCrunch::ParseError
+        error.message.must_match /Invalid encoding/
+      end
+    end
+
     describe 'parsing a track with three cues' do
       subject { CaptionCrunch.parse(fixture('three_cues.vtt')) }
       it 'should return an object with three cues' do
@@ -139,5 +148,14 @@ describe 'CaptionCrunch' do
       end
     end
 
+    describe 'parsing with metadata headers' do
+      subject{ CaptionCrunch.parse(fixture('metadata_headers.vtt')) }
+
+      it 'should ignore them for now and parse cues' do
+        subject.cues.count.must_equal 1
+        subject.cues.first.payload.must_equal "Hey. I have metadata headers."
+      end
+    end
+
   end
 end

data/spec/fixtures/metadata_headers.vtt

@@ -0,0 +1,6 @@
+WEBVTT
+Kind: captions
+Language: en
+
+00:00:06.000 --> 00:00:08.921
+Hey. I have metadata headers.

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: caption_crunch
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - David Peter
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-13 00:00:00.000000000 Z
+date: 2015-05-29 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -87,6 +87,8 @@ files:
 - lib/caption_crunch/track.rb
 - lib/caption_crunch/version.rb
 - spec/caption_crunch_spec.rb
+- spec/fixtures/binary.jpg
+- spec/fixtures/metadata_headers.vtt
 - spec/fixtures/three_cues.vtt
 - spec/spec_helper.rb
 homepage: ''
@@ -115,5 +117,7 @@ specification_version: 4
 summary: A collection of parsers for various caption/subtitle files
 test_files:
 - spec/caption_crunch_spec.rb
+- spec/fixtures/binary.jpg
+- spec/fixtures/metadata_headers.vtt
 - spec/fixtures/three_cues.vtt
 - spec/spec_helper.rb