capsule_crm 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: f4b9fd67a190082bdfaee77004d8b1a955292f6e
-  data.tar.gz: 0194fb59ce8ae5227ecbdf97db8b69384ae810b1
+  metadata.gz: e63af1aeb254c386c75f71887655f99499fb4738
+  data.tar.gz: d686a04491edd661dc7595611fd78a2b906f4687
 SHA512:
-  metadata.gz: db99f83850c54977fea4732871099fc1f1fc5e31f01c8cefda62eb83f29d2f17e09147322e3ddd6f5489ad0435e2659aee1c3ffca06688b973f4aca64bb10b97
-  data.tar.gz: 316ac65226479c988cc5f0565ea9abbe5301a88b66c0f5e4d0c6dc22dccffd6daa97a85f8dcd63248623dda62c89b6d7239c6bd7400d44348f9a2897381afa4c
+  metadata.gz: 9738614f297ebd8b9d293c1a1e2be92f03d4ed254780497eaf89e38ee6832d8f3947b3c5dd203833f41a1fe99ade6f4f968b43f1e581ceada44f2aae97e8d82f
+  data.tar.gz: 78eb9bd924102eb42dfbae78262d51a5c28c45444465020e4cf8ef0396aab6c23fc3e99d9ef7381678b2069b4a489dc13452e90e6cfe54571ef117e1a736fafa

data/.hound.yml

@@ -1,3 +1,739 @@
+# These are all the cops that are enabled in the default configuration.
+
+AccessModifierIndentation:
+  Description: Check indentation of private/protected visibility modifiers.
+  Enabled: false
+
+AccessorMethodName:
+  Description: Check the naming of accessor methods for get_/set_.
+  Enabled: false
+
+Alias:
+  Description: 'Use alias_method instead of alias.'
+  Enabled: false
+
+AlignArray:
+  Description: >-
+                 Align the elements of an array literal if they span more than
+                 one line.
+  Enabled: false
+
+AlignHash:
+  Description: >-
+                 Align the elements of a hash literal if they span more than
+                 one line.
+  Enabled: false
+
+AlignParameters:
+  Description: >-
+                 Align the parameters of a method call if they span more
+                 than one line.
+  Enabled: false
+
+AndOr:
+  Description: 'Use &&/|| instead of and/or.'
+  Enabled: true
+
+ArrayJoin:
+  Description: 'Use Array#join instead of Array#*.'
+  Enabled: false
+
+AsciiComments:
+  Description: 'Use only ascii symbols in comments.'
+  Enabled: false
+
+AsciiIdentifiers:
+  Description: 'Use only ascii symbols in identifiers.'
+  Enabled: false
+
+Attr:
+  Description: 'Checks for uses of Module#attr.'
+  Enabled: false
+
+BeginBlock:
+  Description: 'Avoid the use of BEGIN blocks.'
+  Enabled: false
+
+BlockComments:
+  Description: 'Do not use block comments.'
+  Enabled: true
+
+BlockNesting:
+  Description: 'Avoid excessive block nesting'
+  Enabled: false
+
+Blocks:
+  Description: >-
+                Avoid using {...} for multi-line blocks (multiline chaining is
+                always ugly).
+                Prefer {...} over do...end for single-line blocks.
+  Enabled: true
+
+BracesAroundHashParameters:
+  # Valid values are: braces, no_braces
+  EnforcedStyle: no_braces
+  Enabled: true
+
+CaseEquality:
+  Description: 'Avoid explicit use of the case equality operator(===).'
+  Enabled: false
+
+CaseIndentation:
+  Description: 'Indentation of when in a case/when/[else/]end.'
+  Enabled: false
+
+CharacterLiteral:
+  Description: 'Checks for uses of character literals.'
+  Enabled: false
+
+ClassAndModuleCamelCase:
+  Description: 'Use CamelCase for classes and modules.'
+  Enabled: true
+
+ClassAndModuleChildren:
+  Description: 'Checks style of children classes and modules.'
+  Enabled: false
+
+ClassLength:
+  Description: 'Avoid classes longer than 100 lines of code.'
+  Enabled: false
+
+ClassMethods:
+  Description: 'Use self when defining module/class methods.'
+  Enabled: true
+
+ClassVars:
+  Description: 'Avoid the use of class variables.'
+  Enabled: false
+
+CollectionMethods:
+  Description: 'Preferred collection methods.'
+  Enabled: false
+
+ColonMethodCall:
+  Description: 'Do not use :: for method call.'
+  Enabled: true
+
+CommentAnnotation:
+  Description: >-
+                 Checks formatting of special comments
+                 (TODO, FIXME, OPTIMIZE, HACK, REVIEW).
+  Enabled: false
+
+ConstantName:
+  Description: 'Constants should use SCREAMING_SNAKE_CASE.'
+  Enabled: true
+
+CyclomaticComplexity:
+  Description: 'Avoid complex methods.'
+  Enabled: false
+
+DefWithParentheses:
+  Description: 'Use def with parentheses when there are arguments.'
+  Enabled: true
+
+DefWithoutParentheses:
+  Description: >
+                 Omit the parentheses when the method doesn't accept
+                 any arguments.
+  Enabled: true
+
+DeprecatedHashMethods:
+  Description: 'Checks for use of deprecated Hash methods.'
+  Enabled: false
+
+Documentation:
+  Description: 'Document classes and non-namespace modules.'
+  Enabled: false
+
+DotPosition:
+  Description: 'Checks the position of the dot in multi-line method calls.'
+  Style: 'leading'
+  Enabled: false
+
+DoubleNegation:
+  Description: 'Checks for uses of double negation (!!).'
+  Enabled: false
+
+EmptyLineBetweenDefs:
+  Description: 'Use empty lines between defs.'
+  Enabled: true
+
+EmptyLines:
+  Description: "Don't use several empty lines in a row."
+  Enabled: true
+
+EmptyLinesAroundAccessModifier:
+  Description: "Keep blank lines around access modifiers."
+  Enabled: false
+
+EmptyLinesAroundBody:
+  Description: "Keeps track of empty lines around expression bodies."
+  Enabled: false
+
+EmptyLiteral:
+  Description: 'Prefer literals to Array.new/Hash.new/String.new.'
+  Enabled: false
+
+Encoding:
+  Description: 'Use UTF-8 as the source file encoding.'
+  Enabled: false
+
+EndBlock:
+  Description: 'Avoid the use of END blocks.'
+  Enabled: false
+
+EndOfLine:
+  Description: 'Use Unix-style line endings.'
+  Enabled: true
+
+EvenOdd:
+  Description: 'Favor the use of Fixnum#even? && Fixnum#odd?'
+  Enabled: false
+
+FileName:
+  Description: 'Use snake_case for source file names.'
+  Enabled: false
+
+FinalNewline:
+  Description: 'Checks for a final newline in a source file.'
+  Enabled: true
+
+FlipFlop:
+  Description: 'Checks for flip flops'
+  Enabled: false
+
+For:
+  Description: 'Checks use of for or each in multiline loops.'
+  Enabled: false
+
+FormatString:
+  Description: 'Enforce the use of Kernel#sprintf, Kernel#format or String#%.'
+  Enabled: false
+
+GlobalVars:
+  Description: 'Do not introduce global variables.'
+  Enabled: false
+
+HashSyntax:
+  Description: >
+                 Prefer Ruby 1.9 hash syntax { a: 1, b: 2 } over 1.8 syntax
+                 { :a => 1, :b => 2 }.
+  EnforcedStyle: ruby19
+  Enabled: true
+
+IfUnlessModifier:
+  Description: >-
+                 Favor modifier if/unless usage when you have a
+                 single-line body.
+  Enabled: false
+
+IfWithSemicolon:
+  Description: 'Never use if x; .... Use the ternary operator instead.'
+  Enabled: true
+
+IndentationConsistency:
+  Description: 'Keep indentation straight.'
+  Enabled: fals
+
+IndentationWidth:
+  Description: 'Use 2 spaces for indentation.'
+  Enabled: true
+
+IndentArray:
+  Description: >-
+                 Checks the indentation of the first element in an array
+                 literal.
+  Enabled: false
+
+IndentHash:
+  Description: 'Checks the indentation of the first key in a hash literal.'
+  Enabled: false
+
+Lambda:
+  Description: 'Use the new lambda literal syntax for single-line blocks.'
+  Enabled: false
+
+LambdaCall:
+  Description: 'Use lambda.call(...) instead of lambda.(...).'
+  Enabled: false
+
+LeadingCommentSpace:
+  Description: 'Comments should start with a space.'
+  Enabled: false
+
+LineEndConcatenation:
+  Description: >-
+                 Use \ instead of + or << to concatenate two string literals at
+                 line end.
+  Enabled: false
+
+LineLength:
+  Description: 'Limit lines to 80 characters.'
+  Max: 80
+  Enabled: true
+
+MethodCallParentheses:
+  Description: 'Do not use parentheses for method calls with no arguments.'
+  Enabled: true
+
+MethodDefParentheses:
+  Description: >-
+                 Checks if the method definitions have or don't have
+                 parentheses.
+  Enabled: false
+
+MethodLength:
+  Description: 'Avoid methods longer than 10 lines of code.'
+  Enabled: false
+
+MethodName:
+  # Valid values are: snake_case, camelCase
+  Description: 'Use the configured style when naming methods.'
+  EnforcedStyle: snake_case
+  Enabled: true
+
+ModuleFunction:
+  Description: 'Checks for usage of `extend self` in modules.'
+  Enabled: false
+
+MultilineBlockChain:
+  Description: 'Avoid multi-line chains of blocks.'
+  Enabled: false
+
+MultilineIfThen:
+  Description: 'Never use then for multi-line if/unless.'
+  Enabled: false
+
+MultilineTernaryOperator:
+  Description: >-
+                 Avoid multi-line ?: (the ternary operator);
+                 use if/unless instead.
+  Enabled: false
+
+NegatedIf:
+  Description: >-
+                 Favor unless over if for negative conditions
+                 (or control flow or).
+  Enabled: false
+
+NegatedWhile:
+  Description: 'Favor until over while for negative conditions.'
+  Enabled: false
+
+NestedTernaryOperator:
+  Description: 'Use one expression per branch in a ternary operator.'
+  Enabled: false
+
+NilComparison:
+  Description: 'Prefer x.nil? to x == nil.'
+  Enabled: false
+
+NonNilCheck:
+  Description: 'Checks for redundant nil checks.'
+  Enabled: false
+
+Not:
+  Description: 'Use ! instead of not.'
+  Enabled: true
+
+NumericLiterals:
+  Description: >-
+                 Add underscores to large numeric literals to improve their
+                 readability.
+  Enabled: false
+
+OneLineConditional:
+  Description: >-
+                 Favor the ternary operator(?:) over
+                 if/then/else/end constructs.
+  Enabled: false
+
+OpMethod:
+  Description: 'When defining binary operators, name the argument other.'
+  Enabled: false
+
+ParameterLists:
+  Description: 'Avoid parameter lists longer than three or four parameters.'
+  Enabled: false
+
+ParenthesesAroundCondition:
+  Description: >
+                 Don't use parentheses around the condition of an
+                 if/unless/while.
+  Enabled: true
+
+PercentLiteralDelimiters:
+  Description: 'Use `%`-literal delimiters consistently'
+  Enabled: false
+
+PerlBackrefs:
+  Description: 'Avoid Perl-style regex back references.'
+  Enabled: false
+
+PredicateName:
+  Description: 'Check the names of predicate methods.'
+  Enabled: false
+
+Proc:
+  Description: 'Use proc instead of Proc.new.'
+  Enabled: false
+
+RaiseArgs:
+  Description: 'Checks the arguments passed to raise/fail.'
+  Enabled: false
+
+ReduceArguments:
+  Description: 'Name reduce arguments |a, e| (accumulator, element)'
+  Enabled: true
+
+RedundantBegin:
+  Description: "Don't use begin blocks when they are not needed."
+  Enabled: true
+
+RedundantException:
+  Description: "Checks for an obsolete RuntimeException argument in raise/fail."
+  Enabled: false
+
+RedundantReturn:
+  Description: "Don't use return where it's not required."
+  Enabled: true
+
+RedundantSelf:
+  Description: "Don't use self where it's not needed."
+  Enabled: true
+
+RegexpLiteral:
+  Description: >-
+                 Use %r for regular expressions matching more than
+                 `MaxSlashes` '/' characters.
+                 Use %r only for regular expressions matching more than
+                 `MaxSlashes` '/' character.
+  Enabled: false
+
+RescueModifier:
+  Description: 'Avoid using rescue in its modifier form.'
+  Enabled: false
+
+SelfAssignment:
+  Description: 'Checks for places where self-assignment shorthand should have been used.'
+  Enabled: false
+
+Semicolon:
+  Description: "Don't use semicolons to terminate expressions."
+  Enabled: false
+
+SignalException:
+  Description: 'Checks for proper usage of fail and raise.'
+  Enabled: false
+
+SingleLineBlockParams:
+  Description: 'Enforces the names of some block params.'
+  Enabled: false
+
+SingleLineMethods:
+  Description: 'Avoid single-line methods.'
+  Enabled: false
+
+SingleSpaceBeforeFirstArg:
+  Description: >-
+                 Checks that exactly one space is used between a method name
+                 and the first argument for method calls without parentheses.
+  Enabled: false
+
+SpaceAfterColon:
+  Description: 'Use spaces after colons.'
+  Enabled: true
+
+SpaceAfterComma:
+  Description: 'Use spaces after commas.'
+  Enabled: true
+
+SpaceAfterControlKeyword:
+  Description: 'Use spaces after if/elsif/unless/while/until/case/when.'
+  Enabled: true
+
+SpaceAfterMethodName:
+  Description: >
+                 Never put a space between a method name and the opening
+                 parenthesis.
+  Enabled: true
+
+SpaceAfterNot:
+  Description: Tracks redundant space after the ! operator.
+  Enabled: true
+
+SpaceAfterSemicolon:
+  Description: 'Use spaces after semicolons.'
+  Enabled: true
+
+SpaceBeforeBlockBraces:
+  Description: >-
+                 Checks that the left block brace has or doesn't have space
+                 before it.
+  Enabled: false
+
+SpaceInsideBlockBraces:
+  Description: >-
+                 Checks that block braces have or don't have surrounding space.
+                 For blocks taking parameters, checks that the left brace has
+                 or doesn't have trailing space.
+  Enabled: false
+
+SpaceAroundEqualsInParameterDefault:
+  Description: >
+                 Use spaces around the = operator when assigning default
+                 values in def params.
+  Enabled: true
+
+SpaceAroundOperators:
+  Description: 'Use spaces around operators.'
+  Enabled: true
+
+SpaceBeforeModifierKeyword:
+  Description: 'Put a space before the modifier keyword.'
+  Enabled: true
+
+SpaceInsideBrackets:
+  Description: 'No spaces after [ or before ].'
+  Enabled: true
+
+SpaceInsideHashLiteralBraces:
+  Description: "Use spaces inside hash literal braces - or don't."
+  # Valid values (for both parameters) are: space, no_space
+  EnforcedStyle: space
+  EnforcedStyleForEmptyBraces: no_space
+  Enabled: true
+
+SpaceInsideParens:
+  Description: 'No spaces after ( or before ).'
+  Enabled: true
+
+SpecialGlobalVars:
+  Description: 'Avoid Perl-style global variables.'
+  Enabled: false
+
 StringLiterals:
-  EnforcedStyle: double_quotes
-  Enabled: true
+  # Valid values (denoting the preferred quote delimiters) are:
+  # single_quotes, double_quotes
+  EnforcedStyle: single_quotes
+  Enabled: true
+
+SymbolName:
+  Description: 'Symbol literals should use snake_case.'
+  Enabled: true
+
+Tab:
+  Description: 'No hard tabs.'
+  Enabled: true
+
+TrailingBlankLines:
+  Description: 'Checks for superflous trailing blank lines.'
+  Enabled: true
+
+TrailingComma:
+  Description: 'Checks for trailing comma in parameter lists and literals.'
+  Enabled: false
+
+TrailingWhitespace:
+  Description: 'Avoid trailing whitespace.'
+  Enabled: true
+
+TrivialAccessors:
+  Description: 'Prefer attr_* methods to trivial readers/writers.'
+  Enabled: true
+
+UnlessElse:
+  Description: >
+                 Never use unless with else. Rewrite these with the positive
+                 case first.
+  Enabled: true
+
+VariableInterpolation:
+  Description: >-
+                 Don't interpolate global, instance and class variables
+                 directly in strings.
+  Enabled: true
+
+VariableName:
+  Description: 'Use the configured style when naming variables.'
+  # Valid values are: snake_case, camelCase
+  EnforcedStyle: snake_case
+  Enabled: true
+
+WhenThen:
+  Description: 'Use when x then ... for one-line cases.'
+  Enabled: false
+
+WhileUntilDo:
+  Description: 'Checks for redundant do after while or until.'
+  Enabled: false
+
+WhileUntilModifier:
+  Description: >-
+                 Favor modifier while/until usage when you have a
+                 single-line body.
+  Enabled: false
+
+WordArray:
+  Description: 'Use %w or %W for arrays of words.'
+  Enabled: false
+
+#################### Lint ################################
+### Warnings
+
+AmbiguousOperator:
+  Description: >-
+                 Checks for ambiguous operators in the first argument of a
+                 method invocation without parentheses.
+  Enabled: false
+
+AmbiguousRegexpLiteral:
+  Description: >-
+                 Checks for ambiguous regexp literals in the first argument of
+                 a method invocation without parenthesis.
+  Enabled: false
+
+AssignmentInCondition:
+  Description: "Don't use assignment in conditions."
+  Enabled: false
+
+BlockAlignment:
+  Description: 'Align block ends correctly.'
+  Enabled: false
+
+ConditionPosition:
+  Description: 'Checks for condition placed in a confusing position relative to the keyword.'
+  Enabled: false
+
+Debugger:
+  Description: 'Check for debugger calls.'
+  Enabled: false
+
+DeprecatedClassMethods:
+  Description: 'Check for deprecated class method calls.'
+  Enabled: false
+
+ElseLayout:
+  Description: 'Check for odd code arrangement in an else block.'
+  Enabled: false
+
+EmptyEnsure:
+  Description: 'Checks for empty ensure block.'
+  Enabled: false
+
+EmptyInterpolation:
+  Description: 'Checks for empty string interpolation.'
+  Enabled: false
+
+EndAlignment:
+  Description: 'Align ends correctly.'
+  Enabled: false
+
+EndInMethod:
+  Description: 'END blocks should not be placed inside method definitions.'
+  Enabled: false
+
+EnsureReturn:
+  Description: 'Never use return in an ensure block.'
+  Enabled: false
+
+Eval:
+  Description: 'The use of eval represents a serious security risk.'
+  Enabled: false
+
+HandleExceptions:
+  Description: "Don't suppress exception."
+  Enabled: false
+
+InvalidCharacterLiteral:
+  Description: >-
+                 Checks for invalid character literals with a non-escaped
+                 whitespace character.
+  Enabled: false
+
+LiteralInCondition:
+  Description: 'Checks of literals used in conditions.'
+  Enabled: false
+
+LiteralInInterpolation:
+  Description: 'Checks for literals used in interpolation.'
+  Enabled: false
+
+Loop:
+  Description: >-
+                 Use Kernel#loop with break rather than begin/end/until or
+                 begin/end/while for post-loop tests.
+  Enabled: false
+
+ParenthesesAsGroupedExpression:
+  Description: >-
+                 Checks for method calls with a space before the opening
+                 parenthesis.
+  Enabled: false
+
+RequireParentheses:
+  Description: >-
+                 Use parentheses in the method call to avoid confusion
+                 about precedence.
+  Enabled: false
+
+RescueException:
+  Description: 'Avoid rescuing the Exception class.'
+  Enabled: false
+
+ShadowingOuterLocalVariable:
+  Description: >-
+                 Do not use the same name as outer local variable
+                 for block arguments or block local variables.
+  Enabled: false
+
+SpaceBeforeFirstArg:
+  Description: >-
+                 Put a space between a method name and the first argument
+                 in a method call without parentheses.
+  Enabled: false
+
+StringConversionInInterpolation:
+  Description: 'Checks for Object#to_s usage in string interpolation.'
+  Enabled: false
+
+UnderscorePrefixedVariableName:
+  Description: 'Do not use prefix `_` for a variable that is used.'
+  Enabled: false
+
+UnusedBlockArgument:
+  Description: 'Checks for unused block arguments.'
+  Enabled: false
+
+UnusedMethodArgument:
+  Description: 'Checks for unused method arguments.'
+  Enabled: false
+
+UnreachableCode:
+  Description: 'Unreachable code.'
+  Enabled: false
+
+UselessAccessModifier:
+  Description: 'Checks for useless access modifiers.'
+  Enabled: false
+
+UselessAssignment:
+  Description: 'Checks for useless assignment to a local variable.'
+  Enabled: false
+
+UselessComparison:
+  Description: 'Checks for comparison of something with itself.'
+  Enabled: false
+
+UselessElseWithoutRescue:
+  Description: 'Checks for useless `else` in `begin..end` without `rescue`.'
+  Enabled: false
+
+UselessSetterCall:
+  Description: 'Checks for useless setter call to a local variable.'
+  Enabled: false
+
+Void:
+  Description: 'Possible use of operator/literal/variable in void context.'
+  Enabled: false

data/CHANGELOG.md

@@ -1,5 +1,14 @@
 # Changelog
 
+## 1.6.2
+
+- Fix bug where responses errors always had a blank body
+
+## 1.6.1
+
+- Fix issue where if capsulecrm.com returned a blank error response the
+  ResponseError would raise an undefined method exception
+
 ## 1.6.0
 
 - ResponseError#to_s now return the response message from the server so errors

data/Guardfile

@@ -3,7 +3,8 @@
 
 notification :tmux
 
-guard 'rspec', all_on_start: true, all_after_pass: true, failed_mode: :keep do
+guard 'rspec', cmd: 'rspec', all_on_start: true, all_after_pass: true,
+  failed_mode: :keep do
   watch(%r{^spec/.+_spec\.rb$})
   watch(%r{^lib/(.+)\.rb$})     { |m| "spec/lib/#{m[1]}_spec.rb" }
   watch('spec/spec_helper.rb')  { "spec" }

data/README.md

@@ -38,8 +38,12 @@ can make any requests to it. If you are using rails then you can put this into
 your config/initializers folder.
 ```ruby
 CapsuleCRM.configure do |config|
-  config.api_token = 'API Token here'
-  config.subdomain = 'your capsule crm company subdomain here'
+  config.api_token       = 'API Token here'
+  config.subdomain       = 'your capsule crm company subdomain here'
+
+  # Optional
+  config.logger          = your_logger # default is Logger.new(STDOUT)
+  config.perform_logging = true # default is false
 end
 ```
 

data/lib/capsule_crm/errors.rb

@@ -15,6 +15,10 @@ module CapsuleCRM
         end
       end
 
+      def error_from_env(env)
+        class_for_error_code(env[:status]).new(env)
+      end
+
       def class_name_for_error_name(name)
         name.to_s.titleize.gsub(' ', '')
       end

data/lib/capsule_crm/faraday/middleware/raise_error.rb

@@ -2,10 +2,17 @@ module CapsuleCRM
   module Faraday
     module Middleware
       class RaiseError < ::Faraday::Response::Middleware
+        attr_writer :error_factory
+
         def on_complete(env)
           return if env[:status] < 400
-          raise CapsuleCRM::Errors.class_for_error_code(env[:status]).
-            new(env[:response])
+          raise error_factory.error_from_env(env)
+        end
+
+        private
+
+        def error_factory
+          @error_factory ||= CapsuleCRM::Errors
         end
       end
     end

data/lib/capsule_crm/version.rb

@@ -1,3 +1,3 @@
 module CapsuleCrm
-  VERSION = '1.6.1'
+  VERSION = '1.6.2'
 end

data/spec/lib/capsule_crm/errors_spec.rb

@@ -0,0 +1,41 @@
+require 'spec_helper'
+
+describe CapsuleCRM::Errors do
+  describe '.error_from_env' do
+    let(:env) { OpenStruct.new(body: { message: 'test' }.to_json) }
+
+    subject { described_class.error_from_env(env) }
+
+    context 'with a 400 response' do
+      before { env.status = 400 }
+
+      it 'should return a bad request error' do
+        expect(subject).to be_a(CapsuleCRM::Errors::BadRequest)
+      end
+    end
+
+    context 'with a 401 response' do
+      before { env.status = 401 }
+
+      it 'should return a not authorized error' do
+        expect(subject).to be_a(CapsuleCRM::Errors::NotAuthorized)
+      end
+    end
+
+    context 'with a 404 response' do
+      before { env.status = 404 }
+
+      it 'should return a not found error' do
+        expect(subject).to be_a(CapsuleCRM::Errors::NotFound)
+      end
+    end
+
+    context 'with a 500 response' do
+      before { env.status = 500 }
+
+      it 'should return a internal server error' do
+        expect(subject).to be_a(CapsuleCRM::Errors::InternalServerError)
+      end
+    end
+  end
+end

data/spec/lib/capsule_crm/faraday/middleware/raise_error_spec.rb

@@ -0,0 +1,59 @@
+require 'spec_helper'
+
+describe CapsuleCRM::Faraday::Middleware::RaiseError do
+  describe '#on_complete' do
+    subject { described_class.new }
+
+    context 'when the response is a success' do
+      let(:response) { Hash[status: 200] }
+
+      it 'should return nothing' do
+        expect(subject.on_complete(response)).to eql(nil)
+      end
+    end
+
+    context 'when the response is a 400' do
+      let(:response) do
+        OpenStruct.new(status: 400, body: { message: 'test' }.to_json)
+      end
+
+      it 'should raise a bad request error' do
+        expect { subject.on_complete(response) }.
+          to raise_error(CapsuleCRM::Errors::BadRequest)
+      end
+    end
+
+    context 'when the response is a 401' do
+      let(:response) do
+        OpenStruct.new(status: 401, body: { message: 'test' }.to_json)
+      end
+
+      it 'should raise a not authorized error' do
+        expect { subject.on_complete(response) }.
+          to raise_error(CapsuleCRM::Errors::NotAuthorized)
+      end
+    end
+
+    context 'when the response is a 404' do
+      let(:response) do
+        OpenStruct.new(status: 404, body: { message: 'test' }.to_json)
+      end
+
+      it 'should raise a not found error' do
+        expect { subject.on_complete(response) }.
+          to raise_error(CapsuleCRM::Errors::NotFound)
+      end
+    end
+
+    context 'when the response is a 500' do
+      let(:response) do
+        OpenStruct.new(status: 500, body: { message: 'test' }.to_json)
+      end
+
+      it 'should raise an internal server error' do
+        expect { subject.on_complete(response) }.
+          to raise_error(CapsuleCRM::Errors::InternalServerError)
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capsule_crm
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - Matt Beedle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-08-28 00:00:00.000000000 Z
+date: 2014-09-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -334,6 +334,8 @@ files:
 - spec/lib/capsule_crm/custom_field_spec.rb
 - spec/lib/capsule_crm/email_spec.rb
 - spec/lib/capsule_crm/errors/response_error_spec.rb
+- spec/lib/capsule_crm/errors_spec.rb
+- spec/lib/capsule_crm/faraday/middleware/raise_error_spec.rb
 - spec/lib/capsule_crm/history_spec.rb
 - spec/lib/capsule_crm/milestone_spec.rb
 - spec/lib/capsule_crm/normalizer_spec.rb
@@ -443,6 +445,8 @@ test_files:
 - spec/lib/capsule_crm/custom_field_spec.rb
 - spec/lib/capsule_crm/email_spec.rb
 - spec/lib/capsule_crm/errors/response_error_spec.rb
+- spec/lib/capsule_crm/errors_spec.rb
+- spec/lib/capsule_crm/faraday/middleware/raise_error_spec.rb
 - spec/lib/capsule_crm/history_spec.rb
 - spec/lib/capsule_crm/milestone_spec.rb
 - spec/lib/capsule_crm/normalizer_spec.rb