capsule_crm 0.10.2 → 0.10.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: fe0200eaa38f56d70ebe6aac7a0753b881cd57d5
-  data.tar.gz: 3fddf33fe50156ea8949b456dd072544e01d2b59
+  metadata.gz: 6215127ba0a534da3f66ee07f81e52eb44a1b94f
+  data.tar.gz: 06fcb9fd7bceb43377a8dc31fb7d5a3b3330aff4
 SHA512:
-  metadata.gz: 186db3ab34a48f0417c7a50e31b7f77952a12a39c7e1053c1889c9a0e83b3299308899d308d8357e4fcd6dafdb23b5092267a98f90df01ef9bf95f06398bfc90
-  data.tar.gz: 0def9e908692cad017f50a03c8d8d88abdc9362e79ae7f1f4c5fa3d2413e18ffc0a019ad9c6b621b2675dbb48e22e8a124116125274fa353b18c83fb2c11484e
+  metadata.gz: 548e38de32cbb6759975a5802974ef94196fdbfaa809d02b01d2e1b1bb4401afb94271ebdf979c7ac3a147b68718c33ae0359511ea7770c8118805c8ae854a33
+  data.tar.gz: edda8a8f701984893d6a3b1cd56ee22981d59dfe0ccff4614146937235c7d310656b1af904565b9685439e15df77d32dbc5bba8c47ad74a2d5c174c533e121b3

data/lib/capsule_crm/connection.rb

@@ -8,6 +8,7 @@ module CapsuleCRM
     #
     # Returns a Hash from the JSON response
     def self.get(path, params = {})
+      preprocess_params(params)
       response = faraday.get(path, params) do |req|
         req.headers.update default_request_headers
       end
@@ -35,6 +36,18 @@ module CapsuleCRM
 
     private
 
+    def self.preprocess_params(params)
+      params.symbolize_keys!
+      if params_contains_lastmodified(params)
+        params[:lastmodified] = params[:lastmodified].strftime("%Y%m%dT%H%M%S")
+      end
+    end
+
+    def self.params_contains_lastmodified(params)
+      params.keys.include?(:lastmodified) &&
+        params[:lastmodified].respond_to?(:strftime)
+    end
+
     # TODO clean this shit up
     def self.process_post_response(response)
       if response.success?

data/lib/capsule_crm/party.rb

@@ -9,10 +9,9 @@ class CapsuleCRM::Party
   has_many :tasks, class_name: 'CapsuleCRM::Task', source: :party
 
   def self.all(options = {})
-    process_options(options)
-    attributes = CapsuleCRM::Connection.get('/api/party', options)
-
-    init_collection(attributes['parties'])
+    init_collection(
+      CapsuleCRM::Connection.get('/api/party', options)['parties']
+    )
   end
 
   def self.find(id)
@@ -39,11 +38,4 @@ class CapsuleCRM::Party
     { person: 'CapsuleCRM::Person', organisation: 'CapsuleCRM::Organization' }.
       stringify_keys
   end
-
-  def self.process_options(options)
-    if options[:lastmodified] && options[:lastmodified].respond_to?(:strftime)
-      options[:lastmodified] = options[:lastmodified].
-        strftime("%Y%m%dT%H%M%SZ")
-    end
-  end
 end

data/lib/capsule_crm/version.rb

@@ -1,3 +1,3 @@
 module CapsuleCrm
-  VERSION = '0.10.2'
+  VERSION = '0.10.3'
 end

data/spec/lib/capsule_crm/connection_spec.rb

@@ -0,0 +1,21 @@
+require 'spec_helper'
+
+describe CapsuleCRM::Connection do
+  before { configure }
+
+  describe '.get' do
+    context 'when lastmodified is in the supplied params' do
+      before do
+        stub_request(:get, /\/api\/v1\/foo/).to_return(body: '{}')
+        CapsuleCRM::Connection.
+          get('/api/v1/foo', lastmodified: Time.new(2013, 10, 1, 13, 31, 56))
+      end
+
+      it 'should make sure that the lastmodified is formatted in YYYYMMDDTHHMMSS' do
+        WebMock.should have_requested(
+          :get, 'https://1234:@company.capsulecrm.com/api/v1/foo'
+        ).with(query: { lastmodified: "20131001T133156" })
+      end
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: capsule_crm
 version: !ruby/object:Gem::Version
-  version: 0.10.2
+  version: 0.10.3
 platform: ruby
 authors:
 - Matt Beedle
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-09-27 00:00:00.000000000 Z
+date: 2013-09-30 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activemodel
@@ -299,6 +299,7 @@ files:
 - spec/lib/capsule_crm/associations/has_many_proxy_spec.rb
 - spec/lib/capsule_crm/associations/has_many_spec.rb
 - spec/lib/capsule_crm/case_spec.rb
+- spec/lib/capsule_crm/connection_spec.rb
 - spec/lib/capsule_crm/contacts_spec.rb
 - spec/lib/capsule_crm/country_spec.rb
 - spec/lib/capsule_crm/currency_spec.rb
@@ -378,6 +379,7 @@ test_files:
 - spec/lib/capsule_crm/associations/has_many_proxy_spec.rb
 - spec/lib/capsule_crm/associations/has_many_spec.rb
 - spec/lib/capsule_crm/case_spec.rb
+- spec/lib/capsule_crm/connection_spec.rb
 - spec/lib/capsule_crm/contacts_spec.rb
 - spec/lib/capsule_crm/country_spec.rb
 - spec/lib/capsule_crm/currency_spec.rb