capital_on_tap 0.1.4 → 0.1.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: ff304abb175e93a841c01589d25435e3f8b6528930ea343220f2d212037c1512
-  data.tar.gz: 191e56331d8a27a8598e79571316713e48390a8bce5a9b86221a4e8654f37ea7
+  metadata.gz: 3183097cf91d6bddb3da967e9f7922ac6a2cca30b898b5f72b363b7ee3bb8957
+  data.tar.gz: d360e41c71415ef5b689ff9f5968017b00a52c3e963e06b0f2d4e2f9e276fd74
 SHA512:
-  metadata.gz: b9ff711519ecfa374a4570fe8b7766faee184bdf156ede7d5f2376d157ca51de33c61c0426ab7879b2afbfbd21908263ea24b9ab0f2ef6d21a02847bc2093016
-  data.tar.gz: 75e6517a653a7cf19c401c3a0e6958b629f7c954eadd9f31bb5c0890235606f1fd3ee5c93a0e7098c86dd58d3aae89a791f962b9e43d09c278c53d7d15a150f2
+  metadata.gz: a07ab947afba10aaebfc92beded975658055ef593df5a4833dbf39e1cdaa604f2896a4333c07bf150505b512489b09e885b14f8c5448c65210c20f20f20b0619
+  data.tar.gz: 5e6b24830af44b5d0b578ea321ebe18b7c990ae4cc43075917edc1e2b71ab40c970402386c20a8d80a8b95ceb8e1ea70bb4948400908cc7243aa05fddde32e16

data/Gemfile

@@ -1,6 +1,8 @@
-source "https://rubygems.org"
+# frozen_string_literal: true
 
-git_source(:github) {|repo_name| "https://github.com/#{repo_name}" }
+source 'https://rubygems.org'
+
+git_source(:github) { |repo_name| "https://github.com/#{repo_name}" }
 
 # Specify your gem's dependencies in capital_on_tap.gemspec
 gemspec

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    capital_on_tap (0.1.4)
+    capital_on_tap (0.1.5)
       addressable
       faraday
       faraday_middleware
@@ -13,6 +13,7 @@ GEM
   specs:
     addressable (2.7.0)
       public_suffix (>= 2.0.2, < 5.0)
+    ast (2.4.0)
     byebug (11.0.1)
     coderay (1.1.2)
     diff-lcs (1.3)
@@ -21,9 +22,13 @@ GEM
       multipart-post (>= 1.2, < 3)
     faraday_middleware (0.13.1)
       faraday (>= 0.7.4, < 1.0)
+    jaro_winkler (1.5.4)
     method_source (0.9.2)
-    multi_json (1.13.1)
+    multi_json (1.14.1)
     multipart-post (2.1.1)
+    parallel (1.19.0)
+    parser (2.6.5.0)
+      ast (~> 2.4.0)
     pry (0.12.2)
       coderay (~> 1.1.0)
       method_source (~> 0.9.0)
@@ -46,6 +51,17 @@ GEM
       diff-lcs (>= 1.2.0, < 2.0)
       rspec-support (~> 3.8.0)
     rspec-support (3.8.2)
+    rubocop (0.76.0)
+      jaro_winkler (~> 1.5.1)
+      parallel (~> 1.10)
+      parser (>= 2.6)
+      rainbow (>= 2.2.2, < 4.0)
+      ruby-progressbar (~> 1.7)
+      unicode-display_width (>= 1.4.0, < 1.7)
+    rubocop-rspec (1.36.0)
+      rubocop (>= 0.68.1)
+    ruby-progressbar (1.10.1)
+    unicode-display_width (1.6.0)
 
 PLATFORMS
   ruby
@@ -57,6 +73,8 @@ DEPENDENCIES
   pry-byebug
   rake (~> 10.0)
   rspec (~> 3.0)
+  rubocop
+  rubocop-rspec
 
 BUNDLED WITH
    2.0.2

data/Rakefile

@@ -1,6 +1,8 @@
-require "bundler/gem_tasks"
-require "rspec/core/rake_task"
+# frozen_string_literal: true
+
+require 'bundler/gem_tasks'
+require 'rspec/core/rake_task'
 
 RSpec::Core::RakeTask.new(:spec)
 
-task :default => :spec
+task default: :spec

data/bin/console

@@ -18,38 +18,36 @@ end
 
 CapitalOnTap.setup_connection!
 
-def generate_params
-  {
-    Salutation: 'Mr',
-    FirstName: 'Roberto',
-    LastName: 'Caras',
-    DateOfBirth: Date.parse("1980-#{rand(1..12)}-#{rand(1..28)}"),
-    MobilePhone: "077123456#{rand(11..99)}",
-    EmailAddress: "oterosantos_#{rand(1..100)}@gmail.com",
-    PersonalAddress: {
-      CountryCode: 'UK',
-      Street: "Unit #{rand(1..99)} Falcon Way Adelaide Industrial Estate, Boucher Road",
-      PostCode: 'BT12 6SQ',
-      City: 'Belfast'
-    },
-    TradingName: 'DUNDER MCMIFFLIN LTD',
-    BusinessLegalName: 'DUNDER MCMIFFLIN LTD',
-    BusinessLandline: '07874186570',
-    YearsTrading: rand(1..10),
-    MonthlyTurnOver: rand(300...9000),
-    BusinessType: 'LimitedCompany',
-    BusinessAddress: {
-      CountryCode: 'UK',
-      Street: "Unit #{rand(1..99)} Falcon Way Adelaide Industrial Estate, Boucher Road",
-      PostCode: 'BT12 6SQ',
-      City: 'Belfast'
-    },
-    RegistrationNumber: 'NI644403'
-  }
-end
+TEST_PARAMS = {
+  Salutation: 'Mr',
+  FirstName: 'Roberto',
+  LastName: 'Caras',
+  DateOfBirth: Date.parse("1980-#{rand(1..12)}-#{rand(1..28)}"),
+  MobilePhone: "077123456#{rand(11..99)}",
+  EmailAddress: "oterosantos_#{rand(1..100)}@gmail.com",
+  PersonalAddress: {
+    CountryCode: 'UK',
+    Street: "Unit #{rand(1..99)} Falcon Way Adelaide Industrial Estate, Boucher Road",
+    PostCode: 'BT12 6SQ',
+    City: 'Belfast'
+  },
+  TradingName: 'DUNDER MCMIFFLIN LTD',
+  BusinessLegalName: 'DUNDER MCMIFFLIN LTD',
+  BusinessLandline: '07874186570',
+  YearsTrading: rand(1..10),
+  MonthlyTurnOver: rand(300...9000),
+  BusinessType: 'LimitedCompany',
+  BusinessAddress: {
+    CountryCode: 'UK',
+    Street: "Unit #{rand(1..99)} Falcon Way Adelaide Industrial Estate, Boucher Road",
+    PostCode: 'BT12 6SQ',
+    City: 'Belfast'
+  },
+  RegistrationNumber: 'NI644403'
+}.freeze
 
 def generate_code
-  CapitalOnTap::Application.create(generate_params)
+  CapitalOnTap::Application.create(TEST_PARAMS)
 end
 
 require 'pry'

data/capital_on_tap.gemspec

@@ -1,6 +1,6 @@
 # frozen_string_literal: true
 
-lib = File.expand_path('../lib', __FILE__)
+lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'capital_on_tap/version'
 
@@ -17,7 +17,7 @@ Gem::Specification.new do |spec|
 
   # Specify which files should be added to the gem when it is released.
   # The `git ls-files -z` loads the files in the RubyGem that have been added into git.
-  spec.files         = Dir.chdir(File.expand_path('..', __FILE__)) do
+  spec.files         = Dir.chdir(File.expand_path(__dir__)) do
     `git ls-files -z`.split("\x0").reject { |f| f.match(%r{^(test|spec|features)/}) }
   end
   spec.bindir        = 'exe'
@@ -31,8 +31,10 @@ Gem::Specification.new do |spec|
   spec.add_dependency 'rainbow'
 
   spec.add_development_dependency 'bundler'
-  spec.add_development_dependency 'rake', '~> 10.0'
-  spec.add_development_dependency 'rspec', '~> 3.0'
   spec.add_development_dependency 'dotenv'
   spec.add_development_dependency 'pry-byebug'
+  spec.add_development_dependency 'rake', '~> 10.0'
+  spec.add_development_dependency 'rspec', '~> 3.0'
+  spec.add_development_dependency 'rubocop'
+  spec.add_development_dependency 'rubocop-rspec'
 end

data/lib/capital_on_tap.rb

@@ -22,7 +22,7 @@ module CapitalOnTap
   end
 
   def setup_connection!
-    token_params = CapitalOnTap::Auth.get_token
+    token_params = CapitalOnTap::Auth.obtain_token
 
     raise "ERROR: #{token_params[:error_description]}" if token_params[:error]
 

data/lib/capital_on_tap/application.rb

@@ -2,7 +2,7 @@
 
 module CapitalOnTap
   class Application
-    SALUTATIONS = %w[Mr Mrs Miss Ms Dr]
+    SALUTATIONS = %w[Mr Mrs Miss Ms Dr].freeze
 
     BUSINESS_TYPES = %w[SoleTrader Partnership LimitedCompany LimitedLiabilityPartnership].freeze
 
@@ -31,9 +31,9 @@ module CapitalOnTap
       BusinessLegalName: 'Glamour Bikinis And Clothing Boutique Limited',
       BusinessLandline: '07874186570',
       YearsTrading: 8,
-      MonthlyTurnOver: 10000,
+      MonthlyTurnOver: 10_000,
       BusinessType: 'LimitedCompany',
-      RegistrationNumber: 10322035,
+      RegistrationNumber: 10_322_035,
       BusinessAddress: {},
       PromoCode: nil,
       OnPasteEventFields: nil,
@@ -41,10 +41,10 @@ module CapitalOnTap
       GoogleSessionId: nil,
       PartnerCode: nil,
       ExternalReference: nil,
-      RestrictedCountries:false,
-      RequestedCredit: 10000,
+      RestrictedCountries: false,
+      RequestedCredit: 10_000,
       ApplicationGuid: nil
-    }
+    }.freeze
 
     # Create a new application with the given parameters
     # Example JSON:

data/lib/capital_on_tap/auth.rb

@@ -18,8 +18,8 @@ module CapitalOnTap
       new.refresh_token(refresh_token)
     end
 
-    def self.get_token
-      new.get_token
+    def self.obtain_token
+      new.obtain_token
     end
 
     # Requests a new token. The response will be something like:
@@ -31,7 +31,7 @@ module CapitalOnTap
     #   expires_in: 1200,
     #   refresh_token: '<refresh_token>'
     # }
-    def get_token
+    def obtain_token
       client = Faraday.new(url: config.base_auth_url) do |conn|
         conn.headers['Content-Type'] = 'application/x-www-form-urlencoded'
         conn.response :logger if config.debug?

data/lib/capital_on_tap/configuration.rb

@@ -8,12 +8,12 @@ module CapitalOnTap
     AUTH_DOMAINS = {
       production: 'https://api-auth.capitalontap.com',
       development: 'https://prelive-api-auth.capitalontap.com'
-    }
+    }.freeze
 
     API_DOMAINS = {
       production: 'https://api-partner.capitalontap.com',
       development: 'https://prelive-api-partner.capitalontap.com'
-    }
+    }.freeze
 
     def initialize
       @client_id = ''
@@ -29,11 +29,11 @@ module CapitalOnTap
     end
 
     def base_auth_url
-      AUTH_DOMAINS[@env.to_sym]
+      AUTH_DOMAINS[@env.to_sym] || AUTH_DOMAINS[:development]
     end
 
     def base_url
-      API_DOMAINS[@env.to_sym]
+      API_DOMAINS[@env.to_sym] || API_DOMAINS[:development]
     end
   end
 end

data/lib/capital_on_tap/connection.rb

@@ -62,7 +62,7 @@ module CapitalOnTap
 
     def adapter
       Faraday.new(url: base_url) do |conn|
-        conn.headers['Authorization'] = "Bearer #{@access_token}" if !@access_token.to_s.empty?
+        conn.headers['Authorization'] = "Bearer #{@access_token}" unless @access_token.to_s.empty?
         conn.headers['Content-Type'] = 'application/json'
         conn.use FaradayMiddleware::ParseJson
         conn.response :json, parser_options: { symbolize_names: true }

data/lib/capital_on_tap/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module CapitalOnTap
-  VERSION = '0.1.4'
+  VERSION = '0.1.5'
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: capital_on_tap
 version: !ruby/object:Gem::Version
-  version: 0.1.4
+  version: 0.1.5
 platform: ruby
 authors:
 - rikas
@@ -94,6 +94,34 @@ dependencies:
     - - ">="
       - !ruby/object:Gem::Version
         version: '0'
+- !ruby/object:Gem::Dependency
+  name: dotenv
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: pry-byebug
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
@@ -123,7 +151,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '3.0'
 - !ruby/object:Gem::Dependency
-  name: dotenv
+  name: rubocop
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="
@@ -137,7 +165,7 @@ dependencies:
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
-  name: pry-byebug
+  name: rubocop-rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ">="