canvas_statsd 1.0.4 → 1.0.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 7f93d09a249a24e64798dd4e4b1554b1132cf2e5
-  data.tar.gz: c104aae22f8fe8bf5f86d2e92aa2cda2218f1fb0
+  metadata.gz: 59016469f4db4d82cf1461666d4d7454821dc900
+  data.tar.gz: e45d90741f862de134f4e687d029e24f05f17856
 SHA512:
-  metadata.gz: dfe9e66cff26fe7687e592d6d668295609577228dfa46ae7c3f81cdd2295585cbe9ec571f1547554e0df429012d02d3d68111fb9167ae2ecb63dc70380d3ebc8
-  data.tar.gz: ab4ffc4acf17efc36669900d9e26400a18fc59e547162e59974e15146599129edae89dd4ef190a5e46e62ce9dea43cfb0b1795e4e46fb6f6d774d2c67ca9c6aa
+  metadata.gz: e4604014954d5f4a9db66e4de69d6cc97d3fa740dc541558e8bf0f00e4e34a6f0200865ab4d1c3984e432b651932674560a798752aa6465fd2d2a923b46cc29a
+  data.tar.gz: 3d8c4895afaecc1cd100124e0d69aa87a7df6532fc12c67e95350eaca225bd71053730e4d2ea4f33137e0d23c11492d6e666659b937388a837f73359dcef66c9

data/lib/canvas_statsd/statsd.rb

@@ -39,7 +39,7 @@ module CanvasStatsd
   module Statsd
     # replace "." in key names with another character to avoid creating spurious sub-folders in graphite
     def self.escape(str, replacement = '_')
-      str.gsub('.', replacement)
+      str.respond_to?(:gsub)? str.gsub('.', replacement) : str
     end
 
     def self.hostname

data/lib/canvas_statsd.rb

@@ -36,11 +36,11 @@ module CanvasStatsd
   def self.convert_bool(hash, key)
     value = hash[key]
     return if value.nil?
-    unless ['true', 'false', true, false].include?(value)
+    unless ['true', 'True', 'false', 'False', true, false].include?(value)
       message = "#{key} must be a boolean, or the string representation of a boolean, got: #{value}"
       raise CanvasStatsd::ConfigurationError, message
     end
-    hash[key] = (value == 'true' || value == true) ? true : false
+    hash[key] = ['true', 'True', true].include?(value)
   end
 
   def self.track_default_metrics options={}

data/spec/canvas_statsd/canvas_statsd_spec.rb

@@ -72,6 +72,11 @@ describe CanvasStatsd do
       CanvasStatsd.convert_bool(config, :potential_string_bool)
       expect(config[:potential_string_bool]).to be(true)
     end
+    it 'sets string True values to boolean true' do
+      config = {potential_string_bool: 'True'}
+      CanvasStatsd.convert_bool(config, :potential_string_bool)
+      expect(config[:potential_string_bool]).to be(true)
+    end
     it 'sets boolean true values to boolean true' do
       config = {potential_string_bool: true}
       CanvasStatsd.convert_bool(config, :potential_string_bool)
@@ -82,6 +87,11 @@ describe CanvasStatsd do
       CanvasStatsd.convert_bool(config, :potential_string_bool)
       expect(config[:potential_string_bool]).to be(false)
     end
+    it 'sets False strings to boolean false' do
+      config = {potential_string_bool: 'False'}
+      CanvasStatsd.convert_bool(config, :potential_string_bool)
+      expect(config[:potential_string_bool]).to be(false)
+    end
     it 'sets false booleans to boolean false' do
       config = {potential_string_bool: false}
       CanvasStatsd.convert_bool(config, :potential_string_bool)

data/spec/canvas_statsd/statsd_spec.rb

@@ -68,6 +68,26 @@ describe CanvasStatsd::Statsd do
     expect(instance.namespace).to eq "test"
   end
 
+  describe ".escape" do
+    it "replaces any dots in str with a _ when no replacment given" do
+      result = CanvasStatsd::Statsd.escape("lots.of.dots")
+      expect(result).to eq "lots_of_dots"
+    end
+
+    it "replaces any dots in str with replacement arg" do
+      result = CanvasStatsd::Statsd.escape("lots.of.dots", "/")
+      expect(result).to eq "lots/of/dots"
+    end
+
+    it "returns str when given a str that doesnt respond to gsub" do
+      result = CanvasStatsd::Statsd.escape(nil)
+      expect(result).to eq nil
+      hash = {foo: 'bar'}
+      result = CanvasStatsd::Statsd.escape(hash)
+      expect(result).to eq hash
+    end
+  end
+
   after do
     CanvasStatsd::Statsd.reset_instance
   end

metadata

@@ -1,14 +1,15 @@
 --- !ruby/object:Gem::Specification
 name: canvas_statsd
 version: !ruby/object:Gem::Version
-  version: 1.0.4
+  version: 1.0.5
 platform: ruby
 authors:
 - Nick Cloward
+- Jason Madsen
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-06-19 00:00:00.000000000 Z
+date: 2015-07-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: statsd-ruby
@@ -83,6 +84,7 @@ dependencies:
 description: 
 email:
 - ncloward@instructure.com
+- jmadsen@instructure.com
 executables: []
 extensions: []
 extra_rdoc_files: []