canvas_link_migrator 1.0.7 → 1.0.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: e74a62a030858ee5785138c032c6a03e38f75d05acac287dbded691fa642c593
-  data.tar.gz: d380a8f3b556d0da9d18e198483e48590e767b481415dd417d808da70d12f5fe
+  metadata.gz: a329fcce5ac60d34c29e9e09005e8bb5c6ced87ff0ca2b7529821ff70d280045
+  data.tar.gz: 4b05fe6dae29056eedba8384b00549942eb0d1f5dc72c2ec6310ea7b353e07af
 SHA512:
-  metadata.gz: a8b6f64385cfa820b655f009a327bb207320ffb673ea4228b69f13584550b9da18cb5d79abdf0f3c7c861249ad2a49c20c5fcec0d9372d6299dd832dfe2e18f9
-  data.tar.gz: 442098e04f4bd979f6c64eb6a83060cd8635f8c1cc7dc28e4688b0516cd9dc4215877352e9c3dde7c55798aa88059987ca1578bfb612e844222099940608ecde
+  metadata.gz: 37f76536082684d4f2c40c72a68f885921cd1a5570f1bfd5d0424b2a859933ead7dac479ae0c4fde8968d799eb3f233cf696602a5d4ac962f9e8257e80f781b8
+  data.tar.gz: eb9be3e0f256c16b6c4059f24b76d21d50d7c71ac40f73deb00ba737f2b32e3a4593ae86630ca5a364822839908328463741bafc42df27ddc95bfd3f2a97f01d

data/lib/canvas_link_migrator/link_resolver.rb

@@ -228,6 +228,9 @@ module CanvasLinkMigrator
         media_id = file.try(:media_object)&.media_id || file["media_entry_id"]
         node["data-media-id"] = media_id # safe to delete?
         media_attachment_iframe_url(file["id"], node["data-media-type"])
+      elsif rel_path&.match(/\/media_attachments_iframe\/\d+/)
+        # media attachment from another course or something
+        rel_path
       elsif node["data-media-id"].present?
         file = @migration_id_converter.lookup_attachment_by_media_id(node["data-media-id"])
         file ? media_attachment_iframe_url(file["id"], node["data-media-type"]) : nil

data/lib/canvas_link_migrator/version.rb

@@ -1,3 +1,3 @@
 module CanvasLinkMigrator
-  VERSION = "1.0.7"
+  VERSION = "1.0.8"
 end

data/spec/canvas_link_migrator/imported_html_converter_spec.rb

@@ -311,6 +311,16 @@ describe CanvasLinkMigrator::ImportedHtmlConverter do
       expect(@converter.convert_exported_html(test_string)).to eq([converted_string, nil])
     end
 
+    it "converts source tags to RCE media attachment iframes when link is an unknown media attachment reference (link from a public file in another course)" do
+      test_string = %(<video style="width: 400px; height: 225px; display: inline-block;" title="this is a media comment" data-media-type="video" allowfullscreen="allowfullscreen" allow="fullscreen" data-media-id="0_l4l5n0wt"><source src="/media_attachments_iframe/18?type=video" data-media-id="0_l4l5n0wt" data-media-type="video"></video>)
+      converted_string = %(<iframe style="width: 400px; height: 225px; display: inline-block;" title="this is a media comment" data-media-type="video" allowfullscreen="allowfullscreen" allow="fullscreen" data-media-id="0_l4l5n0wt" src="/media_attachments_iframe/18?type=video"></iframe>)
+      expect(@converter.convert_exported_html(test_string)).to eq([converted_string, nil])
+
+      test_string = %(<audio style="width: 400px; height: 225px; display: inline-block;" title="this is a media comment" data-media-type="audio" data-media-id="0_l4l5n0wu"><source src="/media_attachments_iframe/19?type=audio" data-media-id="0_l4l5n0wu" data-media-type="audio"></video>)
+      converted_string = %(<iframe style="width: 400px; height: 225px; display: inline-block;" title="this is a media comment" data-media-type="audio" data-media-id="0_l4l5n0wu" src="/media_attachments_iframe/19?type=audio"></iframe>)
+      expect(@converter.convert_exported_html(test_string)).to eq([converted_string, nil])
+    end
+
     it "converts course copy style media attachmet iframe links" do
       test_string = %(<video style="width: 400px; height: 225px; display: inline-block;" title="this is a media comment" data-media-type="video" allowfullscreen="allowfullscreen" allow="fullscreen" data-media-id="m-yodawg"><source src="$CANVAS_COURSE_REFERENCE$/file_ref/I?media_attachment=true&type=video" data-media-id="m-yodawg" data-media-type="video"></video>)
       converted_string = %(<iframe style="width: 400px; height: 225px; display: inline-block;" title="this is a media comment" data-media-type="video" allowfullscreen="allowfullscreen" allow="fullscreen" data-media-id="m-yodawg" src="/media_attachments_iframe/9?type=video&embedded=true"></iframe>)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: canvas_link_migrator
 version: !ruby/object:Gem::Version
-  version: 1.0.7
+  version: 1.0.8
 platform: ruby
 authors:
 - Mysti Lilla
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-03-29 00:00:00.000000000 Z
+date: 2024-04-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: activesupport