canon 0.3.1 → 0.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 8180c4d10ad157f5fd7d401d7c4723a70d53daa90894a43c33016253d0355093
-  data.tar.gz: 513538a92c8f209b2eeec7ecf2adedf9e2a86de8e2c6c0e807b45522afffa9b3
+  metadata.gz: b000e9e89684d66d4f037a950a2121a88717dd6c72d975648742f32b5a83fb9f
+  data.tar.gz: c5e8b5ecfdcb8435559be3e6c940e8e8bec99202054b90fa857f9e3afd3097e2
 SHA512:
-  metadata.gz: 15bbb37c41f2fe0809be3a1ae9e6e3bf438d7d509eb478b92eb1ace044d511017a257409024c0c7e042bf5dc146af0dbbfc9397c6ffea13a5d410fb9019c716d
-  data.tar.gz: 81c275d67d47bfeb87a1c5969e90643da41e8816e882a40fa5affa8337fbd3c5bd0ee82428ef63b36bc5dff8338776e8df4da53394d3319663f3167433664785
+  metadata.gz: '0804e7a2a07ff2687e363ee2bd0a1e2d00a5fe826e45ae5bd69fe26749bf2e2b1517a6fb2fcd3518e41d7d9bf6bf0b76fd8e704c288293724d27cbc3613978f4'
+  data.tar.gz: 6d9dca5aa3c29bbde5d067ca02e2a22c4d7bee098635e0fd8b48df16fbf08102fa713608f1965d198f3ace1c064743916b57d34d7a2cc2a6b845902e1553a045

data/lib/canon/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Canon
-  VERSION = "0.3.1"
+  VERSION = "0.3.2"
 end

data/lib/canon/xml/data_model.rb

@@ -154,11 +154,12 @@ module Canon
       end
 
       def self.build_node_from_nokogiri(nokogiri_node,
-preserve_whitespace: false)
+preserve_whitespace: false, inherited_namespaces: nil)
         case nokogiri_node
         when Nokogiri::XML::Element
           build_element_node(nokogiri_node,
-                             preserve_whitespace: preserve_whitespace)
+                             preserve_whitespace: preserve_whitespace,
+                             inherited_namespaces: inherited_namespaces)
         when Nokogiri::XML::Text, Nokogiri::XML::CDATA
           build_text_node(nokogiri_node,
                           preserve_whitespace: preserve_whitespace)
@@ -169,56 +170,44 @@ preserve_whitespace: false)
         end
       end
 
-      def self.build_element_node(nokogiri_element, preserve_whitespace: false)
+      def self.build_element_node(nokogiri_element, preserve_whitespace: false,
+inherited_namespaces: nil)
         element = Nodes::ElementNode.new(
           name: nokogiri_element.name,
           namespace_uri: nokogiri_element.namespace&.href,
           prefix: nokogiri_element.namespace&.prefix,
         )
 
-        build_namespace_nodes(nokogiri_element, element)
+        scope = nokogiri_namespace_scope(nokogiri_element, inherited_namespaces)
+        scope.each do |prefix, uri|
+          element.add_namespace(Nodes::NamespaceNode.new(
+                                  prefix: prefix,
+                                  uri: uri,
+                                ))
+        end
+
         build_attribute_nodes(nokogiri_element, element)
 
         nokogiri_element.children.each do |child|
           node = build_node_from_nokogiri(child,
-                                          preserve_whitespace: preserve_whitespace)
+                                          preserve_whitespace: preserve_whitespace,
+                                          inherited_namespaces: scope)
           element.add_child(node) if node
         end
 
         element
       end
 
-      def self.build_namespace_nodes(nokogiri_element, element)
-        namespaces = collect_in_scope_namespaces(nokogiri_element)
-
-        namespaces.each do |prefix, uri|
-          ns_node = Nodes::NamespaceNode.new(
-            prefix: prefix,
-            uri: uri,
-          )
-          element.add_namespace(ns_node)
-        end
-      end
-
-      def self.collect_in_scope_namespaces(nokogiri_element)
-        namespaces = {}
-
-        current = nokogiri_element
-        while current && !current.is_a?(Nokogiri::XML::Document)
-          if current.is_a?(Nokogiri::XML::Element)
-            current.namespace_definitions.each do |ns|
-              prefix = ns.prefix || ""
-              unless namespaces.key?(prefix)
-                namespaces[prefix] = ns.href
-              end
-            end
-          end
-          current = current.parent
+      # In-scope namespace bindings: the element's own declarations
+      # shadow inherited ones, xml is prebound. The scope is passed down
+      # the recursion — one definition fetch per element instead of an
+      # ancestor walk per element (O(n) total, not O(n * depth)).
+      def self.nokogiri_namespace_scope(nokogiri_element, inherited)
+        scope = inherited ? inherited.dup : { "xml" => "http://www.w3.org/XML/1998/namespace" }
+        nokogiri_element.namespace_definitions.each do |ns|
+          scope[ns.prefix || ""] = ns.href
         end
-
-        namespaces["xml"] ||= "http://www.w3.org/XML/1998/namespace"
-
-        namespaces
+        scope
       end
 
       def self.build_attribute_nodes(nokogiri_element, element)

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: canon
 version: !ruby/object:Gem::Version
-  version: 0.3.1
+  version: 0.3.2
 platform: ruby
 authors:
 - Ribose Inc.