canfig 0.0.3 → 0.0.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 943269b9166513da09c866d6d4bae9e8bdb7f79c
-  data.tar.gz: d1988d15d10df3182c134075461db5640f0bd595
+  metadata.gz: ac2beb0c3075dc310f01561ffded475028a3bbb8
+  data.tar.gz: 235d02c3dd6a3cb91f65b34780d359f13c602d78
 SHA512:
-  metadata.gz: 23d2195e6ae6b208e3a411b2de8904bef726a15c8dc5a4bf06f787fede78161485e3c24404655e63adf450d7fb0a8c7302453f87ee659d87ed171b2f7b39c2b0
-  data.tar.gz: d04944fa211c31db6f20df83f45824bf486c22de4568ce92b38860f875526edf197915d7619b6b07530948534c3449f747c423c6265c08e475eb90ff27de6444
+  metadata.gz: 373862b787b95c189ecee41b186a3e8ad64cab9cb64d0985f645e029c1a0ed1cf5b7fac8228bccd060d03e7306d330820432bd1fbe140d0922b24f0a8f4a9575
+  data.tar.gz: 4a65de2f0f811ac061e26079faaa4144a8dd735532d3f7192db926edf2063489619ecf0b8d903b1666bca818dded1774aa84ffa4a11c2612542e7d80ec0ef13b

data/lib/canfig.rb

@@ -5,7 +5,7 @@ require 'canfig/config'
 require 'canfig/open_config'
 require 'canfig/module'
 require 'canfig/class'
-require 'canfig/object'
+require 'canfig/instance'
 
 module Canfig
 end

data/lib/canfig/config.rb

@@ -2,7 +2,6 @@ module Canfig
   class Config
 
     def configure(argh={}, &block)
-      @options ||= {}
       save_state! do
         configure_with_args argh
         configure_with_block &block
@@ -12,7 +11,7 @@ module Canfig
 
     def configure_with_args(argh)
       save_state! do
-        argh.symbolize_keys.each { |key,val| configure_option(key, val) }
+        argh.symbolize_keys.each { |key,val| set(key, val) }
       end
     end
 
@@ -22,19 +21,33 @@ module Canfig
       end
     end
 
-    def configure_option(key, val)
-      raise ArgumentError, "#{key} is not an allowed configuration option" unless allowed?(key)
+    def set(key, val)
+      raise NoMethodError, "undefined method `#{key.to_s}=' for #{self.to_s}" unless allowed?(key)
 
       save_state! do
-        @changed[key] = [@options[key], val]
-        @options[key] = val
+        @state[key] = val
       end
     end
 
+    def []=(key, val)
+      set key, val
+    end
+
+    def get(key)
+      raise NoMethodError, "undefined method `#{key.to_s}' for #{self.to_s}" unless allowed?(key)
+      @state[key]
+    end
+
+    def [](key)
+      get key
+    end
+
+    def to_h
+      Hash[@allowed.map { |key| [key, @state[key]] }]
+    end
+
     def changed
-      @changed = {}
-      @options.each { |key,val| @changed[key] = [@saved_state[key], val] if @saved_state[key] != val }
-      @changed
+      Hash[@state.map { |key,val| [key, [@saved_state[key], val]] if @saved_state[key] != val }.compact]
     end
 
     def changed?(key)
@@ -43,8 +56,7 @@ module Canfig
 
     def save_state!(&block)
       if save_state?
-        @saved_state = @options.dup
-        @changed = {}
+        @saved_state = to_h
 
         if block_given?
           disable_state_saves!
@@ -78,9 +90,9 @@ module Canfig
     def method_missing(meth, *args, &block)
       if meth.to_s.match(/=\Z/)
         opt = meth.to_s.gsub(/=/,'').to_sym
-        return configure_option(opt, args.first) if allowed?(meth)
+        return set(opt, args.first) if allowed?(opt)
       else
-        return @options[meth] if allowed?(meth)
+        return @state[meth] if allowed?(meth)
       end
 
       super
@@ -90,7 +102,8 @@ module Canfig
 
     def initialize(*args, &block)
       options = args.extract_options!
-      @allowed = options.symbolize_keys.keys
+      @allowed = (args + options.symbolize_keys.keys).uniq.map(&:to_sym)
+      @state = {}
       enable_state_saves!
       configure options, &block
     end

data/lib/canfig/{object.rb → instance.rb}

@@ -1,5 +1,5 @@
 module Canfig
-  module Object
+  module Instance
     def configuration
       @configuration ||= Canfig::OpenConfig.new
     end

data/lib/canfig/open_config.rb

@@ -3,5 +3,9 @@ module Canfig
     def allowed?(opt)
       true
     end
+
+    def to_h
+      @state.to_h
+    end
   end
 end

data/lib/canfig/version.rb

@@ -1,3 +1,3 @@
 module Canfig
-  VERSION = '0.0.3'
+  VERSION = '0.0.4'
 end

data/spec/canfig/config_spec.rb

@@ -0,0 +1,222 @@
+require 'spec_helper'
+
+RSpec.describe Canfig::Config do
+  describe '#initialize' do
+    context 'when passed a list of keys' do
+      subject { Canfig::Config.new(:foo, :bar, :baz) }
+
+      it 'adds those keys to the allowed keys' do
+        expect(subject.allowed?(:foo)).to be_true
+        expect(subject.allowed?(:bar)).to be_true
+        expect(subject.allowed?(:baz)).to be_true
+      end
+    end
+
+    context 'when passed a hash of keys and values' do
+      subject { Canfig::Config.new(foo: 'foo', bar: 'bar', baz: 'baz') }
+
+      it 'adds those keys to the allowed keys' do
+        expect(subject.allowed?(:foo)).to be_true
+        expect(subject.allowed?(:bar)).to be_true
+        expect(subject.allowed?(:baz)).to be_true
+      end
+    end
+
+    context 'when passed a list of keys and a hash of keys and values' do
+      subject { Canfig::Config.new(:foo, :bar, baz: 'baz') }
+
+      it 'adds those keys to the allowed keys' do
+        expect(subject.allowed?(:foo)).to be_true
+        expect(subject.allowed?(:bar)).to be_true
+        expect(subject.allowed?(:baz)).to be_true
+      end
+    end
+  end
+
+  describe '#set' do
+    context 'when the key is allowed' do
+      subject { Canfig::Config.new(:foo) }
+
+      it 'sets the key/value pair' do
+        subject.set(:foo, 'bar')
+        expect(subject.get(:foo)).to eql('bar')
+      end
+    end
+
+    context 'when the key is not allowed' do
+      subject { Canfig::Config.new(:baz) }
+
+      it 'raises a NoMethodError' do
+        expect { subject.set(:foo, 'bar') }.to raise_exception(NoMethodError)
+      end
+    end
+  end
+
+  describe '#get' do
+    context 'when the key is allowed' do
+      subject { Canfig::Config.new(:baz, foo: 'bar') }
+
+      it 'returns the corresponding value' do
+        expect(subject.get(:foo)).to eql('bar')
+      end
+
+      context 'when the key is not set' do
+        it 'returns nil' do
+          expect(subject.get(:baz)).to be_nil
+        end
+      end
+    end
+
+    context 'when the key is not allowed' do
+      subject { Canfig::Config.new(:baz) }
+
+      it 'raises a NoMethodError' do
+        expect { subject.get(:foo) }.to raise_exception(NoMethodError)
+      end
+    end
+  end
+
+  describe '#to_h' do
+    subject { Canfig::Config.new(:foo, bar: 'bar', baz: 'baz') }
+
+    it 'returns a hash' do
+      expect(subject.to_h).to be_an_instance_of(Hash)
+    end
+
+    it 'contain all allowed keys' do
+      [:foo, :bar, :baz].each do |key|
+        expect(subject.to_h.keys).to include(key)
+      end
+    end
+  end
+
+  describe '#configure_with_args' do
+    subject { Canfig::Config.new(:foo, bar: 'bar', baz: 'baz') }
+
+    context 'when the passed keys are allowed' do
+      it 'sets the key/value pairs passed the hash' do
+        subject.configure_with_args({foo: 1, bar: 2})
+        expect(subject.get(:foo)).to eql(1)
+        expect(subject.get(:bar)).to eql(2)
+      end
+    end
+
+    context 'when the passed keys are not allowed' do
+      it 'raises a NoMethodError' do
+        expect { subject.configure_with_args({abc: '123'}) }.to raise_exception(NoMethodError)
+      end
+    end
+  end
+
+  describe '#configure_with_block' do
+    subject { Canfig::Config.new(:foo, bar: 'bar', baz: 'baz') }
+
+    it 'accepts a block' do
+      expect { subject.configure_with_block { |config| } }.to_not raise_exception
+    end
+
+    it 'executes the block with instance_eval' do
+      conf = nil
+      subject.configure_with_block { |config| conf = config }
+      expect(conf).to eql(subject)
+    end
+  end
+
+  describe '#configure' do
+    subject { Canfig::Config.new(:foo, bar: 'bar', baz: 'baz') }
+
+    it 'returns self' do
+      expect(subject.configure).to eql(subject)
+    end
+
+    it 'accepts a hash and a block' do
+      subject.configure foo: 'foo' do |config|
+        config.bar = 'baz'
+        config.baz = 'bar'
+      end
+
+      expect(subject.get(:foo)).to eql('foo')
+      expect(subject.get(:bar)).to eql('baz')
+      expect(subject.get(:baz)).to eql('bar')
+    end
+  end
+
+  context 'when referencing option keys' do
+    subject { Canfig::Config.new(:foo, bar: 'bar', baz: 'baz') }
+
+    context 'that are allowed' do
+      context 'using getter methods' do
+        it 'returns the value' do
+          expect(subject.bar).to eql('bar')
+        end
+      end
+
+      context 'using setter methods' do
+        it 'sets the passed value to the key' do
+          subject.bar = 'foo'
+          expect(subject.bar).to eql('foo')
+        end
+      end
+    end
+
+    context 'that are not allowed' do
+      context 'using getter methods' do
+        it 'returns the value' do
+          expect { subject.abc }.to raise_exception(NoMethodError)
+        end
+      end
+
+      context 'using setter methods' do
+        it 'sets the passed value to the key' do
+          expect { subject.abc = 123 }.to raise_exception(NoMethodError)
+        end
+      end
+    end
+  end
+
+  context 'when saving state' do
+    subject { Canfig::Config.new(:foo, bar: 'bar', baz: 'baz') }
+
+    describe '#changed' do
+      it 'returns a hash' do
+        subject.configure do |config|
+          config.foo = 'test'
+          config.bar = 1
+        end
+
+        expect(subject.changed).to be_an_instance_of(Hash)
+      end
+
+      it 'contains the changed keys' do
+        subject.configure do |config|
+          config.foo = 'test'
+          config.bar = 1
+        end
+
+        [:foo, :bar].each do |key|
+          expect(subject.changed.keys).to include(key)
+        end
+      end
+
+      it 'contains only the changed keys' do
+        subject.configure do |config|
+          config.foo = 'test'
+          config.bar = 1
+        end
+
+        expect(subject.changed.keys).to_not include(:baz)
+      end
+
+      it 'contains the old and new values' do
+        subject.configure do |config|
+          config.foo = 'test'
+          config.bar = 1
+        end
+
+        expect(subject.changed[:foo]).to eql([nil,'test'])
+        expect(subject.changed[:bar]).to eql(['bar',1])
+      end
+    end
+  end
+
+end

data/spec/canfig/open_config_spec.rb

@@ -0,0 +1,20 @@
+require 'spec_helper'
+
+RSpec.describe Canfig::OpenConfig do
+  describe '#to_h' do
+    subject { Canfig::OpenConfig.new() }
+
+    it 'returns a hash' do
+      expect(subject.to_h).to be_an_instance_of(Hash)
+    end
+
+    it 'contain all set keys' do
+      subject.set :foo, 'foo'
+      subject.set :bar, 'bar'
+      subject.set :baz, 'baz'
+      [:foo, :bar, :baz].each do |key|
+        expect(subject.to_h.keys).to include(key)
+      end
+    end
+  end
+end

data/spec/canfig_spec.rb

@@ -0,0 +1,4 @@
+require 'spec_helper'
+
+RSpec.describe Canfig do
+end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: canfig
 version: !ruby/object:Gem::Version
-  version: 0.0.3
+  version: 0.0.4
 platform: ruby
 authors:
 - Mark Rebec
@@ -62,10 +62,13 @@ files:
 - lib/canfig.rb
 - lib/canfig/class.rb
 - lib/canfig/config.rb
+- lib/canfig/instance.rb
 - lib/canfig/module.rb
-- lib/canfig/object.rb
 - lib/canfig/open_config.rb
 - lib/canfig/version.rb
+- spec/canfig/config_spec.rb
+- spec/canfig/open_config_spec.rb
+- spec/canfig_spec.rb
 - spec/spec_helper.rb
 homepage: http://github.com/markrebec/canfig
 licenses: []
@@ -91,4 +94,7 @@ signing_key:
 specification_version: 4
 summary: Dead simple canned configuration for gems or whatever
 test_files:
+- spec/canfig/config_spec.rb
+- spec/canfig/open_config_spec.rb
+- spec/canfig_spec.rb
 - spec/spec_helper.rb