cane-hashcheck 1.1.0 → 1.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: c47adb3d6706afa10b570b5463aa1dd558f71b9c
-  data.tar.gz: 0ce9c5a3192dda4666d823c0e6693b4a7cd63428
+  metadata.gz: 471602330607cb2c010871102bb8b1e0976f8016
+  data.tar.gz: bbe149977d4ffdf1a687a14eab430ce795631687
 SHA512:
-  metadata.gz: 62556ca821047b33b9e047b3de3e22cf24e245db5d13cb1b32cbaf189736a131d83a418c68849d6a0725437e7f8a796c9706e1013fdf355054c5c54c8668f3ae
-  data.tar.gz: ddae7ebec69215afee4be07ef7138dfb61eceae1891e44503e58ffbc0b02ca795446aa84ee2eae20b56562f542741d0ce2d99c0678450ce2ada3035c79937fb4
+  metadata.gz: 77db1bab7a24f90fefb95316be7ef472659d5ec246bffaebebbdd912df542aab385f8abe7d596c873fe5edf06420062ac01819b4405d4dc9b303c8cdee162012
+  data.tar.gz: e8703364ab7e7169b728a67d513467bb48172e18f36524fd69eec7180fb003686989dc0c74284f239efd0cc5215a162cacf9345f3d7887f7c4cc1c54d9494165

data/CHANGELOG.md

@@ -0,0 +1,29 @@
+# Changelog
+
+#v1.2.0
+*2013-06-14*
+
+[\[8 commits\]](https://github.com/chrishunt/cane-hashcheck/compare/v1.1.0...v1.2.0)
+
+- Hash rockets without whitespace are invalid
+- Hash rockets valid in namespaced rescue
+
+##v1.1.0
+*2013-05-15*
+
+[\[2 commits\]](https://github.com/chrishunt/cane-hashcheck/compare/v1.0.0...v1.1.0)
+
+- Allow whitespace around hash rocket when valid
+
+##v1.0.0
+*2013-05-15*
+
+[\[7 commits\]](https://github.com/chrishunt/cane-hashcheck/compare/v0.9.0...v1.0.0)
+
+- Allow hash rocket when key is double quoted
+- Allow hash rockets when keys are Integers
+
+##v0.9.0
+*2013-04-30*
+
+- Initial release

data/CONTRIBUTING.md

@@ -0,0 +1,13 @@
+# Contributing
+
+Want to contribute? Awesome! Thank you so much.
+
+## How?
+
+1. [Fork it](https://help.github.com/articles/fork-a-repo)
+2. Create a feature branch (`git checkout -b my-new-feature`)
+3. Commit changes, **with tests** (`git commit -am 'Add some feature'`)
+4. Run the tests (`bundle exec rake`)
+5. Push to the branch (`git push origin my-new-feature`)
+6. Create new [Pull
+   Request](https://help.github.com/articles/using-pull-requests)

data/README.md

@@ -75,10 +75,13 @@ See the [cane project](https://github.com/square/cane) for general usage
 instructions.
 
 ## Contributing
+Please see the [Contributing
+Document](https://github.com/chrishunt/cane-hashcheck/blob/master/CONTRIBUTING.md)
 
-1. Fork it
-2. Create your feature branch (`git checkout -b my-new-feature`)
-3. Commit your changes, with tests (`git commit -am 'Add some feature'`)
-4. Run the tests (`bundle exec rake`)
-5. Push to the branch (`git push origin my-new-feature`)
-6. Create new Pull Request
+## Changelog
+Please see the [Changelog
+Document](https://github.com/chrishunt/cane-hashcheck/blob/master/CHANGELOG.md)
+
+## License
+Copyright (C) 2013 Chris Hunt, [MIT
+License](https://github.com/chrishunt/cane-hashcheck/blob/master/LICENSE.txt)

data/lib/cane/hashcheck/hash_check.rb

@@ -1,6 +1,6 @@
+# Creates violations for hashes using pre-Ruby 1.9 hash syntax. Hash rockets
+# are allowed only if the key is a 'string' or CONSTANT.
 module Cane
-  # Creates violations for hashes using pre-Ruby 1.9 hash syntax. Hash rockets
-  # are allowed only if the key is a 'string' or CONSTANT.
   HashCheck = Struct.new(:options) do
 
     DESCRIPTION  = 'Ruby 1.9 hash syntax violation'
@@ -49,11 +49,16 @@ module Cane
     end
 
     def invalid?(line)
-      line =~ /([^'"A-Z\d\s])\s+=>\s+/
+      line =~ hash_rocket_regex
     end
 
     def file_names
       Dir[ options.fetch(:hash_glob){ DEFAULT_GLOB } ]
     end
+
+    # http://rubular.com/r/p8AoYTwOWO
+    def hash_rocket_regex
+      /(?:[^:]:\w+)\s*=>\s*/
+    end
   end
 end

data/lib/cane/hashcheck/version.rb

@@ -1,5 +1,5 @@
 module Cane
   module Hashcheck
-    VERSION = '1.1.0'
+    VERSION = '1.2.0'
   end
 end

data/spec/cane/hash_check_spec.rb

@@ -22,17 +22,20 @@ describe Cane::HashCheck do
           :not => :valid,
           TOTALLY => :valid,
           LOTS_OF    =>   :whitespace_is_valid,
-          18 => 1 # this is valid, hash rockets are required for ints
+          18 =>, 1 # this is valid, hash rockets are required for ints
+          :no_whitespace=>:still_not_valid
         }
         {
           'also' => 'valid',
           "and also" => 'valid'
         }
+
+        rescue Foobar::Test => valid
       RUBY
     end
 
     it 'has a violation for each invalid hash rocket' do
-      expect(subject.violations.count).to eq 2
+      expect(subject.violations.count).to eq 3
     end
 
     it 'puts the offending file name in the violation' do
@@ -44,6 +47,7 @@ describe Cane::HashCheck do
     it 'puts the offending line number in the violation' do
       expect(subject.violations[0][:line]).to eq 2
       expect(subject.violations[1][:line]).to eq 5
+      expect(subject.violations[2][:line]).to eq 9
     end
   end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: cane-hashcheck
 version: !ruby/object:Gem::Version
-  version: 1.1.0
+  version: 1.2.0
 platform: ruby
 authors:
 - Chris Hunt
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-05-15 00:00:00.000000000 Z
+date: 2013-06-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -74,6 +74,8 @@ extensions: []
 extra_rdoc_files: []
 files:
 - .gitignore
+- CHANGELOG.md
+- CONTRIBUTING.md
 - Gemfile
 - LICENSE.txt
 - README.md