camille 1.8.0 → 1.8.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: b669731de34897fd2acb06cac773161fe3118a5203d4c9fd3ae41f5a6fca39e8
-  data.tar.gz: bdeca5f3af494575e42fece40de7682f441f43040ac11fe9e88d63516c0fdbc9
+  metadata.gz: 43d1b00b15c6fb8dd557ad587bc0113f56328571ae309bf01e9f16a90cf6cc6e
+  data.tar.gz: f2f994348c8466586b6444885ea225446f15e45fac89f2942aa88ab135287195
 SHA512:
-  metadata.gz: d65f75dc0f47bb06962313132d639ed6acd876ef5524cdbc8fb7e9ec55643f3de5b7e7984c372de017e1e3ddfbd161deb7794ee0876f019ef13de401301a4e62
-  data.tar.gz: 92cab47708e350863586256efab349a85b4f16572f402b336802f4c035f0f2511cbc406d6215c9b9312cc4958d498d3c7bdd41556f6566118f0271e6ff59d326
+  metadata.gz: be0fba9d87641faa8df13542937860f4d04d2cbfb5ec65b7e3ace488aff7d373f6c83d5601fe1aa046e6d6b0df6ab565cc8a5fbe9669a4084613822a6af3c328
+  data.tar.gz: 426ab4e50a688e656552d512bed7b9f324bab52e23165d461abdba7843228a80ab9e2956d7232664a0e0b9f953061316104f4e59544dfdc569b4455e6c0e2efe

data/CHANGELOG.md

@@ -1,5 +1,12 @@
 # Changelog
 
+## 1.8.1
+
+### Fixed
+
+* `Record`, `Pick` and `Omit` now implement `check_params`, so nested objects inside them get their camelCase keys converted instead of failing with errors like `Expected array, got nil`. Record keys are still not converted.
+* `response.data` in `camille/testing` no longer type checks non-200 responses, matching `Camille::Controller#render`, which only checks and converts keys for 200 responses. Non-200 bodies are returned as-is.
+
 ## 1.8.0
 
 ### Added

data/Gemfile.lock

@@ -1,7 +1,7 @@
 PATH
   remote: .
   specs:
-    camille (1.8.0)
+    camille (1.8.1)
       rails (>= 6.1, < 8.1)
 
 GEM

data/README.md

@@ -304,7 +304,7 @@ get '/products/data'
 expect(response.data[:product][:available_stock]).to eq(1)
 ```
 
-If the response body fails the type check the helper raises `Camille::Testing::ResponseTypeError`. If the route has no Camille endpoint it raises `Camille::Testing::MissingEndpointError`.
+Since `Camille::Controller#render` only type checks and converts keys for 200 responses, `response.data` returns non-200 bodies as-is without validation. If a 200 response body fails the type check the helper raises `Camille::Testing::ResponseTypeError`. If the route has no Camille endpoint it raises `Camille::Testing::MissingEndpointError`.
 
 ## Versioning
 

data/lib/camille/pick_and_omit.rb

@@ -25,6 +25,10 @@ module Camille
       processed_object.check(value)
     end
 
+    def check_params value
+      processed_object.check_params(value)
+    end
+
     def literal
       "#{klass_name}<#{@type.literal}, #{keys_in_literal}>"
     end

data/lib/camille/testing.rb

@@ -24,6 +24,10 @@ module Camille
             "No camille endpoint for #{controller_class_name}##{action}."
         end
 
+        # Camille::Controller#render only type checks and converts keys for
+        # 200 responses, so mirror that here and return non-200 bodies as-is.
+        return deep_indifferent(parsed_body) unless status == 200
+
         result = endpoint.response_type.check_params(parsed_body)
         if result.type_error?
           io = StringIO.new

data/lib/camille/types/record.rb

@@ -11,28 +11,14 @@ module Camille
       end
 
       def check value
-        if value.is_a? ::Hash
-
-          results = value.map.with_index do |(k, v), index|
-            [index, check_pair(k, v)]
-          end
-
-          errors = results.map do |index, result|
-            if result.instance_of?(Camille::TypeError)
-              ["record[#{index}]", result]
-            else
-              nil
-            end
-          end.compact
+        check_with_method(value, :check)
+      end
 
-          if errors.empty?
-            Camille::Checked.new(fingerprint, results.map{|_, result| [result[0].value, result[1].value]}.to_h)
-          else
-            Camille::TypeError.new(**errors.to_h)
-          end
-        else
-          Camille::TypeError.new("Expected hash, got #{value.inspect}.")
-        end
+      # Record keys are dynamic, so they are never converted between
+      # camelCase and snake_case. Only the values are checked with
+      # `check_params` so nested objects get their keys converted.
+      def check_params value
+        check_with_method(value, :check_params)
       end
 
       def self.[] key, value
@@ -44,9 +30,34 @@ module Camille
       end
 
       private
-        def check_pair key, value
+        def check_with_method value, method_name
+          if value.is_a? ::Hash
+
+            results = value.map.with_index do |(k, v), index|
+              [index, check_pair(k, v, method_name)]
+            end
+
+            errors = results.map do |index, result|
+              if result.instance_of?(Camille::TypeError)
+                ["record[#{index}]", result]
+              else
+                nil
+              end
+            end.compact
+
+            if errors.empty?
+              Camille::Checked.new(fingerprint, results.map{|_, result| [result[0].value, result[1].value]}.to_h)
+            else
+              Camille::TypeError.new(**errors.to_h)
+            end
+          else
+            Camille::TypeError.new("Expected hash, got #{value.inspect}.")
+          end
+        end
+
+        def check_pair key, value, method_name
           key_result = @key.check key
-          value_result = @value.check value
+          value_result = @value.public_send(method_name, value)
 
           if key_result.checked? && value_result.checked?
             [key_result, value_result]

data/lib/camille/version.rb

@@ -1,5 +1,5 @@
 # frozen_string_literal: true
 
 module Camille
-  VERSION = "1.8.0"
+  VERSION = "1.8.1"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: camille
 version: !ruby/object:Gem::Version
-  version: 1.8.0
+  version: 1.8.1
 platform: ruby
 authors:
 - merely