callcredit 0.3.7 → 0.3.8

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 45614e1397afff4e95991b829a14e1001e0d79d2
-  data.tar.gz: 6b4ca2913c8f061344363fc0773a57e2f836cab1
+  metadata.gz: 1213865aa7687c9adfd222ffeed8c2e1e6a76ccd
+  data.tar.gz: 2e1265299afc2b3198eb4c1c0c07da6e809dd6fe
 SHA512:
-  metadata.gz: 2f555f5241e1a4b127a51dc8cb3229083250cf34eb990f071022a2722e090546e35c1b0d63b94b77ddf3eed5a923e11e3e540fe96a7634b06333e11be22240cc
-  data.tar.gz: 395f439d4527279815c8bce6fb376488185efdcaed86589fe4096d210e3e1d224ad04858da42602de3a9afa3a095eaa34383b98d6b8e0b51f6ac4e064c4b61c3
+  metadata.gz: 88f56e2dce84202fdaed7891de549f8e6c4d89400c6c6b1718efe717fc50368f7ef990ccd9a066ff5568f69388db2a6e9020e38b0e06f732bc1d4cb0581f4259
+  data.tar.gz: 321382da4b9e994eeb5c702c166ff78a8372e5bfb3d640b17a6d8dc596339427c1d507354f87e437bf0945b6021ea5f9cd53887762a2faf4e0bbd8f90e2ba80f

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.8 - July 16, 2014
+
+- Include requiest ID (RID) on all requests
+
 ## 0.3.7 - June 3, 2014
 
 - Add support for Faraday 0.9

data/callcredit.gemspec

@@ -6,8 +6,8 @@ Gem::Specification.new do |gem|
   gem.add_runtime_dependency 'nokogiri',            '~> 1.4'
   gem.add_runtime_dependency 'unicode_utils',       '~> 1.4.0'
 
-  gem.add_development_dependency 'rspec',           '~> 2.14.1'
-  gem.add_development_dependency 'webmock',         '~> 1.17.2'
+  gem.add_development_dependency 'rspec',           '~> 3.0.0'
+  gem.add_development_dependency 'webmock',         '~> 1.18.0'
 
   gem.authors = ['Grey Baker']
   gem.description = %q{Ruby wrapper for Callcredit's CallValidate API}

data/lib/callcredit/request.rb

@@ -27,7 +27,7 @@ module Callcredit
         xml.callvalidate do
           authentication(xml)
           xml.sessions do
-            xml.session do
+            xml.session("RID" => Time.now.to_f) do
               xml.data do
                 personal_data(xml, check_data[:personal_data])
                 card_data(xml, check_data[:card_data])

data/lib/callcredit/version.rb

@@ -1,3 +1,3 @@
 module Callcredit
-  VERSION = '0.3.7'.freeze
+  VERSION = '0.3.8'.freeze
 end

data/spec/callcredit_spec.rb

@@ -8,7 +8,11 @@ describe Callcredit do
     Callcredit::Config::DEFAULT_OPTIONS.keys.map(&:to_sym).each do |key|
       context "setting #{key}" do
         before { Callcredit.configure { |config| config[key] = key } }
-        its([key]) { should == key }
+
+        describe [key] do
+          subject { super()[key] }
+          it { should == key }
+        end
       end
     end
   end
@@ -26,8 +30,8 @@ describe Callcredit do
     let(:data) { { first_name: "Grey", last_name: "Baker" } }
 
     it "delegates to the client" do
-      Callcredit::Client.any_instance.
-        should_receive(:id_enhanced_check).with(data)
+      expect_any_instance_of(Callcredit::Client).
+        to receive(:id_enhanced_check).with(data)
       Callcredit.id_enhanced_check(data)
     end
   end
@@ -39,8 +43,8 @@ describe Callcredit do
     end
 
     it "delegates to the client" do
-      Callcredit::Client.any_instance.
-        should_receive(:perform_check).with(:id_enhanced_check, data)
+      expect_any_instance_of(Callcredit::Client).
+        to receive(:perform_check).with(:id_enhanced_check, data)
       Callcredit.perform_check(:id_enhanced_check, data)
     end
   end

data/spec/checks/id_enhanced_spec.rb

@@ -24,15 +24,19 @@ describe Callcredit::Checks::IDEnhanced do
 
     it "makes a get request" do
       perform_check
-      a_request(:get, config[:api_endpoint]).should have_been_made
+      expect(a_request(:get, config[:api_endpoint])).to have_been_made
     end
 
-    it { should be_a Callcredit::Response }
+    it { is_expected.to be_a Callcredit::Response }
 
     context "when the config[:raw] is true" do
       before { config[:raw] = true }
-      it { should be_a Faraday::Response }
-      its(:body) { should be_a String }
+      it { is_expected.to be_a Faraday::Response }
+
+      describe '#body' do
+        subject { super().body }
+        it { should be_a String }
+      end
     end
 
     describe "validates inputs" do
@@ -48,7 +52,7 @@ describe Callcredit::Checks::IDEnhanced do
 
         it "makes a get request" do
           perform_check
-          a_request(:get, config[:api_endpoint]).should have_been_made
+          expect(a_request(:get, config[:api_endpoint])).to have_been_made
         end
       end
     end

data/spec/client_spec.rb

@@ -10,7 +10,10 @@ describe Callcredit::Client do
       before { configure_callcredit }
       subject(:new_client) { Callcredit::Client.new }
 
-      its(:config) { should_not == Callcredit.config }
+      describe '#config' do
+        subject { super().config }
+        it { should_not == Callcredit.config }
+      end
       it "has the attributes of the global config" do
         new_client.config[:first_name] == Callcredit.config[:first_name]
       end
@@ -20,7 +23,10 @@ describe Callcredit::Client do
       before { config[:first_name] = "test" }
       subject(:new_client) { Callcredit::Client.new(config) }
 
-      its(:config) { should_not == config }
+      describe '#config' do
+        subject { super().config }
+        it { should_not == config }
+      end
       it "has the attributes of the passed in config" do
         new_client.config[:first_name] == config[:first_name]
       end

data/spec/request_spec.rb

@@ -32,13 +32,13 @@ describe Callcredit::Request do
     let(:xsd) { Nokogiri::XML::Schema(xml_schema) }
 
     it "generates a valid XML request" do
-      xsd.validate(request_xml).should == []
+      expect(xsd.validate(request_xml)).to eq([])
     end
 
     context "with a date object for date_of_birth" do
       let(:date_of_birth) { Date.parse("01/01/2000") }
       it "generates a valid XML request" do
-        xsd.validate(request_xml).should == []
+        expect(xsd.validate(request_xml)).to eq([])
       end
     end
   end
@@ -48,18 +48,22 @@ describe Callcredit::Request do
 
     it "makes a get request" do
       perform_check
-      a_request(:get, config[:api_endpoint]).should have_been_made
+      expect(a_request(:get, config[:api_endpoint])).to have_been_made
     end
 
     context "when the config[:raw] is true" do
       before { config[:raw] = true }
-      it { should be_a Faraday::Response }
-      its(:body) { should be_a String }
+      it { is_expected.to be_a Faraday::Response }
+
+      describe '#body' do
+        subject { super().body }
+        it { should be_a String }
+      end
     end
 
     context "when the config[:raw] is false" do
-      it { should be_a Hash }
-      it { should include "Results" }
+      it { is_expected.to be_a Hash }
+      it { is_expected.to include "Results" }
 
       context "errors" do
         context "500" do

data/spec/response_spec.rb

@@ -6,6 +6,6 @@ describe Callcredit::Response do
   subject(:response) { Callcredit::Response.new(result_hash) }
 
   it "makes some helper methods available" do
-    response.pid.should == "LTJ-CT2-1606-13927-46399"
+    expect(response.pid).to eq("LTJ-CT2-1606-13927-46399")
   end
 end

data/spec/spec_helper.rb

@@ -1,6 +1,11 @@
 require 'callcredit'
 require 'webmock/rspec'
-RSpec.configure { |config| config.include WebMock::API }
+
+RSpec.configure do |config|
+  config.mock_with(:rspec) { |mocks| mocks.verify_partial_doubles = true }
+  config.raise_errors_for_deprecations!
+  config.include WebMock::API
+end
 
 def configure_callcredit
   Callcredit.configure do |config|
@@ -23,4 +28,4 @@ shared_examples "it validates presence" do |property|
       expect { subject }.to raise_error Callcredit::InvalidRequestError
     end
   end
-end
+end

data/spec/validations_spec.rb

@@ -6,17 +6,17 @@ describe Callcredit::Validations do
 
     context "without a date of birth" do
       let(:date_of_birth) { nil }
-      it { should == nil }
+      it { is_expected.to eq(nil) }
     end
 
     context "with a date object" do
       let(:date_of_birth) { Date.parse("01/01/2000") }
-      it { should == date_of_birth.strftime("%d/%m/%Y") }
+      it { is_expected.to eq(date_of_birth.strftime("%d/%m/%Y")) }
     end
 
     context "with a parseable string" do
       let(:date_of_birth) { "01-01-2000" }
-      it { should == "01/01/2000" }
+      it { is_expected.to eq("01/01/2000") }
     end
 
     context "with a load of rubbish" do
@@ -32,17 +32,17 @@ describe Callcredit::Validations do
 
     context "without a name" do
       let(:name) { nil }
-      it { should == nil }
+      it { is_expected.to eq(nil) }
     end
 
     context "with a simple name" do
       let(:name) { "Grey" }
-      it { should == name }
+      it { is_expected.to eq(name) }
     end
 
     context "with a name with non-ASCII characters" do
       let(:name) { "Gréy" }
-      it { should == "Grey" }
+      it { is_expected.to eq("Grey") }
     end
 
     context "with a very long name" do
@@ -65,17 +65,17 @@ describe Callcredit::Validations do
 
     context "without a postcode" do
       let(:postcode) { nil }
-      it { should == nil }
+      it { is_expected.to eq(nil) }
     end
 
     context "with a correct postcode" do
       let(:postcode) { "EC2A 1DX" }
-      it { should == postcode }
+      it { is_expected.to eq(postcode) }
     end
 
     context "with a padded postcode" do
       let(:postcode) { "EC2A 1DX    " }
-      it { should == "EC2A 1DX" }
+      it { is_expected.to eq("EC2A 1DX") }
     end
 
     context "with a postcode that is too short" do

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: callcredit
 version: !ruby/object:Gem::Version
-  version: 0.3.7
+  version: 0.3.8
 platform: ruby
 authors:
 - Grey Baker
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-03 00:00:00.000000000 Z
+date: 2014-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: faraday_middleware
@@ -78,28 +78,28 @@ dependencies:
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.0.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 2.14.1
+        version: 3.0.0
 - !ruby/object:Gem::Dependency
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.17.2
+        version: 1.18.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
     - - ~>
       - !ruby/object:Gem::Version
-        version: 1.17.2
+        version: 1.18.0
 description: Ruby wrapper for Callcredit's CallValidate API
 email:
 - grey@gocardless.com