callcredit 0.3.4 → 0.3.5

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 53b5cefad92f98c5380ed32a4898b210c73cd455
-  data.tar.gz: 7afe3319d5e548c209f758d05bb6e859245e6619
+  metadata.gz: fa5511f62db44e4945ee93b3f8be5bdc295ee064
+  data.tar.gz: 4cee4c1eaca735897d678190311dc9ff62383aab
 SHA512:
-  metadata.gz: 1db3d187a7e5bae829f89760ba02a04aec5ca562c5c1b1b9be105e7cd1268bd51f2266d5d3ae12b873181590ce4c0a400a56630fa31f161a8dd3a62c87786b1a
-  data.tar.gz: 13b1835f96b0e1fceb556d5bab3e255082fcfcdeab18e73cb6d3ccacb1dd15e61c8ea3512574c8860411bd00eb38a2a8aabd888ac961650751ee1227c97ca2ca
+  metadata.gz: 3b63ca88889c45fba9f6369c647e54168b266563c47f237230563992fe3e348b0e2d60dc0f5cada2d6b0e8e887e960ed560a2fd5f15ea0ce4df261258e25dab8
+  data.tar.gz: e4e06bc0571ce0f04c5277843330184e73f70333024253007e32c06ea8533a22470ef011b7e417d8d172717047ad9debdbe1d11f557fb3f2166cc7a0d2efaf91

data/CHANGELOG.md

@@ -1,3 +1,7 @@
+## 0.3.5 - February 24, 2014
+
+- Remove insistence on inclusion of date_of_birth, postcode and names
+
 ## 0.3.4 - February 24, 2014
 
 - Validate input (including converting non-ASCII characters in names)

data/lib/callcredit/validations.rb

@@ -4,12 +4,12 @@ module Callcredit
   module Validations
 
     VALIDATIONS = {
-      date_of_birth:    ->(value) { clean_date_of_birth(value) },
-      title:            ->(value) { value || "Unknown" },
-      first_name:       ->(value) { clean_first_name(value) },
-      last_name:        ->(value) { clean_last_name(value) },
-      middle_names:     ->(value) { clean_middle_names(value) },
-      postcode:         ->(value) { clean_postcode(value) }
+      date_of_birth:      ->(value) { clean_date_of_birth(value) },
+      title:              ->(value) { value || "Unknown" },
+      first_name:         ->(value) { clean_first_name(value) },
+      last_name:          ->(value) { clean_last_name(value) },
+      middle_names:       ->(value) { clean_middle_names(value) },
+      postcode:           ->(value) { clean_postcode(value) }
     }
 
     def self.clean_param(key, value)
@@ -18,6 +18,7 @@ module Callcredit
     end
 
     def self.clean_date_of_birth(date_of_birth)
+      return unless date_of_birth
       date_of_birth = Date.parse(date_of_birth) if date_of_birth.is_a? String
       date_of_birth.strftime("%d/%m/%Y")
     rescue
@@ -25,13 +26,15 @@ module Callcredit
     end
 
     def self.clean_first_name(name)
-      name = name && name.to_ascii
+      return unless name
+      name = name.to_ascii
       input_error(:first_name, name) unless name =~ /\A[a-z A-Z'-]{1,30}\z/
       name
     end
 
     def self.clean_last_name(name)
-      name = name && name.to_ascii
+      return unless name
+      name = name.to_ascii
       input_error(:last_name, name) unless name =~ /\A[a-z A-Z'-]{1,30}\z/
       name
     end
@@ -44,7 +47,8 @@ module Callcredit
     end
 
     def self.clean_postcode(postcode)
-      postcode = postcode && postcode.upcase.strip
+      return unless postcode
+      postcode = postcode.upcase.strip
       input_error(:postcode, postcode) unless postcode =~ /\A[A-Z 0-9]{5,8}\z/
       postcode
     end

data/lib/callcredit/version.rb

@@ -1,3 +1,3 @@
 module Callcredit
-  VERSION = '0.3.4'.freeze
+  VERSION = '0.3.5'.freeze
 end

data/spec/validations_spec.rb

@@ -16,6 +16,11 @@ describe Callcredit::Validations do
   describe '#clean_date_of_birth' do
     subject { Callcredit::Validations.clean_date_of_birth(date_of_birth) }
 
+    context "without a date of birth" do
+      let(:date_of_birth) { nil }
+      it { should == nil }
+    end
+
     context "with a date object" do
       let(:date_of_birth) { Date.parse("01/01/2000") }
       it { should == date_of_birth.strftime("%d/%m/%Y") }
@@ -39,9 +44,7 @@ describe Callcredit::Validations do
 
     context "without a first name" do
       let(:first_name) { nil }
-      it "raises an error" do
-        expect { subject }.to raise_error Callcredit::InvalidRequestError
-      end
+      it { should == nil }
     end
 
     context "with a simple first name" do
@@ -54,14 +57,14 @@ describe Callcredit::Validations do
       it { should == "Grey" }
     end
 
-    context "without a very long first name" do
+    context "with a very long first name" do
       let(:first_name) { "A" * 31 }
       it "raises an error" do
         expect { subject }.to raise_error Callcredit::InvalidRequestError
       end
     end
 
-    context "without a first name with numbers in it" do
+    context "with a first name with numbers in it" do
       let(:first_name) { "David the 3rd" }
       it "raises an error" do
         expect { subject }.to raise_error Callcredit::InvalidRequestError
@@ -83,9 +86,7 @@ describe Callcredit::Validations do
 
     context "without a post code" do
       let(:postcode) { nil }
-      it "raises an error" do
-        expect { subject }.to raise_error Callcredit::InvalidRequestError
-      end
+      it { should == nil }
     end
 
     context "with a correct post code" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: callcredit
 version: !ruby/object:Gem::Version
-  version: 0.3.4
+  version: 0.3.5
 platform: ruby
 authors:
 - Grey Baker