cafepress_api 0.1.3 → 0.1.4

data/lib/cafepress_api/version.rb

@@ -15,5 +15,5 @@
 # along with CafePressAPI.  If not, see <http://www.gnu.org/licenses/>.
 
 module CafePressAPI
-  VERSION = "0.1.3"
+  VERSION = "0.1.4"
 end

data/lib/cafepress_api.rb

@@ -66,16 +66,24 @@ Or better yet, add the mapping yourself in product_genders.rb and submit it back
 %})
         end
       end
-      
+
+      # The CafePress API (at the time of this code) doesn't correctly return
+      # product images only for the colors which are available for the product.
+      # as such, I am filtering out "invalid" colors from the productUrl(s)
+      valid_color_ids = product.get_elements('color').map{|color| color.attributes['id']}
+
       image_urls = []
       product.get_elements("productImage").each do |product_image|
-        if product_image.attributes['productUrl'].include?('_Front')
-          image_urls << {:color_id => product_image.attributes['colorId'], :url => product_image.attributes['productUrl'], :view => FRONT_PRODUCT_VIEW, :size => product_image.attributes['imageSize']}
-        elsif product_image.attributes['productUrl'].include?('_Back')
-          image_urls << {:color_id => product_image.attributes['colorId'], :url => product_image.attributes['productUrl'], :view => BACK_PRODUCT_VIEW, :size => product_image.attributes['imageSize']}
-        else
-          warn("\nWARNING: the image url #{product_image.attributes['productUrl']} does not appear to be a front or back image, assuming it is a front image.")
-          image_urls << {:color_id => product_image.attributes['colorId'], :url => product_image.attributes['productUrl'], :view => FRONT_PRODUCT_VIEW, :size => product_image.attributes['imageSize']}
+        # only parse if it is a product image for an available color
+        if valid_color_ids.include?(product_image.attributes['colorId'])
+          if product_image.attributes['productUrl'].include?('_Front')
+            image_urls << {:color_id => product_image.attributes['colorId'], :url => product_image.attributes['productUrl'], :view => FRONT_PRODUCT_VIEW, :size => product_image.attributes['imageSize']}
+          elsif product_image.attributes['productUrl'].include?('_Back')
+            image_urls << {:color_id => product_image.attributes['colorId'], :url => product_image.attributes['productUrl'], :view => BACK_PRODUCT_VIEW, :size => product_image.attributes['imageSize']}
+          else
+            warn("\nWARNING: the image url #{product_image.attributes['productUrl']} does not appear to be a front or back image, assuming it is a front image.")
+            image_urls << {:color_id => product_image.attributes['colorId'], :url => product_image.attributes['productUrl'], :view => FRONT_PRODUCT_VIEW, :size => product_image.attributes['imageSize']}
+          end
         end
       end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: cafepress_api
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 19
   prerelease: false
   segments: 
   - 0
   - 1
-  - 3
-  version: 0.1.3
+  - 4
+  version: 0.1.4
 platform: ruby
 authors: 
 - Benjamin Lee Smith
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-03-04 00:00:00 -07:00
+date: 2011-03-05 00:00:00 -07:00
 default_executable: 
 dependencies: []