cached_model 1.2.1 → 1.3.1

data/History.txt

@@ -0,0 +1,30 @@
+= 1.3.1
+
+* Match behavior of ActiveRecord::Base#transaction
+
+= 1.3.0
+
+* Added support for transaction
+* Use ZenTest's assertions
+* Switched to Hoe
+
+= 1.2.1
+
+* Lost to time
+
+= 1.2.0
+
+* Support Rails 1.1.2+
+* Moved work into find_by_sql
+
+= 1.1.0
+
+* Lost to time
+
+= 1.0.1
+
+* Lost to time
+
+= 1.0.0
+
+* Birthday!

data/Manifest.txt

@@ -1,6 +1,7 @@
-LICENSE
+History.txt
+LICENSE.txt
 Manifest.txt
-README
+README.txt
 Rakefile
 lib/cached_model.rb
 test/test_cached_model.rb

data/{README → README.txt}

@@ -34,31 +34,13 @@ First, install the cached_model gem:
 
   $ sudo gem install cached_model
 
-Then set up memcache-client:
-
-  $ tail -n 20  config/environments/production.rb
-  memcache_options = {
-    :c_threshold => 10_000,
-    :compression => true,
-    :debug => false,
-    :namespace => 'my_rails_app',
-    :readonly => false,
-    :urlencode => false
-  }
-  
-  CACHE = MemCache.new memcache_options
-  CACHE.servers = 'localhost:11211'
-  
-  session_options = {
-    :database_manager => CGI::Session::MemCacheStore,
-    :cache => CACHE,
-    :session_domain => 'trackmap.robotcoop.com'
-  }
-  
-  ActionController::CgiRequest::DEFAULT_SESSION_OPTIONS.update session_options
+Then set up memcache-client for CachedModel by setting CACHE in your
+config/environment files:
+
+  CACHE = MemCache.new 'localhost:11211', :namespace => 'my_rails_app'
 
-You will need separate namespaces for production and development, if using
-memcache on the same machine.
+You will need separate namespaces for production and development, if
+you are using memcache on the same machine.
 
 Note that using memcache with tests will cause test failures, so set your
 memcache to be readonly for the test environment.

data/Rakefile

@@ -1,65 +1,25 @@
-require 'rubygems'
-require 'rake'
-require 'rake/testtask'
-require 'rake/rdoctask'
-require 'rake/gempackagetask'
-
-$VERBOSE = nil
+# vim: syntax=Ruby
 
-spec = Gem::Specification.new do |s|
-  s.name = 'cached_model'
-  s.version = '1.2.1'
-  s.summary = 'An ActiveRecord::Base model that caches records'
-  s.authors = 'Robert Cottrell, Eric Hodel'
-  s.email = 'bob@robotcoop.com'
+require 'hoe'
 
-  s.has_rdoc = true
-  s.files = File.read('Manifest.txt').split($/)
-  s.require_path = 'lib'
+DEV_DOC_PATH = 'Libraries/cached_model'
 
-  s.add_dependency 'memcache-client', '>= 1.0.3'
-end
+hoe = Hoe.new 'cached_model', '1.3.1' do |p|
+  p.summary = 'An ActiveRecord abstract model that caches records in memcached'
+  p.description = 'CachedModel caches simple (by id) finds in memcached reducing the amount of work the database needs to perform for simple queries.'
+  p.author = ['Eric Hodel', 'Robert Cottrell']
+  p.email = 'eric@robotcoop.com'
+  p.url = "http://dev.robotcoop.com/#{DEV_DOC_PATH}"
+  p.rubyforge_name = 'rctools'
 
-desc 'Run tests'
-task :default => [ :test ]
+  p.changes = File.read('History.txt').scan(/\A(=.*?)^=/m).first.first
 
-Rake::TestTask.new('test') do |t|
-  t.libs << 'test'
-  t.pattern = 'test/test_*.rb'
-  t.verbose = true
+  p.extra_deps << ['memcache-client', '>= 1.1.0']
+  p.extra_deps << ['activerecord', '>= 1.14.4']
+  p.extra_deps << ['ZenTest', '>= 3.4.1']
 end
 
-desc 'Update Manifest.txt'
-task :update_manifest do
-  sh "find . -type f | sed -e 's%./%%' | egrep -v 'svn|swp|~' | egrep -v '^(doc|pkg)/' | sort > Manifest.txt"
-end
+SPEC = hoe.spec
 
-desc 'Generate RDoc'
-Rake::RDocTask.new :rdoc do |rd|
-  rd.rdoc_dir = 'doc'
-  rd.rdoc_files.add 'lib', 'README', 'LICENSE'
-  rd.main = 'README'
-  rd.options << '-d' if `which dot` =~ /\/dot/
-end
-
-desc 'Generate RDoc for dev.robotcoop.com'
-Rake::RDocTask.new :dev_rdoc do |rd|
-  rd.rdoc_dir = '../../../www/trunk/dev/html/Libraries/cached_model'
-  rd.rdoc_files.add 'lib', 'README', 'LICENSE'
-  rd.main = 'README'
-  rd.options << '-d' if `which dot` =~ /\/dot/
-end
-
-desc 'Build Gem'
-Rake::GemPackageTask.new spec do |pkg|
-  pkg.need_tar = true
-end
-
-desc 'Clean up'
-task :clean => [ :clobber_rdoc, :clobber_package ]
-
-desc 'Clean up'
-task :clobber => [ :clean ]
-
-# vim: syntax=Ruby
+require '../tasks'
 

data/lib/cached_model.rb

@@ -20,18 +20,34 @@ require 'memcache_util' unless $TESTING_CM
 
 class CachedModel < ActiveRecord::Base
 
+  @cache_delay_commit = {}
   @cache_local = {}
+  @cache_transaction_level = 0
   @use_local_cache = false
   @use_memcache = true
   @ttl = 60 * 15
 
   class << self
 
+    # :stopdoc:
+
+    ##
+    # The transaction commit buffer.  You shouldn't touch me.
+
+    attr_accessor :cache_delay_commit
+
     ##
     # The local process cache.  You shouldn't touch me.
 
     attr_reader :cache_local
 
+    ##
+    # The transaction nesting level.  You shouldn't touch me.
+
+    attr_accessor :cache_transaction_level
+
+    # :startdoc:
+
     ##
     # Enables or disables use of the local cache.
     #
@@ -52,20 +68,6 @@ class CachedModel < ActiveRecord::Base
 
     attr_accessor :ttl
 
-    ##
-    # Returns true if use of the local cache is enabled.
-
-    def use_local_cache?
-      return @use_local_cache
-    end
-
-    ##
-    # Returns true if use of memcache is enabled.
-
-    def use_memcache?
-      return @use_memcache
-    end
-
   end
 
   ##
@@ -172,6 +174,37 @@ class CachedModel < ActiveRecord::Base
     return records
   end
 
+  ##
+  # Delay updating the cache while in a transaction.
+
+  def self.transaction(*args)
+    level = CachedModel.cache_transaction_level += 1
+    CachedModel.cache_delay_commit[level] = []
+
+    value = super
+
+    waiting = CachedModel.cache_delay_commit.delete level
+    waiting.each do |obj| obj.cache_store end
+    
+    return value
+  ensure
+    CachedModel.cache_transaction_level -= 1
+  end
+
+  ##
+  # Returns true if use of the local cache is enabled.
+
+  def self.use_local_cache?
+    return @use_local_cache
+  end
+
+  ##
+  # Returns true if use of memcache is enabled.
+
+  def self.use_memcache?
+    return @use_memcache
+  end
+
   ##
   # Delete the entry from the cache now that it isn't in the DB.
 
@@ -236,12 +269,17 @@ class CachedModel < ActiveRecord::Base
   def cache_store
     obj = dup
     obj.send :instance_variable_set, :@attributes, attributes_before_type_cast
-    if CachedModel.use_local_cache? then
-      cache_local[cache_key_local] = obj
-    end
-    if CachedModel.use_memcache? then
-      Cache.put cache_key_memcache, obj, CachedModel.ttl
+    if CachedModel.cache_delay_commit[CachedModel.cache_transaction_level].nil? then
+      if CachedModel.use_local_cache? then
+        cache_local[cache_key_local] = obj
+      end
+      if CachedModel.use_memcache? then
+        Cache.put cache_key_memcache, obj, CachedModel.ttl
+      end
+    else
+      CachedModel.cache_delay_commit[CachedModel.cache_transaction_level] << obj
     end
+    nil
   end
 
 end

data/test/test_cached_model.rb

@@ -1,4 +1,6 @@
+require 'rubygems'
 require 'test/unit'
+require 'test/zentest_assertions'
 
 $TESTING = true
 $TESTING_CM = true
@@ -25,6 +27,7 @@ class ActiveRecord::Base
   end
 
   def self.abstract_class?
+    @abstract_class ||= false
     return !!@abstract_class
   end
 
@@ -68,6 +71,10 @@ class ActiveRecord::Base
     name.downcase
   end
 
+  def self.transaction(*a)
+    yield
+  end
+
   def self.primary_key
     'id'
   end
@@ -95,6 +102,14 @@ class ActiveRecord::Base
     @attributes[:extra] = nil
   end
 
+  def save
+    update
+  end
+
+  def transaction(*a, &b)
+    self.class.transaction(*a, &b)
+  end
+
   def update
   end
 
@@ -133,6 +148,7 @@ end
 class << CachedModel
 
   attr_writer :cache_local
+  attr_writer :cache_delay_commit
 
 end
 
@@ -145,6 +161,7 @@ class TestCachedModel < Test::Unit::TestCase
     @model = Concrete.new
     Cache.cache = {}
     Cache.ttl = {}
+    CachedModel.cache_delay_commit = {}
     CachedModel.cache_local = {}
     CachedModel.use_local_cache = DEFAULT_USE_LOCAL_CACHE
     CachedModel.use_memcache = DEFAULT_USE_MEMCACHE
@@ -167,8 +184,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     CachedModel.cache_delete @model.class, @model.id
 
-    assert_equal true, CachedModel.cache_local.empty?
-    assert_equal true, Cache.cache.empty?
+    assert_empty CachedModel.cache_local
+    assert_empty Cache.cache
   end
 
   def test_class_cache_delete_without_local_cache
@@ -178,8 +195,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     CachedModel.cache_delete @model.class, @model.id
 
-    assert_equal false, CachedModel.cache_local.empty?
-    assert_equal true, Cache.cache.empty?
+    deny_empty CachedModel.cache_local
+    assert_empty Cache.cache
   end
 
   def test_class_cache_delete_without_memcache
@@ -189,8 +206,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     CachedModel.cache_delete @model.class, @model.id
 
-    assert_equal true, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
+    assert_empty CachedModel.cache_local
+    deny_empty Cache.cache
   end
 
   def test_class_cache_reset
@@ -200,8 +217,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     CachedModel.cache_reset
     
-    assert_equal true, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
+    assert_empty CachedModel.cache_local
+    deny_empty Cache.cache
   end
 
   def test_class_cache_reset_without_local_cache
@@ -211,8 +228,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     CachedModel.cache_reset
     
-    assert_equal false, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
+    deny_empty CachedModel.cache_local
+    deny_empty Cache.cache
   end
 
   def test_class_cache_reset_without_memcache
@@ -222,8 +239,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     CachedModel.cache_reset
     
-    assert_equal true, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
+    assert_empty CachedModel.cache_local
+    deny_empty Cache.cache
   end
 
   def test_class_find_complex
@@ -234,8 +251,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     assert_equal @model.id + 1, record.id
 
-    assert_equal record, CachedModel.cache_local[record.cache_key_local]
-    assert_equal record, Cache.cache[record.cache_key_memcache]
+    assert_equal record, util_local(record)
+    assert_equal record, util_memcache(record)
   end
 
   def test_class_find_complex_without_local_cache
@@ -246,8 +263,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     assert_equal @model.id + 1, record.id
 
-    assert_equal nil, CachedModel.cache_local[record.cache_key_local]
-    assert_equal record, Cache.cache[record.cache_key_memcache]
+    assert_equal nil, util_local(record)
+    assert_equal record, util_memcache(record)
   end
 
   def test_class_find_complex_without_memcache
@@ -258,8 +275,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     assert_equal @model.id + 1, record.id
 
-    assert_equal record, CachedModel.cache_local[record.cache_key_local]
-    assert_equal nil, Cache.cache[record.cache_key_memcache]
+    assert_equal record, util_local(record)
+    assert_equal nil, util_memcache(record)
   end
 
   def test_class_find_in_local_cache
@@ -269,7 +286,7 @@ class TestCachedModel < Test::Unit::TestCase
     record = Concrete.find(1, :order => 'lock_version')
     assert_equal @model.id + 1, record.id
 
-    assert_equal record, CachedModel.cache_local[record.cache_key_local]
+    assert_equal record, util_local(record)
   end
 
   def test_class_find_in_memcache
@@ -282,7 +299,7 @@ class TestCachedModel < Test::Unit::TestCase
 
     assert_equal @model, record
 
-    assert_equal record, CachedModel.cache_local[record.cache_key_local]
+    assert_equal record, util_local(record)
   end
 
   def test_class_find_multiple
@@ -302,8 +319,8 @@ class TestCachedModel < Test::Unit::TestCase
     record = Concrete.find @model.id + 1
     assert_equal @model.id + 1, record.id
 
-    assert_equal record, CachedModel.cache_local[record.cache_key_local]
-    assert_equal record, Cache.cache[record.cache_key_memcache]
+    assert_equal record, util_local(record)
+    assert_equal record, util_memcache(record)
   end
 
   def test_class_find_by_sql
@@ -312,8 +329,8 @@ class TestCachedModel < Test::Unit::TestCase
     record = Concrete.find_by_sql(q).first
     assert_equal @model.id + 1, record.id
 
-    assert_equal record, CachedModel.cache_local[record.cache_key_local]
-    assert_equal record, Cache.cache[record.cache_key_memcache]
+    assert_equal record, util_local(record)
+    assert_equal record, util_memcache(record)
   end
 
   def test_class_find_by_sql_extra_space
@@ -322,8 +339,8 @@ class TestCachedModel < Test::Unit::TestCase
     record = Concrete.find_by_sql(q).first
     assert_equal @model.id + 1, record.id
 
-    assert_equal record, CachedModel.cache_local[record.cache_key_local]
-    assert_equal record, Cache.cache[record.cache_key_memcache]
+    assert_equal record, util_local(record)
+    assert_equal record, util_memcache(record)
   end
 
   def test_class_find_by_sql_no_record
@@ -360,8 +377,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     @model.cache_delete
 
-    assert_equal true, CachedModel.cache_local.empty?
-    assert_equal true, Cache.cache.empty?
+    assert_empty CachedModel.cache_local
+    assert_empty Cache.cache
   end
 
   def test_cache_key_local
@@ -383,25 +400,37 @@ class TestCachedModel < Test::Unit::TestCase
 
     @model.cache_store
 
-    assert_equal false, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
+    deny_empty CachedModel.cache_local
+    deny_empty Cache.cache
 
-    assert_equal @model, CachedModel.cache_local[@model.cache_key_local]
-    assert_equal @model, Cache.cache[@model.cache_key_memcache]
+    assert_equal @model, util_local(@model)
+    assert_equal @model, util_memcache(@model)
     assert_equal CachedModel.ttl, Cache.ttl[@model.cache_key_memcache]
   end
 
+  def test_cache_store_in_transaction
+    CachedModel.use_local_cache = true
+    CachedModel.use_memcache = true
+    CachedModel.cache_delay_commit[0] = []
+
+    @model.cache_store
+
+    deny_empty CachedModel.cache_delay_commit
+    assert_empty CachedModel.cache_local
+    assert_empty Cache.cache
+  end
+
   def test_cache_store_without_local_cache
     CachedModel.use_local_cache = false
     CachedModel.use_memcache = true
 
     @model.cache_store
 
-    assert_equal true, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
+    assert_empty CachedModel.cache_local
+    deny_empty Cache.cache
 
-    assert_equal nil, CachedModel.cache_local[@model.cache_key_local]
-    assert_equal @model, Cache.cache[@model.cache_key_memcache]
+    assert_equal nil, util_local(@model)
+    assert_equal @model, util_memcache(@model)
     assert_equal CachedModel.ttl, Cache.ttl[@model.cache_key_memcache]
   end
 
@@ -411,22 +440,23 @@ class TestCachedModel < Test::Unit::TestCase
 
     @model.cache_store
 
-    assert_equal false, CachedModel.cache_local.empty?
-    assert_equal true, Cache.cache.empty?
+    deny_empty CachedModel.cache_local
+    assert_empty Cache.cache
 
-    assert_equal @model, CachedModel.cache_local[@model.cache_key_local]
-    assert_equal nil, Cache.cache[@model.cache_key_memcache]
+    assert_equal @model, util_local(@model)
+    assert_equal nil, util_memcache(@model)
   end
 
   def test_cache_store_with_attributes
     CachedModel.use_local_cache = true
     @model.attributes[:extra] = 'extra'
     @model.cache_store
-    assert_equal false, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
 
-    local_model = CachedModel.cache_local[@model.cache_key_local]
-    mem_model = Cache.cache[@model.cache_key_memcache]
+    deny_empty CachedModel.cache_local
+    deny_empty Cache.cache
+
+    local_model = util_local(@model)
+    mem_model = util_memcache(@model)
     assert_equal @model, local_model
     assert_equal @model, mem_model
     assert_equal CachedModel.ttl, Cache.ttl[@model.cache_key_memcache]
@@ -443,8 +473,8 @@ class TestCachedModel < Test::Unit::TestCase
 
     @model.destroy
 
-    assert_equal true, CachedModel.cache_local.empty?
-    assert_equal true, Cache.cache.empty?
+    assert_empty CachedModel.cache_local
+    assert_empty Cache.cache
   end
 
   def test_reload
@@ -452,28 +482,105 @@ class TestCachedModel < Test::Unit::TestCase
 
     @model.reload
 
-    assert_equal false, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
+    deny_empty CachedModel.cache_local
+    deny_empty Cache.cache
 
     assert_equal 'datb',
-                 CachedModel.cache_local[@model.cache_key_local].attributes[:data]
+                 util_local(@model).attributes[:data]
     assert_equal 'datb',
-                 Cache.cache[@model.cache_key_memcache].attributes[:data]
+                 util_memcache(@model).attributes[:data]
+  end
+
+  def test_transaction_fail
+    CachedModel.use_local_cache = true
+
+    e = assert_raise RuntimeError do
+      @model.transaction do
+        @model.attributes[:data] = 'atad'
+        @model.save
+        raise 'Oh nos!'
+      end
+    end
+
+    assert_equal 'Oh nos!', e.message
+    assert_equal nil, util_local(@model)
+    assert_equal nil, util_memcache(@model)
+  end
+
+  def test_transaction_nested
+    CachedModel.use_local_cache = true
+
+    @model.transaction do
+      @model.transaction do
+        @model.attributes[:data] = 'value1'
+        @model.save
+
+        assert_equal nil, util_local(@model), 'in t1 local'
+        assert_equal nil, util_memcache(@model), 'in t1 memcache'
+      end
+
+      assert_equal 'value1', util_local(@model).attributes[:data],
+                   'completed t1 local'
+      assert_equal 'value1', util_memcache(@model).attributes[:data],
+                   'completed t1 memcache'
+
+      @model.attributes[:data] = 'value2'
+      @model.save
+
+      assert_equal 'value1', util_local(@model).attributes[:data],
+                   'in t2 local'
+      assert_equal 'value1', util_memcache(@model).attributes[:data],
+                   'in t2 memcache'
+    end
+
+    assert_equal 'value2', util_local(@model).attributes[:data],
+                 'completed t2 local'
+    assert_equal 'value2', util_memcache(@model).attributes[:data],
+                 'completed t2 local'
+  end
+
+  def test_transaction_pass
+    CachedModel.use_local_cache = true
+
+    result = @model.transaction do
+      @model.attributes[:data] = 'atad'
+      @model.save
+
+      assert_equal nil, util_local(@model)
+      assert_equal nil, util_memcache(@model)
+
+      :some_value
+    end
+
+    assert_equal :some_value, result
+
+    assert_equal 'atad', util_local(@model).attributes[:data]
+    assert_equal 'atad',
+                 util_memcache(@model).attributes[:data]
+
   end
 
   def test_update
     util_set
 
     @model.attributes[:data] = 'atad'
-    @model.update
+    assert_equal true, @model.update, "Updates should return true"
 
-    assert_equal false, CachedModel.cache_local.empty?
-    assert_equal false, Cache.cache.empty?
+    deny_empty CachedModel.cache_local
+    deny_empty Cache.cache
 
     assert_equal 'atad',
-                 CachedModel.cache_local[@model.cache_key_local].attributes[:data]
+                 util_local(@model).attributes[:data]
     assert_equal 'atad',
-                 Cache.cache[@model.cache_key_memcache].attributes[:data]
+                 util_memcache(@model).attributes[:data]
+  end
+
+  def util_local(model)
+    CachedModel.cache_local[model.cache_key_local]
+  end
+
+  def util_memcache(model)
+    Cache.cache[model.cache_key_memcache]
   end
 
   def util_set(klass = @model.class, id = @model.id, data = @model)

metadata

@@ -3,15 +3,16 @@ rubygems_version: 0.8.99
 specification_version: 1
 name: cached_model
 version: !ruby/object:Gem::Version 
-  version: 1.2.1
-date: 2006-08-18 00:00:00 -07:00
-summary: An ActiveRecord::Base model that caches records
+  version: 1.3.1
+date: 2006-10-23 00:00:00 -07:00
+summary: An ActiveRecord abstract model that caches records in memcached
 require_paths: 
 - lib
-email: bob@robotcoop.com
-homepage: 
-rubyforge_project: 
-description: 
+- test
+email: eric@robotcoop.com
+homepage: http://dev.robotcoop.com/Libraries/cached_model
+rubyforge_project: rctools
+description: CachedModel caches simple (by id) finds in memcached reducing the amount of work the database needs to perform for simple queries.
 autorequire: 
 default_executable: 
 bindir: bin
@@ -27,11 +28,13 @@ signing_key:
 cert_chain: 
 post_install_message: 
 authors: 
-- Robert Cottrell, Eric Hodel
+- Eric Hodel
+- Robert Cottrell
 files: 
-- LICENSE
+- History.txt
+- LICENSE.txt
 - Manifest.txt
-- README
+- README.txt
 - Rakefile
 - lib/cached_model.rb
 - test/test_cached_model.rb
@@ -48,6 +51,15 @@ extensions: []
 requirements: []
 
 dependencies: 
+- !ruby/object:Gem::Dependency 
+  name: hoe
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Version::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.1.2
+    version: 
 - !ruby/object:Gem::Dependency 
   name: memcache-client
   version_requirement: 
@@ -55,5 +67,23 @@ dependencies:
     requirements: 
     - - ">="
       - !ruby/object:Gem::Version 
-        version: 1.0.3
+        version: 1.1.0
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: activerecord
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Version::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 1.14.4
+    version: 
+- !ruby/object:Gem::Dependency 
+  name: ZenTest
+  version_requirement: 
+  version_requirements: !ruby/object:Gem::Version::Requirement 
+    requirements: 
+    - - ">="
+      - !ruby/object:Gem::Version 
+        version: 3.4.1
     version: