cacheable_flash 0.3.2 → 0.3.3

checksums.yaml

@@ -0,0 +1,7 @@
+---
+SHA1:
+  metadata.gz: 8bdb098987853b71c911ad84e070ca44e3c3dee1
+  data.tar.gz: 167e3d10c1679c57f12d1a7f8127509301092e65
+SHA512:
+  metadata.gz: 3bdf569f5354470eba7634a09c55dfe35d8f43362a1d2ef9949d290b6855bf781023df8555560ee8131851115d4a9150a572df528c56d245439f883b5f338493
+  data.tar.gz: b5a1f3892cefd5b90b3c450b27090e34b9d38fc33486ddd18fcc5cc48968aa2bdaf8c3f5dd050f86e672b46a3546c2826e2875c30dd583549af793c1e59890bf

data/.document

@@ -1,5 +1,5 @@
-lib/**/*.rb
-bin/*
--
-features/**/*.feature
-LICENSE.txt
+lib/**/*.rb
+bin/*
+-
+features/**/*.feature
+LICENSE.txt

data/CHANGELOG

@@ -1,3 +1,8 @@
+0.3.3 - SEP.13.2013
+* Maintenance release with lots of minor changes and fixes.
+* Main gem should be API compatible.
+* Small changes to test helpers which will require updating tests using them.
+
 0.3.2 - AUG.23.2012
 * Properly handles stacked flash in cookie flash according to config :append_as option [Peter Boling]
 

data/LICENSE

@@ -1,23 +1,23 @@
-Copyright (c) 2007-2010 Pivotal Labs
-Copyright (c) 2011-2012 Peter H. Boling (http://peterboling.com)
-
-MIT License
-
-Permission is hereby granted, free of charge, to any person obtaining
-a copy of this software and associated documentation files (the
-"Software"), to deal in the Software without restriction, including
-without limitation the rights to use, copy, modify, merge, publish,
-distribute, sublicense, and/or sell copies of the Software, and to
-permit persons to whom the Software is furnished to do so, subject to
-the following conditions:
-
-The above copyright notice and this permission notice shall be
-included in all copies or substantial portions of the Software.
-
-THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
-EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
-MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
-NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
-LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
-OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
-WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
+Copyright (c) 2007-2010 Pivotal Labs
+Copyright (c) 2011-2012 Peter H. Boling (http://peterboling.com)
+
+MIT License
+
+Permission is hereby granted, free of charge, to any person obtaining
+a copy of this software and associated documentation files (the
+"Software"), to deal in the Software without restriction, including
+without limitation the rights to use, copy, modify, merge, publish,
+distribute, sublicense, and/or sell copies of the Software, and to
+permit persons to whom the Software is furnished to do so, subject to
+the following conditions:
+
+The above copyright notice and this permission notice shall be
+included in all copies or substantial portions of the Software.
+
+THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND,
+EXPRESS OR IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF
+MERCHANTABILITY, FITNESS FOR A PARTICULAR PURPOSE AND
+NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR COPYRIGHT HOLDERS BE
+LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN AN ACTION
+OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
+WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.

data/README.rdoc

@@ -1,4 +1,4 @@
-= CacheableFlash {<img src="https://codeclimate.com/badge.png" />}[https://codeclimate.com/github/pivotal/cacheable-flash] {<img src="https://secure.travis-ci.org/pboling/cacheable-flash.png?branch=master" alt="Build Status" />}[http://travis-ci.org/pboling/cacheable-flash]
+= CacheableFlash {<img src="https://codeclimate.com/badge.png" />}[https://codeclimate.com/github/pivotal/cacheable-flash] {<img src="https://secure.travis-ci.org/pboling/cacheable-flash.png?branch=master" alt="Build Status" />}[http://travis-ci.org/pboling/cacheable-flash] {<img src="http://api.coderwall.com/pboling/endorsecount.png" />}[http://coderwall.com/pboling]
 
 == Description
 
@@ -119,7 +119,7 @@ Cacheable Flash provides test helpers which includes the flash_cookie method.
 
     def test_cacheable_flash_action
       get :index
-      asset_equal "In index", flash_cookie["notice"]
+      assert_equal "In index", flash_cookie["notice"]
     end
   end
 
@@ -150,9 +150,25 @@ Cacheable Flash provides test helpers which includes the flash_cookie method.
 5. Make sure to add tests for it. This is important so I don't break it in a future version unintentionally.
 6. Create new Pull Request
 
+== Versioning
+
+This library aims to adhere to {Semantic Versioning 2.0.0}[http://semver.org/].
+Violations of this scheme should be reported as bugs. Specifically, 
+if a minor or patch version is released that breaks backward 
+compatibility, a new version should be immediately released that
+restores compatibility. Breaking changes to the public API will 
+only be introduced with new major versions.
+
+As a result of this policy, you can (and should) specify a 
+dependency on this gem using the {Pessimistic Version Constraint}[http://docs.rubygems.org/read/chapter/16#page74] with two digits of precision. 
+
+For example:
+
+    spec.add_dependency 'cacheable_flash', '~> 4.0'
+
 == Copyright
 
-Licensed under the MIT License.
+Licensed under the MIT License. See LICENSE for further details.
 
-- Copyright (c) 2011-2012 Peter H. Boling (http://peterboling.com). See LICENSE for further details.
-- Copyright (c) 2007-2010 Pivotal Labs
+- Copyright (c) 2011-2012 {Peter H. Boling}[http://railsbling.com] {<img src="http://api.coderwall.com/pboling/endorsecount.png" />}[http://coderwall.com/pboling]
+- Copyright (c) 2007-2010 {Pivotal Labs}[https://coderwall.com/team/pivotal-labs]

data/init.rb

@@ -1,6 +1,6 @@
-require "json"
-require "cacheable_flash"
-#use Rails::VERSION::STRING for rails < 1 somehow -- or perhaps, who cares??
-if ::Rails::VERSION::MAJOR == 2
-  ActionView::Helpers::AssetTagHelper.register_javascript_include_default('jquery.cookie','flash')
-end
+require "json"
+require "cacheable_flash"
+#use Rails::VERSION::STRING for rails < 1 somehow -- or perhaps, who cares??
+if ::Rails::VERSION::MAJOR == 2
+  ActionView::Helpers::AssetTagHelper.register_javascript_include_default('jquery.cookie','flash')
+end

data/install.rb

@@ -1,18 +1,18 @@
-# Only executed when installed as plugin.
-# When installed as a gem must use the generator, unless using Rails >= 3.1 and asset pipeline,
-#   in which case the asset pipeline takes care of everything
-require 'fileutils'
-include FileUtils
-
-dir = "#{File.dirname(__FILE__)}/vendor/assets/javascripts"
-rails_javascripts_dir = "#{Rails.root}/public/javascripts"
-
-puts "copying flash.js to #{rails_javascripts_dir}"
-cp "#{dir}/flash.js", rails_javascripts_dir
-
-if File.exists?("#{rails_javascripts_dir}/jquery.cookie.js")
-  puts "#{rails_javascripts_dir}/jquery.cookie.js already exists"
-else
-  puts "copying jquery.cookie.js to #{rails_javascripts_dir}"
-  cp "#{dir}/jquery.cookie.js", rails_javascripts_dir
-end
+# Only executed when installed as plugin.
+# When installed as a gem must use the generator, unless using Rails >= 3.1 and asset pipeline,
+#   in which case the asset pipeline takes care of everything
+require 'fileutils'
+include FileUtils
+
+dir = "#{File.dirname(__FILE__)}/vendor/assets/javascripts"
+rails_javascripts_dir = "#{Rails.root}/public/javascripts"
+
+puts "copying flash.js to #{rails_javascripts_dir}"
+cp "#{dir}/flash.js", rails_javascripts_dir
+
+if File.exists?("#{rails_javascripts_dir}/jquery.cookie.js")
+  puts "#{rails_javascripts_dir}/jquery.cookie.js already exists"
+else
+  puts "copying jquery.cookie.js to #{rails_javascripts_dir}"
+  cp "#{dir}/jquery.cookie.js", rails_javascripts_dir
+end

data/lib/cacheable_flash.rb

@@ -2,9 +2,9 @@ require 'json'
 require 'stackable_flash'
 
 module CacheableFlash
-  if defined?(Rails) && ::Rails::VERSION::MAJOR == 3
+  if defined?(Rails) && (::Rails::VERSION::MAJOR >= 3)
     require 'cacheable_flash/middleware'
-    require 'cacheable_flash/engine' if ::Rails::VERSION::MINOR >= 1
+    require 'cacheable_flash/engine' if (::Rails::VERSION::MAJOR == 3 && ::Rails::VERSION::MINOR >= 1) || ::Rails::VERSION::MAJOR > 3
     require 'cacheable_flash/railtie'
   else
     # For older rails use generator
@@ -17,7 +17,7 @@ module CacheableFlash
   # end
   StackableFlash.stacking = false
 
-  # The configure will override the above default
+  # The configure will override the above defaults
   require 'cacheable_flash/config'
   require 'cacheable_flash/cookie_flash'
   include CacheableFlash::CookieFlash
@@ -30,10 +30,12 @@ module CacheableFlash
   def write_flash_to_cookie
     yield if block_given?
 
+
     # Base must define cookies, as in Rails
-    cookies['flash'] = cookie_flash(flash, cookies)
+    domain = CacheableFlash::Config.config[:domain]
+    cookies['flash'] = { :value => cookie_flash(flash, cookies), :domain => domain }
     # Base must define flash, as in Rails
-    # TODO: Does not support flash.now feature of the FlashHash in Rails, 
+    # TODO: Does not support flash.now feature of the FlashHash in Rails,
     #       because flashes are only removed from cookies when they are used.
     flash.clear
   end

data/lib/cacheable_flash/config.rb

@@ -13,7 +13,9 @@ module CacheableFlash
       :stacking => false, # or true if you want auto-magically stacking flashes
       # Specify how multiple flashes at the same key (e.g. :notice, :errors) should be handled
       # :append_as is ignored if :stacking is false
-      :append_as => :br # or :array, :p, :ul, :ol, or a proc or lambda of your own design
+      :append_as => :br, # or :array, :p, :ul, :ol, or a proc or lambda of your own design
+      # if domain is unspecified, defaults to nil and the request domain is used (see middleware.rb)
+      :domain => nil
     }
 
     @config ||= DEFAULTS

data/lib/cacheable_flash/engine.rb

@@ -1,7 +1,10 @@
-module CacheableFlash
-  class Engine < ::Rails::Engine
-    if ::Rails::VERSION::MAJOR == 3 && ::Rails::VERSION::MAJOR >= 1
-      isolate_namespace CacheableFlash
-    end
-  end
-end
+module CacheableFlash
+  class Engine < ::Rails::Engine
+    # Allow for Rails versions ~> 3.1 and > 3
+    if (::Rails::VERSION::MAJOR == 3 && ::Rails::VERSION::MINOR >= 1) || ::Rails::VERSION::MAJOR > 3
+      isolate_namespace CacheableFlash
+    else
+      warn 'CacheableFlash namespace not isolated, check that Rails version is >= 3.1'
+    end
+  end
+end

data/lib/cacheable_flash/middleware.rb

@@ -1,5 +1,6 @@
 module CacheableFlash
   class Middleware
+    require 'cacheable_flash/config'
     require 'cacheable_flash/cookie_flash'
     include CacheableFlash::CookieFlash
     FLASH_HASH_KEY = "action_dispatch.request.flash_hash".freeze
@@ -8,34 +9,17 @@ module CacheableFlash
       @app = app
     end
 
-    # Cookies stick in the flash until rendered (cleared out of the cookie by javascript),
-    #   to ensure they are seen and not lost, so we grab them from the rails flash hash, or the request cookies
     def call(env)
       status, headers, body = @app.call(env)
       env_flash = env[FLASH_HASH_KEY]
 
       if env_flash
-        # There is a flash set from this request, merge it into the cookie flash (which may already be populated)
-        response = Rack::Response.new(body, status, headers)
-        cookies = env["rack.cookies"] || {}
-        response.set_cookie("flash", { :value => cookie_flash(env_flash, cookies), :path => "/" })
-        response.finish
-      else
-        # There is no flash set in this request but there are leftovers from previous requests still in the cookie
-        request = ActionDispatch::Request.new(env)
-        cflash = request.respond_to?(:cookie_jar) ?
-          request.cookie_jar['flash'] :
-          nil
-        if cflash
-          response = Rack::Response.new(body, status, headers)
-          response.set_cookie("flash", { :value => cflash, :path => "/" })
-          response.finish
-        else
-          response = body
-        end
+        domain = CacheableFlash::Config.config[:domain]
+        cookies = Rack::Request.new(env).cookies
+        Rack::Utils.set_cookie_header!(headers, "flash", :value => cookie_flash(env_flash, cookies), :path => "/", :domain => "#{domain}")
       end
-      [status, headers, response]
-    end
 
+      [status, headers, body]
+    end
   end
 end

data/lib/cacheable_flash/railtie.rb

@@ -1,10 +1,10 @@
-# Add cacheable flash JS to defaults for Rails < 3.1 (not needed with asset pipeline)
-module CacheableFlash
-  class Railtie < ::Rails::Railtie
-    if ::Rails::VERSION::MAJOR == 3
-      config.before_configuration do
-        config.action_view.javascript_expansions[:cacheable_flash] = %w(jquery.cookie flash)
-      end
-    end
-  end
-end
+module CacheableFlash
+  class Railtie < ::Rails::Railtie
+    # Add cacheable flash JS to defaults for Rails < 3.1 (not needed with asset pipeline)
+    if ::Rails::VERSION::MAJOR == 3 && ::Rails::VERSION::MINOR == 0
+      config.before_configuration do
+        config.action_view.javascript_expansions[:cacheable_flash] = %w(jquery.cookie flash)
+      end
+    end
+  end
+end

data/lib/cacheable_flash/rspec_matchers.rb

@@ -8,27 +8,27 @@ module CacheableFlash
     include CacheableFlash::TestHelpers
     RSpec::Matchers.define :have_flash_cookie do |flash_status, expecting|
       define_method :has_flash_cookie? do |response|
-        flash_in_stack(testable_flash(response)[flash_status], expecting)
+        flash_in_stack(flash_cookie_for(response)[flash_status], expecting)
       end
       match{|response| has_flash_cookie?(response)}
       failure_message_for_should do |actual|
-        "expected flash[:#{expected[0]}] to be or include #{expected[1].inspect}, but got #{testable_flash(actual)[expected[0]]}"
+        "expected flash[:#{expected[0]}] to be or include #{expected[1].inspect}, but got #{flash_cookie_for(actual)[expected[0]]}"
       end
       failure_message_for_should_not do |actual|
-        "expected flash[:#{expected[0]}] to not be and not include #{expected[1].inspect}, but got #{testable_flash(actual)[expected[0]]}"
+        "expected flash[:#{expected[0]}] to not be and not include #{expected[1].inspect}, but got #{flash_cookie_for(actual)[expected[0]]}"
       end
     end
 
     RSpec::Matchers.define :have_cacheable_flash do |flash_status, expecting|
       define_method :has_cacheable_flash? do |response|
-        flash_in_stack(testable_flash(response)[flash_status], expecting)
+        flash_in_stack(flash_cookie_for(response)[flash_status], expecting)
       end
       match{|response| has_cacheable_flash?(response)}
       failure_message_for_should do |actual|
-        "expected flash[:#{expected[0]}] to be or include #{expected[1].inspect}, but got #{testable_flash(actual)[expected[0]]}"
+        "expected flash[:#{expected[0]}] to be or include #{expected[1].inspect}, but got #{flash_cookie_for(actual)[expected[0]]}"
       end
       failure_message_for_should_not do |actual|
-        "expected flash[:#{expected[0]}] to not be and not include #{expected[1].inspect}, but got #{testable_flash(actual)[expected[0]]}"
+        "expected flash[:#{expected[0]}] to not be and not include #{expected[1].inspect}, but got #{flash_cookie_for(actual)[expected[0]]}"
       end
     end
 

data/lib/cacheable_flash/test_helpers.rb

@@ -10,7 +10,7 @@ module CacheableFlash
       {}
     end
 
-    def testable_flash(response)
+    def flash_cookie_for(response)
       return {} unless cooked_flash = response.cookies['flash']
       JSON(cooked_flash)
     rescue JSON::ParserError

data/lib/cacheable_flash/version.rb

@@ -1,3 +1,3 @@
-module CacheableFlash
-  VERSION = "0.3.2"
-end
+module CacheableFlash
+  VERSION = "0.3.3"
+end

data/lib/generators/cacheable_flash/install/install_generator.rb

@@ -1,23 +1,24 @@
-# encoding: utf-8
-
-module CacheableFlash
-  # Copies javascript libraries flash.js and jquery.cookie.js to public/javascripts/ (Rails 3.0.X only, Rails 3.1 has asset pipeline)
-  #
-  # @example
-  #   $ rails generate cacheable_flash:install
-  #
-  class InstallGenerator < Rails::Generators::Base
-    source_root File.expand_path('../../../../../vendor/assets/javascripts/', __FILE__)
-
-    # Rails 3.1 has the asset pipeline, no need to copy javascript files anymore
-    # Rails 3.0 doesn't have an asset pipeline, so we copy in javascript files
-    desc "Copies some JS files to public/javascripts/"
-    def copy_files
-      if ::Rails::VERSION::MAJOR == 3 && ::Rails::VERSION::MINOR == 1
-        ActiveSupport::Deprecation.warn("Rails 3.1 has the asset pipeline, so you only need to copy javascript files if you aren't using it.")
-      end
-      template 'flash.js',     'public/javascripts/flash.js'
-      template 'jquery.cookie.js', 'public/javascripts/jquery.cookie.js'
-    end
-  end
-end
+# encoding: utf-8
+
+module CacheableFlash
+  # Copies javascript libraries flash.js and jquery.cookie.js to public/javascripts/ (Rails 3.0.X only, Rails 3.1 has asset pipeline)
+  #
+  # @example
+  #   $ rails generate cacheable_flash:install
+  #
+  class InstallGenerator < Rails::Generators::Base
+    source_root File.expand_path('../../../../../vendor/assets/javascripts/', __FILE__)
+
+    # Rails 3.1 has the asset pipeline, no need to copy javascript files anymore
+    # Rails 3.0 doesn't have an asset pipeline, so we copy in javascript files
+    desc "Copies some JS files to public/javascripts/"
+    def copy_files
+      # Also raise this deprecation in rails 4
+      if (::Rails::VERSION::MAJOR == 3 && ::Rails::VERSION::MINOR >= 1) || ::Rails::VERSION::MAJOR > 3
+        ActiveSupport::Deprecation.warn("Rails 3.1 has the asset pipeline, so you only need to copy javascript files if you aren't using it.")
+      end
+      template 'flash.js',     'public/javascripts/flash.js'
+      template 'jquery.cookie.js', 'public/javascripts/jquery.cookie.js'
+    end
+  end
+end

data/lib/tasks/cacheable-flash_tasks.rake

@@ -1,4 +1,4 @@
-# desc "Explaining what the task does"
-# task :cacheable_flash do
-#   # Task goes here
-# end
+# desc "Explaining what the task does"
+# task :cacheable_flash do
+#   # Task goes here
+# end

data/spec/cacheable_flash/cacheable_flash_spec.rb

@@ -11,6 +11,11 @@ describe 'CacheableFlash' do
     @controller.stub(:cookies).and_return(@cookies)
   end
 
+  def controller_cookie_flash
+    @controller.cookies['flash'][:value]
+  end
+
+
   describe "#write_flash_to_cookie" do
     context "when there is not an existing flash cookie" do
       it "sets the flash cookie with a JSON representation of the Hash" do
@@ -18,10 +23,10 @@ describe 'CacheableFlash' do
           'errors' => "This is an Error",
           'notice' => "This is a Notice"
         }
-        controller.flash = expected_flash.dup
-        controller.write_flash_to_cookie
+        @controller.flash = expected_flash.dup
+        @controller.write_flash_to_cookie
 
-        JSON(@controller.cookies['flash']).should == expected_flash
+        JSON(controller_cookie_flash).should == expected_flash
       end
     end
 
@@ -44,7 +49,7 @@ describe 'CacheableFlash' do
             'notice' => "New notice",
             'errors' => "New errors",
           }
-          JSON(@controller.cookies['flash']).should == expected_flash
+          JSON(controller_cookie_flash).should == expected_flash
         end
       end
 
@@ -57,7 +62,7 @@ describe 'CacheableFlash' do
 
           @controller.write_flash_to_cookie
 
-          JSON(@cookies['flash']).should == {}
+          JSON(@cookies['flash'][:value]).should == {}
         end
       end
     end
@@ -65,31 +70,31 @@ describe 'CacheableFlash' do
     it "converts flash value to string before storing in cookie if value is a number" do
       @controller.flash = { 'quantity' => 5 }
       @controller.write_flash_to_cookie
-      JSON(@controller.cookies['flash']).should == { 'quantity' => 5 }
+      JSON(controller_cookie_flash).should == { 'quantity' => 5 }
     end
     
     it "does not convert flash value to string before storing in cookie if value is anything other than a number" do
       @controller.flash = { 'foo' => { 'bar' => 'baz' } }
       @controller.write_flash_to_cookie
-      JSON(@controller.cookies['flash']).should == { 'foo' => { 'bar' => 'baz' } }
+      JSON(controller_cookie_flash).should == { 'foo' => { 'bar' => 'baz' } }
     end
     
     it "encodes plus signs in generated JSON before storing in cookie" do
       @controller.flash = { 'notice' => 'Life, Love + Liberty' }
       @controller.write_flash_to_cookie
-      @controller.cookies['flash'].should == "{\"notice\":\"Life, Love %2B Liberty\"}"
+      controller_cookie_flash.should == "{\"notice\":\"Life, Love %2B Liberty\"}"
     end
 
     it "escapes strings when not html safe" do
       @controller.flash = { 'notice' => '<em>Life, Love + Liberty</em>' } # Not html_safe, so it will be escaped
       @controller.write_flash_to_cookie
-      @controller.cookies['flash'].should == "{\"notice\":\"&lt;em&gt;Life, Love %2B Liberty&lt;/em&gt;\"}"
+      controller_cookie_flash.should == "{\"notice\":\"&lt;em&gt;Life, Love %2B Liberty&lt;/em&gt;\"}"
     end
 
     it "does not escape strings that are html_safe" do
       @controller.flash = { 'notice' => '<em>Life, Love + Liberty</em>'.html_safe } # html_safe so it will not be escaped
       @controller.write_flash_to_cookie
-      @controller.cookies['flash'].should == "{\"notice\":\"<em>Life, Love %2B Liberty</em>\"}"
+      controller_cookie_flash.should == "{\"notice\":\"<em>Life, Love %2B Liberty</em>\"}"
     end
 
     it "clears the controller.flash hash provided by Rails" do
@@ -106,13 +111,13 @@ describe 'CacheableFlash' do
     it "escapes HTML if the flash value is not html safe" do
       @controller.flash = { 'quantity' => "<div>foobar</div>" }
       @controller.write_flash_to_cookie
-      JSON(@controller.cookies['flash']).should == { 'quantity' => "&lt;div&gt;foobar&lt;/div&gt;" }
+      JSON(controller_cookie_flash).should == { 'quantity' => "&lt;div&gt;foobar&lt;/div&gt;" }
     end
     
     it "does not escape flash HTML if the value is html safe" do
       @controller.flash = { 'quantity' => '<div>foobar</div>'.html_safe }
       @controller.write_flash_to_cookie
-      JSON(@controller.cookies['flash']).should == { 'quantity' => "<div>foobar</div>" }
+      JSON(controller_cookie_flash).should == { 'quantity' => "<div>foobar</div>" }
     end
   end