bygpay 0.2.3 → 0.2.4

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0137d4292d71750130b0e716a9f50d1796299c04
-  data.tar.gz: 4b8c91f49179e0cce897b7b1744a8fba2f9683c5
+  metadata.gz: 476dae06f05d44825808c2615b0d5246e14d1cef
+  data.tar.gz: 23a341f51de1fd9fb0cd5afe258e46809289d2fe
 SHA512:
-  metadata.gz: 28dd5642ebc9a4622971829bf28c041ad465347102030a63a94547c6512d8b23248105f7320cbf78784b233d0045c12042255b8de24cab4a7708002fe47ddf16
-  data.tar.gz: f1203b1abcdbd7b0fd104745630ace197212bbf8d3dadf6388bd30a7ecc2f1b3a8d45d9cc4befc438354e8f137895453f8400315e226f7072ee8c3809c84b200
+  metadata.gz: cf8222521ad9896c74e0af9e904d7f73f3751fec4a96907539e94f0d2b6778b7757135de49fcc57840368d04dd08d60505f70fde5e4298c4bd7cbfbb456e2a69
+  data.tar.gz: 8c1d417f28e03680b94c93c11c49f247eb837f41d5c3f320eb92dc656ded3595a5c68aa1775857303c167453157e31eaf1575acc3d9b86431b0a0f23f95ebccc

data/.travis.yml

@@ -1,3 +1,8 @@
+addons:
+  code_climate:
+    repo_token: ea1ac3f76e7689a49786a2b7d8fa8ace6ef3f87f7c00825fed66ca6cc22dc4be
+after_success:
+  - bundle exec codeclimate-test-reporter
 sudo: false
 language: ruby
 rvm:
@@ -6,4 +11,4 @@ rvm:
   - 2.2.0
   - 2.1.0
   - 2.0.0
-before_install: gem install bundler -v 1.14.6
+before_install: gem install bundler -v 1.14.6

data/CHANGELOG.md

@@ -17,4 +17,8 @@
 
 ####v0.2.3
 * Currency Support Added to Deposits
-* Added Tests Coverage
+* Added Tests Coverage
+
+####v0.2.4
+* Added Vodafone Payment Examples
+* Token Param documented for weird Vodafone payments

data/README.md

@@ -1,4 +1,4 @@
-[![Gem Version](https://badge.fury.io/rb/bygpay.svg)](https://badge.fury.io/rb/bygpay) [![Code Climate](https://codeclimate.com/github/nukturnal/bygpay/badges/gpa.svg)](https://codeclimate.com/github/nukturnal/bygpay) [![codebeat badge](https://codebeat.co/badges/8db86406-18f8-4c2d-bacf-58ac1c700c0a)](https://codebeat.co/projects/github-com-nukturnal-bygpay-master) [![Codacy Badge](https://api.codacy.com/project/badge/Grade/7425ac54e6484723a5482a92fc7f35ef)](https://www.codacy.com/app/nukturnal/bygpay?utm_source=github.com&utm_medium=referral&utm_content=nukturnal/bygpay&utm_campaign=Badge_Grade) [![Build Status](https://travis-ci.org/nukturnal/bygpay_ruby.svg?branch=master)](https://travis-ci.org/nukturnal/bygpay_ruby)
+[![Gem Version](https://badge.fury.io/rb/bygpay.svg)](https://badge.fury.io/rb/bygpay) [![Code Climate](https://codeclimate.com/github/nukturnal/bygpay/badges/gpa.svg)](https://codeclimate.com/github/nukturnal/bygpay) [![Test Coverage](https://codeclimate.com/github/nukturnal/bygpay/badges/coverage.svg)](https://codeclimate.com/github/nukturnal/bygpay/coverage) [![Issue Count](https://codeclimate.com/github/nukturnal/bygpay/badges/issue_count.svg)](https://codeclimate.com/github/nukturnal/bygpay) [![codebeat badge](https://codebeat.co/badges/8db86406-18f8-4c2d-bacf-58ac1c700c0a)](https://codebeat.co/projects/github-com-nukturnal-bygpay-master) [![Codacy Badge](https://api.codacy.com/project/badge/Grade/7425ac54e6484723a5482a92fc7f35ef)](https://www.codacy.com/app/nukturnal/bygpay?utm_source=github.com&utm_medium=referral&utm_content=nukturnal/bygpay&utm_campaign=Badge_Grade) [![Build Status](https://travis-ci.org/nukturnal/bygpay_ruby.svg?branch=master)](https://travis-ci.org/nukturnal/bygpay_ruby)
 
 # Bygpay Ruby SDK
 
@@ -32,6 +32,7 @@ Bygpay.configure do |config|
   # Optional Configurations (Every code below this line)
   # (In case you've changed routes in your Bygpay Installation)
   config.deposit_mobile_path = '/deposits/mobile'
+  config.deposit_card_path = '/deposits/card'
   config.deposit_status_overide_path = '/deposits/status-overide'
   config.deposit_status_path = '/deposits'
   
@@ -64,6 +65,7 @@ mobile_payload = {
   walletno: '0244124550', 
   provider: 'MTN',
   currency: 'USD', # optional
+  token: '23571', # Optional (Only required for Vodafone Payments)
   extrnx_code: nil # optional
 }
 result = deposit.charge(1.99, mobile_payload)
@@ -77,21 +79,6 @@ else
 end
 ```
 
-Query Transaction status
-```ruby
-# Checking transaction status
-# You always need the transaction UUID to get status response
-deposit = Bygpay::Deposit::Mobile.new
-result = deposit.transaction_status('e81216aa-9ef7-4c5c-aed0-6e5ff1fe')
-if result
-  puts deposit.uuid # need uuid to check transacion status
-  puts deposit.status # accepted, :pending, :fail, :success
-  puts deposit.transaction_id
-else
-  puts deposit.response_text
-  puts deposit.status
-end
-```
 #### Debit/Credit Card
 
 Supports VISA, MasterCard and any other cards based on the processors available on Bygpay Gateway. This is a onetime transaction and immediate response is the final status of the transaction. However transaction status request is still available
@@ -126,7 +113,7 @@ Query Transaction status
 ```ruby
 # Checking transaction status
 # You always need the transaction UUID to get status response
-deposit = Bygpay::Deposit::Card.new
+deposit = Bygpay::Deposits.new
 result = deposit.transaction_status('e81216aa-9ef7-4c5c-aed0-6e5ff1fe')
 if result
   puts deposit.uuid
@@ -147,7 +134,7 @@ Currently SDK supports MTN, AIRTEL, TIGO, VODAFONE, you may refer to your Bygpay
 ```ruby
 # Making a Mobile Money Withdrawal Request
 withdraw = Bygpay::Withdraw::Mobile.new
-result = withdraw.send(1.99,{walletno: '0244124550', provider: 'MTN'})
+result = withdraw.sendmoney(1.99,{walletno: '0244124550', provider: 'MTN'})
 if result
   puts withdraw.uuid
   puts withdraw.status # accepted, :pending, :fail, :success
@@ -162,7 +149,7 @@ Query Transaction status
 ```ruby
 # Checking transaction status
 # You always need the transaction UUID to get status response
-withdraw = Bygpay::Withdraw::Mobile.new
+withdraw = Bygpay::Withdrawals.new
 result = withdraw.transaction_status('e81216aa-9ef7-4c5c-aed0-6e5ff1fe')
 if result
   puts withdraw.uuid

data/bygpay.gemspec

@@ -24,6 +24,8 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "bundler", "~> 1.14"
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
+  spec.add_development_dependency "simplecov"
+  spec.add_development_dependency "codeclimate-test-reporter", "~> 1.0.0"
   spec.add_dependency "http", "~> 2.0"
   spec.add_dependency "hashie", "~> 3.5.5"
 end

data/lib/bygpay/byg_response.rb

@@ -29,6 +29,10 @@ module Bygpay
       PENDING.include?(data.data.status)
     end
 
+    def uuid
+      data.data.uuid
+    end
+
     def transaction_id
       data.data.trnx_code
     end

data/lib/bygpay/deposit/card.rb

@@ -1,7 +1,6 @@
 module Bygpay
   module Deposit
     class Card < Bygpay::Deposits
-
       # {
       #     "card_number" : "4111111111111111",
       #     "amount": 1.00,
@@ -13,9 +12,8 @@ module Bygpay
       # }
       # Perform a Bankcard debit request
       def charge(amount, card_data = {})
-        post(card_deposit_endpoint, card_data.merge({amount: amount}))
+        post(card_deposit_endpoint, card_data.merge(amount: amount))
       end
-
     end
   end
-end
+end

data/lib/bygpay/deposit/mobile.rb

@@ -2,16 +2,20 @@ module Bygpay
   module Deposit
     class Mobile < Bygpay::Deposits
 
+      # Perform a mobile deposit request
+      # @param amount [Decimal]
+      # @param mobile_data [Hash]
+      # mobile data example
       # {
       #     "walletno" : "0276967627",
       #     "provider": "TIGO",
-      #     "currency": "USD",
-      #     "extrnx_code": null
+      #     "currency": "USD", # Optional
+      #     "token": "393902", # Optional (Only Required for Vodafone Payments)
+      #     "extrnx_code": null # Optional
       # }
-      # Perform a mobile deposit request
       def charge(amount, mobile_data = {})
-        post(mobile_deposit_endpoint, mobile_data.merge({amount: amount}))
+        post(mobile_deposit_endpoint, mobile_data.merge(amount: amount))
       end
     end
   end
-end
+end

data/lib/bygpay/deposits.rb

@@ -2,6 +2,8 @@ module Bygpay
   class Deposits
     include Bygpay::Utils
 
+    def charge; end
+
     # Return deposit transaction status
     def transaction_status(uuid)
       get_status(deposit_status_endpoint,uuid)

data/lib/bygpay/utils.rb

@@ -3,7 +3,7 @@ require 'http'
 module Bygpay
   module Utils
     attr_accessor :status, :response_text, :transaction_id,
-                  :uuid, :result, :response
+                  :uuid, :result, :response, :amount
 
     # Mobile Deposit transactions endpoint
     def mobile_deposit_endpoint
@@ -50,9 +50,10 @@ module Bygpay
     def parse_response(json_payload)
       @response = Bygpay::BygResponse.parse_response(json_payload)
       resp = @response.data
-      @transaction_id = resp.data.trnx_code
+      @transaction_id = @response.transaction_id
       @response_text = resp.message
-      @uuid = resp.data.uuid
+      @uuid = @response.uuid
+      @amount = @response.amount
       @status = @response.transaction_status
       @result = @response.request_successful?
     end

data/lib/bygpay/version.rb

@@ -1,3 +1,3 @@
 module Bygpay
-  VERSION = "0.2.3"
+  VERSION = "0.2.4"
 end

data/lib/bygpay/withdraw/mobile.rb

@@ -1,22 +1,15 @@
 module Bygpay
   module Withdraw
     class Mobile < Bygpay::Withdrawals
-
       # {
       #     "walletno" : "0276967627",
       #     "provider": "TIGO",
       #     "extrnx_code": null
       # }
       # Perform a mobile deposit request
-      def send(amount, payload ={})
-        post(mobile_withdraw_endpoint, payload.merge({amount: amount}))
+      def sendmoney(amount, payload = {})
+        post(mobile_withdraw_endpoint, payload.merge(amount: amount))
       end
-
-      # Return deposit transaction status
-      def transaction_status(uuid)
-        get_status(withdraw_status_endpoint,uuid)
-      end
-
     end
   end
-end
+end

data/lib/bygpay/withdrawals.rb

@@ -2,5 +2,11 @@ module Bygpay
   class Withdrawals
     include Bygpay::Utils
 
+    def sendmoney; end
+
+    # Return deposit transaction status
+    def transaction_status(uuid)
+      get_status(withdraw_status_endpoint, uuid)
+    end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bygpay
 version: !ruby/object:Gem::Version
-  version: 0.2.3
+  version: 0.2.4
 platform: ruby
 authors:
 - Alfred Rowe
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-21 00:00:00.000000000 Z
+date: 2017-09-12 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -52,6 +52,34 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '3.0'
+- !ruby/object:Gem::Dependency
+  name: simplecov
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - ">="
+      - !ruby/object:Gem::Version
+        version: '0'
+- !ruby/object:Gem::Dependency
+  name: codeclimate-test-reporter
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
+  type: :development
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 1.0.0
 - !ruby/object:Gem::Dependency
   name: http
   requirement: !ruby/object:Gem::Requirement
@@ -129,7 +157,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.6.12
+rubygems_version: 2.6.13
 signing_key: 
 specification_version: 4
 summary: Bygpay Payment Gateway Ruby SDK