bygpay 0.2.1 → 0.2.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: d97997559b9bd855bd554bb46231a17be6b14a76
-  data.tar.gz: a8cdcb4d21790731a3ca05c57f15941e26b330dc
+  metadata.gz: 4dbbb7c0fc6bd86ab7308612d53253225cd1a99e
+  data.tar.gz: 6bfbd8cf31e41ec241dcf47c1cf65f4a4ad96a5f
 SHA512:
-  metadata.gz: 1ba24a2f45bce7c47a873a71795e1ea03cab4900eed5c2f5981f3e8a381767f36115023ad5736f10618c4571644249f8b3da037ffc4711b8e11faacb1de425c1
-  data.tar.gz: 62db8eef7d67f30f767b0e3289ae276719c5bfd6b12d147382622aba5c3d7fd40a5a1d23161c2e3e2908a62126bb9c50635c66c84fe276161cdc2d62d248d9b8
+  metadata.gz: 67aef33499c381da810352387eea781ba522fa20a0a3c02b3be50067923ab7f966c63e27732647f1f0537b350cf4314b8267a6213b922a5a49fb12ed7a861a55
+  data.tar.gz: 742a5738f22ffd2d9e6a4e1f1959f3e71fcdaf2bfa742c5901c20d7512bb1ae111e0fbd57af2aec7a3b0ee4344a94569ff26751eccc2054597b720fae1feb4ef

data/CHANGELOG.md

@@ -6,4 +6,11 @@
 
 #####v0.2.0
 * Fixed Bugs
-* MoMo Withdrawal Support
+* MoMo Withdrawal Support
+
+####pre-0.2.1
+* Added Better Response Management
+
+####v0.2.2
+* Bankcard support Added
+* Codebase Improved

data/README.md

@@ -1,4 +1,4 @@
-[![Code Climate](https://codeclimate.com/github/nukturnal/bygpay/badges/gpa.svg)](https://codeclimate.com/github/nukturnal/bygpay) [![codebeat badge](https://codebeat.co/badges/8db86406-18f8-4c2d-bacf-58ac1c700c0a)](https://codebeat.co/projects/github-com-nukturnal-bygpay-master)
+[![Gem Version](https://badge.fury.io/rb/bygpay.svg)](https://badge.fury.io/rb/bygpay) [![Code Climate](https://codeclimate.com/github/nukturnal/bygpay/badges/gpa.svg)](https://codeclimate.com/github/nukturnal/bygpay) [![codebeat badge](https://codebeat.co/badges/8db86406-18f8-4c2d-bacf-58ac1c700c0a)](https://codebeat.co/projects/github-com-nukturnal-bygpay-master)
 
 # Bygpay Ruby SDK
 

data/bygpay.gemspec

@@ -25,4 +25,5 @@ Gem::Specification.new do |spec|
   spec.add_development_dependency "rake", "~> 10.0"
   spec.add_development_dependency "rspec", "~> 3.0"
   spec.add_dependency "http", "~> 2.0"
+  spec.add_dependency "hashie", "~> 3.5.5"
 end

data/lib/bygpay/byg_response.rb

@@ -0,0 +1,77 @@
+module Bygpay
+  class BygResponse
+    SUCCESS = 'success'
+    FAILED = 'fail'
+    PENDING = ['accepted','pending']
+
+    attr_accessor :data
+
+    def initialize(hash = {})
+      @data = Hashie::Mash.new(hash)
+    end
+
+    # Check if Bygpay Gateway processed requests without any issues
+    def request_successful?
+      data.status == SUCCESS
+    end
+
+    def success?
+      data.data.status == SUCCESS
+    end
+
+    def failed?
+      data.data.status == FAILED
+    end
+
+    def pending?
+      PENDING.include?(data.data.status)
+    end
+
+    def transaction_id
+      data.data.trnx_code
+    end
+
+    def processor_transaction_id
+      data.data.provider_txid
+    end
+
+    def transaction_status
+      data.data.status
+    end
+
+    def currency
+      data.data.currency
+    end
+
+    def amount
+      data.data.amount
+    end
+
+    def provider
+      data.data.provider
+    end
+
+    # Hash strucuture
+    # {
+    #     "status": "success",
+    #     "message": "Some messages",
+    #     "data": {
+    #         "uuid": "d1f3395e-ea08-4599-b8a5-41f5e7a4",
+    #         "status": "accepted",
+    #         "currency": "GHS",
+    #         "trnx_code": "DTX00000008",
+    #         "provider_txid": null,
+    #         "extrnx_code": null,
+    #         "walletno": "0276967627",
+    #         "amount": 0.1,
+    #         "provider": "TIGO"
+    #     }
+    # }
+    # This may throw JSON::ParserError if the json_payload is not valid JSON.
+    def self.parse_response(json_payload)
+      data = JSON.parse(json_payload, symbolize_names: true)
+      resp = BygResponse.new(data)
+      resp
+    end
+  end
+end

data/lib/bygpay/configuration.rb

@@ -2,7 +2,8 @@ module Bygpay
   class Configuration
     attr_accessor :base_url, :api_key,
                   :deposit_mobile_path, :deposit_status_overide_path, :deposit_status_path,
-                  :withdraw_mobile_path, :withdraw_status_overide_path, :withdraw_status_path
+                  :withdraw_mobile_path, :withdraw_status_overide_path, :withdraw_status_path,
+                  :deposit_card_path
 
     def initialize
       @base_url = nil
@@ -10,6 +11,7 @@ module Bygpay
 
       # Preset default paths but allow for changes
       @deposit_mobile_path = '/deposits/mobile'
+      @deposit_card_path = '/deposits/card'
       @deposit_status_overide_path = '/deposits/status-overide'
       @deposit_status_path = '/deposits'
 

data/lib/bygpay/deposit/card.rb

@@ -0,0 +1,21 @@
+module Bygpay
+  module Deposit
+    class Card < Bygpay::Deposits
+
+      # {
+      #     "card_number" : "4111111111111111",
+      #     "amount": 1.00,
+      #     "expiry_month": 6,
+      #     "expiry_year": 2017,
+      #     "cvv": 618,
+      #     "country": "GH",
+      #     "currency": "GHS"
+      # }
+      # Perform a Bankcard debit request
+      def charge(amount, card_data = {})
+        post(card_deposit_endpoint, card_data.merge({amount: amount}))
+      end
+
+    end
+  end
+end

data/lib/bygpay/deposit/mobile.rb

@@ -8,15 +8,9 @@ module Bygpay
       #     "extrnx_code": null
       # }
       # Perform a mobile deposit request
-      def charge(amount, payload ={})
-        post(mobile_deposit_endpoint, payload.merge({amount: amount}))
+      def charge(amount, mobile_data = {})
+        post(mobile_deposit_endpoint, mobile_data.merge({amount: amount}))
       end
-
-      # Return deposit transaction status
-      def transaction_status(uuid)
-        get_status(deposit_status_endpoint,uuid)
-      end
-
     end
   end
 end

data/lib/bygpay/deposits.rb

@@ -2,5 +2,9 @@ module Bygpay
   class Deposits
     include Bygpay::Utils
 
+    # Return deposit transaction status
+    def transaction_status(uuid)
+      get_status(deposit_status_endpoint,uuid)
+    end
   end
 end

data/lib/bygpay/utils.rb

@@ -2,8 +2,6 @@ require 'http'
 
 module Bygpay
   module Utils
-    extend self
-
     attr_accessor :status, :response_text, :transaction_id,
                   :uuid, :result, :response
 
@@ -12,6 +10,11 @@ module Bygpay
       Bygpay.configuration.deposit_mobile_path
     end
 
+    # Mobile Deposit transactions endpoint
+    def card_deposit_endpoint
+      Bygpay.configuration.deposit_card_path
+    end
+
     # Deposit transactions status check endpoint
     def deposit_status_endpoint
       Bygpay.configuration.deposit_status_path
@@ -30,7 +33,6 @@ module Bygpay
     # Post payload
     def post(endpoint, payload = {})
       url = "#{Bygpay.configuration.base_url}#{endpoint}"
-      puts "URL: #{url}"
       result = http_connect.post(url, json: payload)
 
       parse_response(result.body)
@@ -44,27 +46,15 @@ module Bygpay
       parse_response(result.body)
     end
 
-    # {
-    #     "status": "success",
-    #     "message": "Some messages",
-    #     "data": {
-    #         "uuid": "d1f3395e-ea08-4599-b8a5-41f5e7a4",
-    #         "status": "accepted",
-    #         "trnx_code": "DTX00000008",
-    #         "provider_txid": null,
-    #         "extrnx_code": null,
-    #         "walletno": "0276967627",
-    #         "amount": 0.1,
-    #         "provider": "TIGO"
-    #     }
-    # }
-    def parse_response(body)
-      @result = JSON.parse(body)
-      @transaction_id = @result['data']['trnx_code']
-      @response_text = @result['message']
-      @uuid = @result['data']['uuid']
-      @status = @result['data']['status']
-      @response = @result['status'] == 'success'
+    # Parse on JSON Body to BygResponse for parsing and processing
+    def parse_response(json_payload)
+      @response = Bygpay::BygResponse.parse_response(json_payload)
+      resp = @response.data
+      @transaction_id = resp.data.trnx_code
+      @response_text = resp.message
+      @uuid = resp.data.uuid
+      @status = @response.transaction_status
+      @result = @response.request_successful?
     end
 
     # global Bygpay connect

data/lib/bygpay/version.rb

@@ -1,3 +1,3 @@
 module Bygpay
-  VERSION = "0.2.1"
+  VERSION = "0.2.2"
 end

data/lib/bygpay.rb

@@ -1,8 +1,10 @@
 require 'bygpay/version'
 require 'bygpay/configuration'
+require 'bygpay/byg_response'
 require 'bygpay/utils'
 require 'bygpay/deposits'
 require 'bygpay/deposit/mobile'
+require 'bygpay/deposit/card'
 require 'bygpay/withdrawals'
 require 'bygpay/withdraw/mobile'
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bygpay
 version: !ruby/object:Gem::Version
-  version: 0.2.1
+  version: 0.2.2
 platform: ruby
 authors:
 - Alfred Rowe
 autorequire: 
 bindir: exe
 cert_chain: []
-date: 2017-06-15 00:00:00.000000000 Z
+date: 2017-06-20 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -66,6 +66,20 @@ dependencies:
     - - "~>"
       - !ruby/object:Gem::Version
         version: '2.0'
+- !ruby/object:Gem::Dependency
+  name: hashie
+  requirement: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.5.5
+  type: :runtime
+  prerelease: false
+  version_requirements: !ruby/object:Gem::Requirement
+    requirements:
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: 3.5.5
 description: Ruby Wrapper to process payments via any installed Bygpay Payment Gateway
 email:
 - alfred@encodevlabs.com
@@ -86,7 +100,9 @@ files:
 - bin/setup
 - bygpay.gemspec
 - lib/bygpay.rb
+- lib/bygpay/byg_response.rb
 - lib/bygpay/configuration.rb
+- lib/bygpay/deposit/card.rb
 - lib/bygpay/deposit/mobile.rb
 - lib/bygpay/deposits.rb
 - lib/bygpay/utils.rb