byebug 8.2.2 → 8.2.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: a36b03a8384040e6115f7a70701fd07388cc51ab
-  data.tar.gz: 842e4928011aeb9832768de39fa49067d8dc3fa6
+  metadata.gz: 3de52e0debad720f122829e148b9b492a2acba4d
+  data.tar.gz: ded3f66ec7d142c98f96448e140bf4084cd26c74
 SHA512:
-  metadata.gz: 15d4d993bcac41bcc06c949fa746ce4198bbaaeae1a893a5caa3f43ee2374a26f3d62b76c9eb46edd5df00709f506e18d4c614a11a98b086bc031cbb9a29f658
-  data.tar.gz: c9a7668f5ebabc9db76f10e7851420303333d17c10e7a77949fa665cc697ac4c2973fe6702d7b6979119758eb4e8682f4dc9893787b0568150bc8dd2e624e946
+  metadata.gz: c8b995f94420f0a6ea19f7adcabd403ab987e2fe0bb5b416eeae799c795faf59d4d93fea0b9e04016690d103e17f27ab4e6f4fc1e2c8b07d6b94448c00f213ef
+  data.tar.gz: 7c3f70142d4f637bc2d40a4564d5b894d0bcee68f96eb655f1c63cce015f5dd10af6fed4bb1fcb10fdbe235f1648292720c6843ee4aaf256efa427c7e007b5cf

data/CHANGELOG.md

@@ -2,7 +2,17 @@
 
 ## Master (Unreleased)
 
-## 8.2.2 - 2015-02-01
+## 8.2.3 - 2016-04-07
+
+### Fixed
+
+* Better interaction with utilities like RSpec when hitting Ctrl-C.
+* `irb` command when original program modified ARGV (#197, thanks @josephks).
+* Unusable debugger when stdin redirected (#211,thanks @sethk).
+* RC file loading when no explicit flag included (#223).
+* Installation on some Windows systems (#175, #226).
+
+## 8.2.2 - 2016-02-01
 
 ### Fixed
 

data/GUIDE.md

@@ -84,7 +84,7 @@ Now let us step through the program.
     8:
     9:   tri
    10: end
-(byebug) p tri
+(byebug) eval tri
 nil
 (byebug) step
 
@@ -99,7 +99,7 @@ nil
     9:   tri
    10: end
    11:
-(byebug) p tri
+(byebug) eval tri
 0
 ```
 
@@ -107,7 +107,7 @@ The first `step` command runs the script one executable unit. The second command
 we entered was just hitting the return key: `byebug` remembers the last command
 you entered was `step` and runs it again.
 
-One way to print the values of variables is `p` (there are other ways). When we
+One way to print the values of variables is `eval` (there are other ways). When we
 look at the value of `tri` the first time, we see it is `nil`. Again we are
 stopped _before_ the assignment on line 5, and this variable hadn't been set
 previously. However after issuing another `step` command we see that the value
@@ -447,7 +447,7 @@ NameError Exception: undefined local variable or method `n_args' for main:Object
 => 28: hanoi(n, :a, :b, :c)
 (byebug) n_args
 0
-(byebug) p n
+(byebug) eval n
 3
 (byebug) down 2
 
@@ -462,12 +462,12 @@ NameError Exception: undefined local variable or method `n_args' for main:Object
     8:
     9:   hanoi(n - 1, c, b, a) if n - 1 > 0
    10: end
-(byebug) p n
+(byebug) eval n
 2
 ```
 
 Notice in the above to get the value of variable `n` we had to use a print
-command like `p n`. If we entered just `n`, that would be taken to mean byebug
+command like `eval n`. If we entered just `n`, that would be taken to mean byebug
 command `next`. In the current scope, variable `n_args` is not defined.  However
 I can change to the top-most frame by using the `frame 2` command. Notice that
 inside frame #2, the value of `n_args` can be shown. Also note that the value of

data/README.md

@@ -9,13 +9,13 @@
 [gem]: https://img.shields.io/gem/v/byebug.svg
 [gpa]: https://img.shields.io/codeclimate/github/deivid-rodriguez/byebug.svg
 [cov]: https://img.shields.io/codeclimate/coverage/github/deivid-rodriguez/byebug.svg
-[tip]: https://img.shields.io/gittip/deivid-rodriguez.svg
+[tip]: https://img.shields.io/gittip/byebug.svg
 [irc]: https://img.shields.io/badge/IRC%20(gitter)-devs%20%26%20users-brightgreen.svg
 
 [gem_url]: https://rubygems.org/gems/byebug
 [gpa_url]: https://codeclimate.com/github/deivid-rodriguez/byebug
 [cov_url]: https://codeclimate.com/github/deivid-rodriguez/byebug
-[tip_url]: https://gratipay.com/~deivid-rodriguez
+[tip_url]: https://gratipay.com/byebug
 [irc_url]: https://gitter.im/deivid-rodriguez/byebug
 
 Byebug is a simple to use, feature rich debugger for Ruby 2. It uses the new
@@ -67,9 +67,22 @@ Simply drop
 
     byebug
 
-wherever you want to start debugging and the execution will stop there. If you
-are debugging rails, start the server and once the execution gets to your
-`byebug` command you will get a debugging prompt.
+wherever you want to start debugging and the execution will stop there.
+If you were debugging Rails, for example, you would add `byebug` to your code.
+
+```ruby
+def index
+  byebug
+  @articles = Article.find_recent
+```
+
+And then start a Rails server.
+
+```shell
+bin/rails s
+```
+
+Once the execution gets to your `byebug` command you will get a debugging prompt.
 
 ## Byebug's commands
 

data/bin/byebug

@@ -1,5 +1,7 @@
 #!/usr/bin/env ruby
 
+$LOAD_PATH.unshift(File.dirname(File.realpath(__FILE__)) + '/../lib')
+
 require 'byebug/runner'
 
 Byebug::Runner.new.run

data/ext/byebug/breakpoint.c

@@ -1,4 +1,4 @@
-#include <byebug.h>
+#include "byebug.h"
 
 #ifdef _WIN32
 #include <ctype.h>

data/ext/byebug/byebug.c

@@ -1,4 +1,4 @@
-#include <byebug.h>
+#include "byebug.h"
 
 static VALUE mByebug;   /* Ruby Byebug Module object */
 

data/ext/byebug/byebug.h

@@ -8,13 +8,13 @@
 #define UNUSED(x) (void)(x)
 
 /* flags */
-#define CTX_FL_DEAD         (1<<1) /* this context belonged to a dead thread */
-#define CTX_FL_IGNORE       (1<<2) /* this context belongs to ignored thread */
-#define CTX_FL_SUSPEND      (1<<3) /* thread currently suspended             */
-#define CTX_FL_TRACING      (1<<4) /* call at_tracing method                 */
-#define CTX_FL_WAS_RUNNING  (1<<5) /* thread was previously running          */
-#define CTX_FL_STOP_ON_RET  (1<<6) /* can stop on method 'end'               */
-#define CTX_FL_IGNORE_STEPS (1<<7) /* doesn't countdown steps to break       */
+#define CTX_FL_DEAD         (1<<1)      /* this context belonged to a dead thread */
+#define CTX_FL_IGNORE       (1<<2)      /* this context belongs to ignored thread */
+#define CTX_FL_SUSPEND      (1<<3)      /* thread currently suspended             */
+#define CTX_FL_TRACING      (1<<4)      /* call at_tracing method                 */
+#define CTX_FL_WAS_RUNNING  (1<<5)      /* thread was previously running          */
+#define CTX_FL_STOP_ON_RET  (1<<6)      /* can stop on method 'end'               */
+#define CTX_FL_IGNORE_STEPS (1<<7)      /* doesn't countdown steps to break       */
 
 /* macro functions */
 #define CTX_FL_TEST(c,f) ((c)->flags & (f))
@@ -22,14 +22,16 @@
 #define CTX_FL_UNSET(c,f) do { (c)->flags &= ~(f); } while (0)
 
 /* types */
-typedef enum {
+typedef enum
+{
   CTX_STOP_NONE,
   CTX_STOP_STEP,
   CTX_STOP_BREAKPOINT,
   CTX_STOP_CATCHPOINT
 } ctx_stop_reason;
 
-typedef struct {
+typedef struct
+{
   int calced_stack_size;
   int flags;
   ctx_stop_reason stop_reason;
@@ -37,22 +39,24 @@ typedef struct {
   VALUE thread;
   int thnum;
 
-  int dest_frame;              /* next stop's frame if stopped by next     */
-  int lines;                   /* # of lines in dest_frame before stopping */
-  int steps;                   /* # of steps before stopping               */
-  int steps_out;               /* # of returns before stopping             */
+  int dest_frame;       /* next stop's frame if stopped by next     */
+  int lines;    /* # of lines in dest_frame before stopping */
+  int steps;    /* # of steps before stopping               */
+  int steps_out;        /* # of returns before stopping             */
 
-  VALUE backtrace;             /* [[loc, self, klass, binding], ...] */
+  VALUE backtrace;      /* [[loc, self, klass, binding], ...] */
 } debug_context_t;
 
-typedef enum {
+typedef enum
+{
   LOCATION,
   SELF,
   CLASS,
   BINDING
 } frame_part;
 
-struct call_with_inspection_data {
+struct call_with_inspection_data
+{
   debug_context_t *dc;
   VALUE ctx;
   ID id;
@@ -60,15 +64,19 @@ struct call_with_inspection_data {
   VALUE *argv;
 };
 
-typedef struct {
+typedef struct
+{
   st_table *tbl;
 } threads_table_t;
 
-enum bp_type { BP_POS_TYPE, BP_METHOD_TYPE };
+enum bp_type
+{ BP_POS_TYPE, BP_METHOD_TYPE };
 
-enum hit_condition { HIT_COND_NONE, HIT_COND_GE, HIT_COND_EQ, HIT_COND_MOD };
+enum hit_condition
+{ HIT_COND_NONE, HIT_COND_GE, HIT_COND_EQ, HIT_COND_MOD };
 
-typedef struct {
+typedef struct
+{
   int id;
   enum bp_type type;
   VALUE source;
@@ -93,9 +101,9 @@ extern void remove_from_locked(VALUE thread);
 /* functions from threads.c */
 extern void Init_threads_table(VALUE mByebug);
 extern VALUE create_threads_table(void);
-extern void thread_context_lookup(VALUE thread, VALUE *context);
+extern void thread_context_lookup(VALUE thread, VALUE * context);
 extern int is_living_thread(VALUE thread);
-extern void acquire_lock(debug_context_t *dc);
+extern void acquire_lock(debug_context_t * dc);
 extern void release_lock(void);
 
 /* global variables */
@@ -105,27 +113,21 @@ extern VALUE next_thread;
 /* functions from context.c */
 extern void Init_context(VALUE mByebug);
 extern VALUE context_create(VALUE thread);
-extern VALUE context_dup(debug_context_t *context);
-extern void reset_stepping_stop_points(debug_context_t *context);
+extern VALUE context_dup(debug_context_t * context);
+extern void reset_stepping_stop_points(debug_context_t * context);
 extern VALUE call_with_debug_inspector(struct call_with_inspection_data *data);
-extern VALUE context_backtrace_set(const rb_debug_inspector_t *inspector,
+extern VALUE context_backtrace_set(const rb_debug_inspector_t * inspector,
                                    void *data);
 
 /* functions from breakpoint.c */
 extern void Init_breakpoint(VALUE mByebug);
-extern VALUE catchpoint_hit_count(VALUE catchpoints,
-                                  VALUE exception,
-                                  VALUE *exception_name);
+extern VALUE catchpoint_hit_count(VALUE catchpoints, VALUE exception,
+                                  VALUE * exception_name);
 
-extern VALUE find_breakpoint_by_pos(VALUE breakpoints,
-                                    VALUE source,
-                                    VALUE pos,
+extern VALUE find_breakpoint_by_pos(VALUE breakpoints, VALUE source, VALUE pos,
                                     VALUE bind);
 
-extern VALUE find_breakpoint_by_method(VALUE breakpoints,
-                                       VALUE klass,
-                                       VALUE mid,
-                                       VALUE bind,
-                                       VALUE self);
+extern VALUE find_breakpoint_by_method(VALUE breakpoints, VALUE klass,
+                                       VALUE mid, VALUE bind, VALUE self);
 
 #endif

data/ext/byebug/context.c

@@ -1,4 +1,4 @@
-#include <byebug.h>
+#include "byebug.h"
 
 static VALUE cContext;
 static VALUE cDebugThread;

data/ext/byebug/extconf.rb

@@ -1,21 +1,10 @@
-if RUBY_VERSION < '2.0'
-  STDERR.print("Ruby version is too old\n")
-  exit(1)
-end
-
 require 'mkmf'
 
 makefile_config = RbConfig::MAKEFILE_CONFIG
 
 makefile_config['CC'] = ENV['CC'] if ENV['CC']
 
-makefile_config['CFLAGS'] << ' -Wall -Werror'
 makefile_config['CFLAGS'] << ' -gdwarf-2 -g3 -O0' if ENV['debug']
 
-if makefile_config['CC'] =~ /clang/
-  makefile_config['CFLAGS'] << ' -Wno-unknown-warning-option'
-  makefile_config['CFLAGS'] << ' -Wno-ignored-attributes'
-end
-
 dir_config('ruby')
 with_cflags(makefile_config['CFLAGS']) { create_makefile('byebug/byebug') }

data/ext/byebug/locker.c

@@ -1,4 +1,4 @@
-#include <byebug.h>
+#include "byebug.h"
 
 /**
  * A simple linked list containing locked threads, FIFO style.

data/ext/byebug/threads.c

@@ -1,4 +1,4 @@
-#include <byebug.h>
+#include "byebug.h"
 
 /* Threads table class */
 static VALUE cThreadsTable;

data/lib/byebug/commands/break.rb

@@ -80,16 +80,16 @@ module Byebug
     end
 
     def add_line_breakpoint(file, line)
-      fail(pr('break.errors.source', file: file)) unless File.exist?(file)
+      raise(pr('break.errors.source', file: file)) unless File.exist?(file)
 
       fullpath = File.realpath(file)
 
       if line > n_lines(file)
-        fail(pr('break.errors.far_line', lines: n_lines(file), file: fullpath))
+        raise(pr('break.errors.far_line', lines: n_lines(file), file: fullpath))
       end
 
       unless Breakpoint.potential_line?(fullpath, line)
-        fail(pr('break.errors.line', file: fullpath, line: line))
+        raise(pr('break.errors.line', file: fullpath, line: line))
       end
 
       Breakpoint.add(fullpath, line, @match[2])

data/lib/byebug/commands/help.rb

@@ -44,7 +44,7 @@ module Byebug
     end
 
     def help_for(input, cmd)
-      fail CommandNotFound.new(input, command) unless cmd
+      raise CommandNotFound.new(input, command) unless cmd
 
       puts(cmd.help)
     end

data/lib/byebug/commands/irb.rb

@@ -29,7 +29,20 @@ module Byebug
         return errmsg(pr('base.errors.only_local'))
       end
 
-      IRB.start(__FILE__)
+      # IRB tries to parse ARGV so we must clear it.  See issue 197
+      with_clean_argv { IRB.start(__FILE__) }
+    end
+
+    private
+
+    def with_clean_argv
+      saved_argv = ARGV.dup
+      ARGV.clear
+      begin
+        yield
+      ensure
+        ARGV.concat(saved_argv)
+      end
     end
   end
 end

data/lib/byebug/commands/list.rb

@@ -36,11 +36,11 @@ module Byebug
 
     def execute
       msg = "No sourcefile available for #{frame.file}"
-      fail(msg) unless File.exist?(frame.file)
+      raise(msg) unless File.exist?(frame.file)
 
       max_lines = n_lines(frame.file)
       b, e = range(@match[2], max_lines)
-      fail('Invalid line range') unless valid_range?(b, e, max_lines)
+      raise('Invalid line range') unless valid_range?(b, e, max_lines)
 
       display_lines(b, e)
 
@@ -85,11 +85,11 @@ module Byebug
 
     def parse_range(input, size, max_line)
       first, err = get_int(lower_bound(input), 'List', 1, max_line)
-      fail(err) unless first
+      raise(err) unless first
 
       if upper_bound(input)
         last, err = get_int(upper_bound(input), 'List', 1, max_line)
-        fail(err) unless last
+        raise(err) unless last
 
         last = amend(last, max_line)
       else

data/lib/byebug/helpers/eval.rb

@@ -42,7 +42,7 @@ module Byebug
       # handling the errors at an error level.
       #
       def error_eval(str, binding = frame._binding)
-        safe_eval(str, binding) { |e| fail(e, msg(e)) }
+        safe_eval(str, binding) { |e| raise(e, msg(e)) }
       end
 
       #

data/lib/byebug/history.rb

@@ -113,7 +113,7 @@ module Byebug
     #
     def ignore?(buf)
       return true if /^\s*$/ =~ buf
-      return false if Readline::HISTORY.length == 0
+      return false if Readline::HISTORY.empty?
 
       Readline::HISTORY[Readline::HISTORY.length - 1] == buf
     end

data/lib/byebug/interface.rb

@@ -1,3 +1,4 @@
+require 'byebug/setting'
 require 'byebug/history'
 require 'byebug/helpers/file'
 

data/lib/byebug/interfaces/local_interface.rb

@@ -1,4 +1,6 @@
 # frozen_string_literal: true
+require 'io/console'
+
 module Byebug
   #
   # Interface class for standard byebug use.
@@ -8,23 +10,38 @@ module Byebug
 
     def initialize
       super()
-      @input = STDIN
-      @output = STDOUT
-      @error = STDERR
+      @input = @output = @error = IO.console
+      Readline.input = @input
+      Readline.output = @output
     end
 
     #
-    # Reads a single line of input using Readline. If Ctrl-C is pressed in the
-    # middle of input, the line is reset to only the prompt and we ask for input
-    # again. If Ctrl-D is pressed, it returns "continue".
+    # Reads a single line of input using Readline. If Ctrl-D is pressed, it
+    # returns "continue", meaning that program's execution will go on.
     #
     # @param prompt Prompt to be displayed.
     #
     def readline(prompt)
-      Readline.readline(prompt, false) || EOF_ALIAS
+      with_repl_like_sigint do
+        Readline.readline(prompt, false) || EOF_ALIAS
+      end
+    end
+
+    #
+    # Yields the block handling Ctrl-C the following way: if pressed while
+    # waiting for input, the line is reset to only the prompt and we ask for
+    # input again.
+    #
+    # @note Any external 'INT' traps are overriden during this method.
+    #
+    def with_repl_like_sigint
+      orig_handler = trap('INT') { raise Interrupt }
+      yield
     rescue Interrupt
       puts('^C')
       retry
+    ensure
+      trap('INT', orig_handler)
     end
   end
 end

data/lib/byebug/interfaces/remote_interface.rb

@@ -30,7 +30,7 @@ module Byebug
       output.puts(prompt)
 
       result = input.gets
-      fail IOError unless result
+      raise IOError unless result
 
       result.chomp
     end

data/lib/byebug/option_setter.rb

@@ -50,7 +50,7 @@ module Byebug
 
     def rc
       @opts.on '-x', '--[no-]rc', 'Run byebug initialization file' do |v|
-        Byebug.run_init_script if v
+        @runner.init_script = v
       end
     end
 

data/lib/byebug/printers/base.rb

@@ -26,7 +26,7 @@ module Byebug
           end
           break if result
         end
-        fail MissedPath, "Can't find part path '#{path}'" unless result
+        raise MissedPath, "Can't find part path '#{path}'" unless result
         result
       end
 
@@ -35,7 +35,7 @@ module Byebug
         string.gsub(/\|\w+$/, '').gsub(/([^#]?){([^}]*)}/) do
           key = Regexp.last_match[2].to_s
           unless args.key?(key.to_sym)
-            fail MissedArgument, "Missed argument #{key} for '#{string}'"
+            raise MissedArgument, "Missed argument #{key} for '#{string}'"
           end
 
           "#{Regexp.last_match[1]}#{args[key.to_sym]}"

data/lib/byebug/runner.rb

@@ -43,6 +43,11 @@ module Byebug
     #
     attr_accessor :stop
 
+    #
+    # Signals that we should run rc scripts before program starts
+    #
+    attr_writer :init_script
+
     #
     # @param stop [Boolean] Whether the runner should stop right before
     # starting the program.
@@ -71,6 +76,10 @@ module Byebug
       @remote ||= Byebug.parse_host_and_port(host_and_port)
     end
 
+    def init_script
+      defined?(@init_script) ? @init_script : true
+    end
+
     #
     # Usage banner.
     #
@@ -96,6 +105,8 @@ module Byebug
         return
       end
 
+      Byebug.run_init_script if init_script
+
       setup_cmd_line_args
 
       loop do
@@ -130,11 +141,11 @@ module Byebug
     def setup_cmd_line_args
       Byebug.mode = :standalone
 
-      fail(NoScript, 'You must specify a program to debug...') if $ARGV.empty?
+      raise(NoScript, 'You must specify a program to debug...') if $ARGV.empty?
 
       program = which($ARGV.shift)
       program = which($ARGV.shift) if program == which('ruby')
-      fail(NonExistentScript, "The script doesn't exist") unless program
+      raise(NonExistentScript, "The script doesn't exist") unless program
 
       $PROGRAM_NAME = program
     end
@@ -144,7 +155,7 @@ module Byebug
     #
     def debug_program
       ok = syntax_valid?(File.read($PROGRAM_NAME))
-      fail(InvalidScript, 'The script has incorrect syntax') unless ok
+      raise(InvalidScript, 'The script has incorrect syntax') unless ok
 
       error = Byebug.debug_load($PROGRAM_NAME, stop)
       puts "#{error}\n#{error.backtrace}" if error

data/lib/byebug/subcommands.rb

@@ -23,7 +23,7 @@ module Byebug
       return puts(help) unless subcmd_name
 
       subcmd = subcommand_list.match(subcmd_name)
-      fail CommandNotFound.new(subcmd_name, self.class) unless subcmd
+      raise CommandNotFound.new(subcmd_name, self.class) unless subcmd
 
       subcmd.new(processor, arguments).execute
     end

data/lib/byebug/version.rb

@@ -3,5 +3,5 @@
 # Reopen main module to define the library version
 #
 module Byebug
-  VERSION = '8.2.2'.freeze
+  VERSION = '8.2.3'.freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: byebug
 version: !ruby/object:Gem::Version
-  version: 8.2.2
+  version: 8.2.3
 platform: ruby
 authors:
 - David Rodriguez
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-02-01 00:00:00.000000000 Z
+date: 2016-04-07 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler
@@ -189,7 +189,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.5.1
+rubygems_version: 2.6.0
 signing_key: 
 specification_version: 4
 summary: Ruby 2.0 fast debugger - base + CLI