by 1.0.0 → 1.0.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: '078f15faf5964b6b3bb4ac860c7733e069c0a8cb46556e9af7e555f8c3808d54'
-  data.tar.gz: e878d37b2417d4d655f138d3e2bae5bf51a76c34b7a3fab2956bc40c88a77dbb
+  metadata.gz: 24eb5316c698a47210046042dac2cd9912b3517fc88e88b0efed5da5f35d1fde
+  data.tar.gz: 77da0597a3214bdec5d90cc8fd5bcb5b746b7dfc606b80f2460f338ddbb3fbed
 SHA512:
-  metadata.gz: 128a3c27c4dfe729b62fa15d9b961f7384a75ec02030403ae85b376981b731c8d892305732e519cbfb84ab105b816275e6a910afff7f9187c2f723d7683eb12d
-  data.tar.gz: 61895959cd9a6097ded3430017d0a831affa73c668c8301579dd4a62f661a6c1fd3bb09871d5eb321ce9d97fb7a64c573fc8b92a60ae34b7adfcad835eb0ae08
+  metadata.gz: 65774c8520ea887f2cd0c11bfe71787ef39a00441648170b03b09825267a248443c5678ba8371a4d58963a557d60b150d77c06aad1cbf88fa5e7ba27357af28d
+  data.tar.gz: 84a86908dd443d71cb42a1150856df38f571ed6f199d9aedeee7bbc6f6dc738d7e0910339ec6151fa3202fc3e98c5b4c6339eb808d70b39daf8d73d16884fe68

data/CHANGELOG

@@ -1,3 +1,11 @@
+=== 1.0.1 (2023-02-09)
+
+* Make by-server stop more reliable by using SIGKILL if server does not stop with SIGQUIT (jeremyevans)
+
+* Remove debugging code when running a single file with minitest autorun (jeremyevans)
+
+* Use RbConfig.ruby to get the ruby binary name (eregon) (#1)
+
 === 1.0.0 (2023-02-07)
 
 * Initial Public Release

data/README.rdoc

@@ -65,8 +65,7 @@ needs the +socket+ standard library. The only issue with that is that
 
      require 'rbconfig'
      by = Gem.activate_bin_path("by", "by")
-     ruby = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['RUBY_INSTALL_NAME'])
-     puts "alias by='#{ruby} --disable-gems #{by}'"
+     puts "alias by='#{RbConfig.ruby} --disable-gems #{by}'"
 
    Note that one issue with using a shell alias is that it only
    works when loaded and used by the shell, it won't work if
@@ -88,8 +87,7 @@ needs the +socket+ standard library. The only issue with that is that
 
      require 'rbconfig'
      by = Gem.activate_bin_path("by", "by")
-     ruby = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['RUBY_INSTALL_NAME'])
-     File.binwrite("by", "#!/bin/sh\nexec #{ruby} --disable-gems #{by} \"$@\"\n")
+     File.binwrite("by", "#!/bin/sh\nexec #{RbConfig.ruby} --disable-gems #{by} \"$@\"\n")
      File.chmod(0755, "by")
 
 With each of these approaches, you can get much faster program

data/bin/by-session

@@ -4,7 +4,7 @@
 require 'rbconfig'
 ENV['BY_SOCKET'] ||= File.join(Dir.pwd, '.by_socket')
 by_server = File.join(__dir__, 'by-server')
-ruby = File.join(RbConfig::CONFIG['bindir'], RbConfig::CONFIG['RUBY_INSTALL_NAME'])
+ruby = RbConfig.ruby
 
 begin
   system(ruby, by_server, *ARGV, exception: true)

data/lib/by/server.rb

@@ -89,7 +89,7 @@ module By
     end
 
     # Handle an existing server socket.  This attempts to connect to the socket and
-    # then shutdown the server. If successful, it removes the socket.  If unnecessful,
+    # then shutdown the server. If successful, it removes the socket.  If unsuccessful,
     # it will print an error.
     def handle_existing_server
       if File.socket?(@socket_path)

data/lib/by/worker.rb

@@ -48,7 +48,28 @@ module By
 
     # Stop the server process by sending it the SIGQUIT signal, then exit.
     def stop_server
-      Process.kill(:QUIT, Process.ppid)
+      i = 0
+      while Process.ppid != 1 && Process.kill(0, Process.ppid)
+        if i < 4
+          Process.kill(:QUIT, Process.ppid)
+        end
+        sleep 0.1
+
+        if i == 5
+          # This is only reached if the QUIT signal does not
+          # cause the process to exit.
+          Process.kill(:KILL, Process.ppid)
+        end
+        if i > 8
+          # This is only reached if the process has still not
+          # stopped even after the KILL signal was sent.
+          $stderr.puts "ERROR: cannot stop by-server"
+          @normal_exit = false
+          break
+        end
+
+        i += 1
+      end
       cleanup_proc.call
       exit
     end
@@ -146,7 +167,7 @@ module By
         if defined?(Minitest) && Minitest.class_variable_get(:@@installed_at_exit)
           Minitest.singleton_class.prepend(Module.new do
             define_method(:run) do |argv|
-              super(argv).tap{|exit_code| p worker.normal_exit = exit_code == true}
+              super(argv).tap{|exit_code| worker.normal_exit = exit_code == true}
             end
           end)
           Minitest.after_run(&cleanup)

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: by
 version: !ruby/object:Gem::Version
-  version: 1.0.0
+  version: 1.0.1
 platform: ruby
 authors:
 - Jeremy Evans
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2023-02-07 00:00:00.000000000 Z
+date: 2023-02-09 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: minitest-global_expectations