business_days 0.0.1 → 0.0.2

data/README.rdoc

@@ -1,6 +1,6 @@
 = business_days
 
-Business Days is a sort-of extension to ActiveSupport to allow adding business days to time objects.
+Business Days is a sort-of extension to ActiveSupport to allow adding business days to time objects. 
 
 == Installation
 
@@ -29,3 +29,10 @@ Or add it to your Gemfile.
     (Time.parse("Friday") - 1.business_day).strftime("%A")
     # => "Thursday" 
 
+== Current Limitations
+
+* Holidays are completely ignored.
+
+* Time.now + 123512.business_days is done iteratively, even though it would be fairly straightforward to add (5/7 * n) + or - some small number based on where in the week you started.
+
+* saturday or sunday + 0.business_days is Monday. There are strong arguments both ways for making this result either monday or saturday. I think Monday is the more helpful. Write me hatemail if you disagree.

data/business_days.gemspec

@@ -1,6 +1,6 @@
 Gem::Specification.new do |gem|
   gem.name    = 'business_days'
-  gem.version = "0.0.1"
+  gem.version = "0.0.2"
 
   gem.author, gem.email = 'Burke Libbey', "burke@burkelibbey.org"
   gem.homepage = "http://github.com/burke/business_days"

data/lib/business_days.rb

@@ -1,5 +1,6 @@
 require 'active_support/all'
 require File.join(File.dirname(__FILE__),'business_days','time')
+require File.join(File.dirname(__FILE__),'business_days','date')
 
 module BusinessDays
   

data/lib/business_days/date.rb

@@ -0,0 +1,42 @@
+module BusinessDays
+  module Date
+    module Calculations
+      def self.included(base) #:nodoc:
+
+        base.class_eval do
+          alias_method :plus_without_business_days, :+
+          alias_method :+, :plus_with_business_days
+
+          alias_method :minus_without_business_days, :-
+          alias_method :-, :minus_with_business_days
+        end
+      end
+
+      def is_business_day?
+        # TODO: Holidays.
+        ! [0,6].include?(self.wday)
+      end 
+      
+      def plus_with_business_days(other)
+        if BusinessDays::BusinessDayDuration === other
+          other.calculate_duration(self, :+)
+        else
+          plus_without_business_days(other)
+        end
+      end
+ 
+      def minus_with_business_days(other)
+        if BusinessDays::BusinessDayDuration === other
+          other.calculate_duration(self, :-)
+        else
+          minus_without_business_days(other)
+        end
+      end
+    end
+
+  end 
+end
+
+class Date
+  include BusinessDays::Date::Calculations
+end 

data/spec/business_days_spec.rb

@@ -3,30 +3,61 @@ require File.join(File.dirname(__FILE__),'..','lib','business_days')
 
 describe BusinessDays do
 
-  before do
-    @friday = Time.parse("Friday, September 10th, 2010")
-    @thursday = @friday - 1.day
-    @saturday = @friday + 1.day
-    @monday = @friday + 3.days
-    @tuesday = @friday + 4.days
-  end 
-  
-  it "should add properly" do
-    (@friday + 1.business_day).should == @monday
-    (@friday + 2.business_days).should == @tuesday
-    (@saturday + 1.business_days).should == @tuesday
-    (@saturday + 0.business_days).should == @monday
-  end 
-
-  it "should subtract properly" do
-    (@saturday - 0.business_days).should == @friday
-    (@saturday - 1.business_day).should == @thursday
-    (@monday - 1.business_days).should == @friday
-    (@monday - 0.business_days).should == @monday
+  describe "with Time" do
+    before do
+      @friday = Time.parse("Friday, September 10th, 2010")
+      @thursday = @friday - 1.day
+      @saturday = @friday + 1.day
+      @monday = @friday + 3.days
+      @tuesday = @friday + 4.days
+    end 
+    
+    it "should add properly" do
+      (@friday + 1.business_day).should == @monday
+      (@friday + 2.business_days).should == @tuesday
+      (@saturday + 1.business_days).should == @tuesday
+      (@saturday + 0.business_days).should == @monday
+    end 
+   
+    it "should subtract properly" do
+      (@saturday - 0.business_days).should == @friday
+      (@saturday - 1.business_day).should == @thursday
+      (@monday - 1.business_days).should == @friday
+      (@monday - 0.business_days).should == @monday
+    end 
+   
+    it "should add with the params reversed" do
+      (1.business_day + @friday).should == @monday
+    end 
   end 
 
-  it "should add with the params reversed" do
-    (1.business_day + @friday).should == @monday
+  describe "with Date" do
+    before do
+      @friday = Date.parse("Friday, September 10th, 2010")
+      @thursday = @friday - 1.day
+      @saturday = @friday + 1.day
+      @monday = @friday + 3.days
+      @tuesday = @friday + 4.days
+    end 
+    
+    it "should add properly" do
+      (@friday + 1.business_day).should == @monday
+      (@friday + 2.business_days).should == @tuesday
+      (@saturday + 1.business_days).should == @tuesday
+      (@saturday + 0.business_days).should == @monday
+    end 
+   
+    it "should subtract properly" do
+      (@saturday - 0.business_days).should == @friday
+      (@saturday - 1.business_day).should == @thursday
+      (@monday - 1.business_days).should == @friday
+      (@monday - 0.business_days).should == @monday
+    end 
+   
+    it "should add with the params reversed" do
+      (1.business_day + @friday).should == @monday
+    end 
+    
   end 
   
 end 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: business_days
 version: !ruby/object:Gem::Version 
-  hash: 29
+  hash: 27
   prerelease: false
   segments: 
   - 0
   - 0
-  - 1
-  version: 0.0.1
+  - 2
+  version: 0.0.2
 platform: ruby
 authors: 
 - Burke Libbey
@@ -41,6 +41,7 @@ extensions: []
 extra_rdoc_files: []
 
 files: 
+- lib/business_days/date.rb
 - lib/business_days/time.rb
 - lib/business_days.rb
 - spec/business_days_spec.rb