bunny 2.7.1 → 2.7.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f58b34695f1799decb5818ead7efbf21448656d
-  data.tar.gz: 4c8db08cd4581da8eab1bdd0afd81693d4042a55
+  metadata.gz: f1dd2f949bcc12b76fad38159f60adfbf52eed85
+  data.tar.gz: 280cc9632f061268091bf5e0b705f1264f3b3aa6
 SHA512:
-  metadata.gz: 941c64ca6a10063df82456aec1f5dd4a44d5df67c6d9e74a73cfc41821b1b3d29f2ddfe260ea31434adb0697d5136d6cbc28e5a84e8adaca2b83d8897fb8d164
-  data.tar.gz: a3056eae41a6600aeed337094851c1f5f16e0f80e7b8170e2a7a18d22ac2caabdb0cf0ce69637c1f9f0ecdee7e693d1e9cf84dbc66ebfdd866bd6602a6b84a67
+  metadata.gz: 5b8e2f0e13ba6488e563ae1e8ba6566cf4c3d6ddfe22e095f3a2444240cfcf78f236cbf6a97cc71aba777e0ec8fcc14e6859fa5266dc012f063c4dbeb3bad3c0
+  data.tar.gz: 99bd85512d22d4da1626e98346a61512b470d6c87fd735838960c951af99fef340cee57cc9b8b6f54905d93f64c94c8b1a180c87b6f69439f654348aaf57e751

data/CONTRIBUTING.md

@@ -1,9 +1,30 @@
+## Overview
+
+This project **does not** use GitHub issues for questions, investigations, discussions, and so on.
+Issues are appropriate for something specific enough for a maintainer or contributor to work on:
+
+ * There should be enough information to reproduce the behavior observed in a reasonable amount of time
+ * It should be reasonably clear why the behavior should be changed and why this cannot or should not be addressed
+   in application code, a separate library and so on
+   
+ All issues that do not satisfy the above properties belong to the [Ruby RabbitMQ clients mailing list](http://groups.google.com/forum/#!forum/ruby-amqp). Pull request that do not satisfy them have a high chance
+ of being closed.
+ 
+## Submitting a Pull Request
+
+Please read the sections below to get an idea about how to run Bunny test suites first. Successfully
+running all tests, at least with `CI` environment variable exported to `true`, is an important
+first step for any contributor.
+
+Once you have a passing test suite, create a branch and make your changes on it.
+When you are done with your changes and all
+tests pass, write a [good, detailed commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) submit a pull request on GitHub.
+
 ## Pre-requisites
 
 The project uses Bundler for dependency management and requires RabbitMQ `3.5+` to be running
 locally with the `rabbitmq-management` and `rabbitmq_consistent_hash_exchange` plugins enabled.
 
-
 ### Running the Specs
 
 The specs require RabbitMQ to be running locally with a specific set of vhosts
@@ -88,8 +109,3 @@ It is possible to run all tests:
 It is possible to run only integration and regression tests but exclude unit and stress tests:
 
     CI=true bundle exec rspec -c spec/higher_level_api/ spec/lower_level_api spec/issues && bundle exec rspec -c spec/higher_level_api/integration/connection_recovery_spec.rb
-
-## Pull Requests
-
-Then create a branch and make your changes on it. Once you are done with your changes and all
-tests pass, write a [good, detailed commit message](http://tbaggery.com/2008/04/19/a-note-about-git-commit-messages.html) submit a pull request on GitHub.

data/ChangeLog.md

@@ -1,6 +1,13 @@
 ## Changes between Bunny 2.7.1 and 2.7.2 (unreleased)
 
-No changes yet.
+### Reading a Frame without Payload Could Result in a `Bunny::NoFinalOctetError`
+
+Reading a frame without payload (e.g. a heartbeat frame) could result in a `Bunny::NoFinalOctetError`
+with mostly idle connections.
+
+GitHub issue: [#521](https://github.com/ruby-amqp/bunny/issues/521).
+
+Contributed by GPif.
 
 
 ## Changes between Bunny 2.7.0 and 2.7.1 (Sep 25th, 2017)
@@ -51,7 +58,7 @@ in those cases.
 
 ### amq-protocol Update
 
-Minimum `amq-protocol` version is now [`2.2.0`]](https://github.com/ruby-amqp/amq-protocol/blob/master/ChangeLog.md#changes-between-210-and-220-may-11th-2017) which includes
+Minimum `amq-protocol` version is now [`2.2.0`](https://github.com/ruby-amqp/amq-protocol/blob/master/ChangeLog.md#changes-between-210-and-220-may-11th-2017) which includes
 a change in [how timestamps are encoded](https://github.com/ruby-amqp/amq-protocol/issues/64).
 
 

data/Gemfile

@@ -33,7 +33,7 @@ end
 
 group :test do
   gem "rspec", "~> 3.5.0"
-  gem "rabbitmq_http_api_client", "~> 1.8.0"
+  gem "rabbitmq_http_api_client", "~> 1.9.1"
 end
 
 gemspec

data/README.md

@@ -160,7 +160,7 @@ to also join the [RabbitMQ mailing list](https://groups.google.com/forum/#!forum
 
 ## Continuous Integration
 
-[![Build Status](https://travis-ci.org/ruby-amqp/bunny.png)](https://travis-ci.org/ruby-amqp/bunny/)
+[![Build Status](https://travis-ci.org/ruby-amqp/bunny.svg)](https://travis-ci.org/ruby-amqp/bunny/)
 
 
 ### News & Announcements on Twitter

data/lib/bunny/session.rb

@@ -89,7 +89,7 @@ module Bunny
     # @return [Integer] Timeout for blocking protocol operations (queue.declare, queue.bind, etc), in milliseconds. Default is 15000.
     attr_reader :continuation_timeout
     attr_reader :network_recovery_interval
-
+    attr_accessor :socket_configurator
 
     # @param [String, Hash] connection_string_or_opts Connection string or a hash of connection options
     # @param [Hash] optz Extra options not related to connection
@@ -1257,7 +1257,7 @@ module Bunny
 
     # @private
     def negotiate_value(client_value, server_value)
-      return server_value if client_value == :server
+      return server_value if [:server, "server"].include?(client_value)
 
       if client_value == 0 || server_value == 0
         [client_value, server_value].max

data/lib/bunny/transport.rb

@@ -233,17 +233,13 @@ module Bunny
     # Exposed primarily for Bunny::Channel
     # @private
     def read_next_frame(opts = {})
-      header    = read_fully(7)
-      # TODO: network issues here will sometimes cause
-      #       the socket method return an empty string. We need to log
-      #       and handle this better.
-      # type, channel, size = begin
-      #                         AMQ::Protocol::Frame.decode_header(header)
-      #                       rescue AMQ::Protocol::EmptyResponseError => e
-      #                         puts "Got AMQ::Protocol::EmptyResponseError, header is #{header.inspect}"
-      #                       end
+      header              = read_fully(7)
       type, channel, size = AMQ::Protocol::Frame.decode_header(header)
-      payload   = read_fully(size)
+      payload             = if size > 0
+                              read_fully(size)
+                            else
+                              ''
+                            end
       frame_end = read_fully(1)
 
       # 1) the size is miscalculated

data/lib/bunny/version.rb

@@ -2,5 +2,5 @@
 
 module Bunny
   # @return [String] Version of the library
-  VERSION = "2.7.1"
+  VERSION = "2.7.2"
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bunny
 version: !ruby/object:Gem::Version
-  version: 2.7.1
+  version: 2.7.2
 platform: ruby
 authors:
 - Chris Duncan
@@ -12,7 +12,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-09-24 00:00:00.000000000 Z
+date: 2017-11-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: amq-protocol