bunny 2.12.0 → 2.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 24b8d9a2421af8117f8f4f1d51949cc990823754e360efd718f7f4f3b9fa3564
-  data.tar.gz: 81757ab16c040ef1fdd69a9f602845c16e3d42725cbe229e0fa76c6bf9911376
+  metadata.gz: 1f6ae1527a8256fe3ca04baa753aae5548c9f139aa1b0e61b9050cc9494025ba
+  data.tar.gz: a7ab97f6fabc3a2c87756d21e6cba49654fef874025cf2e4666c2ed04a49d0c7
 SHA512:
-  metadata.gz: 4fa2762642da8b0a916832425605a11e76fd4451b3996eaa7a947a41161597f0353b3be7ba860ca86a63a35820356dccc6f3b050e24d5577b4ae1e53a55e2d17
-  data.tar.gz: 461ab750880c2767ddaea80927a0154b9ea7d6da5c15aec4a3ad0f1d2177ffb3e77fa89a92c106c61669376a9164cbd8e86fdc460c6780177f7f854b45773b49
+  metadata.gz: 8ecbda36d7c188f96ae54229c42d7b8258936c227742847a1eefc2b6b43da15714e803bf6c66bcd3fa561701a291a694ddaa8d982dd2756b95452db0fb3bb4f5
+  data.tar.gz: 47712973e6f513f4dcd476bf351c812ebf9568e85c0f8695b0fde923ecf5e2432a705d67639a6832745e2c5730f6a29a345545a62293e8242d475948ff0a10a4

data/ChangeLog.md

@@ -1,8 +1,25 @@
-## Changes between Bunny 2.12.0 and 2.13.0 (unreleased)
+## Changes between Bunny 2.12.1 and 2.12.2 (unreleased)
 
 No changes yet.
 
 
+## Changes between Bunny 2.12.0 and 2.12.1 (Dec 3rd, 2018)
+
+### More Defensive `Bunny::Channel` Method(s)
+
+`Bunny::Channel#queue` will now throw an `ArgumentError` if a `nil`
+is passed for queue name.
+
+GitHub issue: [#570](https://github.com/ruby-amqp/bunny/issues/570)
+
+### Correct Logging of Recovery Attempts Left
+
+During connection recovery, if `recover_attempts` is not set (is `nil`)
+connection could produce confusing log messages.
+
+GitHub issue: [#569](https://github.com/ruby-amqp/bunny/issues/569)
+
+
 ## Changes between Bunny 2.11.0 and 2.12.0 (Sep 22nd, 2018)
 
 ### More Defensive Treatment of `queue.declare-ok` Responses
@@ -41,6 +58,16 @@ GitHub issue: [#559](https://github.com/ruby-amqp/bunny/issues/559)
 
 Contributed by Scott Bonebraker.
 
+### Correct Connection State on Connections that Experienced Missed Heartbeat
+
+Connections that experienced connection closure did not always correctly transition to the closed state.
+`Bunny::ConnectionClosedError` will now be thrown when an operation is attempted on such
+connections.
+
+GitHub issue: [#561](https://github.com/ruby-amqp/bunny/issues/561)
+
+Contributed by Scott Bonebraker.
+
 ### Connection Recovery Will Fail When Max Retry Attempt Limit is Exceeded
 
 GitHub issue: [#549](https://github.com/ruby-amqp/bunny/issues/549)

data/Gemfile

@@ -35,7 +35,7 @@ end
 
 group :test do
   gem "rspec", "~> 3.5.0"
-  gem "rabbitmq_http_api_client", "~> 1.9.1", require: "rabbitmq/http/client"
+  gem "rabbitmq_http_api_client", "~> 1.10.0", require: "rabbitmq/http/client"
   gem "toxiproxy", "~> 1.0.3"
 end
 

data/lib/bunny/channel.rb

@@ -415,6 +415,8 @@ module Bunny
     # @see http://rubybunny.info/articles/extensions.html RabbitMQ Extensions guide
     # @api public
     def queue(name = AMQ::Protocol::EMPTY_STRING, opts = {})
+      throw ArgumentError.new("queue name must not be nil") if name.nil?
+
       q = find_queue(name) || Bunny::Queue.new(self, name, opts)
 
       register_queue(q)

data/lib/bunny/session.rb

@@ -772,8 +772,10 @@ module Bunny
 
     # @private
     def decrement_recovery_attemp_counter!
-      @recovery_attempts -= 1 if @recovery_attempts
-      @logger.debug "#{@recovery_attempts} recovery attempts left"
+      if @recovery_attempts
+        @recovery_attempts -= 1
+        @logger.debug "#{@recovery_attempts} recovery attempts left"
+      end
       @recovery_attempts
     end
 

data/lib/bunny/version.rb

@@ -2,5 +2,5 @@
 
 module Bunny
   # @return [String] Version of the library
-  VERSION = "2.12.0"
+  VERSION = "2.12.1"
 end

data/spec/higher_level_api/integration/queue_declare_spec.rb

@@ -36,7 +36,7 @@ describe Bunny::Queue do
   end
 
 
-  context "when queue name is passed on as an empty string" do
+  context "when queue name is passed as an empty string" do
     it "uses server-assigned queue name" do
       ch   = connection.create_channel
 
@@ -51,6 +51,17 @@ describe Bunny::Queue do
   end
 
 
+  context "when a nil is passed for queue name" do
+    it "throws an error" do
+      ch   = connection.create_channel
+
+      expect {
+        ch.queue(nil, durable: true, auto_delete: false)
+      }.to raise_error(ArgumentError)
+    end
+  end
+
+
   context "when queue is declared as durable" do
     it "declares it as durable" do
       ch   = connection.create_channel

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bunny
 version: !ruby/object:Gem::Version
-  version: 2.12.0
+  version: 2.12.1
 platform: ruby
 authors:
 - Chris Duncan
@@ -12,28 +12,28 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2018-09-22 00:00:00.000000000 Z
+date: 2018-12-03 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: amq-protocol
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - "~>"
-      - !ruby/object:Gem::Version
-        version: '2.3'
     - - ">="
       - !ruby/object:Gem::Version
         version: 2.3.0
+    - - "~>"
+      - !ruby/object:Gem::Version
+        version: '2.3'
 description: Easy to use, feature complete Ruby client for RabbitMQ 3.3 and later
   versions.
 email:
@@ -241,7 +241,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.7.7
+rubygems_version: 2.7.8
 signing_key: 
 specification_version: 4
 summary: Popular easy to use Ruby client for RabbitMQ