bundler 1.3.0.pre.6 → 1.3.0.pre.7

data/CHANGELOG.md

@@ -1,4 +1,11 @@
-## 1.3.0.pre.6 (January 22, 2013)
+## 1.3.0.pre.7 (22 January 2013)
+
+Bugfixes:
+
+  - stubs for gems with dev deps no longer cause exceptions (#2272)
+  - don't suggest binstubs to --binstubs users
+
+## 1.3.0.pre.6 (22 January 2013)
 
 Features:
 

data/lib/bundler/installer.rb

@@ -127,9 +127,9 @@ module Bundler
     end
 
     def generate_bundler_executable_stubs(spec, options = {})
-      if spec.executables.empty?
+      if options[:binstubs_cmd] && spec.executables.empty?
         options = {}
-        spec.dependencies.each do |dep|
+        spec.runtime_dependencies.each do |dep|
           bins = Bundler.definition.specs[dep].first.executables
           options[dep.name] = bins unless bins.empty?
         end
@@ -164,7 +164,7 @@ module Bundler
         end
       end
 
-      if options[:binstubs_cmd] && !exists.empty?
+      if options[:binstubs_cmd] && exists.any?
         case exists.size
         when 1
           Bundler.ui.warn "Skipped #{exists[0]} since it already exists."

data/lib/bundler/version.rb

@@ -2,5 +2,5 @@ module Bundler
   # We're doing this because we might write tests that deal
   # with other versions of bundler and we are unsure how to
   # handle this better.
-  VERSION = "1.3.0.pre.6" unless defined?(::Bundler::VERSION)
+  VERSION = "1.3.0.pre.7" unless defined?(::Bundler::VERSION)
 end

data/spec/other/binstubs_spec.rb

@@ -133,4 +133,37 @@ describe "bundle binstubs <gem>" do
       end
     end
   end
+
+  context "when the gem has no bins" do
+    it "suggests child gems if they have bins" do
+      install_gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "rack-obama"
+      G
+
+      bundle "binstubs rack-obama"
+      expect(out).to include('rack-obama has no executables')
+      expect(out).to include('rack has: rackup')
+    end
+
+    it "works if child gems don't have bins" do
+      install_gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "actionpack"
+      G
+
+      bundle "binstubs actionpack"
+      expect(out).to include('no executables for the gem actionpack')
+    end
+
+    it "works if the gem has development dependencies" do
+      install_gemfile <<-G
+        source "file://#{gem_repo1}"
+        gem "with_development_dependency"
+      G
+
+      bundle "binstubs with_development_dependency"
+      expect(out).to include('no executables for the gem with_development_dependency')
+    end
+  end
 end

metadata

@@ -7,8 +7,8 @@ version: !ruby/object:Gem::Version
   - 3
   - 0
   - pre
-  - 6
-  version: 1.3.0.pre.6
+  - 7
+  version: 1.3.0.pre.7
 platform: ruby
 authors: 
 - "Andr\xC3\xA9 Arko"