bundler-stats 1.3.1 → 1.3.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 4a041422eb6d86e13e5b062fe2d7bd309b282523f2804a9470d21754279ca18f
-  data.tar.gz: 84f4a87d5d2a5ba647f59fa98cca6cd7d505bcdfc403efa4445d6cf70f2db6b7
+  metadata.gz: 66d53289a79dd7b950987a512f6876f60f415862ab169c2b3fe935a4199b25c3
+  data.tar.gz: 130b1e1a7d84163bea7fa95802639e1078bb53c1176f1d7482c0168ff752e37e
 SHA512:
-  metadata.gz: 3bf9ea8589a762991695b6bae03d49f0af821fdc2a5db82fdcfdea17ef0cb8750458063cb3ccb5e3cff650ea5212ec194ff7280ddca0a2c29906983d0d3d7c58
-  data.tar.gz: 993b1a9bd53a7e6b34f460689f22717882ed764e11d4f73796fe0d883f2dbf46dc44b2d3f3062f292cba24701bd40e680d3de748e9c94c935dc5b206ce8d5a57
+  metadata.gz: 882690eb56bbbd2bd001703277cd499ddd2e13ce3376470ae5ff1f657a23425a86112acd6bb2d3fa54e9ad92d1c6ccb1adfcca1742ec0a7b821b519cf77c305f
+  data.tar.gz: 7f3dcd1216f8747c1f36bc4627017eebf94f7eb1f668eb8e923e56ed3975958861bf48ceb605004e7f368216de638e2a2065f100c8a52c422417ac6ef0c68063

data/lib/bundler/stats/remover.rb

@@ -1,41 +1,50 @@
-module Bundler
-  module Stats
-    class Remover
-      def initialize(tree, top_level)
-        @tree       = tree
-        @top_level  = top_level
-      end
-
-      def potential_removals(target)
-        candidates = @tree.transitive_dependencies(target)
-        candidates.reject do |candidate|
-          still_used?(candidate.name, deleted: target)
-        end
-      end
+class Bundler::Stats::Remover
+  ERR_MESSAGE = "Trying to check whether `%s` can be removed, but was unable " \
+    "to resolve whether it is used by `%s`. It may not be in your Gemfile.lock. " \
+    "This often happens when a dependency isn't installed on your platform."
+
+  def initialize(tree, top_level)
+    @tree       = tree
+    @top_level  = top_level
+  end
 
-      # TODO: woo naive algorithm
-      # TODO: circular dependencies would be an issue here
-      # TODO: also probably use something like transitive_dependencies
-      # to leverage the abilities in tree...
-      def still_used?(target, deleted: nil)
-        modified_tree = @tree.tree.clone
-        modified_tree.delete(deleted)
+  def potential_removals(target)
+    candidates = @tree.transitive_dependencies(target)
+    candidates.reject do |candidate|
+      still_used?(candidate.name, deleted: target)
+    end
+  end
 
-        deps_to_check = (@top_level - [Gem::Dependency.new(deleted)])
+  # TODO: woo naive algorithm
+  # TODO: circular dependencies would be an issue here
+  # TODO: also probably use something like transitive_dependencies
+  # to leverage the abilities in tree...
+  def still_used?(target, deleted: nil)
+    modified_tree = @tree.tree.clone
+    modified_tree.delete(deleted)
 
-        while !deps_to_check.empty? do
-          candidate = deps_to_check.pop.name
+    deps_to_check = (@top_level - [Gem::Dependency.new(deleted)])
 
-          next if candidate == deleted
-          next if candidate == "bundler"
-          return true if candidate == target
+    while !deps_to_check.empty? do
+      candidate = deps_to_check.pop.name
 
-          deps_to_check += modified_tree[candidate].dependencies
-        end
+      next if candidate == deleted
+      next if candidate == "bundler"
+      return true if candidate == target
 
-        false
+      if modified_tree[candidate].nil?
+        warn(ERR_MESSAGE % [target, candidate])
+      else
+        deps_to_check += modified_tree[candidate].dependencies
       end
     end
+
+    false
   end
-end
 
+  private
+
+  def warn(str)
+    STDERR.puts(str)
+  end
+end

data/lib/bundler/stats/version.rb

@@ -1,6 +1,5 @@
 module Bundler
   module Stats
-    # bundler-stats version
-    VERSION = '1.3.1'
+    VERSION = '1.3.2'
   end
 end

data/spec/lib/bundler/stats/remover_spec.rb

@@ -102,5 +102,15 @@ describe Bundler::Stats::Remover do
 
       expect(target).to be_falsy
     end
+
+    it "raises an error if the top level dependency isn't in the lockfile" do
+      top_level << dep("tzinfo")
+      remover = subject.new(tree, top_level)
+      allow(remover).to receive(:warn)
+
+      remover.still_used?("actionview", deleted: "rails")
+
+      expect(remover).to have_received(:warn)
+    end
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bundler-stats
 version: !ruby/object:Gem::Version
-  version: 1.3.1
+  version: 1.3.2
 platform: ruby
 authors:
 - Joseph Mastey
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2019-04-05 00:00:00.000000000 Z
+date: 2019-04-18 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: bundler