bummr 0.3.0 → 0.3.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 5df73cfbc224bf2570050b72be0b430dbaf46a5b
-  data.tar.gz: 9a214cc4a90355b571afc5434ecdce4dd9af97f9
+  metadata.gz: dfc66045a4cf51578172ac7c875574465d60b019
+  data.tar.gz: 343b2794e4c16c57b938a26a41aa256df41216c3
 SHA512:
-  metadata.gz: 7c54d619a641f855df4e08a3d52ceb8b2032f01e677760198d64fa607381be44faf9c6a390692f310a1b7a0ce3e4ab1ed353499059dc5478093879c946052e31
-  data.tar.gz: 580a3326329d240ab0fc917955421bb2595532a5c9ebaa580cd754f03b797a28c7b61f0f7e500035509b417a9165c90e3d254f87beeb72875966952b4cc1ec0b
+  metadata.gz: 36acc698fe92f04a82c4158bf7600a9453dc2235cbb58c4a125fd05280eaf8abc60d811d9c8f4675ad29df9b14a55f6043ade5c79842daae6c58c3000487ab37
+  data.tar.gz: e68e9a0212deeb3211904b8549b4e7be67d2eb657bc389faaf964e17c9c7519d007aecac6d848a1196c8eae736430b6dc5d733b630088098241dd6a2a2ceb063

data/README.md

@@ -63,6 +63,7 @@ instructions in the Installation section of this README.
 - Commits each gem update separately, with a commit message like:
 - Options:
   - `--all` to include indirect dependencies (`bummr` defaults to direct dependencies only)
+  - `--group` to update only gems from a specific group (i.e. `test`, `development`)
 
 `Update gemname from 0.0.1 to 0.0.2`
 

data/lib/bummr/cli.rb

@@ -12,6 +12,7 @@ module Bummr
 
     desc "update", "Update outdated gems, run tests, bisect if tests fail"
     method_option :all, type: :boolean, default: false
+    method_option :group, type: :string
     def update
       ask_questions
 
@@ -20,7 +21,9 @@ module Bummr
         log("Bummr update initiated #{Time.now}")
         system("bundle")
 
-        outdated_gems = Bummr::Outdated.instance.outdated_gems(all_gems: options[:all])
+        outdated_gems = Bummr::Outdated.instance.outdated_gems(
+          all_gems: options[:all], group: options[:group]
+        )
 
         if outdated_gems.empty?
           puts "No outdated gems to update".color(:green)
@@ -66,7 +69,7 @@ module Bummr
       puts "- Have a 'log' directory, where we can place logs"
       puts "- Have your build configured to fail fast (recommended)"
       puts "- Have locked any Gem version that you don't wish to update in your Gemfile"
-      puts "- It is recommended that you lock your versions of `ruby` and `rails in your Gemfile`"
+      puts "- It is recommended that you lock your versions of `ruby` and `rails` in your `Gemfile`"
       puts "Your test command is: '#{TEST_COMMAND}'"
     end
   end

data/lib/bummr/outdated.rb

@@ -5,18 +5,19 @@ module Bummr
   class Outdated
     include Singleton
 
-    def outdated_gems(all_gems: false)
+    def outdated_gems(options = {})
       results = []
 
-      options =  ""
-      options << " --strict" unless all_gems
+      bundle_options =  ""
+      bundle_options << " --strict" unless options[:all_gems]
+      bundle_options << " --group #{options[:group]}" if options[:group]
 
-      Open3.popen2("bundle outdated" + options) do |_std_in, std_out|
+      Open3.popen2("bundle outdated" + bundle_options) do |_std_in, std_out|
         while line = std_out.gets
           puts line
           gem = parse_gem_from(line)
 
-          if gem && (all_gems || gemfile_contains(gem[:name]))
+          if gem && (options[:all_gems] || gemfile_contains(gem[:name]))
             results.push gem
           end
         end

data/lib/bummr/version.rb

@@ -1,3 +1,3 @@
 module Bummr
-  VERSION = "0.3.0"
+  VERSION = "0.3.1"
 end

data/spec/lib/cli_spec.rb

@@ -25,6 +25,20 @@ describe Bummr::CLI do
     end
 
     context "when user agrees to move forward" do
+      def mock_bummr_standard_flow
+        updater = double
+        allow(updater).to receive(:update_gems)
+
+        expect(cli).to receive(:ask_questions)
+        expect(cli).to receive(:yes?).and_return(true)
+        expect(cli).to receive(:check)
+        expect(cli).to receive(:log)
+        expect(cli).to receive(:system).with("bundle")
+        expect(Bummr::Updater).to receive(:new).with(outdated_gems).and_return updater
+        expect(cli).to receive(:system).with("git rebase -i #{BASE_BRANCH}")
+        expect(cli).to receive(:test)
+      end
+
       context "and there are no outdated gems" do
         it "informs that there are no outdated gems" do
           allow_any_instance_of(Bummr::Outdated).to receive(:outdated_gems)
@@ -45,17 +59,8 @@ describe Bummr::CLI do
         it "calls 'update' on the updater" do
           allow_any_instance_of(Bummr::Outdated).to receive(:outdated_gems)
             .and_return outdated_gems
-          updater = double
-          allow(updater).to receive(:update_gems)
 
-          expect(cli).to receive(:ask_questions)
-          expect(cli).to receive(:yes?).and_return(true)
-          expect(cli).to receive(:check)
-          expect(cli).to receive(:log)
-          expect(cli).to receive(:system).with("bundle")
-          expect(Bummr::Updater).to receive(:new).with(outdated_gems).and_return updater
-          expect(cli).to receive(:system).with("git rebase -i #{BASE_BRANCH}")
-          expect(cli).to receive(:test)
+          mock_bummr_standard_flow
 
           cli.update
         end
@@ -66,20 +71,24 @@ describe Bummr::CLI do
           options[:all] = true
 
           expect_any_instance_of(Bummr::Outdated)
-            .to receive(:outdated_gems).with({ all_gems: true })
+            .to receive(:outdated_gems).with(hash_including({ all_gems: true }))
             .and_return outdated_gems
 
-          updater = double
-          allow(updater).to receive(:update_gems)
+          mock_bummr_standard_flow
 
-          expect(cli).to receive(:ask_questions)
-          expect(cli).to receive(:yes?).and_return(true)
-          expect(cli).to receive(:check)
-          expect(cli).to receive(:log)
-          expect(cli).to receive(:system).with("bundle")
-          expect(Bummr::Updater).to receive(:new).with(outdated_gems).and_return updater
-          expect(cli).to receive(:system).with("git rebase -i #{BASE_BRANCH}")
-          expect(cli).to receive(:test)
+          cli.update
+        end
+      end
+
+      describe "group option" do
+        it "requests only outdated gems from supplied be listed" do
+          options[:group] = 'test'
+
+          expect_any_instance_of(Bummr::Outdated)
+            .to receive(:outdated_gems).with(hash_including({ group: 'test' }))
+            .and_return outdated_gems
+
+          mock_bummr_standard_flow
 
           cli.update
         end

data/spec/lib/outdated_spec.rb

@@ -7,6 +7,7 @@ describe Bummr::Outdated do
     output += "  * devise (newest 4.1.1, installed 3.5.2) in group \"default\"\n"
     output += "  * rake (newest 11.1.2, installed 10.4.2)\n"
     output += "  * rails (newest 4.2.6, installed 4.2.5.1, requested ~> 4.2.0) in group \"default\"\n"
+    output += "  * spring (newest 4.2.6, installed 4.2.5.1, requested ~> 4.2.0) in group \"development\"\n"
     output += "  * indirect_dep (newest 1.0.0, installed 0.0.1)\n"
     StringIO.new(output)
   }
@@ -16,6 +17,7 @@ describe Bummr::Outdated do
     gemfile += "gem 'devise'\n"
     gemfile += "gem 'rake'\n"
     gemfile += "gem 'rails'\n"
+    gemfile += "gem 'spring', :group => :development\n"
     gemfile
   }
 
@@ -38,6 +40,10 @@ describe Bummr::Outdated do
       expect(result[2][:name]).to eq('rails')
       expect(result[2][:newest]).to eq('4.2.6')
       expect(result[2][:installed]).to eq('4.2.5.1')
+
+      expect(result[3][:name]).to eq('spring')
+      expect(result[3][:newest]).to eq('4.2.6')
+      expect(result[3][:installed]).to eq('4.2.5.1')
     end
 
     describe "all gems option" do
@@ -63,6 +69,40 @@ describe Bummr::Outdated do
         expect(gem_names).to_not include "indirect_dep"
       end
     end
+
+    describe "group option" do
+      let(:stdoutput_from_development_group) {
+        output = String.new
+        output += "  * spring (newest 4.2.6, installed 4.2.5.1, requested ~> 4.2.0)"
+        StringIO.new(output)
+      }
+
+      it "lists outdated gems only from supplied group" do
+        allow(Open3).to receive(:popen2)
+          .with("bundle outdated --strict --group development")
+          .and_yield(nil, stdoutput_from_development_group)
+
+        allow(Bummr::Outdated.instance).to receive(:gemfile).and_return gemfile
+
+        results = Bummr::Outdated.instance.outdated_gems(group: :development)
+        gem_names = results.map { |result| result[:name] }
+
+        expect(gem_names).to match_array ['spring']
+      end
+
+      it "defaults to all groups" do
+        allow(Open3).to receive(:popen2)
+          .with("bundle outdated --strict")
+          .and_yield(nil, stdoutput)
+
+        allow(Bummr::Outdated.instance).to receive(:gemfile).and_return gemfile
+
+        results = Bummr::Outdated.instance.outdated_gems
+        gem_names = results.map { |result| result[:name] }
+
+        expect(gem_names).to include 'devise', 'rake', 'rails', 'spring'
+      end
+    end
   end
 
   describe "#parse_gem_from" do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bummr
 version: !ruby/object:Gem::Version
-  version: 0.3.0
+  version: 0.3.1
 platform: ruby
 authors:
 - Lee Pender