bumbleworks 0.0.92 → 0.0.93

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0df99684fff68087775bfb18c85a3f7694ec3b48
-  data.tar.gz: c68565a77f17645225e9a2bd0db42aeb2662deef
+  metadata.gz: 3f902dbdee4b72458152553662a223f201f63f0c
+  data.tar.gz: f8f5690483301d7e49cd40f2c3105d95ad54cf8f
 SHA512:
-  metadata.gz: 5c343ac5331a98abc82b0f8215ffd7eee6064273a05f89d49eaa40a5130d032b21ef7c8cd72494da24e09c1790e1dac6f77b4a12eca54a9d8d0547d4fd19a169
-  data.tar.gz: 2d03b80893c9812932f43e67c322ac64f554bb6efd0c093d37659bcd6a71a613915ad5065ca58514b8a3ae848cc5e1fc10849ab1e17f3044525b47593f20afed
+  metadata.gz: dc5843ef1b0b19af4e4c56acef982dfb59b198415f2b20c2551181bf872688ee0a5c65fbfd3a444f961baf47daec5756c4fdcdd36271e532da6b353ace5023a1
+  data.tar.gz: e7a9d498569fe88c6c1d7c298d425959628530a5c26d38270f52acc68d3a33c1eabe50a0cf88db0759b2a361e3cfc60d0e0cd85b084aafde524577916098f4e7

data/README.md

@@ -1,5 +1,7 @@
 # Bumbleworks
 
+[![Gem Version](https://badge.fury.io/rb/bumbleworks.svg)](http://badge.fury.io/rb/bumbleworks) [![Build Status](https://travis-ci.org/bumbleworks/bumbleworks.svg)](https://travis-ci.org/bumbleworks/bumbleworks) [![Code Climate](https://codeclimate.com/github/bumbleworks/bumbleworks/badges/gpa.svg)](https://codeclimate.com/github/bumbleworks/bumbleworks) [![Dependency Status](https://gemnasium.com/bumbleworks/bumbleworks.svg)](https://gemnasium.com/bumbleworks/bumbleworks) [![Inline docs](http://inch-ci.org/github/bumbleworks/bumbleworks.svg?branch=master)](http://inch-ci.org/github/bumbleworks/bumbleworks)
+
 **NOTE**: This product is still pre-release, and implementation is *not* in sync with documentation yet - hence the pre-release version.  We'll follow [the Semantic Versioning Specification (Semver)](http://semver.org/), so you can assume anything at 0.x.x still has an unstable API.  But we *are* actively developing this.
 
 Bumbleworks is a gem that adds a workflow engine (via [ruote](http://github.com/jmettraux/ruote)) to your Ruby application, and adds tools for task authorization and locking.  It also establishes conventions for easily loading process definitions and registering participant classes based on configurable file locations.

data/lib/bumbleworks/entity.rb

@@ -1,5 +1,7 @@
 module Bumbleworks
   module Entity
+    class ProcessNotRegistered < StandardError; end
+
     def self.included(klass)
       unless Bumbleworks.entity_classes.include? klass
         Bumbleworks.entity_classes << klass
@@ -68,7 +70,9 @@ module Bumbleworks
     end
 
     def attribute_for_process_name(name)
-      self.class.processes[name][:attribute]
+      process_config = self.class.processes[name]
+      raise ProcessNotRegistered.new(name) unless process_config
+      process_config && process_config[:attribute]
     end
 
     def tasks(nickname = nil)

data/lib/bumbleworks/participants/storage_participant.rb

@@ -2,8 +2,16 @@ module Bumbleworks
   class StorageParticipant < ::Ruote::StorageParticipant
     def on_workitem
       return_value = super
-      Bumbleworks::Task.new(self[workitem.sid]).on_dispatch
+      trigger_on_dispatch
       return return_value
     end
+
+    def trigger_on_dispatch
+      Bumbleworks::Task.new(current_workitem).on_dispatch
+    end
+
+    def current_workitem
+      self[workitem.sid]
+    end
   end
 end

data/lib/bumbleworks/task.rb

@@ -124,7 +124,9 @@ module Bumbleworks
 
     # proceed workitem (saving changes to fields)
     def complete(metadata = {}, options = {})
-      raise NotCompletable.new(not_completable_error_message) unless completable?
+      unless completable? || options.fetch(:force, false)
+        raise NotCompletable.new(not_completable_error_message)
+      end
       with_hooks(:update, metadata, options) do
         with_hooks(:complete, metadata, options) do
           proceed_workitem

data/lib/bumbleworks/version.rb

@@ -1,3 +1,3 @@
 module Bumbleworks
-  VERSION = "0.0.92"
+  VERSION = "0.0.93"
 end

data/lib/bumbleworks/worker.rb

@@ -31,7 +31,7 @@ class Bumbleworks::Worker < Ruote::Worker
     def active_worker_states
       info.inject({}) { |hsh, info|
         id, state = info.id, info.state
-        unless info.state.nil? || info.in_stopped_state?
+        unless info.in_stopped_state?
           hsh[id] = state
         end
         hsh
@@ -60,10 +60,23 @@ class Bumbleworks::Worker < Ruote::Worker
       end
     end
 
+    def toggle_worker_state_enabled(switch)
+      unless [true, false].include?(switch)
+        raise ArgumentError, "Must call with true or false"
+      end
+      Bumbleworks.dashboard.context['worker_state_enabled'] = switch
+    end
+
+    def worker_state_enabled?
+      !!Bumbleworks.dashboard.context['worker_state_enabled']
+    end
+
     def with_worker_state_enabled
-      Bumbleworks.dashboard.context['worker_state_enabled'] = true
+      was_already_enabled = worker_state_enabled?
+      toggle_worker_state_enabled(true) unless was_already_enabled
       yield
-      Bumbleworks.dashboard.context['worker_state_enabled'] = false
+    ensure
+      toggle_worker_state_enabled(false) unless was_already_enabled
     end
 
     def control_document

data/spec/lib/bumbleworks/entity_spec.rb

@@ -212,7 +212,7 @@ describe Bumbleworks::Entity do
       entity = entity_class.new
       expect {
         entity.attribute_for_process_name(:the_punisher)
-      }.to raise_error
+      }.to raise_error(Bumbleworks::Entity::ProcessNotRegistered, "the_punisher")
     end
   end
 

data/spec/lib/bumbleworks/participants/storage_participant_spec.rb

@@ -0,0 +1,39 @@
+describe Bumbleworks::StorageParticipant do
+  let(:workitem) {
+    double(:sid => :storage_id, :to_h => {
+      'fei' => { 'wfid' => :the_workflow_id }
+    })
+  }
+  subject { described_class.new(Bumbleworks.dashboard.context) }
+
+  describe "#on_workitem" do
+    it "stores workitem and triggers on dispatch" do
+      expect(subject).to receive(:trigger_on_dispatch)
+      expect {
+        subject._on_workitem(workitem)
+      }.to change {
+        Bumbleworks.dashboard.context.storage.get_many("workitems").count
+      }.by(1)
+    end
+  end
+
+  describe "#trigger_on_dispatch" do
+    it "calls on_dispatch on a new Bumbleworks Task" do
+      allow(subject).to receive(:current_workitem).and_return(workitem)
+      new_task = double(Bumbleworks::Task)
+      expect(Bumbleworks::Task).to receive(:new).
+        with(workitem).
+        and_return(new_task)
+      expect(new_task).to receive(:on_dispatch)
+      subject.trigger_on_dispatch
+    end
+  end
+
+  describe "#current_workitem" do
+    it "reloads the workitem from the storage" do
+      allow(subject).to receive(:workitem).and_return(workitem)
+      allow(subject).to receive(:[]).with(:storage_id).and_return(:the_workitem)
+      expect(subject.current_workitem).to eq(:the_workitem)
+    end
+  end
+end

data/spec/lib/bumbleworks/process_definition_spec.rb

@@ -155,7 +155,7 @@ describe Bumbleworks::ProcessDefinition do
       })
       expect {
         described_class.create_all_from_directory!(definitions_path)
-      }.to raise_error
+      }.to raise_error(described_class::Invalid)
       expect(Bumbleworks.dashboard.variables['test_process']).to be_nil
       expect(Bumbleworks.dashboard.variables['keep_me']).to eq('top_secret_cat_pics')
     end

data/spec/lib/bumbleworks/process_spec.rb

@@ -422,7 +422,7 @@ describe Bumbleworks::Process do
       allow(bp).to receive_messages(:process_status => double('process status'))
       expect {
         bp.kerplunk!(:oh_no)
-      }.to raise_error
+      }.to raise_error(NoMethodError)
     end
   end
 end

data/spec/lib/bumbleworks/storage_adapter_spec.rb

@@ -25,13 +25,13 @@ describe Bumbleworks::StorageAdapter do
 
   describe '.storage_class' do
     it 'is a subclass responsibility' do
-      expect { described_class.storage_class }.to raise_error
+      expect { described_class.storage_class }.to raise_error(StandardError, "Subclass responsibility")
     end
   end
 
   describe '.driver' do
     it 'is a subclass responsibility' do
-      expect { described_class.driver }.to raise_error
+      expect { described_class.driver }.to raise_error(StandardError, "Subclass responsibility")
     end
   end
 

data/spec/lib/bumbleworks/task_spec.rb

@@ -1,8 +1,10 @@
 describe Bumbleworks::Task do
+  subject { described_class.new(workflow_item) }
+
   let(:workflow_item) {
     Ruote::Workitem.new({
       'fields' => {
-        'params' => {'task' => 'go_to_work'},
+        'params' => {'task' => 'go_to_work', 'claimant' => 'employee'},
         'dispatched_at' => 'some time ago'
       }
     })
@@ -19,7 +21,6 @@ describe Bumbleworks::Task do
   end
 
   it_behaves_like "comparable" do
-    subject { described_class.new(workflow_item) }
     let(:other) { described_class.new(workflow_item) }
     before(:each) do
       allow(workflow_item).to receive(:sid).and_return('blah-123-blah')
@@ -61,14 +62,13 @@ describe Bumbleworks::Task do
 
   describe '#dispatched_at' do
     it 'returns dispatched_at timestamp from workitem' do
-      task = described_class.new(workflow_item)
-      expect(task.dispatched_at).to eq 'some time ago'
+      expect(subject.dispatched_at).to eq 'some time ago'
     end
   end
 
   describe '#completable?' do
     it 'defaults to true on base task' do
-      expect(described_class.new(workflow_item)).to be_completable
+      expect(subject).to be_completable
     end
   end
 
@@ -99,12 +99,11 @@ describe Bumbleworks::Task do
 
   describe '#reload' do
     it 'reloads the workitem from the storage participant' do
-      task = described_class.new(workflow_item)
-      allow(task).to receive(:sid).and_return(:the_sid)
+      allow(subject).to receive(:sid).and_return(:the_sid)
       expect(Bumbleworks.dashboard.storage_participant).to receive(
         :[]).with(:the_sid).and_return(:amazing_workitem)
-      task.reload
-      expect(task.instance_variable_get(:@workitem)).to eq(:amazing_workitem)
+      subject.reload
+      expect(subject.instance_variable_get(:@workitem)).to eq(:amazing_workitem)
     end
   end
 
@@ -113,89 +112,84 @@ describe Bumbleworks::Task do
       it "calls #{phase} hooks on task and all observers" do
         observer1, observer2 = double('observer1'), double('observer2')
         Bumbleworks.observers = [observer1, observer2]
-        task = described_class.new(workflow_item)
-        expect(task).to receive(:"#{phase}_snoogle").with(:chachunga, :faloop)
+        expect(subject).to receive(:"#{phase}_snoogle").with(:chachunga, :faloop)
         expect(observer1).to receive(:"#{phase}_snoogle").with(:chachunga, :faloop)
         expect(observer2).to receive(:"#{phase}_snoogle").with(:chachunga, :faloop)
-        task.send(:"call_#{phase}_hooks", :snoogle, :chachunga, :faloop)
+        subject.send(:"call_#{phase}_hooks", :snoogle, :chachunga, :faloop)
       end
     end
   end
 
-  describe '#on_dispatch' do
-    before :each do
-      Bumbleworks.define_process 'planting_a_noodle' do
-        concurrence do
-          horse_feeder :task => 'give_the_horse_a_bon_bon'
-        end
-      end
-    end
-
-    it 'is called when task is dispatched' do
-      expect_any_instance_of(described_class).to receive(:on_dispatch)
-      Bumbleworks.launch!('planting_a_noodle')
-      Bumbleworks.dashboard.wait_for(:horse_feeder)
+  describe "#log" do
+    it "creates a log entry with information from the task" do
+      allow(subject).to receive(:id).and_return(:the_id)
+      expect(Bumbleworks.logger).to receive(:info).with({
+        :actor => "employee",
+        :action => :did_a_thing,
+        :target_type => "Task",
+        :target_id => :the_id,
+        :metadata => {
+          :extra_stuff => "nothing special",
+          :current_fields => {
+            "params" => { "task" => "go_to_work", "claimant" => "employee" },
+            "dispatched_at" => "some time ago"
+          }
+        }
+      })
+      subject.log(:did_a_thing, :extra_stuff => "nothing special")
     end
+  end
 
+  describe '#on_dispatch' do
     it 'logs dispatch' do
-      Bumbleworks.launch!('planting_a_noodle')
-      Bumbleworks.dashboard.wait_for(:horse_feeder)
-      task = described_class.for_role('horse_feeder').first
-      log_entry = Bumbleworks.logger.entries.last[:entry]
-      expect(log_entry[:action]).to eq(:dispatch)
-      expect(log_entry[:target_type]).to eq('Task')
-      expect(log_entry[:target_id]).to eq(task.id)
+      expect(subject).to receive(:log).with(:dispatch)
+      subject.on_dispatch
     end
 
     it 'calls after hooks' do
-      task = described_class.new(workflow_item)
-      allow(task).to receive(:log)
-      expect(task).to receive(:call_after_hooks).with(:dispatch)
-      task.on_dispatch
+      allow(subject).to receive(:log)
+      expect(subject).to receive(:call_after_hooks).with(:dispatch)
+      subject.on_dispatch
     end
   end
 
   describe '#extend_module' do
     it 'extends with base module and task module' do
-      task = described_class.new(workflow_item)
-      expect(task).to receive(:task_module).and_return(:task_module_double)
-      expect(task).to receive(:extend).with(Bumbleworks::Task::Base).ordered
-      expect(task).to receive(:extend).with(:task_module_double).ordered
-      task.extend_module
+      expect(subject).to receive(:task_module).and_return(:task_module_double)
+      expect(subject).to receive(:extend).with(Bumbleworks::Task::Base).ordered
+      expect(subject).to receive(:extend).with(:task_module_double).ordered
+      subject.extend_module
     end
 
     it 'extends only with base module if no nickname' do
-      task = described_class.new(workflow_item)
-      allow(task).to receive(:nickname).and_return(nil)
-      expect(task).to receive(:extend).with(Bumbleworks::Task::Base)
-      task.extend_module
+      allow(subject).to receive(:nickname).and_return(nil)
+      expect(subject).to receive(:extend).with(Bumbleworks::Task::Base)
+      subject.extend_module
     end
 
     it 'extends only with base module if task module does not exist' do
-      task = described_class.new(workflow_item)
-      expect(task).to receive(:extend).with(Bumbleworks::Task::Base)
-      task.extend_module
+      expect(subject).to receive(:extend).with(Bumbleworks::Task::Base)
+      subject.extend_module
     end
   end
 
   describe '#task_module' do
     it 'returns nil if no nickname' do
-      task = described_class.new(workflow_item)
-      allow(task).to receive(:nickname).and_return(nil)
-      expect(task.task_module).to be_nil
+      allow(subject).to receive(:nickname).and_return(nil)
+      expect(subject.task_module).to be_nil
     end
 
     it 'returns constantized task nickname with "Task" appended' do
-      task = described_class.new(workflow_item)
+      subject
       allow(Bumbleworks::Support).to receive(:constantize).with("GoToWorkTask").and_return(:the_task_module)
-      expect(task.task_module).to eq(:the_task_module)
+      expect(subject.task_module).to eq(:the_task_module)
     end
   end
 
   describe '#id' do
     it 'returns the sid from the workitem' do
       allow(workflow_item).to receive(:sid).and_return(:an_exciting_id)
-      expect(described_class.new(workflow_item).id).to eq(:an_exciting_id)
+      expect(subject.id).to eq(:an_exciting_id)
     end
   end
 
@@ -620,7 +614,6 @@ describe Bumbleworks::Task do
   end
 
   describe '#[], #[]=' do
-    subject{described_class.new(workflow_item)}
     it 'sets values on workitem fields' do
       subject['hive'] = 'bees at work'
       expect(workflow_item.fields['hive']).to eq('bees at work')
@@ -634,14 +627,13 @@ describe Bumbleworks::Task do
 
   describe '#nickname' do
     it 'returns the "task" param' do
-      expect(described_class.new(workflow_item).nickname).to eq('go_to_work')
+      expect(subject.nickname).to eq('go_to_work')
     end
 
     it 'is immutable; cannot be changed by modifying the param' do
-      task = described_class.new(workflow_item)
-      expect(task.nickname).to eq('go_to_work')
-      task.params['task'] = 'what_is_wrong_with_you?'
-      expect(task.nickname).to eq('go_to_work')
+      expect(subject.nickname).to eq('go_to_work')
+      subject.params['task'] = 'what_is_wrong_with_you?'
+      expect(subject.nickname).to eq('go_to_work')
     end
   end
 
@@ -779,27 +771,25 @@ describe Bumbleworks::Task do
       end
 
       it 'calls before_claim and after_claim callbacks' do
-        task = described_class.new(workflow_item)
-        allow(task).to receive(:log)
-        expect(task).to receive(:before_claim).with(:doctor_claim).ordered
-        expect(task).to receive(:set_claimant).ordered
-        expect(task).to receive(:after_claim).with(:doctor_claim).ordered
-        task.claim(:doctor_claim)
+        allow(subject).to receive(:log)
+        expect(subject).to receive(:before_claim).with(:doctor_claim).ordered
+        expect(subject).to receive(:set_claimant).ordered
+        expect(subject).to receive(:after_claim).with(:doctor_claim).ordered
+        subject.claim(:doctor_claim)
       end
 
       it 'skips callbacks if requested' do
-        task = described_class.new(workflow_item)
-        allow(task).to receive(:log)
-        expect(task).to receive(:before_claim).never
-        expect(task).to receive(:set_claimant)
-        expect(task).to receive(:after_claim).never
-        task.claim(:doctor_claim, :skip_callbacks => true)
+        allow(subject).to receive(:log)
+        expect(subject).to receive(:before_claim).never
+        expect(subject).to receive(:set_claimant)
+        expect(subject).to receive(:after_claim).never
+        subject.claim(:doctor_claim, :skip_callbacks => true)
       end
 
       it 'logs event' do
-        log_entry = Bumbleworks.logger.entries.last[:entry]
-        expect(log_entry[:action]).to eq(:claim)
-        expect(log_entry[:actor]).to eq('boss')
+        @task.release
+        expect(@task).to receive(:log).with(:claim)
+        @task.claim(:whatever)
       end
     end
 
@@ -853,10 +843,8 @@ describe Bumbleworks::Task do
       end
 
       it 'logs event' do
+        expect(@task).to receive(:log).with(:release)
         @task.release
-        log_entry = Bumbleworks.logger.entries.last[:entry]
-        expect(log_entry[:action]).to eq(:release)
-        expect(log_entry[:actor]).to eq('boss')
       end
     end
   end
@@ -883,21 +871,19 @@ describe Bumbleworks::Task do
       end
 
       it 'calls with hooks' do
-        task = described_class.new(workflow_item)
-        allow(task).to receive(:log)
-        expect(task).to receive(:call_before_hooks).with(:update, :argue_mints).ordered
-        expect(task).to receive(:update_workitem).ordered
-        expect(task).to receive(:call_after_hooks).with(:update, :argue_mints).ordered
-        task.update(:argue_mints)
+        allow(subject).to receive(:log)
+        expect(subject).to receive(:call_before_hooks).with(:update, :argue_mints).ordered
+        expect(subject).to receive(:update_workitem).ordered
+        expect(subject).to receive(:call_after_hooks).with(:update, :argue_mints).ordered
+        subject.update(:argue_mints)
       end
 
       it 'skips callbacks if requested' do
-        task = described_class.new(workflow_item)
-        allow(task).to receive(:log)
-        expect(task).to receive(:call_before_hooks).never
-        expect(task).to receive(:update_workitem)
-        expect(task).to receive(:call_after_hooks).never
-        task.update({:actual => :params}, {:skip_callbacks => true})
+        allow(subject).to receive(:log)
+        expect(subject).to receive(:call_before_hooks).never
+        expect(subject).to receive(:update_workitem)
+        expect(subject).to receive(:call_after_hooks).never
+        subject.update({:actual => :params}, {:skip_callbacks => true})
       end
 
       it 'reloads after updating workitem' do
@@ -913,19 +899,8 @@ describe Bumbleworks::Task do
         event = Bumbleworks.dashboard.wait_for :dog_mouth
         task = described_class.for_role('dog_mouth').first
         task.params['claimant'] = :some_user
+        expect(task).to receive(:log).with(:update, :extra_data => :fancy)
         task.update(:extra_data => :fancy)
-        expect(Bumbleworks.logger.entries.last).to eq({
-          :level => :info, :entry => {
-            :actor => "some_user", # claimant is a string after #reload
-            :action => :update,
-            :target_type => 'Task',
-            :target_id => task.id,
-            :metadata => {
-              :extra_data => :fancy,
-              :current_fields => task.fields
-            }
-          }
-        })
       end
     end
 
@@ -959,43 +934,38 @@ describe Bumbleworks::Task do
         expect(described_class.for_role('dog_mouth')).not_to be_empty
       end
 
+      it 'allows completion for non-completable tasks if given force option' do
+        event = Bumbleworks.dashboard.wait_for :dog_mouth
+        task = described_class.for_role('dog_mouth').first
+        allow(task).to receive(:completable?).and_return(false)
+        expect(task).to receive(:proceed_workitem)
+        task.complete({:actual => :params}, {:force => true})
+      end
+
       it 'calls update and complete callbacks' do
-        task = described_class.new(workflow_item)
-        allow(task).to receive(:log)
-        expect(task).to receive(:call_before_hooks).with(:update, :argue_mints).ordered
-        expect(task).to receive(:call_before_hooks).with(:complete, :argue_mints).ordered
-        expect(task).to receive(:proceed_workitem).ordered
-        expect(task).to receive(:call_after_hooks).with(:complete, :argue_mints).ordered
-        expect(task).to receive(:call_after_hooks).with(:update, :argue_mints).ordered
-        task.complete(:argue_mints)
+        allow(subject).to receive(:log)
+        expect(subject).to receive(:call_before_hooks).with(:update, :argue_mints).ordered
+        expect(subject).to receive(:call_before_hooks).with(:complete, :argue_mints).ordered
+        expect(subject).to receive(:proceed_workitem).ordered
+        expect(subject).to receive(:call_after_hooks).with(:complete, :argue_mints).ordered
+        expect(subject).to receive(:call_after_hooks).with(:update, :argue_mints).ordered
+        subject.complete(:argue_mints)
       end
 
       it 'skips callbacks if requested' do
-        task = described_class.new(workflow_item)
-        allow(task).to receive(:log)
-        expect(task).to receive(:call_before_hooks).never
-        expect(task).to receive(:proceed_workitem)
-        expect(task).to receive(:call_after_hooks).never
-        task.complete({:actual => :params}, {:skip_callbacks => true})
+        allow(subject).to receive(:log)
+        expect(subject).to receive(:call_before_hooks).never
+        expect(subject).to receive(:proceed_workitem)
+        expect(subject).to receive(:call_after_hooks).never
+        subject.complete({:actual => :params}, {:skip_callbacks => true})
       end
 
       it 'logs event' do
         event = Bumbleworks.dashboard.wait_for :dog_mouth
         task = described_class.for_role('dog_mouth').first
         task.params['claimant'] = :some_user
+        expect(task).to receive(:log).with(:complete, :extra_data => :fancy)
         task.complete(:extra_data => :fancy)
-        expect(Bumbleworks.logger.entries.last).to eq({
-          :level => :info, :entry => {
-            :actor => :some_user,
-            :action => :complete,
-            :target_type => 'Task',
-            :target_id => task.id,
-            :metadata => {
-              :extra_data => :fancy,
-              :current_fields => task.fields
-            }
-          }
-        })
       end
     end
   end
@@ -1080,7 +1050,7 @@ describe Bumbleworks::Task do
     it 'falls back to method missing if no finder method' do
       expect {
         described_class.kerplunk!(:oh_no)
-      }.to raise_error
+      }.to raise_error(NoMethodError)
     end
   end
 
@@ -1122,64 +1092,55 @@ describe Bumbleworks::Task do
 
   describe '#humanize' do
     it "returns humanized version of task name when no entity" do
-      task = described_class.new(workflow_item)
-      expect(task.humanize).to eq('Go to work')
+      expect(subject.humanize).to eq('Go to work')
     end
 
     it "returns humanized version of task name with entity" do
-      task = described_class.new(workflow_item)
-      task[:entity_id] = '45'
-      task[:entity_type] = 'RhubarbSandwich'
-      expect(task.humanize).to eq('Go to work: Rhubarb sandwich 45')
+      subject[:entity_id] = '45'
+      subject[:entity_type] = 'RhubarbSandwich'
+      expect(subject.humanize).to eq('Go to work: Rhubarb sandwich 45')
     end
 
     it "returns humanized version of task name without entity if requested" do
-      task = described_class.new(workflow_item)
-      task[:entity_id] = '45'
-      task[:entity_type] = 'RhubarbSandwich'
-      expect(task.humanize(:entity => false)).to eq('Go to work')
+      subject[:entity_id] = '45'
+      subject[:entity_type] = 'RhubarbSandwich'
+      expect(subject.humanize(:entity => false)).to eq('Go to work')
     end
   end
 
   describe '#to_s' do
     it "is aliased to #titleize" do
-      task = described_class.new(workflow_item)
-      allow(task).to receive(:titleize).with(:the_args).and_return(:see_i_told_you_so)
-      expect(task.to_s(:the_args)).to eq(:see_i_told_you_so)
+      allow(subject).to receive(:titleize).with(:the_args).and_return(:see_i_told_you_so)
+      expect(subject.to_s(:the_args)).to eq(:see_i_told_you_so)
     end
   end
 
   describe '#titleize' do
     it "returns titleized version of task name when no entity" do
-      task = described_class.new(workflow_item)
-      expect(task.titleize).to eq('Go To Work')
+      expect(subject.titleize).to eq('Go To Work')
     end
 
     it "returns titleized version of task name with entity" do
-      task = described_class.new(workflow_item)
-      task[:entity_id] = '45'
-      task[:entity_type] = 'RhubarbSandwich'
-      expect(task.titleize).to eq('Go To Work: Rhubarb Sandwich 45')
+      subject[:entity_id] = '45'
+      subject[:entity_type] = 'RhubarbSandwich'
+      expect(subject.titleize).to eq('Go To Work: Rhubarb Sandwich 45')
     end
 
     it "returns titleized version of task name without entity if requested" do
-      task = described_class.new(workflow_item)
-      task[:entity_id] = '45'
-      task[:entity_type] = 'RhubarbSandwich'
-      expect(task.titleize(:entity => false)).to eq('Go To Work')
+      subject[:entity_id] = '45'
+      subject[:entity_type] = 'RhubarbSandwich'
+      expect(subject.titleize(:entity => false)).to eq('Go To Work')
     end
   end
 
   describe '#temporary_storage' do
     it 'returns an empty hash by default' do
-      task = described_class.new(workflow_item)
-      expect(task.temporary_storage).to eq({})
+      expect(subject.temporary_storage).to eq({})
     end
 
     it 'persists stored values' do
-      task = described_class.new(workflow_item)
-      task.temporary_storage[:foo] = :bar
-      expect(task.temporary_storage[:foo]).to eq(:bar)
+      subject.temporary_storage[:foo] = :bar
+      expect(subject.temporary_storage[:foo]).to eq(:bar)
     end
   end
 

data/spec/lib/bumbleworks/worker/info_spec.rb

@@ -202,6 +202,11 @@ describe Bumbleworks::Worker::Info do
       allow(subject).to receive(:updated_at).and_return(frozen_time - 3)
       expect(subject).not_to be_updated_since(frozen_time - 2)
     end
+
+    it "returns true if updated_at same as given time" do
+      allow(subject).to receive(:updated_at).and_return(frozen_time - 3)
+      expect(subject).to be_updated_since(frozen_time - 3)
+    end
   end
 
   describe "#updated_recently?" do

data/spec/lib/bumbleworks/worker_spec.rb

@@ -73,6 +73,25 @@ describe Bumbleworks::Worker do
           described_class.refresh_worker_info
         }.not_to raise_error
       end
+
+      it 'return worker state enabled setting to off' do
+        expect(described_class.worker_state_enabled?).to eq(false)
+        described_class.refresh_worker_info
+        expect(described_class.worker_state_enabled?).to eq(false)
+      end
+
+      context "when worker state enabled setting is already on" do
+        after(:each) do
+          described_class.toggle_worker_state_enabled(false)
+        end
+
+        it 'leaves setting on' do
+          described_class.toggle_worker_state_enabled(true)
+          expect(described_class.worker_state_enabled?).to eq(true)
+          described_class.refresh_worker_info
+          expect(described_class.worker_state_enabled?).to eq(true)
+        end
+      end
     end
 
     describe '.change_worker_state' do
@@ -106,6 +125,41 @@ describe Bumbleworks::Worker do
           described_class.change_worker_state('paused')
         }.not_to raise_error
       end
+
+      it 'return worker state enabled setting to off' do
+        expect(described_class.worker_state_enabled?).to eq(false)
+        described_class.change_worker_state('paused')
+        expect(described_class.worker_state_enabled?).to eq(false)
+      end
+
+      context "when worker state enabled setting is already on" do
+        after(:each) do
+          described_class.toggle_worker_state_enabled(false)
+        end
+
+        it 'leaves setting on' do
+          described_class.toggle_worker_state_enabled(true)
+          expect(described_class.worker_state_enabled?).to eq(true)
+          described_class.change_worker_state('paused')
+          expect(described_class.worker_state_enabled?).to eq(true)
+        end
+      end
+    end
+  end
+
+  describe ".toggle_worker_state_enabled" do
+    it "turns on or off worker_state_enabled setting" do
+      expect(described_class.worker_state_enabled?).to eq(false)
+      described_class.toggle_worker_state_enabled(true)
+      expect(described_class.worker_state_enabled?).to eq(true)
+      described_class.toggle_worker_state_enabled(false)
+      expect(described_class.worker_state_enabled?).to eq(false)
+    end
+
+    it "raises exception if given non-Boolean argument" do
+      expect {
+        described_class.toggle_worker_state_enabled(:horse)
+      }.to raise_error(ArgumentError)
     end
   end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bumbleworks
 version: !ruby/object:Gem::Version
-  version: 0.0.92
+  version: 0.0.93
 platform: ruby
 authors:
 - Maher Hawash
@@ -11,7 +11,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2015-05-06 00:00:00.000000000 Z
+date: 2015-09-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: ruote
@@ -219,11 +219,12 @@ files:
 - spec/lib/bumbleworks/error_logger_spec.rb
 - spec/lib/bumbleworks/expression_spec.rb
 - spec/lib/bumbleworks/hash_storage_spec.rb
-- spec/lib/bumbleworks/participant/base_spec.rb
-- spec/lib/bumbleworks/participant/entity_interactor_spec.rb
-- spec/lib/bumbleworks/participant/error_dispatcher_spec.rb
-- spec/lib/bumbleworks/participant/local_participant_spec.rb
 - spec/lib/bumbleworks/participant_registration_spec.rb
+- spec/lib/bumbleworks/participants/base_spec.rb
+- spec/lib/bumbleworks/participants/entity_interactor_spec.rb
+- spec/lib/bumbleworks/participants/error_dispatcher_spec.rb
+- spec/lib/bumbleworks/participants/local_participant_spec.rb
+- spec/lib/bumbleworks/participants/storage_participant_spec.rb
 - spec/lib/bumbleworks/process/error_record_spec.rb
 - spec/lib/bumbleworks/process_definition_spec.rb
 - spec/lib/bumbleworks/process_spec.rb
@@ -308,11 +309,12 @@ test_files:
 - spec/lib/bumbleworks/error_logger_spec.rb
 - spec/lib/bumbleworks/expression_spec.rb
 - spec/lib/bumbleworks/hash_storage_spec.rb
-- spec/lib/bumbleworks/participant/base_spec.rb
-- spec/lib/bumbleworks/participant/entity_interactor_spec.rb
-- spec/lib/bumbleworks/participant/error_dispatcher_spec.rb
-- spec/lib/bumbleworks/participant/local_participant_spec.rb
 - spec/lib/bumbleworks/participant_registration_spec.rb
+- spec/lib/bumbleworks/participants/base_spec.rb
+- spec/lib/bumbleworks/participants/entity_interactor_spec.rb
+- spec/lib/bumbleworks/participants/error_dispatcher_spec.rb
+- spec/lib/bumbleworks/participants/local_participant_spec.rb
+- spec/lib/bumbleworks/participants/storage_participant_spec.rb
 - spec/lib/bumbleworks/process/error_record_spec.rb
 - spec/lib/bumbleworks/process_definition_spec.rb
 - spec/lib/bumbleworks/process_spec.rb