bumbleworks 0.0.85 → 0.0.86

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 47d3d5c9dcf82c6040641bd3fc2ebad001223025
-  data.tar.gz: 581a2b5a3a244221f42dcb06c87c24fcb1323468
+  metadata.gz: 803b0ca4b01ae7606eb47ce6c2037656f7d92564
+  data.tar.gz: e5fa78cad9e93b529310cfd7df343cca83026061
 SHA512:
-  metadata.gz: df6d711ecdc07505a85c028b40f329c0ec3a279a87b2a897e21e9ed64751c5526cd625333e1020f534c941d2b28297f6a93e857d10f6f4d6c7b4a571f5fccd2c
-  data.tar.gz: 9d1448f9ae21f784d24aca0b710c541905ac5db8d97326197558c365bd591bf7e21d4d4b098577e2b241da172cc9bb001d1be95e6d7762519f077386ee60e0ac
+  metadata.gz: 4f5e0d79e475abb6cdde5a7e77f494804f81623a98dd9b09a1f5275b0a4ebe7e0da3e19d967117a595b8716577ea607951f4d7d5f31cee8978368fd9ab3f8d94
+  data.tar.gz: 4c7d72432405cdf5c44da24b09888436865a1a2ef7db212501cff7099b0e0425f767ab0e36d3b0034ef4b0c75544a116e73c69acd107b90bf1805b52337a9744

data/lib/bumbleworks/expression.rb

@@ -16,6 +16,7 @@ module Bumbleworks
     end
 
     def ==(other)
+      return false unless other.is_a?(self.class)
       @fei == other.fei
     end
 

data/lib/bumbleworks/process.rb

@@ -47,14 +47,14 @@ module Bumbleworks
     alias_method :wfid, :id
 
     def <=>(other)
-      unless other.respond_to?(:wfid)
+      unless other.is_a?(self.class)
         raise ArgumentError, "comparison of Bumbleworks::Process with #{other.class} failed"
       end
       wfid <=> other.wfid
     end
 
     def ==(other)
-      return false unless other.respond_to?(:wfid)
+      return false unless other.is_a?(self.class)
       wfid == other.wfid
     end
 

data/lib/bumbleworks/schedule.rb

@@ -20,6 +20,7 @@ module Bumbleworks
     end
 
     def ==(other)
+      return false unless other.is_a?(self.class)
       @id == other.id
     end
 

data/lib/bumbleworks/version.rb

@@ -1,3 +1,3 @@
 module Bumbleworks
-  VERSION = "0.0.85"
+  VERSION = "0.0.86"
 end

data/lib/bumbleworks/workitem.rb

@@ -7,6 +7,7 @@ module Bumbleworks
     end
 
     def ==(other)
+      return false unless other.is_a?(self.class)
       raw_workitem == other.raw_workitem
     end
 

data/spec/lib/bumbleworks/expression_spec.rb

@@ -23,6 +23,12 @@ describe Bumbleworks::Expression do
       exp2 = described_class.new(double('FlowExpression', :fei => double(:expid => '4')))
       expect(exp1).not_to eq(exp2)
     end
+
+    it 'returns false if other object has is not an expression' do
+      exp1 = described_class.new(fexp)
+      exp2 = double('not an expression')
+      expect(exp1).not_to eq(exp2)
+    end
   end
 
   describe '#expid' do

data/spec/lib/bumbleworks/process_spec.rb

@@ -357,10 +357,9 @@ describe Bumbleworks::Process do
       expect(bp1).to eq(bp2)
     end
 
-    it 'returns false if other object does not respond to wfid' do
+    it 'returns false if other object is not a process' do
       bp1 = described_class.new('in_da_sky')
       bp2 = double('not a process')
-      allow(bp2).to receive(:respond_to?).with(:wfid).and_return(false)
       expect(bp1).not_to eq(bp2)
     end
   end
@@ -375,10 +374,9 @@ describe Bumbleworks::Process do
       expect(bp3 <=> bp1).to eq 0
     end
 
-    it 'raises ArgumentError if other object does not respond to wfid' do
+    it 'raises ArgumentError if other object is not a process' do
       bp1 = described_class.new('in_da_sky')
       bp2 = double('not a process')
-      allow(bp2).to receive(:respond_to?).with(:wfid).and_return(false)
       expect { bp1 <=> bp2 }.to raise_error(ArgumentError, "comparison of Bumbleworks::Process with RSpec::Mocks::Double failed")
     end
   end

data/spec/lib/bumbleworks/schedule_spec.rb

@@ -45,6 +45,12 @@ describe Bumbleworks::Schedule do
       schedule2 = described_class.new({ '_id' => 'snooglebunk', 'yeah' => 'whatevs' })
       expect(schedule1).not_to eq(schedule2)
     end
+
+    it 'returns false if other object is not a schedule' do
+      schedule1 = described_class.new({ '_id' => 'snaggletooth', 'who' => 'cares' })
+      schedule2 = double('not a schedule')
+      expect(schedule1).not_to eq(schedule2)
+    end
   end
 
   describe '#wfid' do

data/spec/lib/bumbleworks/workitem_spec.rb

@@ -10,6 +10,12 @@ describe Bumbleworks::Workitem do
       bw2 = described_class.new('in_da_sky')
       expect(bw1).to eq(bw2)
     end
+
+    it 'returns false if other object is not a workitem' do
+      bw1 = described_class.new('in_da_sky')
+      bw2 = double('not a workitem')
+      expect(bw1).not_to eq(bw2)
+    end
   end
 
   describe '#has_entity_fields?' do

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bumbleworks
 version: !ruby/object:Gem::Version
-  version: 0.0.85
+  version: 0.0.86
 platform: ruby
 authors:
 - Maher Hawash