bullet_train 1.3.22 → 1.3.23

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 347c8bc91b3b401f88551f4e20464258313548a54bbcfc8568088cfb3eea401b
-  data.tar.gz: f12fd053f264a5cd60c9789195cd0ced4b171febfa96bfbdd2bf3b020fec6241
+  metadata.gz: 69fb638be13d9c3fbdba294e923647b5fb0829f91310cd6b074392a9cccdb1b9
+  data.tar.gz: 5a04389c3d325a38daade6b53ddd76da939c2fd1600d431954c054da346aafc3
 SHA512:
-  metadata.gz: e86a8f1861ee560b385397be2034e0933bbf020f24a1a909eec9a25e239291915aacebc74a8dddfc3172dd4d1e48f2526169101df369d321108e3e50dcc987bf
-  data.tar.gz: 21433ad6bccf6e919838e239141b3aa27840c8c04cfe9bcf6ce9b3fc804c1168599fea7f6e6dbe1bc0d11059c6ee596e3e5bd49731411880967499b06157592a
+  metadata.gz: aa22da5d6f03596473026371eee473ad9607c2424d411b489dd1f292ea569022d0d3c1ea23217b923991f85df9e01b6472bc7a387707645764075496ba8e7d8c
+  data.tar.gz: 1c1c1c7f22760d42593f4b156734c59b01c56915b9783672261268d86d596fcd2ec4b2307074a4e207c89758b57824b6868a8ef08945da0a3735ebd979fd3e8b

data/app/views/account/onboarding/user_details/edit.html.erb

@@ -10,11 +10,11 @@
 
         <div class="grid grid-cols-1 gap-y gap-x sm:grid-cols-2">
           <div class="sm:col-span-1">
-            <%= render 'shared/fields/text_field', form: f, method: :first_name, options: {autofocus: true} %>
+            <%= render 'shared/fields/text_field', form: f, method: :first_name, other_options: {required: true}, options: {autofocus: true} %>
           </div>
 
           <div class="sm:col-span-1">
-            <%= render 'shared/fields/text_field', form: f, method: :last_name %>
+            <%= render 'shared/fields/text_field', form: f, method: :last_name, other_options: {required: true} %>
           </div>
 
           <% # only edit the team name if this user is an admin and they are the first user. %>
@@ -30,7 +30,7 @@
           <div class="sm:col-span-2">
             <%= render 'shared/fields/super_select', form: f, method: :time_zone,
               choices: time_zone_options_for_select(@user.time_zone, nil, ActiveSupport::TimeZone),
-              other_options: {search: true} %>
+              other_options: {search: true, required: true} %>
           </div>
         </div>
 

data/app/views/account/teams/_breadcrumbs.html.erb

@@ -11,8 +11,8 @@
   <% end %>
 <% end %>
 
-<%if action_name == 'edit' %>
+<% if (action_name == 'edit' && controller_name == 'teams') %>
   <%= render 'account/shared/breadcrumb', label: t('.team_settings') %>
-<%else %>
+<% else %>
   <%= render 'account/shared/breadcrumbs/actions', only_for: 'teams' %>
 <% end %>

data/app/views/devise/registrations/new.html.erb

@@ -17,7 +17,7 @@
            <%= render 'shared/fields/password_field', form: f, method: :password, options: {show_strength_indicator: true} %>
          </div>
          <div>
-           <%= render 'shared/fields/password_field', form: f, method: :password_confirmation, other_options: {error: f.object.errors.full_messages_for(:password).first, hide_custom_error: true} %>
+           <%= render 'shared/fields/password_field', form: f, method: :password_confirmation, other_options: {required: true, error: f.object.errors.full_messages_for(:password).first, hide_custom_error: true} %>
          </div>
        </div>
 

data/config/locales/en/framework_packages.yml

@@ -20,6 +20,8 @@ en:
       git: "bullet-train-co/bullet_train-core"
     bullet_train-outgoing_webhooks:
       git: "bullet-train-co/bullet_train-core"
+    bullet_train-roles:
+      git: "bullet-train-co/bullet_train-core"
     bullet_train-scope_questions:
       git: "bullet-train-co/bullet_train-core"
     bullet_train-scope_validator:

data/docs/field-partials.md

@@ -63,6 +63,16 @@ For example, to suppress a label on any field, we can use the `hide_label` optio
 | `help` | string | Display a specific help string. |
 | `error` | string | Display a specific error string. |
 | `hide_label` | boolean | Hide the field label. |
+| `required` | boolean | Display an asterisk by the field label to indicate the field is required. |
+
+## `required`: through presence validation vs. `options: {required: true}` vs. `other_options:{required: true}`
+
+By default, where there's a presence validation on the model attribute, we add an asterisk to indicate the field is required. For fields without a presence validation, you have options to pass the `:required` detail:
+
+1. `other_options: {required: true}` adds the asterisk to the field manually.
+2. `options: {required: true}` adds asterisk but also triggers client-side validation via the [`required`](https://developer.mozilla.org/en-US/docs/Web/HTML/Attributes/required) attribute.
+
+Since client-side validations vary from browser to browser, we recommend relying on server-side validation for most forms, and thus mostly using `other_options[:required]`.
 
 ## Reducing Repetition
 When you're including multiple fields, you can DRY up redundant settings (e.g. `form: form`) like so:

data/lib/bullet_train/version.rb

@@ -1,3 +1,3 @@
 module BulletTrain
-  VERSION = "1.3.22"
+  VERSION = "1.3.23"
 end

data/lib/tasks/bullet_train_tasks.rake

@@ -311,6 +311,8 @@ namespace :bullet_train do
             "#{original_path.chomp}, git: 'http://github.com/bullet-train-co/bullet_train-core.git'\n"
           elsif link_flag_value&.match?(version_regexp)
             "#{original_path.chomp}, \"#{link_flag_value}\"\n"
+          elsif link_flag_value
+            "#{original_path.chomp}, path: \"#{link_flag_value}/#{package}\"\n"
           else
             "#{local_path}\n"
           end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet_train
 version: !ruby/object:Gem::Version
-  version: 1.3.22
+  version: 1.3.23
 platform: ruby
 authors:
 - Andrew Culver
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2023-09-01 00:00:00.000000000 Z
+date: 2023-09-05 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: standard