bullet_train 1.12.0 → 1.12.1

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: bd6fdf70fe639d436c4c3a30bdb7334486a06fd164cc1143cfb7c61f594807a1
-  data.tar.gz: 26bfbb1745af219cc5e1a88c63960091e988060b99e6d8c663849a182a2e2d75
+  metadata.gz: 7a7d2a3ad862f57f8b91e0db97982d672c8c73c896f24f1af13a398ccb3b2a96
+  data.tar.gz: 3ec97fc6cc70d9701ad1b4cef65276d14b8e188b0b3fcf63e3a7151b8c976d4f
 SHA512:
-  metadata.gz: 405d7b2680925803f52982019d1311f494b4bfb0d798b45898fc98afe6a2a0e2ce49e83af6ed2dc73fe6ba6f693a699a439e923d9ace5715e35fd68d3c4b2c59
-  data.tar.gz: 1889ac585f748aaf37f4917750e5d4d26e8214a7aa164d8fe45354eab0f24d182ee3dc7bde4b2f45be3c3fe2b08a6d4788539b6bc95b5c14f66c969b79d55397
+  metadata.gz: 72de63a2467f4753c80706dac5b23d51afc7d197c4e6fbc43945e447a19dd0b3cf90372eb2aa1dfb0fdf9a08d6f11986615606a7fc72c669e786e274c9870ca8
+  data.tar.gz: f95130d7f6e2fd446e532239bc6543c4581cf1f63958969e3ae2855d1bb7f057ebea73247a53f3c2bef61832114742e916edb1fd8b523c2b0c1243efb3006162

data/lib/bullet_train/version.rb

@@ -1,3 +1,3 @@
 module BulletTrain
-  VERSION = "1.12.0"
+  VERSION = "1.12.1"
 end

data/lib/bullet_train.rb

@@ -73,7 +73,33 @@ def default_url_options_from_base_url
 end
 
 def heroku?
-  ENV["HEROKU_APP_NAME"].present?
+  # This is a value we set in `app.json` so anyone using the "Deploy to Heroku" button
+  # should have it. This is kind of a brute force method that should be future-proofed
+  # against changes that Heroku might make to their runtime environment. We'll fallback
+  # to some additional checks if this isn't here, to maintain backwards compatibility
+  # for existing apps.
+  if ENV["BT_IS_IN_HEROKU"].present?
+    ENV["BT_IS_IN_HEROKU"] == "true"
+  else
+    # This requires the app to run `heroku labs:enable runtime-dyno-metadata` and then
+    # deploy at least once before the ENV var is set. Many existing BT apps have enabled
+    # this feature, and this used to be the only detection method that we had. We're
+    # keeping it for backwards compability reasons because it's probably more stable
+    # than the following fallbacks.
+    ENV["HEROKU_APP_NAME"].present? ||
+      # And finally we fallback to checking for some artifacts that Heroku happens to leave
+      # lying around. These may change in the future, so who knows how long they'll be good.
+      #
+      # If there's a `DYNO` ENV var, then we're probably on Heroku. Will they _always_ set
+      # this variable?
+      ENV["DYNO"].present? ||
+      # Finally we look for the the existence of the `/app/.heroku` directory.
+      # This should make detection work for apps that don't have any of the above ENV vars, for
+      # whatever reasons. But, in the future Heroku could decide to remove `/app/.heroku`
+      # which will break this fallback method and then we'll have to come up with something else.
+      # This is currently our last line of defense.
+      File.directory?("/app/.heroku")
+  end
 end
 
 def inbound_email_enabled?

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet_train
 version: !ruby/object:Gem::Version
-  version: 1.12.0
+  version: 1.12.1
 platform: ruby
 authors:
 - Andrew Culver
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2024-12-10 00:00:00.000000000 Z
+date: 2024-12-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: standard