bullet_train-outgoing_webhooks 1.0.5 → 1.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: a4d3884adf8d199b92ccf09ca749e8237e86a421224de5b8b81cf5ab0d9f4329
-  data.tar.gz: cec7b468644c484f8bcb0f4064b74764ab3e7b8873cb72ba5c8944009b95a576
+  metadata.gz: 067e22f503dd4bf72b809ba6cd0d0e43d3930a50876a2bc5c846bc186700a3ff
+  data.tar.gz: fbddcd29981bdb80d81c7a66ed0fb15ef36d971ebeaf7eab50b4e8ae9d54fe99
 SHA512:
-  metadata.gz: 98d7265e65165a0c2b55a0b2880063f00c72292e0a461e4bde667d54f077860f1b4861873f5131bd203e45b85ab03868822970071e626c34e2ed640059e5cc11
-  data.tar.gz: f36d57ccd33ba9268a106ef22c1457560f9b171ff0533b4f8102301e5962691f827ffa437c7f13d3fd7ab847b1b626a9c6374cca45efbbcab228caf7c265d2a9
+  metadata.gz: 20128e3bb542c2e40d0b93d331a8e0e5bec6cca33ec5b6a2ceaf0e2cbbb8fd155150c40cf82cd89aaedcc1242bce7a8cd5a8c571ff0cc2bd22d0348057b0ff04
+  data.tar.gz: b4ace453d0be7351e0ce89e9fc451a492c3e8fc11f4b5270c57012494caefba063cd7577f875bb5dccde9a46a9a17a4b188c4393e0926d2999978d9d992163ec

data/app/models/concerns/webhooks/outgoing/issuing_model.rb

@@ -45,7 +45,9 @@ module Webhooks::Outgoing::IssuingModel
 
   def generate_webhook_perform(action)
     event_type = Webhooks::Outgoing::EventType.find_by(id: "#{self.class.name.underscore}.#{action}")
-    data = "Api::V1::#{self.class.name}Serializer".constantize.new(self).serializable_hash[:data]
+    # TODO This is crazy that we generate JSON just to parse it. Can't be good for performance.
+    # Does Jbuilder support generating a hash instead of a JSON string?
+    data = JSON.parse(to_api_json)
     webhook = send(BulletTrain::OutgoingWebhooks.parent_association).webhooks_outgoing_events.create(event_type_id: event_type.id, subject: self, data: data)
     webhook.deliver
   end

data/lib/bullet_train/outgoing_webhooks/engine.rb

@@ -25,14 +25,6 @@ module BulletTrain
           audit_callback: ->(obj, uri) { Rails.logger.error("BlockedURI obj=#{obj.persisted? ? obj.to_global_id : "New #{obj.class}"} uri=#{uri}") }
         }
       end
-
-      initializer "bullet_train.outgoing_webhooks.register_api_endpoints" do |app|
-        if Object.const_defined?("BulletTrain::Api")
-          BulletTrain::Api.endpoints << "Api::V1::Webhooks::Outgoing::EndpointsEndpoint"
-          BulletTrain::Api.endpoints << "Api::V1::Webhooks::Outgoing::DeliveriesEndpoint"
-          BulletTrain::Api.endpoints << "Api::V1::Webhooks::Outgoing::DeliveryAttemptsEndpoint"
-        end
-      end
     end
   end
 end

data/lib/bullet_train/outgoing_webhooks/version.rb

@@ -1,5 +1,5 @@
 module BulletTrain
   module OutgoingWebhooks
-    VERSION = "1.0.5"
+    VERSION = "1.1.0"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet_train-outgoing_webhooks
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.1.0
 platform: ruby
 authors:
 - Andrew Culver
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-08-24 00:00:00.000000000 Z
+date: 2022-09-02 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: standard
@@ -67,9 +67,6 @@ files:
 - app/controllers/account/webhooks/outgoing/deliveries_controller.rb
 - app/controllers/account/webhooks/outgoing/delivery_attempts_controller.rb
 - app/controllers/account/webhooks/outgoing/endpoints_controller.rb
-- app/controllers/api/v1/webhooks/outgoing/deliveries_endpoint.rb
-- app/controllers/api/v1/webhooks/outgoing/delivery_attempts_endpoint.rb
-- app/controllers/api/v1/webhooks/outgoing/endpoints_endpoint.rb
 - app/jobs/webhooks/outgoing/delivery_job.rb
 - app/jobs/webhooks/outgoing/generate_job.rb
 - app/models/concerns/webhooks/outgoing/delivery_attempt_support.rb
@@ -86,9 +83,6 @@ files:
 - app/models/webhooks/outgoing/endpoint.rb
 - app/models/webhooks/outgoing/event.rb
 - app/models/webhooks/outgoing/event_type.rb
-- app/serializers/api/v1/webhooks/outgoing/delivery_attempt_serializer.rb
-- app/serializers/api/v1/webhooks/outgoing/delivery_serializer.rb
-- app/serializers/api/v1/webhooks/outgoing/endpoint_serializer.rb
 - app/views/account/webhooks/outgoing/deliveries/_breadcrumbs.html.erb
 - app/views/account/webhooks/outgoing/deliveries/_delivery.json.jbuilder
 - app/views/account/webhooks/outgoing/deliveries/_form.html.erb

data/app/controllers/api/v1/webhooks/outgoing/deliveries_endpoint.rb

@@ -1,63 +0,0 @@
-class Api::V1::Webhooks::Outgoing::DeliveriesEndpoint < Api::V1::Root
-  helpers do
-    params :endpoint_id do
-      requires :endpoint_id, type: Integer, allow_blank: false, desc: "Endpoint ID"
-    end
-
-    params :id do
-      requires :id, type: Integer, allow_blank: false, desc: "Delivery ID"
-    end
-
-    params :delivery do
-      optional :event_id, type: String, desc: Api.heading(:event_id)
-      optional :endpoint_url, type: String, desc: Api.heading(:endpoint_url)
-      optional :delivered_at, type: DateTime, desc: Api.heading(:delivered_at)
-      # 🚅 super scaffolding will insert new fields above this line.
-      # 🚅 super scaffolding will insert new arrays above this line.
-
-      # 🚅 super scaffolding will insert processing for new fields above this line.
-    end
-  end
-
-  resource "webhooks/outgoing/endpoints", desc: Api.title(:collection_actions) do
-    after_validation do
-      load_and_authorize_api_resource Webhooks::Outgoing::Delivery
-    end
-
-    #
-    # INDEX
-    #
-
-    desc Api.title(:index), &Api.index_desc
-    params do
-      use :endpoint_id
-    end
-    oauth2
-    paginate per_page: 100
-    get "/:endpoint_id/deliveries" do
-      @paginated_deliveries = paginate @deliveries
-      render @paginated_deliveries, serializer: Api.serializer
-    end
-  end
-
-  resource "webhooks/outgoing/deliveries", desc: Api.title(:member_actions) do
-    after_validation do
-      load_and_authorize_api_resource Webhooks::Outgoing::Delivery
-    end
-
-    #
-    # SHOW
-    #
-
-    desc Api.title(:show), &Api.show_desc
-    params do
-      use :id
-    end
-    oauth2
-    route_param :id do
-      get do
-        render @delivery, serializer: Api.serializer
-      end
-    end
-  end
-end

data/app/controllers/api/v1/webhooks/outgoing/delivery_attempts_endpoint.rb

@@ -1,65 +0,0 @@
-class Api::V1::Webhooks::Outgoing::DeliveryAttemptsEndpoint < Api::V1::Root
-  helpers do
-    params :delivery_id do
-      requires :delivery_id, type: Integer, allow_blank: false, desc: "Delivery ID"
-    end
-
-    params :id do
-      requires :id, type: Integer, allow_blank: false, desc: "Delivery Attempt ID"
-    end
-
-    params :delivery_attempt do
-      optional :response_code, type: String, desc: Api.heading(:response_code)
-      optional :response_body, type: String, desc: Api.heading(:response_body)
-      optional :response_message, type: String, desc: Api.heading(:response_message)
-      optional :error_message, type: String, desc: Api.heading(:error_message)
-      optional :attempt_number, type: String, desc: Api.heading(:attempt_number)
-      # 🚅 super scaffolding will insert new fields above this line.
-      # 🚅 super scaffolding will insert new arrays above this line.
-
-      # 🚅 super scaffolding will insert processing for new fields above this line.
-    end
-  end
-
-  resource "webhooks/outgoing/deliveries", desc: Api.title(:collection_actions) do
-    after_validation do
-      load_and_authorize_api_resource Webhooks::Outgoing::DeliveryAttempt
-    end
-
-    #
-    # INDEX
-    #
-
-    desc Api.title(:index), &Api.index_desc
-    params do
-      use :delivery_id
-    end
-    oauth2
-    paginate per_page: 100
-    get "/:delivery_id/delivery_attempts" do
-      @paginated_delivery_attempts = paginate @delivery_attempts
-      render @paginated_delivery_attempts, serializer: Api.serializer
-    end
-  end
-
-  resource "webhooks/outgoing/delivery_attempts", desc: Api.title(:member_actions) do
-    after_validation do
-      load_and_authorize_api_resource Webhooks::Outgoing::DeliveryAttempt
-    end
-
-    #
-    # SHOW
-    #
-
-    desc Api.title(:show), &Api.show_desc
-    params do
-      use :id
-    end
-    oauth2
-    route_param :id do
-      get do
-        render @delivery_attempt, serializer: Api.serializer
-      end
-    end
-  end
-end

data/app/controllers/api/v1/webhooks/outgoing/endpoints_endpoint.rb

@@ -1,119 +0,0 @@
-class Api::V1::Webhooks::Outgoing::EndpointsEndpoint < Api::V1::Root
-  helpers do
-    params BulletTrain::OutgoingWebhooks.parent_association_id do
-      requires BulletTrain::OutgoingWebhooks.parent_association_id, type: Integer, allow_blank: false, desc: "#{BulletTrain::OutgoingWebhooks.parent_class} ID"
-    end
-
-    params :id do
-      requires :id, type: Integer, allow_blank: false, desc: "Endpoint ID"
-    end
-
-    params :endpoint do
-      optional :name, type: String, desc: Api.heading(:name)
-      optional :url, type: String, desc: Api.heading(:url)
-      # 🚅 super scaffolding will insert new fields above this line.
-      optional :event_type_ids, type: Array, desc: Api.heading(:event_type_ids)
-      # 🚅 super scaffolding will insert new arrays above this line.
-
-      # 🚅 super scaffolding will insert processing for new fields above this line.
-    end
-  end
-
-  resource BulletTrain::OutgoingWebhooks.parent_resource, desc: Api.title(:collection_actions) do
-    after_validation do
-      load_and_authorize_api_resource Webhooks::Outgoing::Endpoint
-    end
-
-    #
-    # INDEX
-    #
-
-    desc Api.title(:index), &Api.index_desc
-    params do
-      use BulletTrain::OutgoingWebhooks.parent_association_id
-    end
-    oauth2
-    paginate per_page: 100
-    get "/:#{BulletTrain::OutgoingWebhooks.parent_association_id}/webhooks/outgoing/endpoints" do
-      @paginated_endpoints = paginate @endpoints
-      render @paginated_endpoints, serializer: Api.serializer
-    end
-
-    #
-    # CREATE
-    #
-
-    desc Api.title(:create), &Api.create_desc
-    params do
-      use BulletTrain::OutgoingWebhooks.parent_association_id
-      use :endpoint
-    end
-    route_setting :api_resource_options, permission: :create
-    oauth2 "write"
-    post "/:#{BulletTrain::OutgoingWebhooks.parent_association_id}/webhooks/outgoing/endpoints" do
-      if @endpoint.save
-        render @endpoint, serializer: Api.serializer
-      else
-        record_not_saved @endpoint
-      end
-    end
-  end
-
-  resource "webhooks/outgoing/endpoints", desc: Api.title(:member_actions) do
-    after_validation do
-      load_and_authorize_api_resource Webhooks::Outgoing::Endpoint
-    end
-
-    #
-    # SHOW
-    #
-
-    desc Api.title(:show), &Api.show_desc
-    params do
-      use :id
-    end
-    oauth2
-    route_param :id do
-      get do
-        render @endpoint, serializer: Api.serializer
-      end
-    end
-
-    #
-    # UPDATE
-    #
-
-    desc Api.title(:update), &Api.update_desc
-    params do
-      use :id
-      use :endpoint
-    end
-    route_setting :api_resource_options, permission: :update
-    oauth2 "write"
-    route_param :id do
-      put do
-        if @endpoint.update(declared(params, include_missing: false))
-          render @endpoint, serializer: Api.serializer
-        else
-          record_not_saved @endpoint
-        end
-      end
-    end
-
-    #
-    # DESTROY
-    #
-
-    desc Api.title(:destroy), &Api.destroy_desc
-    params do
-      use :id
-    end
-    route_setting :api_resource_options, permission: :destroy
-    oauth2 "delete"
-    route_param :id do
-      delete do
-        render @endpoint.destroy, serializer: Api.serializer
-      end
-    end
-  end
-end

data/app/serializers/api/v1/webhooks/outgoing/delivery_attempt_serializer.rb

@@ -1,16 +0,0 @@
-class Api::V1::Webhooks::Outgoing::DeliveryAttemptSerializer < Api::V1::ApplicationSerializer
-  set_type "webhooks/outgoing/delivery_attempt"
-
-  attributes :id,
-    :delivery_id,
-    :response_code,
-    :response_body,
-    :response_message,
-    :error_message,
-    :attempt_number,
-    # 🚅 super scaffolding will insert new fields above this line.
-    :created_at,
-    :updated_at
-
-  belongs_to :delivery, serializer: Api::V1::Webhooks::Outgoing::DeliverySerializer
-end

data/app/serializers/api/v1/webhooks/outgoing/delivery_serializer.rb

@@ -1,14 +0,0 @@
-class Api::V1::Webhooks::Outgoing::DeliverySerializer < Api::V1::ApplicationSerializer
-  set_type "webhooks/outgoing/delivery"
-
-  attributes :id,
-    :endpoint_id,
-    :event_id,
-    :endpoint_url,
-    :delivered_at,
-    # 🚅 super scaffolding will insert new fields above this line.
-    :created_at,
-    :updated_at
-
-  belongs_to :endpoint, serializer: Api::V1::Webhooks::Outgoing::EndpointSerializer
-end

data/app/serializers/api/v1/webhooks/outgoing/endpoint_serializer.rb

@@ -1,14 +0,0 @@
-class Api::V1::Webhooks::Outgoing::EndpointSerializer < Api::V1::ApplicationSerializer
-  set_type "webhooks/outgoing/endpoint"
-
-  attributes :id,
-    :team_id,
-    :name,
-    :url,
-    :event_type_ids,
-    # 🚅 super scaffolding will insert new fields above this line.
-    :created_at,
-    :updated_at
-
-  belongs_to :team, serializer: Api::V1::TeamSerializer
-end