bullet_train-fields 1.0.5 → 1.0.6

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: fc400167a3654881eab0140f0e4c256928f8c46cda2398897e4883d7c778d89b
-  data.tar.gz: 80b95fd1af091b146684217ae697882163c61609c885b20105b2967b73abbbab
+  metadata.gz: 0f63de0bb7a786cd95e769c829420c2a29c10713e5be22dfd157aa53315bd925
+  data.tar.gz: fd78ed080007169562c4b28fbf1ff8df578c16b666a92dd8ebe722ae30d050fc
 SHA512:
-  metadata.gz: 0164f78c54a1db1aba3d120460b26ea718c7c67dd8f8d20a4c217322b64cf1e60f32eb9a6860a3e10b1e23e0bca385b6c63cb5dfe9a7ed62cd99e2d575ba46f3
-  data.tar.gz: 5e313ecb25347839dfbe835c883cfa86f00ef665cada93a1b73c32471fe7160aaa8b310129508e1ff028b9d068ddf8a903e1ed4eccf1f63b6f6fa7d2861ef2ef
+  metadata.gz: 40fd79035d4b8624b924b18279ba58503fc5e0202c7ed6970fbe6bfb5a0016ba9f7793fa22c40e54c74dd8111f277a81383b9cb7aca35970f026cfa58ef11b4e
+  data.tar.gz: 77ff3f43a2c03aa461a8ef9ee27a22e1fa390e904ae0ef3de4eb7064c1c9682acc2c8de3538287cd0c65303e51a7f75d1ffb0a07214d94e41ddbc6c68a24d06f

data/app/helpers/fields/html_editor_helper.rb

@@ -1,8 +1,16 @@
 module Fields::HtmlEditorHelper
   TEMPORARY_REPLACEMENT = "https://temp.bullettrain.co/"
+
   def html_sanitize(string)
     return string unless string
+    # TODO this is a hack to get around the fact that rails doesn't allow us to add any acceptable protocols.
+    string = string.gsub("bullettrain://", TEMPORARY_REPLACEMENT)
     string = sanitize(string, tags: %w[div br strong em b i del a h1 blockquote pre ul ol li], attributes: %w[href])
+    # given the limited scope of what we're doing here, this string replace should work.
+    # it should also use a lot less memory than nokogiri.
+    string = string.gsub(/<a href="#{TEMPORARY_REPLACEMENT}(.*?)\/.*?">(.*?)<\/a>/o, "<span class=\"tribute-reference tribute-\\1-reference\">\\2</span>").html_safe
+
+    # Also, while we're at it ...
     links_target_blank(string).html_safe
   end
 

data/app/helpers/fields/trix_editor_helper.rb

@@ -1,17 +1,13 @@
 module Fields::TrixEditorHelper
   TEMPORARY_REPLACEMENT = "https://temp.bullettrain.co/"
-  def trix_sanitize(string)
-    return string unless string
-    # TODO this is a hack to get around the fact that rails doesn't allow us to add any acceptable protocols.
-    string = string.gsub("bullettrain://", TEMPORARY_REPLACEMENT)
-    string = sanitize(string, tags: %w[div br strong em del a h1 blockquote pre ul ol li], attributes: %w[href])
-    # given the limited scope of what we're doing here, this string replace should work.
-    # it should also use a lot less memory than nokogiri.
-    string = string.gsub(/<a href="#{TEMPORARY_REPLACEMENT}(.*?)\/.*?">(.*?)<\/a>/o, "<span class=\"tribute-reference tribute-\\1-reference\">\\2</span>").html_safe
-    trix_content(string)
+
+  # TODO We should migrate away from this, but I think we'll need to update Super Scaffolding.
+  def trix_sanitize(html)
+    html_sanitize(html)
   end
 
+  # TODO Confirm there are no references to this anywhere (in other repositories) and remove it.
   def trix_content(body)
-    links_target_blank(body).html_safe
+    html_sanitize(string)
   end
 end

data/lib/bullet_train/fields/version.rb

@@ -1,5 +1,5 @@
 module BulletTrain
   module Fields
-    VERSION = "1.0.5"
+    VERSION = "1.0.6"
   end
 end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bullet_train-fields
 version: !ruby/object:Gem::Version
-  version: 1.0.5
+  version: 1.0.6
 platform: ruby
 authors:
 - Andrew Culver
 autorequire:
 bindir: bin
 cert_chain: []
-date: 2022-03-29 00:00:00.000000000 Z
+date: 2022-03-31 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rails