bulldog 0.2.3 → 0.2.4

data/CHANGELOG

@@ -1,3 +1,8 @@
+== 0.2.4 2011-01-07
+
+ * Support alias_method_chain on base attachments when extended in
+   subclasses.
+
 == 0.2.3 2011-01-06
 
  * #process accepts an :input_file option.

data/lib/bulldog/has_attachment.rb

@@ -13,9 +13,11 @@ module Bulldog
 
       reflection = attachment_reflections[name] || Reflection.new(self, name)
       reflection.configure(&block)
-      attachment_reflections[name] = reflection
-      define_attachment_accessors(reflection.name)
-      define_attachment_attribute_methods(reflection.name)
+      unless attachment_reflections.key?(name)
+        attachment_reflections[name] = reflection
+        define_attachment_accessors(reflection.name)
+        define_attachment_attribute_methods(reflection.name)
+      end
     end
 
     module InstanceMethods

data/lib/bulldog/version.rb

@@ -1,5 +1,5 @@
 module Bulldog
-  VERSION = [0, 2, 3]
+  VERSION = [0, 2, 4]
 
   class << VERSION
     include Comparable

data/spec/unit/has_attachment_spec.rb

@@ -29,7 +29,7 @@ describe HasAttachment do
       Thing.attachment_reflections[:photo].styles[:two].should_not be_blank
     end
 
-    describe "when an attachment is inherited" do
+    describe "when an attachment is extended in a subclass" do
       use_model_class(:Parent)
 
       before do
@@ -41,13 +41,22 @@ describe HasAttachment do
 
       use_model_class(:Child => :Parent)
 
-      it "should not affect the superclasses' attachment" do
+      before do
         Child.has_attachment :photo do
           style :two
         end
+      end
+
+      it "should not affect the superclasses' attachment" do
         Child.attachment_reflections[:photo].styles[:two].should_not be_blank
         Parent.attachment_reflections[:photo].styles[:two].should be_blank
       end
+
+      it "should not define accessors in the subclass, so alias_method_chain can be used in the abstract class" do
+        Child.public_instance_methods(false).map{|s| s.to_sym}.should_not include(:photo)
+        Child.public_instance_methods(false).map{|s| s.to_sym}.should_not include(:photo=)
+        Child.public_instance_methods(false).map{|s| s.to_sym}.should_not include(:photo?)
+      end
     end
   end
 

metadata

@@ -1,13 +1,13 @@
 --- !ruby/object:Gem::Specification 
 name: bulldog
 version: !ruby/object:Gem::Version 
-  hash: 17
+  hash: 31
   prerelease: false
   segments: 
   - 0
   - 2
-  - 3
-  version: 0.2.3
+  - 4
+  version: 0.2.4
 platform: ruby
 authors: 
 - George Ogata
@@ -15,7 +15,7 @@ autorequire:
 bindir: bin
 cert_chain: []
 
-date: 2011-01-06 00:00:00 -05:00
+date: 2011-01-07 00:00:00 -05:00
 default_executable: 
 dependencies: 
 - !ruby/object:Gem::Dependency