bulk_dependency_eraser 1.5.0 → 2.0.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 3466516854a6d613dae24320c55a3a5de1d921b53f8e9de06f08cde2226ff87d
-  data.tar.gz: 34c1025b73e2410eb3dca55ff7197903a1da148ed1bad55833f8495d70900265
+  metadata.gz: a7d8f49a22e2103cef90bfb21c415d0dd687040cf31961d199ff5041d942de68
+  data.tar.gz: 5d264a97b2a00f479c13d8f69a2b00218464700465b2f8cf6f7703d37742b4a5
 SHA512:
-  metadata.gz: 67caff3857272988508f54f08aad5b8eddefb4fbd545a652e1d1cb060690b49c01270758237f6a37be4cac52a7c2f8ca43d3d543ab25d5287e0868cca9819443
-  data.tar.gz: 366cc6941a419a0a5437422f7c22f64c712a1cf4a222638de58c22b672f5d60086aadffda673f7edc60565e34eda7bf613345d4d87593097ed24a0aef60aa592
+  metadata.gz: cdfe1a03baab1a7d0bbd1a6984723815790dca786564df1cdf322ace227fc4734db60ae5c11d42d0b0d1f9f507fc6483091b42a641927acfe12cd87b5cf5eedb
+  data.tar.gz: 1c80246cc7315d5250fdbf0aa75fb199f0b1cdedd510282e45885e476caaff5ecee2896ef12a5053060858a300d860cb1ac2ace462907d0a021efed7dfa7cc9f

data/lib/bulk_dependency_eraser/builder.rb

@@ -94,27 +94,6 @@ module BulkDependencyEraser
         end
       end
 
-      # Reverse order IDs
-      # - if a class self-referenced itself the children will be deleted/nullified before parent
-      deletion_list.keys.each do |class_name|
-        deletion_list[class_name] = deletion_list.delete(class_name).reverse
-
-        # TODO: Hard to test if not sorted
-        deletion_list[class_name] = deletion_list[class_name].sort if Rails.env.test?
-      end
-
-      nullification_list.keys.each do |class_name|
-        columns_and_ids = nullification_list.delete(class_name)
-        # we don't need to reverse the column keys
-        columns_and_ids.keys.each do |column_name|
-          columns_and_ids[column_name] = columns_and_ids.delete(column_name).reverse
-
-          # TODO: Hard to test if not sorted
-          columns_and_ids[column_name] = columns_and_ids.delete(column_name).sort if Rails.env.test?
-        end
-        nullification_list[class_name] = columns_and_ids
-      end
-
       return build_result
     end
 

data/lib/bulk_dependency_eraser/deleter.rb

@@ -36,32 +36,29 @@ module BulkDependencyEraser
         puts "ActiveRecord::Base.connection.disable_referential_integrity - disabled!"
       end
 
-      ActiveRecord::Base.transaction do
-        current_class_name = 'N/A'
-        begin
-          # IDs should have already been reversed in builder
-          class_names_and_ids.keys.reverse.each do |class_name|
-            current_class_name = class_name
-            ids = class_names_and_ids[class_name]
-            klass = class_name.constantize
+      current_class_name = 'N/A'
+      begin
+        # IDs should have already been reversed in builder
+        class_names_and_ids.keys.reverse.each do |class_name|
+          current_class_name = class_name
+          ids = class_names_and_ids[class_name].reverse
+          klass = class_name.constantize
 
-            if opts_c.enable_invalid_foreign_key_detection
-              # delete with referential integrity
+          if opts_c.enable_invalid_foreign_key_detection
+            # delete with referential integrity
+            delete_by_klass_and_ids(klass, ids)
+          else
+            # delete without referential integrity
+            # Disable any ActiveRecord::InvalidForeignKey raised errors.
+            # - src: https://stackoverflow.com/questions/41005849/rails-migrations-temporarily-ignore-foreign-key-constraint
+            #        https://apidock.com/rails/ActiveRecord/ConnectionAdapters/AbstractAdapter/disable_referential_integrity
+            ActiveRecord::Base.connection.disable_referential_integrity do
               delete_by_klass_and_ids(klass, ids)
-            else
-              # delete without referential integrity
-              # Disable any ActiveRecord::InvalidForeignKey raised errors.
-              # - src: https://stackoverflow.com/questions/41005849/rails-migrations-temporarily-ignore-foreign-key-constraint
-              #        https://apidock.com/rails/ActiveRecord/ConnectionAdapters/AbstractAdapter/disable_referential_integrity
-              ActiveRecord::Base.connection.disable_referential_integrity do
-                delete_by_klass_and_ids(klass, ids)
-              end
             end
           end
-        rescue StandardError => e
-          report_error("Issue attempting to delete '#{current_class_name}': #{e.class.name} - #{e.message}")
-          raise ActiveRecord::Rollback
         end
+      rescue StandardError => e
+        report_error("Issue attempting to delete '#{current_class_name}': #{e.class.name} - #{e.message}")
       end
 
       return errors.none?

data/lib/bulk_dependency_eraser/nullifier.rb

@@ -89,37 +89,36 @@ module BulkDependencyEraser
     end
 
     def execute
-      ActiveRecord::Base.transaction do
-        current_class_name = 'N/A'
-        current_column = 'N/A'
-        begin
-          # column_and_ids should have already been reversed in builder
-          class_names_columns_and_ids.keys.reverse.each do |class_name|
-            current_class_name = class_name
-            klass = class_name.constantize
-            columns_and_ids = class_names_columns_and_ids[class_name]
-
-            columns_and_ids.each do |column, ids|
-              current_column = column
-
-              if opts_c.enable_invalid_foreign_key_detection
-                # nullify with referential integrity
+      current_class_name = 'N/A'
+      current_column = 'N/A'
+      begin
+        # column_and_ids should have already been reversed in builder
+        class_names_columns_and_ids.keys.reverse.each do |class_name|
+          current_class_name = class_name
+          klass = class_name.constantize
+          columns_and_ids = class_names_columns_and_ids[class_name]
+
+          columns_and_ids.each do |column, ids|
+            current_column = column
+            # Reversing IDs. Last ones in are more likely to be dependencies, and should be deleted first.
+            ids = ids.reverse
+
+            if opts_c.enable_invalid_foreign_key_detection
+              # nullify with referential integrity
+              nullify_by_klass_column_and_ids(klass, column, ids)
+            else
+              # nullify without referential integrity
+              # Disable any ActiveRecord::InvalidForeignKey raised errors.
+              # - src: https://stackoverflow.com/questions/41005849/rails-migrations-temporarily-ignore-foreign-key-constraint
+              #        https://apidock.com/rails/ActiveRecord/ConnectionAdapters/AbstractAdapter/disable_referential_integrity
+              ActiveRecord::Base.connection.disable_referential_integrity do
                 nullify_by_klass_column_and_ids(klass, column, ids)
-              else
-                # nullify without referential integrity
-                # Disable any ActiveRecord::InvalidForeignKey raised errors.
-                # - src: https://stackoverflow.com/questions/41005849/rails-migrations-temporarily-ignore-foreign-key-constraint
-                #        https://apidock.com/rails/ActiveRecord/ConnectionAdapters/AbstractAdapter/disable_referential_integrity
-                ActiveRecord::Base.connection.disable_referential_integrity do
-                  nullify_by_klass_column_and_ids(klass, column, ids)
-                end
               end
             end
           end
-        rescue StandardError => e
-          report_error("Issue attempting to nullify '#{current_class_name}' column '#{current_column}': #{e.class.name} - #{e.message}")
-          raise ActiveRecord::Rollback
         end
+      rescue StandardError => e
+        report_error("Issue attempting to nullify '#{current_class_name}' column '#{current_column}': #{e.class.name} - #{e.message}")
       end
 
       return errors.none?

data/lib/bulk_dependency_eraser/version.rb

@@ -1,3 +1,3 @@
 module BulkDependencyEraser
-  VERSION = "1.5.0".freeze
+  VERSION = "2.0.0".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bulk_dependency_eraser
 version: !ruby/object:Gem::Version
-  version: 1.5.0
+  version: 2.0.0
 platform: ruby
 authors:
 - benjamin.dana.software.dev@gmail.com