bulk_dependency_eraser 1.3.2 → 1.3.3

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA256:
-  metadata.gz: 7e0b2a7c10501166d33e7076cf19b7c241ffd9de2704d94aca6f7c9fecc6e2d4
-  data.tar.gz: 6788ed915a4a6b4f7d7dbe2c8387244b0ff5e758098fe48f47b47127e64d9fb5
+  metadata.gz: bb8d638145b6ff810e2cb3deb79c11a134b9df5e6abdc25755a166d92158c583
+  data.tar.gz: 0f7525a93ddb69db0b0fdb1243973c2a1db1db1d33051fa3fe49e1aaefdb538d
 SHA512:
-  metadata.gz: ab13a12a9e5965890ae2e27cbf0971ba75aec2dbdc463d92c1631ac9cdb6dd98729e22cedb9c05cfb4cd4f897ca774c5204d0c3a61c804f8f7f8961de4e686cb
-  data.tar.gz: 9d0968970dd212e9e07c459134e829c8b1fd17c3c65d2b1e7665f983a68c4655044e3732ce7e2f6d28fb0c0e59606ffde0f343761a4730abb2f6dc74c3ba521d
+  metadata.gz: 8841e5385fdd92b2d1c14315d849df28a4d8af00a7d8f151a4e04767fd27a9b1cd1653d269912a23385520cb7eb18f8e4b483ab74c7f9a0a5249048fbb81f20b
+  data.tar.gz: c0701a14385970abc0ac5ec0025215a11c5818d391d2bcbef89c36e47c8f7a7919a6dbded77521efdb60108bdb88266ef21268e743265399d58c9a7c4044f648

data/lib/bulk_dependency_eraser/builder.rb

@@ -427,11 +427,8 @@ module BulkDependencyEraser
         assoc_query = assoc_query.where(specified_foreign_key.to_sym => query_ids)
       end
 
-      # Works in theory for ONE record's has_one, but we're dealing with potentially many
-      # # Apply limit if has_one assocation (subset of has_many)
-      # if opts[:limit]
-      #   assoc_query = assoc_query.limit(opts[:limit])
-      # end
+      # remove any ordering or limits imposed on the association queries from the association definitions
+      assoc_query = assoc_query.reorder('').unscope(:limit)
 
       if type == :delete
         # Recursively call 'deletion_query_parser' on association query, to delete any if the assoc's dependencies
@@ -554,6 +551,9 @@ module BulkDependencyEraser
         specified_primary_key.to_sym => foreign_keys
       )
 
+      # remove any ordering or limits imposed on the association queries from the association definitions
+      assoc_query = assoc_query.reorder('').unscope(:limit)
+
       if type == :delete
         # Recursively call 'deletion_query_parser' on association query, to delete any if the assoc's dependencies
         deletion_query_parser(assoc_query, parent_class)
@@ -572,6 +572,7 @@ module BulkDependencyEraser
     # This method will replicate association_parser, but instantiate and iterate in batches
     def association_parser_belongs_to_instantiation(parent_class, query, query_ids, association_name, type)
       # pending
+      raise "Invalid State! Not ready to instantiate!"
     end
 
     # In this case, it's like a `belongs_to :polymorphicable, polymorphic: true, dependent: :destroy` use-case

data/lib/bulk_dependency_eraser/version.rb

@@ -1,3 +1,3 @@
 module BulkDependencyEraser
-  VERSION = "1.3.2".freeze
+  VERSION = "1.3.3".freeze
 end

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: bulk_dependency_eraser
 version: !ruby/object:Gem::Version
-  version: 1.3.2
+  version: 1.3.3
 platform: ruby
 authors:
 - benjamin.dana.software.dev@gmail.com