builder 2.1.1 → 2.1.2

data/CHANGES

@@ -1,5 +1,12 @@
 = Change Log
 
+== Version 2.1.2
+
+* Fixed bug where private methods in kernel could leak through using
+  tag!().  Thanks to Hagen Overdick for finding and diagnosing this
+  bug.
+
+
 == Version 2.1.1
 
 * Fixed typo in XmlMarkup class docs (ident => indent). (from Martin

data/Rakefile

@@ -21,7 +21,7 @@ end
 
 CLOBBER.include('pkg')
 
-CURRENT_VERSION = '2.1.1'
+CURRENT_VERSION = '2.1.2'
 PKG_VERSION = ENV['REL'] ? ENV['REL'] : CURRENT_VERSION
 
 SRC_RB = FileList['lib/**/*.rb']

data/lib/blankslate.rb

@@ -33,6 +33,8 @@ class BlankSlate
       @hidden_methods[name] || superclass.find_hidden_method(name)
     end
 
+    # Redefine a previously hidden method so that it may be called on a blank
+    # slate object.
     def reveal(name)
       bound_method = nil
       unbound_method = find_hidden_method(name)

data/lib/builder/xmlbase.rb

@@ -28,7 +28,7 @@ module Builder
     # is the tag name, the arguements are the same as the tags
     # implemented via <tt>method_missing</tt>.
     def tag!(sym, *args, &block)
-      self.__send__(sym, *args, &block)
+      method_missing(sym.to_sym, *args, &block)
     end
 
     # Create XML markup based on the name of the method.  This method

data/test/testblankslate.rb

@@ -3,6 +3,7 @@
 require 'test/unit'
 require 'test/preload'
 require 'builder/blankslate'
+require 'stringio'
 
 # Methods to be introduced into the Object class late.
 module LateObject
@@ -147,7 +148,7 @@ class TestBlankSlate < Test::Unit::TestCase
     assert_raise(NoMethodError) { @bs.late_kernel }
   end
 
-  def test_revealing_previously_hidden_methods_is_ok
+  def test_revealing_previously_hidden_methods_are_callable
     with_to_s = Class.new(BlankSlate) do
       reveal :to_s
     end

data/test/testmarkupbuilder.rb

@@ -91,6 +91,11 @@ class TestMarkup < Test::Unit::TestCase
     assert_equal %{<non-ruby-token id="1"><ok/></non-ruby-token>}, @xml.target!
   end
 
+  def test_tag_can_handle_private_method
+    @xml.tag!("loop", :id=>1) { |x| x.ok }
+    assert_equal %{<loop id="1"><ok/></loop>}, @xml.target!
+  end
+
   def test_no_explicit_marker
     @xml.p { |x| x.b("HI") }
     assert_equal "<p><b>HI</b></p>", @xml.target!
@@ -441,3 +446,4 @@ class TestIndentedXmlMarkup < Test::Unit::TestCase
   end
 
 end
+

metadata

@@ -1,10 +1,10 @@
 --- !ruby/object:Gem::Specification 
-rubygems_version: 0.9.2
+rubygems_version: 0.9.4.1
 specification_version: 1
 name: builder
 version: !ruby/object:Gem::Version 
-  version: 2.1.1
-date: 2007-03-01 00:00:00 -05:00
+  version: 2.1.2
+date: 2007-06-15 00:00:00 -04:00
 summary: Builders for MarkUp.
 require_paths: 
 - lib