build_eval 0.0.8 → 0.0.9

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    MTJiNTE3NDJkMjUxNWRkN2FmZTMwNjViY2MxNWJjOWEzZmM4YWRjNA==
+    N2I3Zjc5OWM0NDBmMTQ1MTM1YjVhODE1OWI3NTk0NzE1NGI0Y2Y3Mg==
   data.tar.gz: !binary |-
-    OTBiZjJmOWJiMDBiYjFhZjViMmEyOGIyZWRlMDY5NWIyNjc0NTFhMw==
+    NWUyZDEyMzExZDM0NjkwMzY5MWNjNDczNGRkMzg0YTE0OWNlYzcxMg==
 SHA512:
   metadata.gz: !binary |-
-    YmY2Y2Q3ZmMxYzUzNTkwNGEwNzc2NGYxZGNjODkyNDlhZDIwMzg0YzczODBh
-    ZDc0YWMyMjEzNzE2YWM3N2JmYmI1ZDhhNjIyMDYwM2NkODdiY2E1MzA5Nzk0
-    Y2JiZTZhMWQzNDE4NDljMWE3ZGFhZGIwYTM2ZTA3MWNmMjcxMDA=
+    NTc3NGQyZmNiZjg0MmFjYzE2NDFkZmQ2OTBhZTc5ZTRhZjI2NTdkMmY5ZThh
+    N2NlNDUyODA4ZjgxMzlhMjhjMGU3N2NlNDljMGI0MmI4OGI5YWI3YWM4Y2E1
+    MzI1ZDc4YTdiOGNmMjYwMjIyYjU5MDBhOTAzMDBmOWUxNjYxZjU=
   data.tar.gz: !binary |-
-    MDM5MmUwN2Q3NGQ5YWJlZDA5ZGYwY2E5NDVkMjc2YmU0NGQzNTQwZDY3N2Ri
-    MzliZGM3NjRlOWFhM2ZjMTM0ZmFjZTVhNDJkN2NiNWM3OTU3Njk5NmUwMmZm
-    OWQ0MTg3MmE2ODU3MGQ2Y2Y5MzAwN2RiNWQzMDRhYjc2YzFhNDU=
+    MTQzZWEyOWY2NmExZTBiZTkxNDhkOTM2M2EyYmZmOTZhOGYyMzcyMzVmYjgx
+    YTgzODM5ODM3YzRmMjE2NDg0NDcxN2NmNDZjZTZjMzA1MGJhZjE3MDEyNjY5
+    ZDkwOWIwOTQzYmRhNTZjNWYyMzdhMWE0ZjI2YTRhZTYwZjc5MWE=

data/lib/build_eval/server/travis.rb

@@ -8,18 +8,20 @@ module BuildEval
       end
 
       def build_result(name)
-        repo_string = "#{@username}/#{name}"
-        has_failed = ::Travis::Repository.find(repo_string).recent_builds.first.failed?
-        BuildEval::Result::BuildResult.create(
-          build_name:  repo_string,
-          status_name: has_failed ? "Failure" : "Success"
-        )
+        build_path = "#{@username}/#{name}"
+        BuildEval::Result::BuildResult.create(build_name: build_path, status_name: last_status_name(build_path))
       end
 
       def to_s
         "Travis CI #{@username}"
       end
 
+      private
+
+      def last_status_name(build_path)
+        ::Travis::Repository.find(build_path).recent_builds.find(&:finished?).passed? ? "Success" : "Failure"
+      end
+
     end
 
   end

data/lib/build_eval/server/travis_pro.rb

@@ -9,11 +9,8 @@ module BuildEval
       end
 
       def build_result(name)
-        repository_path = "#{@username}/#{name}"
-        BuildEval::Result::BuildResult.create(
-          build_name:  repository_path,
-          status_name: last_build_failed?(repository_path) ? "Failure" : "Success"
-        )
+        build_path = "#{@username}/#{name}"
+        BuildEval::Result::BuildResult.create(build_name: build_path, status_name: last_status_name(build_path))
       end
 
       def to_s
@@ -22,9 +19,9 @@ module BuildEval
 
       private
 
-      def last_build_failed?(repository_path)
+      def last_status_name(build_path)
         ::Travis::Pro.github_auth(@github_token)
-        ::Travis::Pro::Repository.find(repository_path).recent_builds.first.failed?
+        ::Travis::Pro::Repository.find(build_path).recent_builds.find(&:finished?).passed? ? "Success" : "Failure"
       end
 
     end

data/lib/build_eval/version.rb

@@ -1,3 +1,3 @@
 module BuildEval
-  VERSION = "0.0.8".freeze
+  VERSION = "0.0.9".freeze
 end

data/spec/lib/build_eval/server/travis_pro_spec.rb

@@ -14,12 +14,14 @@ describe BuildEval::Server::TravisPro do
 
   describe "#build_result" do
 
-    let(:build_name)             { "some_build_name" }
-    let(:travis_repository)      { instance_double(::Travis::Client::Repository) }
-    let(:recent_builds)          { (1..3).map { instance_double(::Travis::Client::Build) } }
-    let(:last_build)             { recent_builds.first }
-    let(:last_build_failed_flag) { false }
-    let(:build_result)           { instance_double(BuildEval::Result::BuildResult) }
+    let(:build_name)                      { "some_build_name" }
+    let(:travis_repository)               { instance_double(::Travis::Client::Repository) }
+    let(:recent_builds)                   do
+      (1..3).map { |i| instance_double(::Travis::Client::Build, finished?: i > 1) }
+    end
+    let(:last_finished_build)             { recent_builds[1] }
+    let(:last_finished_build_passed_flag) { true }
+    let(:build_result)                    { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_pro_server.build_result(build_name) }
 
@@ -27,7 +29,7 @@ describe BuildEval::Server::TravisPro do
       allow(::Travis::Pro).to receive(:github_auth)
       allow(::Travis::Pro::Repository).to receive(:find).and_return(travis_repository)
       allow(travis_repository).to receive(:recent_builds).and_return(recent_builds)
-      allow(last_build).to receive(:failed?).and_return(last_build_failed_flag)
+      allow(last_finished_build).to receive(:passed?).and_return(last_finished_build_passed_flag)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
@@ -49,8 +51,8 @@ describe BuildEval::Server::TravisPro do
       subject
     end
 
-    it "determines if the last build has failed" do
-      expect(last_build).to receive(:failed?)
+    it "determines if the last finished build has passed" do
+      expect(last_finished_build).to receive(:passed?)
 
       subject
     end
@@ -63,9 +65,9 @@ describe BuildEval::Server::TravisPro do
       subject
     end
 
-    context "when the last build had passed" do
+    context "when the last finished build passed" do
 
-      let(:last_build_failed_flag) { false }
+      let(:last_finished_build_passed_flag) { true }
 
       it "creates a successful build result" do
         expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Success"))
@@ -75,9 +77,9 @@ describe BuildEval::Server::TravisPro do
 
     end
 
-    context "when the last build had failed" do
+    context "when the last finished build failed" do
 
-      let(:last_build_failed_flag) { true }
+      let(:last_finished_build_passed_flag) { false }
 
       it "creates a failed build result" do
         expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Failure"))

data/spec/lib/build_eval/server/travis_spec.rb

@@ -8,19 +8,21 @@ describe BuildEval::Server::Travis do
 
   describe "#build_result" do
 
-    let(:build_name)             { "some_build_name" }
-    let(:travis_repository)      { instance_double(::Travis::Client::Repository) }
-    let(:recent_builds)          { (1..3).map { instance_double(::Travis::Client::Build) } }
-    let(:last_build)             { recent_builds.first }
-    let(:last_build_failed_flag) { false }
-    let(:build_result)           { instance_double(BuildEval::Result::BuildResult) }
+    let(:build_name)                      { "some_build_name" }
+    let(:travis_repository)               { instance_double(::Travis::Client::Repository) }
+    let(:recent_builds)                   do
+      (1..3).map { |i| instance_double(::Travis::Client::Build, finished?: i > 1) }
+    end
+    let(:last_finished_build)             { recent_builds[1] }
+    let(:last_finished_build_passed_flag) { true }
+    let(:build_result)                    { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_server.build_result(build_name) }
 
     before(:example) do
       allow(::Travis::Repository).to receive(:find).and_return(travis_repository)
       allow(travis_repository).to receive(:recent_builds).and_return(recent_builds)
-      allow(last_build).to receive(:failed?).and_return(last_build_failed_flag)
+      allow(last_finished_build).to receive(:passed?).and_return(last_finished_build_passed_flag)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
@@ -36,8 +38,8 @@ describe BuildEval::Server::Travis do
       subject
     end
 
-    it "determines if the last build has failed" do
-      expect(last_build).to receive(:failed?)
+    it "determines if the last finished build has passed" do
+      expect(last_finished_build).to receive(:passed?)
 
       subject
     end
@@ -50,9 +52,9 @@ describe BuildEval::Server::Travis do
       subject
     end
 
-    context "when the last build has passed" do
+    context "when the last finished build passed" do
 
-      let(:last_build_failed_flag) { false }
+      let(:last_finished_build_passed_flag) { true }
 
       it "creates a successful build result" do
         expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Success"))
@@ -62,9 +64,9 @@ describe BuildEval::Server::Travis do
 
     end
 
-    context "when the last build has failed" do
+    context "when the last finished build failed" do
 
-      let(:last_build_failed_flag) { true }
+      let(:last_finished_build_passed_flag) { false }
 
       it "creates a failed build result" do
         expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Failure"))

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: build_eval
 version: !ruby/object:Gem::Version
-  version: 0.0.8
+  version: 0.0.9
 platform: ruby
 authors:
 - Matthew Ueckerman