build_eval 0.0.7 → 0.0.8

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    Yjk2OGI1MTg0ZWFiYjBhYTgyZDE4MmY5NzI2ODRkNDMyNWVjM2Y1NA==
+    MTJiNTE3NDJkMjUxNWRkN2FmZTMwNjViY2MxNWJjOWEzZmM4YWRjNA==
   data.tar.gz: !binary |-
-    ZjFmYmY4MjEzNzViNTYxZWExZmZiNTg1OTBiYTRjZWFiMjU3MDZmMw==
+    OTBiZjJmOWJiMDBiYjFhZjViMmEyOGIyZWRlMDY5NWIyNjc0NTFhMw==
 SHA512:
   metadata.gz: !binary |-
-    YThkNjhmN2Q4YmFmM2Q4NjU5MTk0ZjZjOGE3ZjAwODFkMWRjYjgyNWNkOTJl
-    MGYwMTUxNDVhMzRlZjE2Nzk0NjU0MjNiMDBlNTcwMzFhMThhNWNkNTNmOWFh
-    YmUxY2MxMTc1NTJlYTU4ZWIxMmU0Mjc5MmE5MzA1ZDQyYTE2NjM=
+    YmY2Y2Q3ZmMxYzUzNTkwNGEwNzc2NGYxZGNjODkyNDlhZDIwMzg0YzczODBh
+    ZDc0YWMyMjEzNzE2YWM3N2JmYmI1ZDhhNjIyMDYwM2NkODdiY2E1MzA5Nzk0
+    Y2JiZTZhMWQzNDE4NDljMWE3ZGFhZGIwYTM2ZTA3MWNmMjcxMDA=
   data.tar.gz: !binary |-
-    YjY0ZTUyZGRiMWEyYTIxNzc2MGVhYmQ1ZjRjODEwZTc4NWRlNzI2NWFiNmRl
-    Y2JmZWIzNDU5YmVjMWI3ODlkOGJiNjhmOTFlZmI4YzgzZWIyODk5Yjg3YTRh
-    ODY3NTZhYWVjZjZhMzhjNTk2MzM3ZGI5NDg5ZDAyMTk1YWYyNTk=
+    MDM5MmUwN2Q3NGQ5YWJlZDA5ZGYwY2E5NDVkMjc2YmU0NGQzNTQwZDY3N2Ri
+    MzliZGM3NjRlOWFhM2ZjMTM0ZmFjZTVhNDJkN2NiNWM3OTU3Njk5NmUwMmZm
+    OWQ0MTg3MmE2ODU3MGQ2Y2Y5MzAwN2RiNWQzMDRhYjc2YzFhNDU=

data/lib/build_eval/server/travis_pro.rb

@@ -4,16 +4,15 @@ module BuildEval
     class TravisPro
 
       def initialize(args)
-        @username = args[:username]
-        ::Travis::Pro.github_auth(args[:github_token])
+        @username     = args[:username]
+        @github_token = args[:github_token]
       end
 
       def build_result(name)
-        repo_string = "#{@username}/#{name}"
-        has_failed = ::Travis::Pro::Repository.find(repo_string).recent_builds.first.failed?
+        repository_path = "#{@username}/#{name}"
         BuildEval::Result::BuildResult.create(
-          build_name:  repo_string,
-          status_name: has_failed ? "Failure" : "Success"
+          build_name:  repository_path,
+          status_name: last_build_failed?(repository_path) ? "Failure" : "Success"
         )
       end
 
@@ -21,7 +20,14 @@ module BuildEval
         "Travis CI Pro #{@username}"
       end
 
+      private
+
+      def last_build_failed?(repository_path)
+        ::Travis::Pro.github_auth(@github_token)
+        ::Travis::Pro::Repository.find(repository_path).recent_builds.first.failed?
+      end
+
     end
-  end
 
+  end
 end

data/lib/build_eval/version.rb

@@ -1,3 +1,3 @@
 module BuildEval
-  VERSION = "0.0.7".freeze
+  VERSION = "0.0.8".freeze
 end

data/spec/lib/build_eval/server/travis_pro_spec.rb

@@ -12,20 +12,6 @@ describe BuildEval::Server::TravisPro do
 
   let(:travis_pro_server) { described_class.new(constructor_args) }
 
-  before(:example) { allow(::Travis::Pro).to receive(:github_auth) }
-
-  describe "#initialize" do
-
-    subject { described_class.new(constructor_args) }
-
-    it "establishes the GitHub auth token" do
-      expect(::Travis::Pro).to receive(:github_auth).with(github_token)
-
-      subject
-    end
-
-  end
-
   describe "#build_result" do
 
     let(:build_name)             { "some_build_name" }
@@ -38,31 +24,38 @@ describe BuildEval::Server::TravisPro do
     subject { travis_pro_server.build_result(build_name) }
 
     before(:example) do
+      allow(::Travis::Pro).to receive(:github_auth)
       allow(::Travis::Pro::Repository).to receive(:find).and_return(travis_repository)
       allow(travis_repository).to receive(:recent_builds).and_return(recent_builds)
       allow(last_build).to receive(:failed?).and_return(last_build_failed_flag)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
-    it "retrieves the relevant Travis repository" do
+    it "logs-in to Travis Pro using the provided GitHub token" do
+      expect(::Travis::Pro).to receive(:github_auth).with(github_token)
+
+      subject
+    end
+
+    it "retrieves the relevant Travis Pro Repository" do
       expect(::Travis::Pro::Repository).to receive(:find).with("#{username}/#{build_name}")
 
       subject
     end
 
-    it "retrieves the recent builds from Travis" do
+    it "retrieves the recent builds from the Travis Repository" do
       expect(travis_repository).to receive(:recent_builds)
 
       subject
     end
 
-    it "retrieves the build status from the last build" do
+    it "determines if the last build has failed" do
       expect(last_build).to receive(:failed?)
 
       subject
     end
 
-    it "creates a build result whose build name is the path to the repository" do
+    it "creates a build result whose build name is the path to the GitHub repository" do
       expect(BuildEval::Result::BuildResult).to(
         receive(:create).with(hash_including(build_name: "#{username}/#{build_name}"))
       )
@@ -70,7 +63,7 @@ describe BuildEval::Server::TravisPro do
       subject
     end
 
-    context "when the last build has passed" do
+    context "when the last build had passed" do
 
       let(:last_build_failed_flag) { false }
 
@@ -82,7 +75,7 @@ describe BuildEval::Server::TravisPro do
 
     end
 
-    context "when the last build has failed" do
+    context "when the last build had failed" do
 
       let(:last_build_failed_flag) { true }
 
@@ -94,7 +87,7 @@ describe BuildEval::Server::TravisPro do
 
     end
 
-    it "returns the parsed build result" do
+    it "returns the build result" do
       expect(subject).to eql(build_result)
     end
 

data/spec/lib/build_eval/server/travis_spec.rb

@@ -30,13 +30,13 @@ describe BuildEval::Server::Travis do
       subject
     end
 
-    it "retrieves the recent builds from Travis" do
+    it "retrieves the recent builds from the Travis repository" do
       expect(travis_repository).to receive(:recent_builds)
 
       subject
     end
 
-    it "retrieves the status of the last build" do
+    it "determines if the last build has failed" do
       expect(last_build).to receive(:failed?)
 
       subject
@@ -74,7 +74,7 @@ describe BuildEval::Server::Travis do
 
     end
 
-    it "returns the parsed build result" do
+    it "returns the build result" do
       expect(subject).to eql(build_result)
     end
 

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: build_eval
 version: !ruby/object:Gem::Version
-  version: 0.0.7
+  version: 0.0.8
 platform: ruby
 authors:
 - Matthew Ueckerman