build_eval 0.0.9 → 0.0.10

checksums.yaml

@@ -1,15 +1,15 @@
 ---
 !binary "U0hBMQ==":
   metadata.gz: !binary |-
-    N2I3Zjc5OWM0NDBmMTQ1MTM1YjVhODE1OWI3NTk0NzE1NGI0Y2Y3Mg==
+    Y2RmM2FlM2IyNDIwNGI2YmRmZjM0ODkyOTU1Y2MxNzBiZmEyNjY4MQ==
   data.tar.gz: !binary |-
-    NWUyZDEyMzExZDM0NjkwMzY5MWNjNDczNGRkMzg0YTE0OWNlYzcxMg==
+    OTRkNzVhNjY0Njg5Y2NhZWMwN2Q2Y2NjMzYxYmEyZDZlODQxNTNiNg==
 SHA512:
   metadata.gz: !binary |-
-    NTc3NGQyZmNiZjg0MmFjYzE2NDFkZmQ2OTBhZTc5ZTRhZjI2NTdkMmY5ZThh
-    N2NlNDUyODA4ZjgxMzlhMjhjMGU3N2NlNDljMGI0MmI4OGI5YWI3YWM4Y2E1
-    MzI1ZDc4YTdiOGNmMjYwMjIyYjU5MDBhOTAzMDBmOWUxNjYxZjU=
+    Y2FiMDJhZjdlYTA0Yzg0NGU2NDMyMTJhMjk4MTYzYzBhNTY5ZDA2OTAyODlm
+    YmFlMWRmOWJiZDE2Y2VkOWEyODA4MWFkOTM4NmI0ZjcwZDNhMzE5MzhmNmI2
+    ZTFlNjYwMzlhOWE1ODBjMGM4ZTJiMGIwNTk2YWQ2Y2U1NjU4NDY=
   data.tar.gz: !binary |-
-    MTQzZWEyOWY2NmExZTBiZTkxNDhkOTM2M2EyYmZmOTZhOGYyMzcyMzVmYjgx
-    YTgzODM5ODM3YzRmMjE2NDg0NDcxN2NmNDZjZTZjMzA1MGJhZjE3MDEyNjY5
-    ZDkwOWIwOTQzYmRhNTZjNWYyMzdhMWE0ZjI2YTRhZTYwZjc5MWE=
+    NDZiYjI2Yzg4OWRhNWE2YmM0OGMzMjE3YmE2NDQ1MTZhYzQwNDY0ZjQwZGNi
+    ODBmNmFiOGI3YTc2NjY5ZDg3NzY0YTM0ZjRmZmI2ZGU2Y2Q0MWY4NDlhOWIw
+    NzI1MWQ3ZjhiMzg3YzQ5OWYwMDc5NWI4NTkxODg3ODYxMWEzMWM=

data/lib/build_eval/server/travis.rb

@@ -5,23 +5,21 @@ module BuildEval
 
       def initialize(args)
         @username = args[:username]
+        @travis   = BuildEval::Travis.new(::Travis)
       end
 
       def build_result(name)
         build_path = "#{@username}/#{name}"
-        BuildEval::Result::BuildResult.create(build_name: build_path, status_name: last_status_name(build_path))
+        BuildEval::Result::BuildResult.create(
+          build_name:  build_path,
+          status_name: @travis.last_build_status_for(build_path)
+        )
       end
 
       def to_s
         "Travis CI #{@username}"
       end
 
-      private
-
-      def last_status_name(build_path)
-        ::Travis::Repository.find(build_path).recent_builds.find(&:finished?).passed? ? "Success" : "Failure"
-      end
-
     end
 
   end

data/lib/build_eval/server/travis_pro.rb

@@ -6,6 +6,7 @@ module BuildEval
       def initialize(args)
         @username     = args[:username]
         @github_token = args[:github_token]
+        @travis       = BuildEval::Travis.new(::Travis::Pro)
       end
 
       def build_result(name)
@@ -20,8 +21,8 @@ module BuildEval
       private
 
       def last_status_name(build_path)
-        ::Travis::Pro.github_auth(@github_token)
-        ::Travis::Pro::Repository.find(build_path).recent_builds.find(&:finished?).passed? ? "Success" : "Failure"
+        @travis.login(@github_token)
+        @travis.last_build_status_for(build_path)
       end
 
     end

data/lib/build_eval/travis.rb

@@ -0,0 +1,21 @@
+module BuildEval
+
+  class Travis
+
+    def initialize(travis_module)
+      @travis_module = travis_module
+    end
+
+    def login(auth_token)
+      @travis_module.github_auth(auth_token)
+    end
+
+    def last_build_status_for(build_path)
+      @travis_module::Repository.find(build_path).recent_builds.find(&:finished?).passed? ? "Success" : "Failure"
+    rescue ::Travis::Client::Error
+      "Unknown"
+    end
+
+  end
+
+end

data/lib/build_eval/version.rb

@@ -1,3 +1,3 @@
 module BuildEval
-  VERSION = "0.0.9".freeze
+  VERSION = "0.0.10".freeze
 end

data/lib/build_eval.rb

@@ -7,6 +7,7 @@ require 'travis/tools/github'
 
 require_relative 'build_eval/error'
 require_relative 'build_eval/http'
+require_relative 'build_eval/travis'
 require_relative 'build_eval/result/status'
 require_relative 'build_eval/result/build_result'
 require_relative 'build_eval/result/server_result'

data/spec/lib/build_eval/server/travis_pro_spec.rb

@@ -1,5 +1,5 @@
 describe BuildEval::Server::TravisPro do
-  include_context "stubbed http interactions"
+  include_context "stubbed Travis API interactions"
 
   let(:username)     { "some_username" }
   let(:github_token) { "ABCD1234" }
@@ -14,45 +14,32 @@ describe BuildEval::Server::TravisPro do
 
   describe "#build_result" do
 
-    let(:build_name)                      { "some_build_name" }
-    let(:travis_repository)               { instance_double(::Travis::Client::Repository) }
-    let(:recent_builds)                   do
-      (1..3).map { |i| instance_double(::Travis::Client::Build, finished?: i > 1) }
-    end
-    let(:last_finished_build)             { recent_builds[1] }
-    let(:last_finished_build_passed_flag) { true }
-    let(:build_result)                    { instance_double(BuildEval::Result::BuildResult) }
+    let(:build_name)        { "some_build_name" }
+    let(:last_build_status) { "Unknown" }
+    let(:travis)            { instance_double(BuildEval::Travis, login: nil, last_build_status_for: last_build_status) }
+    let(:build_result)      { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_pro_server.build_result(build_name) }
 
     before(:example) do
-      allow(::Travis::Pro).to receive(:github_auth)
-      allow(::Travis::Pro::Repository).to receive(:find).and_return(travis_repository)
-      allow(travis_repository).to receive(:recent_builds).and_return(recent_builds)
-      allow(last_finished_build).to receive(:passed?).and_return(last_finished_build_passed_flag)
+      allow(BuildEval::Travis).to receive(:new).and_return(travis)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
-    it "logs-in to Travis Pro using the provided GitHub token" do
-      expect(::Travis::Pro).to receive(:github_auth).with(github_token)
-
-      subject
-    end
-
-    it "retrieves the relevant Travis Pro Repository" do
-      expect(::Travis::Pro::Repository).to receive(:find).with("#{username}/#{build_name}")
+    it "creates a Travis API wrapping the Pro module" do
+      expect(BuildEval::Travis).to receive(:new).with(::Travis::Pro)
 
       subject
     end
 
-    it "retrieves the recent builds from the Travis Repository" do
-      expect(travis_repository).to receive(:recent_builds)
+    it "logs-in to the Travis API using the provided GitHub token" do
+      expect(travis).to receive(:login).with(github_token)
 
       subject
     end
 
-    it "determines if the last finished build has passed" do
-      expect(last_finished_build).to receive(:passed?)
+    it "retrieves the last build status for the GitHub repository" do
+      expect(travis).to receive(:last_build_status_for).with("#{username}/#{build_name}")
 
       subject
     end
@@ -65,28 +52,12 @@ describe BuildEval::Server::TravisPro do
       subject
     end
 
-    context "when the last finished build passed" do
-
-      let(:last_finished_build_passed_flag) { true }
-
-      it "creates a successful build result" do
-        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Success"))
-
-        subject
-      end
-
-    end
-
-    context "when the last finished build failed" do
-
-      let(:last_finished_build_passed_flag) { false }
-
-      it "creates a failed build result" do
-        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Failure"))
-
-        subject
-      end
+    it "creates a build result whose status is the status the last build status" do
+      expect(BuildEval::Result::BuildResult).to(
+        receive(:create).with(hash_including(status_name: last_build_status))
+      )
 
+      subject
     end
 
     it "returns the build result" do

data/spec/lib/build_eval/server/travis_spec.rb

@@ -1,5 +1,5 @@
 describe BuildEval::Server::Travis do
-  include_context "stubbed http interactions"
+  include_context "stubbed Travis API interactions"
 
   let(:username)         { "some_username" }
   let(:constructor_args) { { username: username } }
@@ -8,43 +8,31 @@ describe BuildEval::Server::Travis do
 
   describe "#build_result" do
 
-    let(:build_name)                      { "some_build_name" }
-    let(:travis_repository)               { instance_double(::Travis::Client::Repository) }
-    let(:recent_builds)                   do
-      (1..3).map { |i| instance_double(::Travis::Client::Build, finished?: i > 1) }
-    end
-    let(:last_finished_build)             { recent_builds[1] }
-    let(:last_finished_build_passed_flag) { true }
-    let(:build_result)                    { instance_double(BuildEval::Result::BuildResult) }
+    let(:build_name)        { "some_build_name" }
+    let(:last_build_status) { "Failure" }
+    let(:travis)            { instance_double(BuildEval::Travis, last_build_status_for: last_build_status) }
+    let(:build_result)      { instance_double(BuildEval::Result::BuildResult) }
 
     subject { travis_server.build_result(build_name) }
 
     before(:example) do
-      allow(::Travis::Repository).to receive(:find).and_return(travis_repository)
-      allow(travis_repository).to receive(:recent_builds).and_return(recent_builds)
-      allow(last_finished_build).to receive(:passed?).and_return(last_finished_build_passed_flag)
+      allow(BuildEval::Travis).to receive(:new).and_return(travis)
       allow(BuildEval::Result::BuildResult).to receive(:create).and_return(build_result)
     end
 
-    it "retrieves the relevant Travis repository" do
-      expect(::Travis::Repository).to receive(:find).with("#{username}/#{build_name}")
-
-      subject
-    end
-
-    it "retrieves the recent builds from the Travis repository" do
-      expect(travis_repository).to receive(:recent_builds)
+    it "creates a Travis API wrapping the Standard module" do
+      expect(BuildEval::Travis).to receive(:new).with(::Travis)
 
       subject
     end
 
-    it "determines if the last finished build has passed" do
-      expect(last_finished_build).to receive(:passed?)
+    it "retrieves the last build status for the GitHub repository" do
+      expect(travis).to receive(:last_build_status_for).with("#{username}/#{build_name}")
 
       subject
     end
 
-    it "creates a build result whose build name is the path to the repository" do
+    it "creates a build result whose build name is the path to the GitHub repository" do
       expect(BuildEval::Result::BuildResult).to(
         receive(:create).with(hash_including(build_name: "#{username}/#{build_name}"))
       )
@@ -52,28 +40,12 @@ describe BuildEval::Server::Travis do
       subject
     end
 
-    context "when the last finished build passed" do
-
-      let(:last_finished_build_passed_flag) { true }
-
-      it "creates a successful build result" do
-        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Success"))
-
-        subject
-      end
-
-    end
-
-    context "when the last finished build failed" do
-
-      let(:last_finished_build_passed_flag) { false }
-
-      it "creates a failed build result" do
-        expect(BuildEval::Result::BuildResult).to receive(:create).with(hash_including(status_name: "Failure"))
-
-        subject
-      end
+    it "creates a build result whose status is the status the last build status" do
+      expect(BuildEval::Result::BuildResult).to(
+        receive(:create).with(hash_including(status_name: last_build_status))
+      )
 
+      subject
     end
 
     it "returns the build result" do

data/spec/lib/build_eval/travis_shared_context.rb

@@ -0,0 +1,7 @@
+shared_context "stubbed Travis API interactions" do
+
+  let(:travis_namespace) { instance_double(::Travis::Client::Namespace) }
+
+  before(:each) { allow(::Travis::Client::Namespace).to receive(:new).and_return(travis_namespace) }
+
+end

data/spec/lib/build_eval/travis_spec.rb

@@ -0,0 +1,94 @@
+describe BuildEval::Travis do
+  include_context "stubbed Travis API interactions"
+
+  let(:travis_module) { ::Travis }
+
+  let(:travis) { described_class.new(travis_module) }
+
+  describe "#login" do
+
+    let(:github_token) { "SOMEGITHUBTOKEN" }
+
+    subject { travis.login(github_token) }
+
+    it "logs-in to Travis using the GitHub Auth token provided" do
+      expect(travis_module).to receive(:github_auth).with(github_token)
+
+      subject
+    end
+
+  end
+
+  describe "#last_build_status_for" do
+
+    let(:build_path) { "some/build_path" }
+
+    let(:recent_builds)                   do
+      (1..3).map { |i| instance_double(::Travis::Client::Build, finished?: i > 1) }
+    end
+    let(:last_finished_build)             { recent_builds[1] }
+    let(:last_finished_build_passed_flag) { true }
+    let(:travis_repository)               do
+      instance_double(::Travis::Client::Repository, recent_builds: recent_builds)
+    end
+
+    subject { travis.last_build_status_for(build_path) }
+
+    before(:example) do
+      allow(travis_module::Repository).to receive(:find).and_return(travis_repository)
+      allow(last_finished_build).to receive(:passed?).and_return(last_finished_build_passed_flag)
+    end
+
+    it "retrieves the Travis Repository for the provided build path" do
+      expect(travis_module::Repository).to receive(:find).with(build_path)
+
+      subject
+    end
+
+    it "retrieves the recent builds from the Travis Repository" do
+      expect(travis_repository).to receive(:recent_builds)
+
+      subject
+    end
+
+    it "determines if the last finished build has passed" do
+      expect(last_finished_build).to receive(:passed?)
+
+      subject
+    end
+
+    context "when the last finished build passed" do
+
+      let(:last_finished_build_passed_flag) { true }
+
+      it "returns 'Success'" do
+        expect(subject).to eql("Success")
+      end
+
+    end
+
+    context "when the last finished build failed" do
+
+      let(:last_finished_build_passed_flag) { false }
+
+      it "returns 'Failure'" do
+        expect(subject).to eql("Failure")
+      end
+
+    end
+
+    context "when an Travis Client error occurs" do
+
+      before(:example) do
+        allow(travis_repository).to receive(:recent_builds).and_raise(::Travis::Client::Error.new("Forced error"))
+      end
+
+      it "returns 'Unknown'" do
+        expect(subject).to eql("Unknown")
+      end
+
+    end
+
+  end
+
+end

data/spec/lib/build_eval_smoke_spec.rb

@@ -1,7 +1,8 @@
 describe BuildEval, "integrating with a real CI server", smoke: true do
-  let(:server) { BuildEval.server(type: :Travis, username: "MYOB-Technology") }
 
-  let(:monitor) { server.monitor("build_eval") }
+  let(:builds)  { BuildEval::Examples::Travis.builds }
+
+  let(:monitor) { BuildEval::Examples::Travis.monitor }
 
   describe "the evaluated results from a build monitor for the server" do
 
@@ -16,12 +17,14 @@ describe BuildEval, "integrating with a real CI server", smoke: true do
 
     subject { monitor.evaluate }
 
-    it "indicate the builds status" do
+    it "indicates the combined status of all builds" do
       expect(tolerated_statuses).to include(subject.status)
     end
 
-    it "describe the build and its status" do
-      expect(subject.to_s).to match(/build_eval: (#{tolerated_statuses.map(&:to_s).join("|")})/)
+    it "describes the builds and their individual status" do
+      builds.each do |build|
+        expect(subject.to_s).to match(/#{build}: (#{tolerated_statuses.map(&:to_s).join("|")})/)
+      end
     end
 
   end

data/spec/spec_helper.rb

@@ -7,6 +7,7 @@ if ENV['coverage']
   SimpleCov.start do
     coverage_dir 'tmp/coverage'
 
+    add_filter '/examples/'
     add_filter '/spec/'
 
     minimum_coverage 100
@@ -15,6 +16,7 @@ if ENV['coverage']
 end
 
 require_relative '../lib/build_eval'
+require_relative '../examples/travis'
 
 %w( shared_examples shared_context ).each do |file_type|
   Dir[::File.expand_path("../**/*_#{file_type}.rb", __FILE__)].each { |file| require file }

metadata

@@ -1,7 +1,7 @@
 --- !ruby/object:Gem::Specification
 name: build_eval
 version: !ruby/object:Gem::Version
-  version: 0.0.9
+  version: 0.0.10
 platform: ruby
 authors:
 - Matthew Ueckerman
@@ -10,7 +10,7 @@ authors:
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-06-22 00:00:00.000000000 Z
+date: 2016-06-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: nokogiri
@@ -162,6 +162,7 @@ files:
 - ./lib/build_eval/server/team_city.rb
 - ./lib/build_eval/server/travis.rb
 - ./lib/build_eval/server/travis_pro.rb
+- ./lib/build_eval/travis.rb
 - ./lib/build_eval/version.rb
 - ./spec/lib/build_eval/error_spec.rb
 - ./spec/lib/build_eval/http_shared_context.rb
@@ -183,6 +184,8 @@ files:
 - ./spec/lib/build_eval/server/team_city_spec.rb
 - ./spec/lib/build_eval/server/travis_pro_spec.rb
 - ./spec/lib/build_eval/server/travis_spec.rb
+- ./spec/lib/build_eval/travis_shared_context.rb
+- ./spec/lib/build_eval/travis_spec.rb
 - ./spec/lib/build_eval_smoke_spec.rb
 - ./spec/lib/build_eval_spec.rb
 - ./spec/spec_helper.rb
@@ -231,6 +234,8 @@ test_files:
 - ./spec/lib/build_eval/server/team_city_spec.rb
 - ./spec/lib/build_eval/server/travis_pro_spec.rb
 - ./spec/lib/build_eval/server/travis_spec.rb
+- ./spec/lib/build_eval/travis_shared_context.rb
+- ./spec/lib/build_eval/travis_spec.rb
 - ./spec/lib/build_eval_smoke_spec.rb
 - ./spec/lib/build_eval_spec.rb
 - ./spec/spec_helper.rb