bugsnag 5.1.0 → 5.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 3f0f6a45c465fe50809b882075249dcfcc1ef50b
-  data.tar.gz: be4d6495a21ed0d396e8c225520d3f99c3809796
+  metadata.gz: d4b00bead73bfc579980368d65edb60286f0531b
+  data.tar.gz: fbb45b08f2dc84545752c020110bb5c0bc746706
 SHA512:
-  metadata.gz: 922f1851260cfe26d8f650eaeb2363a79a6f8d23c4eb5967cf3d9cbcf4343eab4649bc4bb61e1b96b93943396644820f31af8b1c0ade13e8507aa02693151f0f
-  data.tar.gz: 3950c972f77ccd51637f3f167207cc4b2b17be9db6ff4165b88ba8d1bae5416a0313e48923d84c021038983bfa8caa9d20b54e163653737113e37fdf413d9ca9
+  metadata.gz: 08581bdce123264cbd592ddb6c4074f03b4d7d044bfa8ef8e72ee4af29dce3c34d183bb5db93b2fe770eee9b170ce39220969c6d93f784ab87dc50fb270a355b
+  data.tar.gz: baa4a8957c00e2ac6608471ff19b3976dbe076b4c63fb3277c3c24ecfb18586fb40a80a896c3d8a1685cc3062d859311730f26e0e03fa0e1eb3586caf5c97b43

data/CHANGELOG.md

@@ -1,6 +1,26 @@
 Changelog
 =========
 
+## 5.2.0 (10 February 2017)
+
+### Enhancements
+
+* Allow provider attribute in Deploy#notify
+  | [@jbaranov](https://github.com/jbaranov)
+  | [#339](https://github.com/bugsnag/bugsnag-ruby/pull/339)
+
+### Bug fixes
+
+* Correctly hook on Action Controller
+  | [@rafaelfranca](https://github.com/rafaelfranca)
+  | [#338](https://github.com/bugsnag/bugsnag-ruby/pull/338)
+* Fix Bugsnag error message typo
+  | [@Adsidera](https://github.com/Adsidera)
+  | [#344](https://github.com/bugsnag/bugsnag-ruby/pull/344)
+* Default delivery method
+  | [@martin308](https://github.com/martin308)
+  | [#346](https://github.com/bugsnag/bugsnag-ruby/pull/346)
+
 ## 5.1.0 (23 January 2017)
 
 ### Bug fixes

data/VERSION

@@ -1 +1 @@
-5.1.0
+5.2.0

data/lib/bugsnag/capistrano2.rb

@@ -18,7 +18,7 @@ module Bugsnag
                 :app_version => fetch(:app_version, ENV["BUGSNAG_APP_VERSION"]))
               })
             rescue
-              logger.important("Bugnsag deploy notification failed, #{$!.inspect}")
+              logger.important("Bugsnag deploy notification failed, #{$!.inspect}")
             end
 
             logger.info "Bugsnag deploy notification complete."

data/lib/bugsnag/configuration.rb

@@ -31,7 +31,6 @@ module Bugsnag
     attr_accessor :proxy_password
     attr_accessor :timeout
     attr_accessor :hostname
-    attr_accessor :delivery_method
     attr_writer :ignore_classes
 
     THREAD_LOCAL_NAME = "bugsnag_req_data"
@@ -77,7 +76,6 @@ module Bugsnag
       self.ignore_user_agents = Set.new(DEFAULT_IGNORE_USER_AGENTS)
       self.endpoint = DEFAULT_ENDPOINT
       self.hostname = default_hostname
-      self.delivery_method = DEFAULT_DELIVERY_METHOD
       self.timeout = 15
       self.vendor_paths = [%r{vendor/}]
       self.notify_release_stages = nil
@@ -96,6 +94,30 @@ module Bugsnag
       self.middleware.use Bugsnag::Middleware::Callbacks
     end
 
+    ##
+    # Gets the delivery_method that Bugsnag will use to communicate with the
+    # notification endpoint.
+    #
+    def delivery_method
+      @delivery_method || @default_delivery_method || DEFAULT_DELIVERY_METHOD
+    end
+
+    ##
+    # Sets the delivery_method that Bugsnag will use to communicate with the
+    # notification endpoint.
+    #
+    def delivery_method=(delivery_method)
+      @delivery_method = delivery_method
+    end
+
+    ##
+    # Used to set a new default delivery method that will be used if one is not
+    # set with #delivery_method.
+    #
+    def default_delivery_method=(delivery_method)
+      @default_delivery_method = delivery_method
+    end
+
     # Accept both String and Class instances as an ignored class
     def ignore_classes
       @mutex.synchronize { @ignore_classes.map! { |klass| klass.is_a?(Class) ? klass.name : klass } }

data/lib/bugsnag/deploy.rb

@@ -22,7 +22,8 @@ module Bugsnag
         "appVersion" => configuration.app_version,
         "revision" => opts[:revision],
         "repository" => opts[:repository],
-        "branch" => opts[:branch]
+        "branch" => opts[:branch],
+        "provider" => opts[:provider]
       }.reject {|k,v| v == nil}
 
       raise RuntimeError.new("No API key found when notifying of deploy") if !parameters["apiKey"] || parameters["apiKey"].empty?

data/lib/bugsnag/railtie.rb

@@ -37,12 +37,9 @@ module Bugsnag
       config = YAML.load_file(config_file) if File.exist?(config_file)
       Bugsnag.configure(config[::Rails.env] ? config[::Rails.env] : config) if config
 
-      if defined?(::ActionController::Base)
+      ActiveSupport.on_load(:action_controller) do
         require "bugsnag/rails/controller_methods"
-        ::ActionController::Base.send(:include, Bugsnag::Rails::ControllerMethods)
-      end
-      if defined?(ActionController::API)
-        ActionController::API.send(:include, Bugsnag::Rails::ControllerMethods)
+        include Bugsnag::Rails::ControllerMethods
       end
       ActiveSupport.on_load(:active_record) do
         require "bugsnag/rails/active_record_rescue"

data/lib/bugsnag/resque.rb

@@ -26,7 +26,7 @@ module Bugsnag
     end
 
     def save
-      Bugsnag.auto_notify(exception, {:context => "#{payload['class']}@#{queue}", :payload => payload, :delivery_method => :synchronous})
+      Bugsnag.auto_notify(exception, {:context => "#{payload['class']}@#{queue}", :payload => payload})
     end
   end
 end
@@ -39,5 +39,5 @@ Bugsnag::Resque.add_failure_backend
 
 Resque.before_first_fork do
   Bugsnag.configuration.app_type = "resque"
-  Bugsnag.configuration.delivery_method = :synchronous
+  Bugsnag.configuration.default_delivery_method = :synchronous
 end

data/lib/bugsnag/shoryuken.rb

@@ -4,7 +4,7 @@ module Bugsnag
   class Shoryuken
     def initialize
       Bugsnag.configuration.app_type = "shoryuken"
-      Bugsnag.configuration.delivery_method = :synchronous
+      Bugsnag.configuration.default_delivery_method = :synchronous
     end
 
     def call(_, queue, _, body)

data/lib/bugsnag/sidekiq.rb

@@ -5,7 +5,7 @@ module Bugsnag
     def initialize
       Bugsnag.configuration.internal_middleware.use(Bugsnag::Middleware::Sidekiq)
       Bugsnag.configuration.app_type = "sidekiq"
-      Bugsnag.configuration.delivery_method = :synchronous
+      Bugsnag.configuration.default_delivery_method = :synchronous
     end
 
     def call(worker, msg, queue)

data/spec/configuration_spec.rb

@@ -0,0 +1,26 @@
+# encoding: utf-8
+require 'spec_helper'
+
+describe Bugsnag::Configuration do
+  describe "delivery_method" do
+    it "should have the default delivery method" do
+      expect(subject.delivery_method).to eq(Bugsnag::Configuration::DEFAULT_DELIVERY_METHOD)
+    end
+
+    it "should have the defined delivery_method" do
+      subject.delivery_method = :test
+      expect(subject.delivery_method).to eq(:test)
+    end
+
+    it "should allow a new default delivery_method to be set" do
+      subject.default_delivery_method = :test
+      expect(subject.delivery_method).to eq(:test)
+    end
+
+    it "should allow the delivery_method to be set over a default" do
+      subject.default_delivery_method = :test
+      subject.delivery_method = :wow
+      expect(subject.delivery_method).to eq(:wow)
+    end
+  end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 5.1.0
+  version: 5.2.0
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2017-01-23 00:00:00.000000000 Z
+date: 2017-02-10 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -158,6 +158,7 @@ files:
 - rails/init.rb
 - spec/cleaner_spec.rb
 - spec/code_spec.rb
+- spec/configuration_spec.rb
 - spec/fixtures/crashes/end_of_file.rb
 - spec/fixtures/crashes/short_file.rb
 - spec/fixtures/crashes/start_of_file.rb