bugsnag 5.0.1 → 5.1.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 23cafc9f023e6c956fe901ba153135c7c6443247
-  data.tar.gz: 0f46e18ea6d4e69601e3c68038dd04be2b1316c9
+  metadata.gz: 3f0f6a45c465fe50809b882075249dcfcc1ef50b
+  data.tar.gz: be4d6495a21ed0d396e8c225520d3f99c3809796
 SHA512:
-  metadata.gz: 87006c230acdf61331523fda1d3245e5a527c03475d723e46748843a2f3992431514d426bed9e03364fc8a1711dcf8149fd95457630768943d128541157216eb
-  data.tar.gz: 5808f705aac760af3d681caffe5b4ff5a34b8f870ef3069a2374f280fe0df285f4b737fe95ebfb5d435db82fe006ffef60f1dde6555fe564e3a06f6fe0bf069e
+  metadata.gz: 922f1851260cfe26d8f650eaeb2363a79a6f8d23c4eb5967cf3d9cbcf4343eab4649bc4bb61e1b96b93943396644820f31af8b1c0ade13e8507aa02693151f0f
+  data.tar.gz: 3950c972f77ccd51637f3f167207cc4b2b17be9db6ff4165b88ba8d1bae5416a0313e48923d84c021038983bfa8caa9d20b54e163653737113e37fdf413d9ca9

data/.travis.yml

@@ -10,5 +10,4 @@ rvm:
 - jruby-19mode
 
 before_install:
-- gem update --system 2.1.11
 - gem --version

data/CHANGELOG.md

@@ -1,6 +1,22 @@
 Changelog
 =========
 
+## 5.1.0 (23 January 2017)
+
+### Bug fixes
+
+* Fix behavior to not override Rails 5 `belongs_to` association
+  | [#314](https://github.com/bugsnag/bugsnag-ruby/pull/314)
+
+### Enhancements
+
+* Add Clearance support
+  | [Jonathan Rochkind](https://github.com/jrochkind)
+  | [#313](https://github.com/bugsnag/bugsnag-ruby/pull/313)
+* Add Shoruken support
+  | [Nigel Ramsay](https://github.com/nigelramsay)
+  | [#324](https://github.com/bugsnag/bugsnag-ruby/pull/324)
+
 ## 5.0.1 (7 September 2016)
 
 ### Bug fixes

data/CONTRIBUTING.md

@@ -30,7 +30,7 @@ If you're a member of the core team, follow these instructions for releasing bug
 * Commit/push your changes
 
     ```
-    git commit -am v2.X.X
+    git commit -am v5.X.X
     git push origin master
     ```
 

data/VERSION

@@ -1 +1 @@
-5.0.1
+5.1.0

data/bugsnag.gemspec

@@ -24,5 +24,5 @@ Gem::Specification.new do |s|
   s.add_development_dependency 'rdoc'
   s.add_development_dependency 'pry'
   s.add_development_dependency 'addressable', '~> 2.3.8'
-  s.add_development_dependency 'webmock'
+  s.add_development_dependency 'webmock', '2.1.0'
 end

data/lib/bugsnag.rb

@@ -18,6 +18,7 @@ require "bugsnag/railtie" if defined?(Rails::Railtie)
 
 require "bugsnag/middleware/rack_request"
 require "bugsnag/middleware/warden_user"
+require "bugsnag/middleware/clearance_user"
 require "bugsnag/middleware/callbacks"
 require "bugsnag/middleware/rails3_request"
 require "bugsnag/middleware/sidekiq"
@@ -130,7 +131,7 @@ module Bugsnag
   end
 end
 
-[:resque, :sidekiq, :mailman, :delayed_job].each do |integration|
+[:resque, :sidekiq, :mailman, :delayed_job, :shoryuken].each do |integration|
   begin
     require "bugsnag/#{integration}"
   rescue LoadError

data/lib/bugsnag/cleaner.rb

@@ -37,7 +37,7 @@ module Bugsnag
         end
         clean_hash
       when Array, Set
-        obj.map { |el| traverse_object(el, seen, scope) }.compact
+        obj.map { |el| traverse_object(el, seen, scope) }
       when Numeric, TrueClass, FalseClass
         obj
       when String

data/lib/bugsnag/helpers.rb

@@ -13,6 +13,7 @@ module Bugsnag
     # Trim the size of value if the serialized JSON value is longer than is
     # accepted by Bugsnag
     def self.trim_if_needed(value)
+      value = "" if value.nil?
       sanitized_value = Bugsnag::Cleaner.clean_object_encoding(value)
       return sanitized_value unless payload_too_long?(sanitized_value)
       reduced_value = trim_strings_in_value(sanitized_value)
@@ -67,7 +68,11 @@ module Bugsnag
     # Validate that the serialized JSON string value is below maximum payload
     # length
     def self.payload_too_long?(value)
-      ::JSON.dump(value).length >= MAX_PAYLOAD_LENGTH
+      if value.is_a?(String)
+        value.length >= MAX_PAYLOAD_LENGTH
+      else
+        ::JSON.dump(value).length >= MAX_PAYLOAD_LENGTH
+      end
     end
 
     def self.trim_strings_in_hash(hash)

data/lib/bugsnag/middleware/clearance_user.rb

@@ -0,0 +1,31 @@
+module Bugsnag::Middleware
+  class ClearanceUser
+    COMMON_USER_FIELDS = [:email, :name, :first_name, :last_name, :created_at, :id]
+
+    def initialize(bugsnag)
+      @bugsnag = bugsnag
+    end
+
+    def call(notification)
+      if notification.request_data[:rack_env] &&
+            notification.request_data[:rack_env][:clearance] &&
+            notification.request_data[:rack_env][:clearance].signed_in? &&
+            notification.request_data[:rack_env][:clearance].current_user
+
+        # Extract useful user information
+        user = {}
+        user_object = notification.request_data[:rack_env][:clearance].current_user
+        if user_object
+          # Build the bugsnag user info from the current user record
+          COMMON_USER_FIELDS.each do |field|
+            user[field] = user_object.send(field) if user_object.respond_to?(field)
+          end
+        end
+
+        notification.user = user unless user.empty?
+      end
+
+      @bugsnag.call(notification)
+    end
+  end
+end

data/lib/bugsnag/rack.rb

@@ -20,6 +20,7 @@ module Bugsnag
         # Hook up rack-based notification middlewares
         config.middleware.insert_before([Bugsnag::Middleware::Rails3Request,Bugsnag::Middleware::Callbacks], Bugsnag::Middleware::RackRequest) if defined?(::Rack)
         config.middleware.insert_before(Bugsnag::Middleware::Callbacks, Bugsnag::Middleware::WardenUser) if defined?(Warden)
+        config.middleware.insert_before(Bugsnag::Middleware::Callbacks, Bugsnag::Middleware::ClearanceUser) if defined?(Clearance)
 
         Bugsnag.configuration.app_type ||= "rack"
       end

data/lib/bugsnag/rails.rb

@@ -31,7 +31,7 @@ module Bugsnag
 
       # Auto-load configuration settings from config/bugsnag.yml if it exists
       config_file = File.join(rails_root, "config", "bugsnag.yml")
-      config = YAML.load_file(config_file) if File.exists?(config_file)
+      config = YAML.load_file(config_file) if File.exist?(config_file)
       Bugsnag.configure(config[rails_env] ? config[rails_env] : config) if config
 
       Bugsnag.configuration.app_type = "rails"

data/lib/bugsnag/railtie.rb

@@ -34,7 +34,7 @@ module Bugsnag
 
       # Auto-load configuration settings from config/bugsnag.yml if it exists
       config_file = ::Rails.root.join("config", "bugsnag.yml")
-      config = YAML.load_file(config_file) if File.exists?(config_file)
+      config = YAML.load_file(config_file) if File.exist?(config_file)
       Bugsnag.configure(config[::Rails.env] ? config[::Rails.env] : config) if config
 
       if defined?(::ActionController::Base)
@@ -44,9 +44,9 @@ module Bugsnag
       if defined?(ActionController::API)
         ActionController::API.send(:include, Bugsnag::Rails::ControllerMethods)
       end
-      if defined?(ActiveRecord::Base)
+      ActiveSupport.on_load(:active_record) do
         require "bugsnag/rails/active_record_rescue"
-        ActiveRecord::Base.send(:include, Bugsnag::Rails::ActiveRecordRescue)
+        include Bugsnag::Rails::ActiveRecordRescue
       end
 
       Bugsnag.configuration.app_type = "rails"

data/lib/bugsnag/shoryuken.rb

@@ -0,0 +1,34 @@
+require 'shoryuken'
+
+module Bugsnag
+  class Shoryuken
+    def initialize
+      Bugsnag.configuration.app_type = "shoryuken"
+      Bugsnag.configuration.delivery_method = :synchronous
+    end
+
+    def call(_, queue, _, body)
+      begin
+        Bugsnag.before_notify_callbacks << lambda {|notification|
+          notification.add_tab(:shoryuken, {
+            queue: queue,
+            body: body
+          })
+        }
+
+        yield
+      rescue Exception => ex
+        Bugsnag.auto_notify(ex) unless [Interrupt, SystemExit, SignalException].include?(ex.class)
+        raise
+      ensure
+        Bugsnag.clear_request_data
+      end
+    end
+  end
+end
+
+::Shoryuken.configure_server do |config|
+  config.server_middleware do |chain|
+    chain.add ::Bugsnag::Shoryuken
+  end
+end

data/spec/cleaner_spec.rb

@@ -19,6 +19,11 @@ describe Bugsnag::Cleaner do
       expect(subject.clean_object(a)).to eq(["[RECURSION]", "hello"])
     end
 
+    it "doesn't remove nil from arrays" do
+      a = ["b", nil, "c"]
+      expect(subject.clean_object(a)).to eq(["b", nil, "c"])
+    end
+
     it "allows multiple copies of the same string" do
       a = {:name => "bugsnag"}
       a[:second] = a[:name]

data/spec/helper_spec.rb

@@ -62,7 +62,7 @@ describe Bugsnag::Helpers do
       context "value is a String" do
         it "trims length" do
           value = Bugsnag::Helpers.trim_if_needed(SecureRandom.hex(500_000/2))
-          expect(::JSON.dump(value.length).length).to be < Bugsnag::Helpers::MAX_STRING_LENGTH
+          expect(value.length).to be <= Bugsnag::Helpers::MAX_STRING_LENGTH
         end
       end
 

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 5.0.1
+  version: 5.1.0
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2016-09-07 00:00:00.000000000 Z
+date: 2017-01-23 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: rake
@@ -84,16 +84,16 @@ dependencies:
   name: webmock
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.1.0
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ">="
+    - - '='
       - !ruby/object:Gem::Version
-        version: '0'
+        version: 2.1.0
 description: Ruby notifier for bugsnag.com
 email: james@bugsnag.com
 executables: []
@@ -130,6 +130,7 @@ files:
 - lib/bugsnag/mailman.rb
 - lib/bugsnag/meta_data.rb
 - lib/bugsnag/middleware/callbacks.rb
+- lib/bugsnag/middleware/clearance_user.rb
 - lib/bugsnag/middleware/mailman.rb
 - lib/bugsnag/middleware/rack_request.rb
 - lib/bugsnag/middleware/rails2_request.rb
@@ -147,6 +148,7 @@ files:
 - lib/bugsnag/railtie.rb
 - lib/bugsnag/rake.rb
 - lib/bugsnag/resque.rb
+- lib/bugsnag/shoryuken.rb
 - lib/bugsnag/sidekiq.rb
 - lib/bugsnag/tasks.rb
 - lib/bugsnag/tasks/bugsnag.cap
@@ -188,7 +190,7 @@ required_rubygems_version: !ruby/object:Gem::Requirement
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.4.5
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby notifier for bugsnag.com