bugsnag 2.1.0 → 2.2.0

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 0aeecfdb8779e10d102017b3c790a61a267ec9d5
-  data.tar.gz: f25ba587cd16bbdae435b974af0cea1f304fb72f
+  metadata.gz: 9c3dbbe217f7c08fdabec9e5735794d768baada9
+  data.tar.gz: 4bbe9e4a0f85bb2b5a3ebf991cee121eb75d5020
 SHA512:
-  metadata.gz: d94df43a04e198a7c59be2562653dd6725dcf0a1cd6a61eb4ffb3941edc7c1cb73991af7c849c993ca4fb951e205f1891c8d299fedcc36126304d76913cf5d52
-  data.tar.gz: 680796ec69b78407e88ddd6de482dc6cd9f5a08f28bad3c9579be2f90a2529cf1355dd8aa6dc8956b5113ada3e5c50f4f8951818cfac9cc0257d7e154c412b94
+  metadata.gz: bcb11d2887710b46c363ec11d81952f04488ef1e4c9afb9236a6cad76a7509293ce53778e254cae9f694ab909ff8b2ae7c07d9066b7cc4e2ec8b800dd39c4d6b
+  data.tar.gz: 162cc3f3f3f8cacd55faa84fa20ebbe0a90d3214f0712460a26b54f7ef556b08479a450ee52335a6d5c521397552097c77979a9de0bb6d8f5d7c73df8f16af9f

data/.travis.yml

@@ -1,18 +1,15 @@
 language: ruby
-
 rvm:
-  - 2.1.0
-  - 2.0.0
-  - 1.9.3
-  - jruby-18mode
-  - jruby-19mode
-  - 1.8.7
-
-# Workaround for broken bundler on travis CI - https://github.com/bundler/bundler/issues/2784
+- 2.1.0
+- 2.0.0
+- 1.9.3
+- jruby-18mode
+- jruby-19mode
+- 1.8.7
 before_install:
-  - gem update --system 2.1.11
-  - gem --version
-
+- gem update --system 2.1.11
+- gem --version
 notifications:
   hipchat:
-    secure: "OLw2B1ggBDSeyJYgnZ2Ezf2fXbu5BHWSNFEJF38+TB4hYv+Wp3rElROhnyP6IttftLYz68Q8n9SjEUXTX9zXwTNt2fGBHIDwLnjt1uw7BrIOIHCUheOJdPheV2XxdJv9yem5MQ0vF+y33auLpyrA53b+nCbI5UsCXKISLe+C8ME="
+    rooms:
+      secure: cv5V8ivZExOywKL9n0CODnxy9m5u4rQ5ZMYK8XHPIoqQKkvH9DQOeb2ItW2aM2kxeupJEcQEy1Eu4sYMGhyzKUNdqbFtQBhDYxRwSAgTRIkGlHQCnznyExHWZbGfDB8y/m11HiZ1wuPuqs8ZZ+VccNb4bwJKbhPTbf1RZ+GPeU8=

data/CHANGELOG.md

@@ -1,6 +1,10 @@
 Changelog
 =========
 
+2.2.0
+-----
+-   Move Bugsnag notifications onto a background thread.
+
 2.1.0
 -----
 -   Add job detail support to delayed_job integration (thanks dtaniwaki!)

data/README.md

@@ -17,7 +17,7 @@ Contents
 
 - [How to Install](#how-to-install)
 - [Sending Custom Data With Exceptions](#sending-custom-data-with-exceptions)
-- [Sending Non-Fatal Exceptions](#sending-non-fatal-exceptions)
+- [Sending Handled Exceptions](#sending-handled-exceptions)
 - [Configuration](#configuration)
 - [Bugsnag Middleware](#bugsnag-middleware)
 - [Deploy Tracking](#deploy-tracking)
@@ -64,6 +64,15 @@ How to Install
     use Bugsnag::Rack
     ```
 
+    **Sinatra**: Note that `raise_errors` must be enabled. If you are using custom
+    error handlers, then you will need to notify Bugsnag explicitly:
+
+    ```ruby
+    error 500 do
+      Bugsnag.auto_notify($!)
+      erb :"errors/500"
+    end
+    ```
 
 Sending Custom Data With Exceptions
 -----------------------------------

data/VERSION

@@ -1 +1 @@
-2.1.0
+2.2.0

data/lib/bugsnag/configuration.rb

@@ -14,7 +14,6 @@ module Bugsnag
     attr_accessor :app_version
     attr_accessor :app_type
     attr_accessor :params_filters
-    attr_accessor :ignore_classes
     attr_accessor :ignore_user_agents
     attr_accessor :endpoint
     attr_accessor :logger
@@ -28,6 +27,8 @@ module Bugsnag
     attr_accessor :timeout
     attr_accessor :hostname
 
+    attr_writer :ignore_classes
+
     THREAD_LOCAL_NAME = "bugsnag_req_data"
 
     DEFAULT_ENDPOINT = "notify.bugsnag.com"
@@ -68,6 +69,11 @@ module Bugsnag
       self.middleware.use Bugsnag::Middleware::Callbacks
     end
 
+    # Accept both String and Class instances as an ignored class
+    def ignore_classes
+      @ignore_classes.map! { |klass| klass.is_a?(Class) ? klass.name : klass }
+    end
+
     def should_notify?
       @release_stage.nil? || @notify_release_stages.nil? || @notify_release_stages.include?(@release_stage)
     end

data/lib/bugsnag/notification.rb

@@ -32,6 +32,8 @@ module Bugsnag
     attr_accessor :user
     attr_accessor :configuration
 
+    @queue = Bugsnag::Queue.new
+
     class << self
       def deliver_exception_payload(endpoint, payload)
         begin
@@ -44,8 +46,8 @@ module Bugsnag
             payload_string = Bugsnag::Helpers.dump_json(payload)
           end
 
-          response = post(endpoint, {:body => payload_string})
-          Bugsnag.debug("Notification to #{endpoint} finished, response was #{response.code}, payload was #{payload_string}")
+          do_post(endpoint, payload_string)
+
         rescue StandardError => e
           # KLUDGE: Since we don't re-raise http exceptions, this breaks rspec
           raise if e.class.to_s == "RSpec::Expectations::ExpectationNotMetError"
@@ -53,6 +55,19 @@ module Bugsnag
           Bugsnag.warn("Notification to #{endpoint} failed, #{e.inspect}")
           Bugsnag.warn(e.backtrace)
         end
+
+      end
+
+      def do_post(endpoint, payload_string)
+        @queue.push proc{
+          begin
+            response = post(endpoint, {:body => payload_string})
+            Bugsnag.debug("Notification to #{endpoint} finished, response was #{response.code}, payload was #{payload_string}")
+          rescue StandardError => e
+            Bugsnag.warn("Notification to #{endpoint} failed, #{e.inspect}")
+            Bugsnag.warn(e.backtrace)
+          end
+        }
       end
     end
 
@@ -270,8 +285,11 @@ module Bugsnag
 
     def ignore_exception_class?
       ex = @exceptions.last
+      ex_name = error_class(ex)
+      ancestor_chain = ex.class.ancestors.select { |ancestor| ancestor.is_a?(Class) }.map { |ancestor| error_class(ancestor) }.to_set
+
       @configuration.ignore_classes.any? do |to_ignore|
-        to_ignore.is_a?(Proc) ? to_ignore.call(ex) : to_ignore == error_class(ex)
+        to_ignore.is_a?(Proc) ? to_ignore.call(ex) : ancestor_chain.include?(to_ignore)
       end
     end
 

data/lib/bugsnag/queue.rb

@@ -0,0 +1,36 @@
+require 'thread'
+
+module Bugsnag
+  class Queue < ::Queue
+    MAX_OUTSTANDING_REQUESTS = 100
+    STOP = Object.new
+
+    def push(*)
+      if length > MAX_OUTSTANDING_REQUESTS
+        Bugsnag.warn("Dropping notification, #{length} outstanding requests")
+        return
+      end
+      @thread ||= create_processor
+      super
+    end
+
+    private
+
+    def create_processor
+      t = Thread.new do
+        while x = pop
+          break if x == STOP
+          x.call
+        end
+      end
+
+      at_exit do
+        Bugsnag.warn("Waiting for #{length} outstanding request(s)") unless empty?
+        push STOP
+        t.join
+      end
+
+      t
+    end
+  end
+end

data/lib/bugsnag.rb

@@ -1,6 +1,7 @@
 require "rubygems"
 
 require "bugsnag/version"
+require "bugsnag/queue"
 require "bugsnag/configuration"
 require "bugsnag/meta_data"
 require "bugsnag/notification"

data/spec/integration_spec.rb

@@ -0,0 +1,33 @@
+require 'webrick'
+require 'spec_helper'
+
+describe 'Bugsnag' do
+  server = nil
+  queue = Queue.new
+
+  before do
+    server = WEBrick::HTTPServer.new :Port => 0, :Logger => WEBrick::Log.new("/dev/null"), :AccessLog => []
+    server.mount_proc '/' do |req, res|
+      queue.push req.body
+      res.status = 200
+      res.body = "OK\n"
+    end
+    Thread.new{ server.start }
+  end
+  after do
+    server.stop
+  end
+
+  let(:request) { JSON.parse(queue.pop) }
+
+  it 'should send notifications over the wire' do
+    Bugsnag.configure do |config|
+      config.endpoint = "localhost:#{server.config[:Port]}"
+      config.use_ssl = false
+    end
+
+    Bugsnag.notify 'yo'
+
+    expect(request['events'][0]['exceptions'][0]['message']).to eq('yo')
+  end
+end

data/spec/notification_spec.rb

@@ -6,6 +6,7 @@ require 'ostruct'
 module ActiveRecord; class RecordNotFound < RuntimeError; end; end
 class NestedException < StandardError; attr_accessor :original_exception; end
 class BugsnagTestExceptionWithMetaData < Exception; include Bugsnag::MetaData; end
+class BugsnagSubclassTestException < BugsnagTestException; end
 
 class Ruby21Exception < RuntimeError
   attr_accessor :cause
@@ -251,10 +252,10 @@ describe Bugsnag::Notification do
   end
 
   it "truncates large meta_data before sending" do
-    expect(Bugsnag::Notification).to receive(:post) do |endpoint, opts|
+    expect(Bugsnag::Notification).to receive(:do_post) do |endpoint, payload_string|
       # Truncated body should be no bigger than
       # 2 truncated hashes (4096*2) + rest of payload (5000)
-      expect(opts[:body].length).to be < 4096*2 + 5000
+      expect(payload_string.length).to be < 4096*2 + 5000
     end
 
     Bugsnag.notify(BugsnagTestException.new("It crashed"), {
@@ -493,8 +494,16 @@ describe Bugsnag::Notification do
     Bugsnag.notify_or_ignore(BugsnagTestException.new("It crashed"))
   end
 
-  it "does not notify if the exception is matched by an ignore_classes lambda function" do
-    Bugsnag.configuration.ignore_classes << lambda {|e| e.message =~ /crashed/}
+  it "does not notify if exception's ancestor is an ignored class" do
+    Bugsnag.configuration.ignore_classes << "BugsnagTestException"
+
+    expect(Bugsnag::Notification).not_to receive(:deliver_exception_payload)
+
+    Bugsnag.notify_or_ignore(BugsnagSubclassTestException.new("It crashed"))
+  end
+
+  it "accepts both String and Class instances as an ignored class" do
+    Bugsnag.configuration.ignore_classes << BugsnagTestException
 
     expect(Bugsnag::Notification).not_to receive(:deliver_exception_payload)
 
@@ -693,8 +702,8 @@ describe Bugsnag::Notification do
     invalid_data = "fl\xc3ff"
     invalid_data.force_encoding('BINARY') if invalid_data.respond_to?(:force_encoding)
 
-    expect(Bugsnag::Notification).to receive(:post) do |endpoint, opts|
-      expect(opts[:body]).to match(/fl�ff/) if defined?(Encoding::UTF_8)
+    expect(Bugsnag::Notification).to receive(:do_post) do |endpoint, payload_string|
+      expect(payload_string).to match(/fl�ff/) if defined?(Encoding::UTF_8)
     end
 
     notify_test_exception(:fluff => {:fluff => invalid_data})

metadata

@@ -1,103 +1,103 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 2.1.0
+  version: 2.2.0
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2014-06-26 00:00:00.000000000 Z
+date: 2014-07-16 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - ~>
+    - - "~>"
       - !ruby/object:Gem::Version
         version: '1.0'
 - !ruby/object:Gem::Dependency
   name: httparty
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.6'
   type: :runtime
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - <
+    - - "<"
       - !ruby/object:Gem::Version
         version: '1.0'
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0.6'
 - !ruby/object:Gem::Dependency
   name: rake
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rspec
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: rdoc
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 - !ruby/object:Gem::Dependency
   name: pry
   requirement: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
   type: :development
   prerelease: false
   version_requirements: !ruby/object:Gem::Requirement
     requirements:
-    - - '>='
+    - - ">="
       - !ruby/object:Gem::Version
         version: '0'
 description: Ruby notifier for bugsnag.com
@@ -108,10 +108,10 @@ extra_rdoc_files:
 - LICENSE.txt
 - README.md
 files:
-- .document
-- .gitignore
-- .rspec
-- .travis.yml
+- ".document"
+- ".gitignore"
+- ".rspec"
+- ".travis.yml"
 - CHANGELOG.md
 - Gemfile
 - LICENSE.txt
@@ -136,6 +136,7 @@ files:
 - lib/bugsnag/middleware/warden_user.rb
 - lib/bugsnag/middleware_stack.rb
 - lib/bugsnag/notification.rb
+- lib/bugsnag/queue.rb
 - lib/bugsnag/rack.rb
 - lib/bugsnag/rails.rb
 - lib/bugsnag/rails/action_controller_rescue.rb
@@ -152,6 +153,7 @@ files:
 - lib/generators/bugsnag/bugsnag_generator.rb
 - rails/init.rb
 - spec/helper_spec.rb
+- spec/integration_spec.rb
 - spec/middleware_spec.rb
 - spec/notification_spec.rb
 - spec/rack_spec.rb
@@ -166,17 +168,17 @@ require_paths:
 - lib
 required_ruby_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 required_rubygems_version: !ruby/object:Gem::Requirement
   requirements:
-  - - '>='
+  - - ">="
     - !ruby/object:Gem::Version
       version: '0'
 requirements: []
 rubyforge_project: 
-rubygems_version: 2.0.14
+rubygems_version: 2.2.2
 signing_key: 
 specification_version: 4
 summary: Ruby notifier for bugsnag.com