bugsnag 1.6.1 → 1.6.2

checksums.yaml

@@ -1,7 +1,7 @@
 ---
 SHA1:
-  metadata.gz: 560790fe15fb481a9b1d65558167316b6d750726
-  data.tar.gz: 5c5712e8c5a2d5a077cec7bf181acb9ed51aa291
+  metadata.gz: ead9c3ae435b2c76b2ad41748a846992993032b0
+  data.tar.gz: 9c7572192cdc46149bfd17d9f26183ac2ac54f3e
 SHA512:
-  metadata.gz: f665d1bfa8f5b3afb5746be6f0300317ae17fc6246657f0231ff46ec8cbc170ad8bbc53a81aba171f8f212601fff7b2d1a9e3ca4a80b1c42122927b6f95a031f
-  data.tar.gz: 45d99adcdac49b2c37f87263a3b2aef29978065e85dffba847ab887b24c371173f67fa5d3efff64d0831f29c52ae2f4edaf1621ebbb8c1f05c13fc68f593984b
+  metadata.gz: ed8321d8b710b85ad78c37aaadf50669ba34ee17d924014604715440c07fcd72da35e10502d45831cfcb7bc78381ec8275cad8f6b3b2e89ee4dc546d5d5c6653
+  data.tar.gz: 23205103196fe19e341204072b74be923447f912afe01bb5ca6d21e22eef91c2f6aa039be8c09dbf4d0d5bb5d708ff667aac36572fa5e8cbf702a5369b5b60b6

data/CHANGELOG.md

@@ -1,6 +1,11 @@
 Changelog
 =========
 
+1.6.2
+-----
+-   Notify about exceptions that occur in ActiveRecord `commit` and `rollback`
+    callbacks (these are usually swallowed silently by rails)
+
 1.6.1
 -----
 -   Ensure sidekiq, mailman and rake hooks respect the `ignore_classes` setting

data/VERSION

@@ -1 +1 @@
-1.6.1
+1.6.2

data/bugsnag.gemspec

@@ -5,11 +5,11 @@
 
 Gem::Specification.new do |s|
   s.name = "bugsnag"
-  s.version = "1.6.1"
+  s.version = "1.6.2"
 
   s.required_rubygems_version = Gem::Requirement.new(">= 0") if s.respond_to? :required_rubygems_version=
   s.authors = ["James Smith"]
-  s.date = "2013-10-11"
+  s.date = "2013-10-14"
   s.description = "Ruby notifier for bugsnag.com"
   s.email = "james@bugsnag.com"
   s.extra_rdoc_files = [
@@ -46,6 +46,7 @@ Gem::Specification.new do |s|
     "lib/bugsnag/rack.rb",
     "lib/bugsnag/rails.rb",
     "lib/bugsnag/rails/action_controller_rescue.rb",
+    "lib/bugsnag/rails/active_record_rescue.rb",
     "lib/bugsnag/rails/controller_methods.rb",
     "lib/bugsnag/railtie.rb",
     "lib/bugsnag/rake.rb",

data/lib/bugsnag/rails.rb

@@ -4,6 +4,7 @@
 require "bugsnag"
 require "bugsnag/rails/controller_methods"
 require "bugsnag/rails/action_controller_rescue"
+require "bugsnag/rails/active_record_rescue"
 require "bugsnag/middleware/rails2_request"
 require "bugsnag/middleware/callbacks"
 
@@ -14,6 +15,9 @@ module Bugsnag
         ActionController::Base.send(:include, Bugsnag::Rails::ActionControllerRescue)
         ActionController::Base.send(:include, Bugsnag::Rails::ControllerMethods)
       end
+      if defined?(ActiveRecord::Base)
+        ActiveRecord::Base.send(:include, Bugsnag::Rails::ActiveRecordRescue)
+      end
 
       # Try to find where to log to
       rails_logger = nil
@@ -39,4 +43,4 @@ module Bugsnag
   end
 end
 
-Bugsnag::Rails.initialize
+Bugsnag::Rails.initialize

data/lib/bugsnag/rails/active_record_rescue.rb

@@ -0,0 +1,18 @@
+module Bugsnag::Rails
+  module ActiveRecordRescue
+    def run_callbacks(kind, *args, &block)
+      if %w(commit rollback).include?(kind.to_s)
+        begin
+          super
+        rescue StandardError => exception
+          # This exception will NOT be escalated, so notify it here.
+          Bugsnag.auto_notify(exception)
+          raise
+        end
+      else
+        # Let the post process handle the exception
+        super
+      end
+    end
+  end
+end

data/lib/bugsnag/railtie.rb

@@ -31,6 +31,10 @@ module Bugsnag
         require "bugsnag/rails/controller_methods"
         ::ActionController::Base.send(:include, Bugsnag::Rails::ControllerMethods)
       end
+      if defined?(ActiveRecord::Base)
+        require "bugsnag/rails/active_record_rescue"
+        ActiveRecord::Base.send(:include, Bugsnag::Rails::ActiveRecordRescue)
+      end
     end
 
     initializer "bugsnag.use_rack_middleware" do |app|
@@ -41,4 +45,4 @@ module Bugsnag
       end
     end
   end
-end
+end

metadata

@@ -1,14 +1,14 @@
 --- !ruby/object:Gem::Specification
 name: bugsnag
 version: !ruby/object:Gem::Version
-  version: 1.6.1
+  version: 1.6.2
 platform: ruby
 authors:
 - James Smith
 autorequire: 
 bindir: bin
 cert_chain: []
-date: 2013-10-11 00:00:00.000000000 Z
+date: 2013-10-14 00:00:00.000000000 Z
 dependencies:
 - !ruby/object:Gem::Dependency
   name: multi_json
@@ -123,6 +123,7 @@ files:
 - lib/bugsnag/rack.rb
 - lib/bugsnag/rails.rb
 - lib/bugsnag/rails/action_controller_rescue.rb
+- lib/bugsnag/rails/active_record_rescue.rb
 - lib/bugsnag/rails/controller_methods.rb
 - lib/bugsnag/railtie.rb
 - lib/bugsnag/rake.rb